mirror of
https://github.com/gristlabs/grist-core.git
synced 2024-10-27 20:44:07 +00:00
2b2e19c5b5
Summary: The problem is that the implementation for a summary update was relying on type consistency to get columns (ie: matches agains colId and type). Type consistency is an attempt at maintaining consistent type across same-named column for summaries of same table. But the problem is that the consistency of types is NOT a strict guarantee or an invariant, more of a best-effort attempt (there are too many possible sequences of operations possible with renaming/adding/removing in summary tables and the underlying table). With current implementation and with a document violating the type consistency, a summary table could end up with fields referencing columns to the former summary table (more detail below(1)). Which is a bad state (yields js errors on the client). This diff fixes this issue by relaxing the type comparison when search for same-named column. (1) __Below is a description of how a violation of type consistency could end-up in bad state document (example taken from the reported bug):__ > In this document, let's assume two summary tables `Table1 [by A]` and `Table1 [Totals]`. Let's also assume Table1 and `Table1 [Totals]` both have an `Amount(Numeric)` column, and that `Table1 [by A]` has one `Amount(Any)` column (violating the type consistency principle). Now when users wanted to change the `Table1 [Totals]` section to group by 'A', grist found that there is already a summary table with same grouping. But it couldn't find a matching column for `Amount(Numeric)` so it created a new one. Except that because there was still an `Amount(Any)` the new column was named `Amount2` which caused following code to ignore it and in particular forgetting to update it's corresponding section's field which was then pointing toward the column of a different table (which is bad). Test Plan: Added python test. Reviewers: georgegevoian Reviewed By: georgegevoian Differential Revision: https://phab.getgrist.com/D3809 |
||
|---|---|---|
| .. | ||
| functions | ||
| imports | ||
| acl_formula.py | ||
| acl.py | ||
| action_obj.py | ||
| action_summary.py | ||
| actions.py | ||
| autocomplete_context.py | ||
| codebuilder.py | ||
| column.py | ||
| csv_patch.py | ||
| depend.py | ||
| docactions.py | ||
| docmodel.py | ||
| engine.py | ||
| formula_prompt.py | ||
| friendly_errors.py | ||
| gencode.py | ||
| grist.py | ||
| identifiers.py | ||
| import_actions.py | ||
| logger.py | ||
| lookup.py | ||
| main.py | ||
| match_counter.py | ||
| migrations.py | ||
| moment.py | ||
| objtypes.py | ||
| parse_data.py | ||
| records.py | ||
| relabeling.py | ||
| relation.py | ||
| runtests.py | ||
| sandbox.py | ||
| schema.py | ||
| sort_specs.py | ||
| summary.py | ||
| table_data_set.py | ||
| table.py | ||
| test_acl_formula.py | ||
| test_acl_renames.py | ||
| test_actions.py | ||
| test_codebuilder.py | ||
| test_column_actions.py | ||
| test_completion.py | ||
| test_default_formulas.py | ||
| test_depend.py | ||
| test_derived.py | ||
| test_display_cols.py | ||
| test_docmodel.py | ||
| test_engine.py | ||
| test_find_col.py | ||
| test_formula_error.py | ||
| test_formula_prompt.py | ||
| test_formula_undo.py | ||
| test_functions.py | ||
| test_gencode.py | ||
| test_import_actions.py | ||
| test_logger.py | ||
| test_lookups.py | ||
| test_match_counter.py | ||
| test_migrations.py | ||
| test_moment.py | ||
| test_record_func.py | ||
| test_recordlist.py | ||
| test_reflist_rel.py | ||
| test_relabeling.py | ||
| test_renames2.py | ||
| test_renames.py | ||
| test_replay.py | ||
| test_requests.py | ||
| test_rules_grid.py | ||
| test_rules.py | ||
| test_side_effects.py | ||
| test_sort_spec.py | ||
| test_summary2.py | ||
| test_summary_choicelist.py | ||
| test_summary_undo.py | ||
| test_summary.py | ||
| test_table_actions.py | ||
| test_table_data_set.py | ||
| test_temp_rowids.py | ||
| test_textbuilder.py | ||
| test_treeview.py | ||
| test_trigger_formulas.py | ||
| test_twowaymap.py | ||
| test_types.py | ||
| test_undo.py | ||
| test_urllib_patch.py | ||
| test_user.py | ||
| test_useractions.py | ||
| testsamples.py | ||
| testscript.json | ||
| testutil.py | ||
| textbuilder.py | ||
| treeview.py | ||
| twowaymap.py | ||
| tzdata.data | ||
| urllib_patch.py | ||
| user.py | ||
| useractions.py | ||
| usercode.py | ||
| usertypes.py | ||
| xmlrunner.py | ||