use profile instead of system property to set db-kind

This commit is contained in:
Athou
2024-08-12 10:25:25 +02:00
parent aaf237d111
commit 6b0aa32da2
3 changed files with 128 additions and 7 deletions

View File

@@ -35,7 +35,7 @@ jobs:
# Build & Test
- name: Build with Maven
run: mvn --batch-mode --no-transfer-progress install -Pnative -D"quarkus.datasource.db-kind"=${{ matrix.database }}
run: mvn --batch-mode --no-transfer-progress install -Pnative -P${{ matrix.database }}
# Upload artifacts
- name: Upload cross-platform app

View File

@@ -7,11 +7,11 @@ MVP:
- https://github.com/quarkusio/quarkus/issues/42463
- Rewrite cookie with https://quarkus.io/guides/rest#request-or-response-filters in the mean time
- mvn profile instead of -Dquarkus.datasource.db-kind
- update github actions
- release after tag
- new job that downloads all artifacts because we need them all to create the release
- update readme
- update docker readme
- update release notes (+ mention h2 migration has been removed, upgrade to last 4.x is required)
Nice to have:
@@ -24,8 +24,3 @@ Nice to have:
- OPML encoding is not handled correctly
- remove Timers metrics page
native-image
-------------
- https://www.graalvm.org/latest/reference-manual/native-image/dynamic-features/Resources/
- https://github.com/rometools/rome/pull/636/files

View File

@@ -16,6 +16,7 @@
<querydsl.version>6.6</querydsl.version>
<rome.version>2.1.0</rome.version>
<jersey.version>3.1.8</jersey.version>
<properties-plugin.version>1.2.1</properties-plugin.version>
<quarkus.datasource.db-kind>h2</quarkus.datasource.db-kind>
</properties>
@@ -41,6 +42,19 @@
</extension>
</extensions>
<plugins>
<plugin>
<artifactId>maven-help-plugin</artifactId>
<version>3.4.1</version>
<executions>
<execution>
<phase>initialize</phase>
<goals>
<goal>active-profiles</goal>
</goals>
</execution>
</executions>
</plugin>
<plugin>
<groupId>io.quarkus.platform</groupId>
<artifactId>quarkus-maven-plugin</artifactId>
@@ -480,5 +494,117 @@
<quarkus.native.enabled>true</quarkus.native.enabled>
</properties>
</profile>
<profile>
<id>h2</id>
<activation>
<activeByDefault>true</activeByDefault>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>properties-maven-plugin</artifactId>
<version>${properties-plugin.version}</version>
<executions>
<execution>
<goals>
<goal>set-system-properties</goal>
</goals>
</execution>
</executions>
<configuration>
<properties>
<property>
<name>quarkus.datasource.db-kind</name>
<value>h2</value>
</property>
</properties>
</configuration>
</plugin>
</plugins>
</build>
</profile>
<profile>
<id>mysql</id>
<build>
<plugins>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>properties-maven-plugin</artifactId>
<version>${properties-plugin.version}</version>
<executions>
<execution>
<goals>
<goal>set-system-properties</goal>
</goals>
</execution>
</executions>
<configuration>
<properties>
<property>
<name>quarkus.datasource.db-kind</name>
<value>mysql</value>
</property>
</properties>
</configuration>
</plugin>
</plugins>
</build>
</profile>
<profile>
<id>mariadb</id>
<build>
<plugins>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>properties-maven-plugin</artifactId>
<version>${properties-plugin.version}</version>
<executions>
<execution>
<goals>
<goal>set-system-properties</goal>
</goals>
</execution>
</executions>
<configuration>
<properties>
<property>
<name>quarkus.datasource.db-kind</name>
<value>mariadb</value>
</property>
</properties>
</configuration>
</plugin>
</plugins>
</build>
</profile>
<profile>
<id>postgresql</id>
<build>
<plugins>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>properties-maven-plugin</artifactId>
<version>${properties-plugin.version}</version>
<executions>
<execution>
<goals>
<goal>set-system-properties</goal>
</goals>
</execution>
</executions>
<configuration>
<properties>
<property>
<name>quarkus.datasource.db-kind</name>
<value>postgresql</value>
</property>
</properties>
</configuration>
</plugin>
</plugins>
</build>
</profile>
</profiles>
</project>