Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity
9b36fb4dab
gristlabs_grist-core/app/client/components
History
Alex Hall 9b36fb4dab (core) Fix error in sandbox when removing multiple summary source columns 
Summary:
Fixes a very specific bug reported here: https://grist.slack.com/archives/C069RUP71/p1694630242765769

The error occurred when:

1. Removing multiple columns simultaneously
2. Those columns were sources of groupby columns for a summary table (so removing them meant recreating the summary table and thus deleting its columns)
3. There was a display column for one of the columns that got deleted (either directly or indirectly) which was set to be automatically removed since it was no longer needed, but this failed because the column was already deleted as part of earlier table removal.

I fixed this by making `apply_auto_removes` remove table records last, so removing the display column wouldn't be a problem.

That fixed the original error, but then I noticed that trying to undo the removal could lead to another error (under even more specific circumstances). It's hard to see exactly why, but I can see that just 3 `RemoveColumn` user actions generated over 100 doc actions and corresponding undo actions, hence the difficulty in narrowing the problem down. This is partly because removing a single column would recreate a summary table, only for that table to be immediately replaced again when another column was removed. Making the frontend send a single `[BulkRemoveRecord, _grist_Tables_column, ...] ` leads to a more efficient and sensible process with about half as many doc actions and no undo error. I think this alone would also solve the original error, but the data engine change seems more generally helpful and worth keeping.

Test Plan: Added a Python test and an nbrowser test

Reviewers: jarek

Reviewed By: jarek

Differential Revision: https://phab.getgrist.com/D4052
2023-09-27 16:23:49 +02:00
..
AceEditor.css (core) Polish dark mode and remove beta tag 2023-09-21 13:14:48 -04:00
AceEditor.js (core) Implement AI Assistant UI V2 2023-07-13 10:30:35 -04:00
AceEditorCompletions.ts (core) Implement AI Assistant UI V2 2023-07-13 10:30:35 -04:00
ActionLog.css (core) Polish dark mode and remove beta tag 2023-09-21 13:14:48 -04:00
ActionLog.ts (core) Polish dark mode and remove beta tag 2023-09-21 13:14:48 -04:00
Banner.ts (core) Add AI assistant usage banners 2023-08-30 16:00:04 -04:00
Base.js (core) move client code to core 2020-10-02 13:24:21 -04:00
BaseView2.ts (core) Copy column type and options when pasting into an empty column 2022-04-04 14:53:16 +02:00
BaseView.js Bidirectional Linking (#622) 2023-09-25 18:48:18 -04:00
BehavioralPromptsManager.ts (core) Fix calendar and card tip bug on mobile 2023-09-26 21:05:30 -04:00
buildViewSectionDom.ts (core) Polish dark mode and remove beta tag 2023-09-21 13:14:48 -04:00
CellPosition.ts (core) Cursor in custom widgets 2023-08-29 09:19:52 +02:00
CellSelector.ts (core) Add cell selection summary 2022-09-30 09:11:46 -07:00
ChartView.css (core) move client code to core 2020-10-02 13:24:21 -04:00
ChartView.ts i18n: userManager translation + some forgotten translations (#557) 2023-07-16 12:52:13 -04:00
ClientScope.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
Clipboard.css (core) move client code to core 2020-10-02 13:24:21 -04:00
Clipboard.js (core) Add cut, copy, and paste to context menu 2023-05-10 00:48:15 -04:00
CodeEditorPanel.css (core) Improve dark mode 2023-04-12 01:58:48 -04:00
CodeEditorPanel.ts Remove prefix from translations keys 2023-01-03 16:01:45 +01:00
ColumnFilters.css (core) Context menu for cards. 2021-06-29 15:29:56 +02:00
ColumnTransform.ts (core) Polish dark mode and remove beta tag 2023-09-21 13:14:48 -04:00
Comm.ts (core) Fix issue with 'UNEXPECTED ORDER OF CALLBACKS' in Client.ts. 2022-06-16 23:51:14 -04:00
commandList.ts Support grid selection with Ctrl+Shift+Arrow (#615) 2023-08-14 09:28:41 -07:00
commands.css (core) move client code to core 2020-10-02 13:24:21 -04:00
commands.ts (core) Floating formula editor 2023-06-02 17:59:22 +02:00
CopySelection.ts (core) Cursor in custom widgets 2023-08-29 09:19:52 +02:00
Cursor.ts Bidirectional Linking (#622) 2023-09-25 18:48:18 -04:00
CursorMonitor.ts (core) Cursor in custom widgets 2023-08-29 09:19:52 +02:00
CustomCalendarView.ts (core) custom widget appear as build-in widget 2023-08-30 09:44:25 +02:00
CustomView.css (core) Fix CustomView css to take full height of widget on all browsers including Safari 2020-10-06 13:18:50 -04:00
CustomView.ts (core) Support dark mode in custom widgets 2023-09-19 16:08:21 -04:00
DataTables.ts (core) Add cut, copy, and paste to context menu 2023-05-10 00:48:15 -04:00
DetailView.css (core) Polish dark mode and remove beta tag 2023-09-21 13:14:48 -04:00
DetailView.js (core) Polish dark mode and remove beta tag 2023-09-21 13:14:48 -04:00
DocComm.ts (core) Billing for formula assistant 2023-07-10 13:24:08 +02:00
DocConfigTab.js (core) move client code to core 2020-10-02 13:24:21 -04:00
DocumentUsage.ts (core) Add AI assistant usage banners 2023-08-30 16:00:04 -04:00
Drafts.ts Change translation keys for components directory 2023-01-03 15:49:26 +01:00
duplicatePage.ts (core) Polish tutorial popups 2023-04-20 12:20:03 -04:00
EditorMonitor.ts (core) Fix problem with localStorage in some cross-origin embed situations 2022-11-30 23:52:50 -05:00
EmbedForm.css (core) move client code to core 2020-10-02 13:24:21 -04:00
FieldConfigTab.css (core) move client code to core 2020-10-02 13:24:21 -04:00
FormulaTransform.ts (core) TypeTransform race condition fix 2023-08-02 17:11:34 +02:00
GridView.css (core) Allow scrolling the grid horizontally while column-shadow is under the cursor 2023-09-26 20:42:10 -04:00
GridView.js (core) Fix error in sandbox when removing multiple summary source columns 2023-09-27 16:23:49 +02:00
GristDoc.css (core) move client code to core 2020-10-02 13:24:21 -04:00
GristDoc.ts (core) updates from grist-core 2023-09-27 09:18:41 -04:00
GristWSConnection.ts (core) Manage memory used for websocket responses to reduce the risk of server crashes. 2023-08-07 11:28:31 -04:00
Importer.ts (core) Adding testId to the widget iframe once it receives the ready message 2023-08-30 21:28:06 +02:00
Layout.css (core) Expanding widgets 2023-01-19 09:46:59 +01:00
Layout.ts (core) Avoiding the view layout's rebuild, when nothing has changed. 2023-09-18 09:47:50 +02:00
LayoutEditor.css (core) move client code to core 2020-10-02 13:24:21 -04:00
LayoutEditor.ts (core) Minimazing widgets 2023-03-02 11:22:49 +01:00
LayoutTray.ts (core) Adjust the style of the 'attic' to have more of a toolbar feel, flush to the top, and taking up less space 2023-06-30 08:22:26 -04:00
LinkingState.ts Bidirectional Linking (#622) 2023-09-25 18:48:18 -04:00
Login.css (core) move client code to core 2020-10-02 13:24:21 -04:00
modals.ts (core) Fix blurry tooltips 2023-09-22 03:51:58 -04:00
ParseOptions.ts (core) Improve encoding detection for csv imports, and make encoding an editable option. 2023-08-24 09:50:52 -04:00
PluginScreen.ts (core) Import redesign 2023-08-04 14:59:55 +02:00
Printing.css (core) Improve printing of tables, fix printing of charts, add a browser test. 2020-10-12 16:04:18 -04:00
Printing.ts (core) Improve dark mode 2023-04-12 01:58:48 -04:00
RawDataPage.ts (core) Polish dark mode and remove beta tag 2023-09-21 13:14:48 -04:00
RecordLayout.css (core) Add behavioral and coaching call popups 2022-12-20 09:49:41 -05:00
RecordLayout.js (core) Add cut, copy, and paste to context menu 2023-05-10 00:48:15 -04:00
RecordLayoutEditor.js (core) Minimazing widgets 2023-03-02 11:22:49 +01:00
RefSelect.ts (core) Polish dark mode and remove beta tag 2023-09-21 13:14:48 -04:00
SearchBar.css (core) move client code to core 2020-10-02 13:24:21 -04:00
SelectionSummary.ts (core) Polish dark mode and remove beta tag 2023-09-21 13:14:48 -04:00
TypeConversion.ts (core) Polish dark mode and remove beta tag 2023-09-21 13:14:48 -04:00
TypeTransform.ts (core) TypeTransform race condition fix 2023-08-02 17:11:34 +02:00
UndoStack.ts (core) Cursor in custom widgets 2023-08-29 09:19:52 +02:00
UnsavedChanges.ts (core) support ?embed=true and &style=light for a clean embed experience 2020-08-14 13:34:38 -04:00
ValidationPanel.css (core) move client code to core 2020-10-02 13:24:21 -04:00
ValidationPanel.js Remove prefix from translations keys 2023-01-03 16:01:45 +01:00
ViewAsBanner.ts (core) Adds dots menu to access rules page item 2023-01-12 09:40:45 +01:00
viewCommon.css (core) Polish dark mode and remove beta tag 2023-09-21 13:14:48 -04:00
viewCommon.js (core) Skip saving column resizes in read-only mode 2021-12-07 14:37:25 -08:00
ViewConfigTab.css (core) move client code to core 2020-10-02 13:24:21 -04:00
ViewConfigTab.js (core) Polish dark mode and remove beta tag 2023-09-21 13:14:48 -04:00
ViewLayout.css (core) Polish dark mode and remove beta tag 2023-09-21 13:14:48 -04:00
ViewLayout.ts (core) Polish dark mode and remove beta tag 2023-09-21 13:14:48 -04:00
ViewLinker.css (core) move client code to core 2020-10-02 13:24:21 -04:00
ViewPane.ts (core) Implementing row conditional formatting 2022-08-09 20:11:36 +02:00
WidgetFrame.ts (core) Support dark mode in custom widgets 2023-09-19 16:08:21 -04:00