mirror of
https://github.com/gristlabs/grist-core.git
synced 2024-10-27 20:44:07 +00:00
9b36fb4dab
Summary: Fixes a very specific bug reported here: https://grist.slack.com/archives/C069RUP71/p1694630242765769 The error occurred when: 1. Removing multiple columns simultaneously 2. Those columns were sources of groupby columns for a summary table (so removing them meant recreating the summary table and thus deleting its columns) 3. There was a display column for one of the columns that got deleted (either directly or indirectly) which was set to be automatically removed since it was no longer needed, but this failed because the column was already deleted as part of earlier table removal. I fixed this by making `apply_auto_removes` remove table records last, so removing the display column wouldn't be a problem. That fixed the original error, but then I noticed that trying to undo the removal could lead to another error (under even more specific circumstances). It's hard to see exactly why, but I can see that just 3 `RemoveColumn` user actions generated over 100 doc actions and corresponding undo actions, hence the difficulty in narrowing the problem down. This is partly because removing a single column would recreate a summary table, only for that table to be immediately replaced again when another column was removed. Making the frontend send a single `[BulkRemoveRecord, _grist_Tables_column, ...] ` leads to a more efficient and sensible process with about half as many doc actions and no undo error. I think this alone would also solve the original error, but the data engine change seems more generally helpful and worth keeping. Test Plan: Added a Python test and an nbrowser test Reviewers: jarek Reviewed By: jarek Differential Revision: https://phab.getgrist.com/D4052 |
||
|---|---|---|
| .. | ||
| AceEditor.css | ||
| AceEditor.js | ||
| AceEditorCompletions.ts | ||
| ActionLog.css | ||
| ActionLog.ts | ||
| Banner.ts | ||
| Base.js | ||
| BaseView2.ts | ||
| BaseView.js | ||
| BehavioralPromptsManager.ts | ||
| buildViewSectionDom.ts | ||
| CellPosition.ts | ||
| CellSelector.ts | ||
| ChartView.css | ||
| ChartView.ts | ||
| ClientScope.ts | ||
| Clipboard.css | ||
| Clipboard.js | ||
| CodeEditorPanel.css | ||
| CodeEditorPanel.ts | ||
| ColumnFilters.css | ||
| ColumnTransform.ts | ||
| Comm.ts | ||
| commandList.ts | ||
| commands.css | ||
| commands.ts | ||
| CopySelection.ts | ||
| Cursor.ts | ||
| CursorMonitor.ts | ||
| CustomCalendarView.ts | ||
| CustomView.css | ||
| CustomView.ts | ||
| DataTables.ts | ||
| DetailView.css | ||
| DetailView.js | ||
| DocComm.ts | ||
| DocConfigTab.js | ||
| DocumentUsage.ts | ||
| Drafts.ts | ||
| duplicatePage.ts | ||
| EditorMonitor.ts | ||
| EmbedForm.css | ||
| FieldConfigTab.css | ||
| FormulaTransform.ts | ||
| GridView.css | ||
| GridView.js | ||
| GristDoc.css | ||
| GristDoc.ts | ||
| GristWSConnection.ts | ||
| Importer.ts | ||
| Layout.css | ||
| Layout.ts | ||
| LayoutEditor.css | ||
| LayoutEditor.ts | ||
| LayoutTray.ts | ||
| LinkingState.ts | ||
| Login.css | ||
| modals.ts | ||
| ParseOptions.ts | ||
| PluginScreen.ts | ||
| Printing.css | ||
| Printing.ts | ||
| RawDataPage.ts | ||
| RecordLayout.css | ||
| RecordLayout.js | ||
| RecordLayoutEditor.js | ||
| RefSelect.ts | ||
| SearchBar.css | ||
| SelectionSummary.ts | ||
| TypeConversion.ts | ||
| TypeTransform.ts | ||
| UndoStack.ts | ||
| UnsavedChanges.ts | ||
| ValidationPanel.css | ||
| ValidationPanel.js | ||
| ViewAsBanner.ts | ||
| viewCommon.css | ||
| viewCommon.js | ||
| ViewConfigTab.css | ||
| ViewConfigTab.js | ||
| ViewLayout.css | ||
| ViewLayout.ts | ||
| ViewLinker.css | ||
| ViewPane.ts | ||
| WidgetFrame.ts | ||