gristlabs_grist-core/app/client
Alex Hall 9b36fb4dab (core) Fix error in sandbox when removing multiple summary source columns
Summary:
Fixes a very specific bug reported here: https://grist.slack.com/archives/C069RUP71/p1694630242765769

The error occurred when:

1. Removing multiple columns simultaneously
2. Those columns were sources of groupby columns for a summary table (so removing them meant recreating the summary table and thus deleting its columns)
3. There was a display column for one of the columns that got deleted (either directly or indirectly) which was set to be automatically removed since it was no longer needed, but this failed because the column was already deleted as part of earlier table removal.

I fixed this by making `apply_auto_removes` remove table records last, so removing the display column wouldn't be a problem.

That fixed the original error, but then I noticed that trying to undo the removal could lead to another error (under even more specific circumstances). It's hard to see exactly why, but I can see that just 3 `RemoveColumn` user actions generated over 100 doc actions and corresponding undo actions, hence the difficulty in narrowing the problem down. This is partly because removing a single column would recreate a summary table, only for that table to be immediately replaced again when another column was removed. Making the frontend send a single `[BulkRemoveRecord, _grist_Tables_column, ...] ` leads to a more efficient and sensible process with about half as many doc actions and no undo error. I think this alone would also solve the original error, but the data engine change seems more generally helpful and worth keeping.

Test Plan: Added a Python test and an nbrowser test

Reviewers: jarek

Reviewed By: jarek

Differential Revision: https://phab.getgrist.com/D4052
2023-09-27 16:23:49 +02:00
..
aclui (core) Polish dark mode and remove beta tag 2023-09-21 13:14:48 -04:00
components (core) Fix error in sandbox when removing multiple summary source columns 2023-09-27 16:23:49 +02:00
lib (core) Polish dark mode and remove beta tag 2023-09-21 13:14:48 -04:00
models (core) updates from grist-core 2023-09-27 09:18:41 -04:00
ui (core) updates from grist-core 2023-09-27 09:18:41 -04:00
ui2018 (core) Delete my account button 2023-09-27 14:49:23 +02:00
widgets (core) Polish dark mode and remove beta tag 2023-09-21 13:14:48 -04:00
app.css (core) Polish tutorial popups 2023-04-20 12:20:03 -04:00
app.js (core) i18 2022-09-29 18:02:09 +02:00
billingMain.ts (core) Add basic activation page to grist-ee 2022-08-23 10:30:52 -07:00
browserCheck.ts (core) On mobile, only show a warning for older and unknown browsers rather than for all 2023-06-01 11:15:21 -04:00
declarations.d.ts (core) Cursor in custom widgets 2023-08-29 09:19:52 +02:00
DefaultHooks.ts add hooks for tweaking how downloads happen (for grist-static) (#665) 2023-09-09 14:50:32 -04:00
errorMain.ts (core) Enable MFA configuration (and add SMS) 2022-01-19 13:55:54 -08:00
exposeModulesForTests.js support other SQLite wrappers, and various hooks needed by grist-static (#516) 2023-05-23 15:17:28 -04:00
Hooks.ts support other SQLite wrappers, and various hooks needed by grist-static (#516) 2023-05-23 15:17:28 -04:00
logo.css (core) Cleanup removing some old unused files, fixing logo.css, and removing #grist-app. 2020-10-09 17:04:09 -04:00
tsconfig.json (core) Migrate to SRP and add change password dialog 2022-03-16 21:35:06 -07:00