release 5.10.0

fix(deps): update dependency react-router-dom to ^7.6.1

.dockerignore

@@ -1,6 +1 @@
-# ignore everything
+commafeed-client
-*
-
-# allow only what we need
-!commafeed-server/target/commafeed.jar
-!commafeed-server/config.yml.example

.gitattributes

@@ -0,0 +1,3 @@
+*       text eol=lf
+*.cmd   text eol=crlf
+*.png   binary

.github/FUNDING.yml

@@ -1,2 +1,5 @@
-github: [athou]
+github: [ athou ]
-custom: ['https://www.paypal.com/donate/?business=9CNQHMJG2ZJVY&no_recurring=0&item_name=CommaFeed&currency_code=EUR']
+custom: [
+  'https://github.com/sponsors/Athou',
+  'https://www.paypal.com/donate/?business=9CNQHMJG2ZJVY&no_recurring=0&item_name=CommaFeed&currency_code=EUR'
+]

.github/ISSUE_TEMPLATE/bug_report.md

@@ -25,7 +25,8 @@ If applicable, add screenshots to help explain your problem.
 
 **Environment (please complete the following information):**
 
-- CommaFeed version (or "commafeed.com"): 3.2.1
+- commafeed.com or self-hosted:
+- If self-hosted, CommaFeed version [e.g. 5.1.0 (a3dcb2c)]:
 - Browser [e.g. chrome, firefox]:
 - Device [e.g. desktop, mobile]:
 

.github/dependabot.yml

@@ -1,24 +0,0 @@
-version: 2
-updates:
-  - package-ecosystem: "maven"
-    directory: "/"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 10
-  - package-ecosystem: "npm"
-    directory: "/commafeed-client"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 10
-    groups:
-      mantine:
-        patterns:
-          - "@mantine/*"
-      lingui:
-        patterns:
-          - "@lingui/*"
-  - package-ecosystem: "github-actions"
-    directory: "/"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 10

.github/stale.yml

@@ -1,19 +1,19 @@
-# Number of days of inactivity before an issue becomes stale
+# Number of days of inactivity before an issue becomes stale
-daysUntilStale: 60
+daysUntilStale: 60
-# Number of days of inactivity before a stale issue is closed
+# Number of days of inactivity before a stale issue is closed
-daysUntilClose: 7
+daysUntilClose: 7
-# Issues with these labels will never be considered stale
+# Issues with these labels will never be considered stale
-exemptLabels:
+exemptLabels:
-  - pinned
+  - pinned
-  - security
+  - security
-  - enhancement
+  - enhancement
-  - bug
+  - bug
-# Label to use when marking an issue as stale
+# Label to use when marking an issue as stale
-staleLabel: wontfix
+staleLabel: wontfix
-# Comment to post when marking an issue as stale. Set to `false` to disable
+# Comment to post when marking an issue as stale. Set to `false` to disable
-markComment: >
+markComment: >
-  This issue has been automatically marked as stale because it has not had
+  This issue has been automatically marked as stale because it has not had
-  recent activity. It will be closed if no further activity occurs. Thank you
+  recent activity. It will be closed if no further activity occurs. Thank you
-  for your contributions.
+  for your contributions.
-# Comment to post when closing a stale issue. Set to `false` to disable
+# Comment to post when closing a stale issue. Set to `false` to disable
 closeComment: false

.github/workflows/build.yml

@@ -1,89 +0,0 @@
-name: Java CI
-
-on: [ push ]
-
-jobs:
-  build:
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        java: [ "17", "21" ]
-
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
-
-      # Setup
-      - name: Set up QEMU
-        uses: docker/setup-qemu-action@v3
-
-      - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v3
-
-      - name: Set up Java
-        uses: actions/setup-java@v4
-        with:
-          java-version: ${{ matrix.java }}
-          distribution: "temurin"
-          cache: "maven"
-
-      # Build
-      - name: Build with Maven
-        run: mvn --batch-mode --update-snapshots verify
-
-      - name: Upload JAR
-        uses: actions/upload-artifact@v4
-        if: ${{ matrix.java == '17' }}
-        with:
-          name: commafeed.jar
-          path: commafeed-server/target/commafeed.jar
-
-      # Docker
-      - name: Login to Container Registry
-        uses: docker/login-action@v3
-        if: ${{ matrix.java == '17' && (github.ref_type == 'tag' || github.ref_name == 'master') }}
-        with:
-          username: ${{ secrets.DOCKERHUB_USERNAME }}
-          password: ${{ secrets.DOCKERHUB_TOKEN }}
-
-      - name: Docker build and push tag
-        uses: docker/build-push-action@v5
-        if: ${{ matrix.java == '17' && github.ref_type == 'tag' }}
-        with:
-          context: .
-          push: true
-          platforms: linux/amd64,linux/arm/v7,linux/arm64/v8
-          tags: |
-            athou/commafeed:latest
-            athou/commafeed:${{ github.ref_name }}
-
-      - name: Docker build and push master
-        uses: docker/build-push-action@v5
-        if: ${{ matrix.java == '17' && github.ref_name == 'master' }}
-        with:
-          context: .
-          push: true
-          platforms: linux/amd64,linux/arm/v7,linux/arm64/v8
-          tags: athou/commafeed:master
-
-      # Create GitHub release after Docker image has been published
-      - name: Extract Changelog Entry
-        uses: mindsers/changelog-reader-action@v2
-        if: ${{ matrix.java == '17' && github.ref_type == 'tag' }}
-        id: changelog_reader
-        with:
-          version: ${{ github.ref_name }}
-
-      - name: Create GitHub release
-        uses: softprops/action-gh-release@v1
-        if: ${{ matrix.java == '17' && github.ref_type == 'tag' }}
-        with:
-          name: CommaFeed ${{ github.ref_name }}
-          body: ${{ steps.changelog_reader.outputs.changes }}
-          draft: false
-          prerelease: false
-          files: |
-            commafeed-server/target/commafeed.jar
-            commafeed-server/config.yml.example

.github/workflows/ci.yml

@@ -0,0 +1,278 @@
+name: ci
+permissions:
+  contents: read
+
+on:
+  push:
+  pull_request:
+
+env:
+  JAVA_VERSION: 21
+  DOCKER_BUILD_SUMMARY: false
+
+jobs:
+  build:
+    if: github.event_name != 'pull_request' || github.actor != 'renovate[bot]' # renovate already triggers the build on pushes
+
+    strategy:
+      matrix:
+        os: [ "ubuntu-latest", "ubuntu-22.04-arm", "windows-latest" ]
+        database: [ "h2", "postgresql", "mysql", "mariadb" ]
+
+    runs-on: ${{ matrix.os }}
+    steps:
+      # Checkout
+      - name: Checkout
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
+        with:
+          fetch-depth: 0
+
+      # Setup
+      - name: Set up GraalVM
+        uses: graalvm/setup-graalvm@01ed653ac833fe80569f1ef9f25585ba2811baab # v1
+        with:
+          java-version: ${{ env.JAVA_VERSION }}
+          distribution: "graalvm"
+          cache: "maven"
+
+      - name: Install Playwright dependencies
+        run: sudo apt-get install -y libgbm1
+        if: matrix.os != 'windows-latest'
+
+      # Build & Test
+      - name: Build with Maven
+        run: mvn --batch-mode --no-transfer-progress install -Pnative -P${{ matrix.database }} -DskipTests=${{ matrix.os == 'windows-latest' && matrix.database != 'h2' }}
+
+      # Build pages
+      - name: Create pages directory structure
+        run: mkdir -p target/pages/documentation/custom-css
+
+      - name: Convert readme file to html
+        uses: jaywcjlove/markdown-to-html-cli@d2c8ffd676de1801e2586904bc540a938e4bc480 # v5.0.3
+        with:
+          source: README.md
+          output: target/pages/index.html
+
+      - name: Convert config documentation to html
+        uses: jaywcjlove/markdown-to-html-cli@d2c8ffd676de1801e2586904bc540a938e4bc480 # v5.0.3
+        with:
+          source: commafeed-server/target/quarkus-generated-doc/config/commafeed-server.md
+          output: target/pages/documentation/index.html
+
+      - name: Convert custom css documentation to html
+        uses: jaywcjlove/markdown-to-html-cli@d2c8ffd676de1801e2586904bc540a938e4bc480 # v5.0.3
+        with:
+          source: documentation/CUSTOMCSS.md
+          output: target/pages/documentation/custom-css/index.html
+
+      # Upload artifacts
+      - name: Upload cross-platform app
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
+        if: matrix.os == 'ubuntu-latest' # we only need to upload the cross-platform artifact once per database
+        with:
+          name: commafeed-${{ matrix.database }}-jvm
+          path: commafeed-server/target/commafeed-*.zip
+
+      - name: Upload native executable
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
+        with:
+          name: commafeed-${{ matrix.database }}-${{ runner.os }}-${{ runner.arch }}
+          path: commafeed-server/target/commafeed-*-runner*
+
+      - name: Upload pages
+        uses: actions/upload-pages-artifact@56afc609e74202658d3ffba0e8f6dda462b719fa # v3
+        if: matrix.os == 'ubuntu-latest' && matrix.database == 'h2' # we only need to upload the pages once
+        with:
+          path: target/pages
+
+  docker:
+    runs-on: ubuntu-latest
+    needs: build
+    env:
+      DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
+
+    strategy:
+      matrix:
+        database: [ "h2", "postgresql", "mysql", "mariadb" ]
+
+    steps:
+      # Checkout
+      - name: Checkout
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
+        with:
+          fetch-depth: 0
+
+      # Setup
+      - name: Set up QEMU
+        uses: docker/setup-qemu-action@29109295f81e9208d7d86ff1c6c12d2833863392 # v3
+
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@b5ca514318bd6ebac0fb2aedd5d36ec1b5c232a2 # v3
+
+      - name: Install required packages
+        run: sudo apt-get install -y rename unzip
+
+      # Prepare artifacts
+      - name: Download artifacts
+        uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4
+        with:
+          pattern: commafeed-${{ matrix.database }}-*
+          path: ./artifacts
+          merge-multiple: true
+
+      - name: Set the exec flag on the native executables
+        run: chmod +x artifacts/*-runner
+
+      - name: Rename native executables to match buildx TARGETARCH
+        run: |
+          rename 's/x86_64/amd64/g' artifacts/*
+          rename 's/aarch_64/arm64/g' artifacts/*
+
+      - name: Unzip jvm package
+        run: |
+          unzip artifacts/*-jvm.zip -d artifacts/extracted-jvm-package
+          rename 's/commafeed-.*/quarkus-app/g' artifacts/extracted-jvm-package/*
+
+      # Docker
+      - name: Login to Container Registry
+        uses: docker/login-action@74a5d142397b4f367a81961eba4e8cd7edddf772 # v3
+        if: ${{ env.DOCKERHUB_USERNAME != '' }}
+        with:
+          username: ${{ secrets.DOCKERHUB_USERNAME }}
+          password: ${{ secrets.DOCKERHUB_TOKEN }}
+
+      ## build but don't push for PRs and renovate
+      - name: Docker build - native
+        uses: docker/build-push-action@263435318d21b8e681c14492fe198d362a7d2c83 # v6
+        with:
+          context: .
+          file: commafeed-server/src/main/docker/Dockerfile.native
+          push: false
+          platforms: linux/amd64,linux/arm64/v8
+
+      - name: Docker build - jvm
+        uses: docker/build-push-action@263435318d21b8e681c14492fe198d362a7d2c83 # v6
+        with:
+          context: .
+          file: commafeed-server/src/main/docker/Dockerfile.jvm
+          push: false
+          platforms: linux/amd64,linux/arm64/v8
+
+      ## build and push tag
+      - name: Docker build and push tag - native
+        uses: docker/build-push-action@263435318d21b8e681c14492fe198d362a7d2c83 # v6
+        if: ${{ github.ref_type == 'tag' }}
+        with:
+          context: .
+          file: commafeed-server/src/main/docker/Dockerfile.native
+          push: ${{ env.DOCKERHUB_USERNAME != '' }}
+          platforms: linux/amd64,linux/arm64/v8
+          tags: |
+            athou/commafeed:latest-${{ matrix.database }}
+            athou/commafeed:${{ github.ref_name }}-${{ matrix.database }}
+
+      - name: Docker build and push tag - jvm
+        uses: docker/build-push-action@263435318d21b8e681c14492fe198d362a7d2c83 # v6
+        if: ${{ github.ref_type == 'tag' }}
+        with:
+          context: .
+          file: commafeed-server/src/main/docker/Dockerfile.jvm
+          push: ${{ env.DOCKERHUB_USERNAME != '' }}
+          platforms: linux/amd64,linux/arm64/v8
+          tags: |
+            athou/commafeed:latest-${{ matrix.database }}-jvm
+            athou/commafeed:${{ github.ref_name }}-${{ matrix.database }}-jvm
+
+      ## build and push master
+      - name: Docker build and push master - native
+        uses: docker/build-push-action@263435318d21b8e681c14492fe198d362a7d2c83 # v6
+        if: ${{ github.ref_name == 'master' }}
+        with:
+          context: .
+          file: commafeed-server/src/main/docker/Dockerfile.native
+          push: ${{ env.DOCKERHUB_USERNAME != '' }}
+          platforms: linux/amd64,linux/arm64/v8
+          tags: athou/commafeed:master-${{ matrix.database }}
+
+      - name: Docker build and push master - jvm
+        uses: docker/build-push-action@263435318d21b8e681c14492fe198d362a7d2c83 # v6
+        if: ${{ github.ref_name == 'master' }}
+        with:
+          context: .
+          file: commafeed-server/src/main/docker/Dockerfile.jvm
+          push: ${{ env.DOCKERHUB_USERNAME != '' }}
+          platforms: linux/amd64,linux/arm64/v8
+          tags: athou/commafeed:master-${{ matrix.database }}-jvm
+
+  release:
+    runs-on: ubuntu-latest
+    needs:
+      - build
+      - docker
+    permissions:
+      contents: write
+    if: github.ref_type == 'tag'
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
+        with:
+          fetch-depth: 0
+
+      - name: Download artifacts
+        uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4
+        with:
+          pattern: commafeed-*
+          path: ./artifacts
+          merge-multiple: true
+
+      - name: Set the exec flag on the native executables
+        run: chmod +x artifacts/*-runner
+
+      - name: Extract Changelog Entry
+        uses: mindsers/changelog-reader-action@32aa5b4c155d76c94e4ec883a223c947b2f02656 # v2
+        id: changelog_reader
+        with:
+          version: ${{ github.ref_name }}
+
+      - name: Create GitHub release
+        uses: ncipollo/release-action@440c8c1cb0ed28b9f43e4d1d670870f059653174 # v1
+        with:
+          name: CommaFeed ${{ github.ref_name }}
+          body: ${{ steps.changelog_reader.outputs.changes }}
+          artifacts: ./artifacts/*
+
+
+  update-dockerhub-description:
+    runs-on: ubuntu-latest
+    needs: release
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
+        with:
+          fetch-depth: 0
+
+      - name: Update Docker Hub Description
+        uses: peter-evans/dockerhub-description@432a30c9e07499fd01da9f8a49f0faf9e0ca5b77 # v4
+        with:
+          username: ${{ secrets.DOCKERHUB_USERNAME }}
+          password: ${{ secrets.DOCKERHUB_TOKEN }}
+          repository: athou/commafeed
+          short-description: ${{ github.event.repository.description }}
+          readme-filepath: commafeed-server/src/main/docker/README.md
+
+
+  deploy-pages:
+    runs-on: ubuntu-latest
+    needs: release
+    permissions:
+      pages: write
+      id-token: write
+    environment:
+      name: github-pages
+      url: ${{ steps.deployment.outputs.page_url }}
+
+    steps:
+      - uses: actions/deploy-pages@d6db90164ac5ed86f2b6aed7e0febac5b3c0c03e # v4
+        id: deployment

.mvn/wrapper/maven-wrapper.properties

@@ -1,18 +1,18 @@
-# Licensed to the Apache Software Foundation (ASF) under one
+# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements.  See the NOTICE file
+# or more contributor license agreements.  See the NOTICE file
-# distributed with this work for additional information
+# distributed with this work for additional information
-# regarding copyright ownership.  The ASF licenses this file
+# regarding copyright ownership.  The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
+# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
+# "License"); you may not use this file except in compliance
-# with the License.  You may obtain a copy of the License at
+# with the License.  You may obtain a copy of the License at
-#
+#
-#   https://www.apache.org/licenses/LICENSE-2.0
+#   http://www.apache.org/licenses/LICENSE-2.0
-#
+#
-# Unless required by applicable law or agreed to in writing,
+# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
+# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied.  See the License for the
+# KIND, either express or implied.  See the License for the
-# specific language governing permissions and limitations
+# specific language governing permissions and limitations
-# under the License.
+# under the License.
-distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.3/apache-maven-3.8.3-bin.zip
+distributionType=only-script
-wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1.jar
+distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.9/apache-maven-3.9.9-bin.zip

CHANGELOG.md

@@ -1,315 +1,497 @@
-# Changelog
+# Changelog
-
+
-## [4.3.2]
+## [5.10.0]
-
+
-- added support for unix sockets (#1278)
+- Add an indicator next to each feed's unread count in the tree to show when new entries are discovered while the app is open (#1762)
-
+- Feeds with uppercase HTTP:// or HTTPS:// URLs are now correctly handled again
-## [4.3.1]
+- The aarch64 native executable now also works on the Raspberry Pi 5 (#1795)
-
+- Improve general performance of the UI by reducing the number of re-renders, especially when a lot of entries are displayed (#1087)
-- fix an issue that prevents new feeds from being added when mysql/mariadb is used as the database and the database
+
-  timezone is not UTC (#1239)
+## [5.9.0]
-- videos in enclosures can no longer have a width larger than the page (#1240)
+
-
+- A lot of CSS classes have been added to the elements of the application to ease custom CSS rules (#1757)
-## [4.3.0]
+- Added a link in the README to the [documentation](https://athou.github.io/commafeed/documentation/custom-css/) of the new CSS classes
-
+- Static resources are now cached for much longer (#1782)
-- h2 (the embedded database) has been upgraded to 2.2.224
+
-    - this version uses a different file format than 2.1.x, the first time you start CommaFeed with this version, the
+## [5.8.0]
-      database will be automatically converted to the new format
+
-- add a setting to completely disable scrolling to selected entry (#1157)
+- A color picker is now available on the settings page to change the orange accent of the application (#1598)
-- add a css class reflecting the current view mode to ease custom css rules (#1232)
+- A font size slider is now available to change the size of the text of feed entries (#1462)
-- fix an issue that prevents new feeds from being added when mysql/mariadb is used as the database (#1239)
+- The "mark all as read" confirmation setting now also applies to the "shift+a" keyboard shortcut (#1744)
-
+- CommaFeed wil try to match the language of the browser before defaulting to english (#1767)
-## [4.2.1]
+- The default value for the number of entries to keep above the selected entry when scrolling is now 1 instead of 0 to match what other feed readers do
-
+
-- fix an issue that caused the tree to show an incorrect unread count after a websocket notification because entries
+## [5.7.0]
-  that were already marked as read by a filtering expression were not ignored (#1191)
+
-
+- Add Shift+J/Shift+K keyboard shortcuts to navigate to the next/previous feed or category with unread entries (#1558)
-## [4.2.0]
+- Add the referrer "no-referrer" meta to index.html (#1724)
-
+- Load custom JS code when the app is done loading (#1724)
-- add a setting to display the action buttons in the footer instead of in the header on mobile (#1121)
+- Correctly handle feeds that return an unmodified Last-Modified header but a different ETag header (#1746)
-- the websocket notification now contains everything needed to update the UI, the client no longer needs to make an API
+- Restore gzip compression of responses that was accidentaly disabled since 5.0.0
-  call to get the latest data when receiving the notification
+- Fix tooltips not showing up in mobile view
-- add a workaround to the Fever API for the Unread iOS app (#1188)
+- Fix the bookmarklet generator on the About page
-- fix an issue that caused dates to be saved incorrectly if the database server and the application server were in
+
-  different timezones (#1187)
+## [5.6.1]
-
+
-## [4.1.0]
+- Restore support for iframes in feed entries (#1688)
-
+- There is now a package available for Arch Linux thanks to @dcelasun (#1691)
-- it is now possible to open the sidebar on mobile by swiping to the right (#1098)
+
-- swiping to mark entries as read/unread changed from swiping right to left because swiping right now opens the sidebar
+## [5.6.0]
-- the full hierarchy of categories are now displayed in the category dropdown (#1045)
+
-- added a setting `maxEntriesAgeDays` to delete old entries based on their age during database cleanup.
+- To better respect the bandwidth of feed owners, the default value of `commafeed.feed-refresh.interval-empirical` is now true. This means feeds no longer refresh exactly every 5 minutes (the default value of `commafeed.feed-refresh.interval`) but between 5 minutes and 4 hours (the default value of the new `commafeed.feed-refresh.max-interval` setting). The interval is calculated based on feed activity, so highly active feeds refresh more often (#1677)
-  The setting is disabled by default for existing installations, except for the docker image where it is enabled and set
+- Many previously hardcoded values used in feed refresh interval calculation are now exposed as settings (#1677)
-  to 365 days
+- Access to local addresses is now blocked to mitigate server-side request forgery (SSRF) attacks, which could potentially expose internal resources. You might want to disable the new `commafeed.http-client.block-local-addresses` setting if you subscribe to feeds only available on your local network and you trust all your users
-- if user registrations are disabled on your instance which is the default behavior, users are redirected on the login
+- If a feed responds with a "429 - Too many requests" response, a backoff mechanism is triggered when the response does not contain a "Retry-After" header
-  page instead of the welcome page when not logged in (#1185)
+
-- the sidebar resizer is no longer shown in the middle of the screen on mobile
+## [5.5.0]
-- when using the system color scheme and the system is using a dark theme, feed entries no longer flicker on load
+
-- the demo account (if enabled) cannot register custom javascript code anymore
+- CommaFeed now honors the Retry-After response header and will not try to refresh a feed sooner than the value of this header
-- removed the usage of `toSorted` in the client because older browsers do not support it (#1183)
+- Audio enclosures (e.g. podcasts) now fill available entry width
-- the openapi documentation is no longer cached by the browser so you always have access to the latest version
+- Fix an issue with some labels not correctly internationalized
-- added a memory management section to the readme, reading it is recommended if you are running CommaFeed on a server
+
-  with limited memory
+## [5.4.0]
-- fixed an issue that caused users without an email address set to be unable to edit their profile (#1184)
+
-
+- An arm64 native executable is now available for download on the releases page
-## [4.0.0]
+- The native executable Docker image now supports arm64
-
+- Fixed an issue with feeds that declared an invalid DOCTYPE (#1260)
-- migrated from dropwizard 2 to dropwizard 4, Java 17+ is now required
+
-- entries that were fetched and inserted in the database but not yet shown in the UI are no longer marked as read when
+## [5.3.6]
-  marking all entries as read
+
-- your custom sidebar width is now persisted in the local storage of your browser
+- Ignore invalid Cache-Control header values (#1619)
-- there is now a third color scheme option in addition to light and dark: system (follows the system color scheme)
+
-- added support for youtube playlist favicons
+## [5.3.5]
-- custom JS code is now executed when the app is done loading instead of when the page is loaded
+
-- the favicon is now correctly returned for feeds that return an invalid content type
+- Fixed an issue with the aspect ratio of images of some feeds (#1595)
-- the feed refresh engine now uses httpclient5 with connection pooling and no longer creates a new client for each
+- CommaFeed now honors the Cache-Control response header and will not try to refresh a feed sooner than its max-age property (#1615)
-  request, reducing CPU usage
+- Added support for compilation with JDK 23+. If you're building CommaFeed from sources with a JDK 17 or 21, you may need to update it to the most recent patch version to support `-proc:full` (#1618)
-- updated UI library Mantine to 7.0, improving performance
+
-- the h2 embedded database is now compacted on shutdown to reclaim unused space
+## [5.3.4]
-- the admin connector on port 8084 is now disabled in config.yml.example. Disabling it in your config.yml is
+
-  recommended (see https://github.com/Athou/commafeed/commit/929df60f09cce56020b0962ab111cd8349b271b0)
+- Added support for Internationalized Domain Names (#1588)
-- migrated documentation from swagger 2 to openapi 3
+
-- added a GET method to the fever api to indicate that the endpoint is working correctly when accessed from a browser
+## [5.3.3]
-- the websocket connection can now be disabled, the websocket ping interval and the tree reload interval can now be
+
-  configured (see config.yml.example)
+- Removed image bottom margins (#1587)
-- the websocket connection now works correctly when the context root of the application is not "/"
+
-- unstable pubsubhubbub support was removed
+## [5.3.2]
-
+
-## [3.10.1]
+- Fixed an issue that could cause some images from not being rendered correctly (#1587)
-
+
-- swap next and previous buttons (#1159)
+## [5.3.1]
-- unread count for subscriptions will now be shortened starting at 10k instead of 1k
+
-- increased websocket ping interval to just under a minute to reduce data and battery usage on mobile
+- Fixed an issue that could cause some HTTP feeds to return a 400 error (#1572)
-- only refresh subscription tree on a timer if websocket connection is unavailable
+
-- the Docker image now uses less memory by returning unused memory to the OS
+## [5.3.0]
-- add support for Java 21
+
-
+- Added a setting to set a cooldown on the "fetch all my feeds" action, disabled by default (#1556)
-## [3.10.0]
+- Fixed an issue that could cause entries to not correctly load when using the "next" header button (#1557)
-
+
-- added a Fever-compatible API that is usable with mobile clients that support the Fever API (see instructions in
+## [5.2.0]
-  Settings -> Profile)
+
-- long entry titles are no longer shortened in the detailed view
+- Added an option to keep a number of entries above the selected entry when scrolling
-- added the "s" keyboard shortcut to star/unstar entries
+- Added a cache to the HTTP client to reduce the number of requests made to feeds when subscribing (#1431)
-- http sessions are now stored in the database (they were stored on disk before)
+- Feeds are no longer refreshed between the moment its last user unsubscribes and the moment the feed is cleaned up (every hour)
-- fixed an issue that made it impossible to override the database url in a config.yml mounted in the Docker image
+- Fixed an issue that could cause entries to not correctly load when using keyboard navigation (#1557)
-
+
-## [3.9.0]
+## [5.1.1]
-
+
-- improve performance by disabling the loader when nothing is loading (most noticeable on mobile)
+- Fixed database migration issue when upgrading from 5.0.0 to 5.1.0 on MariaDB (#1544)
-- added a setting to disable the 'mark all as read' confirmation
+- When feeds without unread entries are hidden from the tree, the feed is displayed in the tree until another one is selected (#1543)
-- added a setting to disable the custom context menu
+
-- if the custom context is enabled, it can still be disabled by pressing the shift key
+## [5.1.0]
-- the announcement feature is now working again and supports html ('announcement' configuration element in config.yml)
+
-- add support for MariaDB 11+
+- Added a setting for showing/hiding unread count in the browser's tab title/favicon (#1518)
-- fix entry header shortly rendered as mobile on desktop, causing a small visual glitch
+- Fixed an issue that could prevent the app from starting on some systems (#1532)
-- fix an issue that could cause a feed to not refresh correctly if the url was very long
+- Added a cache busting filter for the webapp index.html and openapi documentation to make sure they are always up to date
-- database cleanup batch size is now configurable
+- Reduced database cleanup log verbosity
-- css parsing errors are no longer logged to the standard output
+
-- fix small errors in the api documentation
+## [5.0.2]
-
+
-## [3.8.1]
+- Fix favicon fetching for Youtube channels in native mode when Google auth key is set
-
+- Fix an error that appears in the logs when fetching some favicons
-- in expanded mode, don't scroll when clicking on the body of the current entry
+
-- improve content cleanup task performance for instances with a very large number of feeds
+## [5.0.1]
-
+
-## [3.8.0]
+- Configure native compilation to support older CPU architectures (#1524)
-
+
-- add previous and next buttons in the toolbar
+## [5.0.0]
-- add a setting to always scroll selected entry to the top of the page, even if it fits entirely on screen
+
-- clicking on the body of an entry in expanded mode selects it and marks it as read
+CommaFeed is now powered by Quarkus instead of Dropwizard. Read the rationale behind this change in
-- add rich text editor with autocomplete for custom css and js code in settings (desktop only)
+the [announcement](https://github.com/Athou/commafeed/discussions/1517).
-- dramatically improve performance while scrolling
+The gist of it is that CommaFeed can now be compiled to a native binary, resulting in blazing fast startup times (around
-- fix broken welcome page mobile layout
+0.3s) and very low memory footprint (< 50M).
-- format dates in user locale instead of GMT in relative date popups
+
-
+- CommaFeed now has a different package for each supported database.
-## [3.7.0]
+    - If you are deploying CommaFeed with a precompiled package, please
-
+      read [this section of the README](https://github.com/Athou/commafeed/tree/master?tab=readme-ov-file#download-a-precompiled-package).
-- the sidebar is now resizable
+    - If you are building CommaFeed from sources, please
-- added the "f" keyboard shortcut to hide the sidebar
+      read [this section of the README](https://github.com/Athou/commafeed/tree/master?tab=readme-ov-file#build-from-sources).
-- added tooltips to relative dates with the exact date
+    - If you are using the Docker image, please read the instructions on
-- add a setting to hide commafeed from search engines (exposes a robots.txt file, enabled by default)
+      the [Docker Hub page](https://hub.docker.com/r/athou/commafeed).
-- the browser extension unread count now updates when articles are marked as read/unread in the app
+- Due to the switch to Quarkus, the way CommaFeed is configured is very different (the `config.yml` file is gone).
-- The "b" keyboard shortcut now works as expected on Chrome but requires the browser extension to be installed
+  Please
-- dark mode has been disabled on the api documentation page as it was unreadable
+  read [this section of the README](https://github.com/Athou/commafeed/tree/master?tab=readme-ov-file#configuration).
-- improvement to the feed refresh queuing logic when "heavy load" mode is enabled
+  Note that a lot of configuration elements have been removed or renamed and are now nested/grouped by feature.
-- fix a bug that could prevent feeds and categories from being edited
+- Added a setting to prevent parsing large feeds to avoid out of memory errors. The default is 5MB.
-
+- Use a different icon for filtering unread entries and marking an entry as read (#1506)
-## [3.6.0]
+- Added various HTML attributes to ease custom JS/CSS customization (#1507)
-
+- The Redis cache has been removed. There have been multiple enhancements to the feed refresh engine and it is no longer
-- add a button to open CommaFeed in a new tab and a button to open options when using the browser extension
+  needed, even for instances with a large number of feeds.
-- clicking on the entry title in expanded mode now opens the link instead of doing nothing
+- The H2 migration tool that automatically upgrades H2 databases from format 2 to 3 has been removed. If you're using
-- add tooltips to buttons when the mobile layout is used on desktop
+  the H2 embedded database, please upgrade to at least version 4.3.0 before upgrading to CommaFeed 5.0.0.
-- redirect the user to the welcome page if the user was deleted from the database
+
-- add link to api documentation on welcome page
+## [4.6.0]
-- the unread count is now correctly updated when using the "/next" bookmarklet while redis cache is enabled
+
-
+- switched from Temurin to OpenJ9 as the JVM used in the Docker image, resulting in memory usage reduction by up to 50%
-## [3.5.0]
+- fix an issue that could cause old entries to reappear if they were updated by their author (#1486)
-
+- show all entries regardless of their read status when searching with keywords, even if the ui is configured to show
-- add compatibility with the new version of the CommaFeed browser extension
+  unread entries only
-- disable pull-to-refresh on mobile as it messes with vertical scrolling
+
-- add css classes to feed entries to help with custom css rules
+## [4.5.0]
-- api documentation page no longer requires users to be authenticated
+
-- add a setting to limit the number of feeds a user can subscribe to
+- significantly reduce the time needed to retrieve entries or mark them as read, especially when there are a lot of
-- add a setting to disable strict password policy
+  entries (#1452)
-- add feed refresh engine metrics
+- fix a race condition where a feed could be refreshed before it was created in the database
-- fix redis timeouts
+- fix an issue that could cause the websocket notification to contain the wrong number of unread entries when using
-
+  mysql/mariadb
-## [3.4.0]
+- fix an error when trying to mark all starred entries as read
-
+- remove the `onlyIds` parameter from REST endpoints since retrieving all the entries is now just as fast
-- add support for arm64 docker images
+- remove support for microsoft sqlserver because it's not covered with integration tests (please open an issue if you'd
-- add divider to visually separate read-only information from form on the profile settings page
+  like it back)
-- reduce javascript bundle size by 30% by loading only the necessary translations
+
-- add a standalone donate page with all ways to support CommaFeed
+## [4.4.1]
-- fix an issue introduced in 3.1.0 that could make CommaFeed not refresh feeds as fast as before on instances with lots
+
-  of feeds
+- fix vertical scrolling issues with Safari (#1168)
-- fix alignment of icon with text for category tree nodes
+- the default value for new users for the "star entry" button and the "open in new tab" button in the entry headers is
-- fix alignment of burger button with the rest of the header on mobile
+  now "on desktop" instead of "always"
-
+- the "keyboard shortcuts" help page now shows "Cmd" instead of "Ctrl" on macOS (#1389)
-## [3.3.2]
+- remove a superfluous feed fetch when subscribing to a feed (#1431)
-
+- the Docker image now uses Java 21
-- restore entry selection indicator (left orange border) that was lost with the mantine 6.x upgrade (3.3.0)
+
-- add dividers to visually separate read-only information from forms on feed and category details pages
+## [4.4.0]
-- reduced javascript bundle size by 10%
+
-
+- add support for sharing using the browser native capabilities if available (#1255)
-## [3.3.1]
+- add a button in the entry headers to star an entry (#1025)
-
+- add a button in the entry headers to open links in a new tab (#1333)
-- fix long feed names not being shortened to respect tree max width
+- add two options in the settings to toggle those buttons
-
+- accept .opml file extension when importing and export with the .opml extension
-## [3.3.0]
+- the "mark as read" option is no longer shown in the context menu for entries that are too old to be marked as read (
-
+  older than `keepStatusDays`) (#1303)
-- there are now database changes, rolling back to 2.x will no longer be possible
+
-- restore support for user custom CSS rules
+## [4.3.3]
-- add support for user custom JS code that will be executed on page load
+
-
+- fix OPML import (#1279)
-## [3.2.0]
+
-
+## [4.3.2]
-- restore the welcome page
+
-- only apply hover effect for unread entries (same as commafeed v2)
+- added support for unix sockets (#1278)
-- move notifications at the bottom of the screen
+
-- always use https for sharing urls
+## [4.3.1]
-- add support for redis ACLs
+
-- transition to google analytics v4
+- fix an issue that prevents new feeds from being added when mysql/mariadb is used as the database and the database
-
+  timezone is not UTC (#1239)
-## [3.1.0]
+- videos in enclosures can no longer have a width larger than the page (#1240)
-
+
-- add an even more compact layout
+## [4.3.0]
-- restore hover effect from commafeed 2.x
+
-- view mode (compact, expanded, ...) is now stored on the device so you can have a different view mode on desktop and
+- h2 (the embedded database) has been upgraded to 2.2.224
-  mobile
+    - this version uses a different file format than 2.1.x, the first time you start CommaFeed with this version, the
-- fix for the "Illegal attempt to associate a collection with two open sessions." error
+      database will be automatically converted to the new format
-- feed fetching workflow is now orchestrated with rxjava, removing a lot of code
+- add a setting to completely disable scrolling to selected entry (#1157)
-
+- add a css class reflecting the current view mode to ease custom css rules (#1232)
-## [3.0.1]
+- fix an issue that prevents new feeds from being added when mysql/mariadb is used as the database (#1239)
-
+
-- allow env variable substitution in config.yml
+## [4.2.1]
-- e.g. having a custom config.yml file with `app.session.path=${SOME_ENV_VAR}` will substitute `SOME_ENV_VAR` with its
+
-  value
+- fix an issue that caused the tree to show an incorrect unread count after a websocket notification because entries
-- allow env variable prefixed with `CF_` to override config.yml properties
+  that were already marked as read by a filtering expression were not ignored (#1191)
-- e.g. setting `CF_APP_ALLOWREGISTRATIONS=true` will set `app.allowRegistrations` to `true`
+
-
+## [4.2.0]
-## [3.0.0]
+
-
+- add a setting to display the action buttons in the footer instead of in the header on mobile (#1121)
-- complete overhaul of the UI
+- the websocket notification now contains everything needed to update the UI, the client no longer needs to make an API
-- backend and frontend are now in separate maven modules
+  call to get the latest data when receiving the notification
-- no changes to the api or the database
+- add a workaround to the Fever API for the Unread iOS app (#1188)
-- Docker images are now automatically built and available at https://hub.docker.com/r/athou/commafeed
+- fix an issue that caused dates to be saved incorrectly if the database server and the application server were in
-
+  different timezones (#1187)
-## [2.6.0]
+
-
+## [4.1.0]
-- add support for media content as a backup for missing content (useful for youtube feeds)
+
-- correctly follow http error code 308 redirects
+- it is now possible to open the sidebar on mobile by swiping to the right (#1098)
-- fixed a bug that prevented users from deleting their account
+- swiping to mark entries as read/unread changed from swiping right to left because swiping right now opens the sidebar
-- fixed a bug that made commafeed store entry contents multiple times
+- the full hierarchy of categories are now displayed in the category dropdown (#1045)
-- fixed a bug that prevented the app to be used as an installed app on mobile devices if the context path of commafeed
+- added a setting `maxEntriesAgeDays` to delete old entries based on their age during database cleanup.
-  was not "/"
+  The setting is disabled by default for existing installations, except for the docker image where it is enabled and set
-- fixed a bug that prevented entries from being "marked as read older than xxx" for a feed that was just added
+  to 365 days
-- removed support for google+ and readability as those services no longer exist
+- if user registrations are disabled on your instance which is the default behavior, users are redirected on the login
-- removed support for deploying on openshift
+  page instead of the welcome page when not logged in (#1185)
-- removed alphabetical sorting of entries because of really poor performance (title cannot be indexed)
+- the sidebar resizer is no longer shown in the middle of the screen on mobile
-- improve performance for instances with the heavy load setting enabled by preventing CommaFeed from fetching feeds from
+- when using the system color scheme and the system is using a dark theme, feed entries no longer flicker on load
-  users that did not log in for a long time
+- the demo account (if enabled) cannot register custom javascript code anymore
-- various dependencies upgrades (notably dropwizard from 1.3 to 2.1)
+- removed the usage of `toSorted` in the client because older browsers do not support it (#1183)
-- add support for mariadb
+- the openapi documentation is no longer cached by the browser so you always have access to the latest version
-- add support for java17+ runtime
+- added a memory management section to the readme, reading it is recommended if you are running CommaFeed on a server
-- various security improvements
+  with limited memory
-
+- fixed an issue that caused users without an email address set to be unable to edit their profile (#1184)
-## [2.5.0]
+
-
+## [4.0.0]
-- unread count is now displayed in a favicon badge when supported
+
-- the user agent string for the bot fetching feeds is now configurable
+- migrated from dropwizard 2 to dropwizard 4, Java 17+ is now required
-- feed parsing performance improvements
+- entries that were fetched and inserted in the database but not yet shown in the UI are no longer marked as read when
-- support for java9+ runtime
+  marking all entries as read
-- can now properly start from an empty postgresql database
+- your custom sidebar width is now persisted in the local storage of your browser
-
+- there is now a third color scheme option in addition to light and dark: system (follows the system color scheme)
-## [2.4.0]
+- added support for youtube playlist favicons
-
+- custom JS code is now executed when the app is done loading instead of when the page is loaded
-- users were not able to change password or delete account
+- the favicon is now correctly returned for feeds that return an invalid content type
-- fix api key generation
+- the feed refresh engine now uses httpclient5 with connection pooling and no longer creates a new client for each
-- feed entries can now be sorted alphabetically
+  request, reducing CPU usage
-- fix facebook sharing
+- updated UI library Mantine to 7.0, improving performance
-- fix layout on iOS
+- the h2 embedded database is now compacted on shutdown to reclaim unused space
-- postgresql driver update (fix for postgres 9.6)
+- the admin connector on port 8084 is now disabled in config.yml.example. Disabling it in your config.yml is
-- various internationalization fixes
+  recommended (see https://github.com/Athou/commafeed/commit/929df60f09cce56020b0962ab111cd8349b271b0)
-- security fixes
+- migrated documentation from swagger 2 to openapi 3
-
+- added a GET method to the fever api to indicate that the endpoint is working correctly when accessed from a browser
-## [2.3.0]
+- the websocket connection can now be disabled, the websocket ping interval and the tree reload interval can now be
-
+  configured (see config.yml.example)
-- dropwizard upgrade 0.9.1
+- the websocket connection now works correctly when the context root of the application is not "/"
-- feed enclosures are hidden if they already displayed in the content
+- unstable pubsubhubbub support was removed
-- fix youtube favicons
+
-- various internationalization fixes
+## [3.10.1]
-
+
-## [2.2.0]
+- swap next and previous buttons (#1159)
-
+- unread count for subscriptions will now be shortened starting at 10k instead of 1k
-- fix youtube and instagram favicon fetching
+- increased websocket ping interval to just under a minute to reduce data and battery usage on mobile
-- mark as read filter was lost when a feed was rearranged with drag&drop
+- only refresh subscription tree on a timer if websocket connection is unavailable
-- feed entry categories are now displayed if available
+- the Docker image now uses less memory by returning unused memory to the OS
-- various performance and dependencies upgrades
+- add support for Java 21
-- java8 is now required
+
-
+## [3.10.0]
-## [2.1.0]
+
-
+- added a Fever-compatible API that is usable with mobile clients that support the Fever API (see instructions in
-- dropwizard upgrade to 0.8.0
+  Settings -> Profile)
-- you have to remove the "app.contextPath" setting from your yml file, you can optionally use
+- long entry titles are no longer shortened in the detailed view
-  server.applicationContextPath instead
+- added the "s" keyboard shortcut to star/unstar entries
-- new setting app.maxFeedCapacity for deleting old entries
+- http sessions are now stored in the database (they were stored on disk before)
-- ability to set filtering expressions for subscriptions to automatically mark new entries as read based on title,
+- fixed an issue that made it impossible to override the database url in a config.yml mounted in the Docker image
-  content, author or url.
+
-- ability to use !keyword or -keyword to exclude a keyword from a search query
+## [3.9.0]
-- facebook feeds now show user favicon instead of facebook favicon
+
-- new dark theme 'nightsky'
+- improve performance by disabling the loader when nothing is loading (most noticeable on mobile)
-
+- added a setting to disable the 'mark all as read' confirmation
-## [2.0.3]
+- added a setting to disable the custom context menu
-
+- if the custom context is enabled, it can still be disabled by pressing the shift key
-- internet explorer ajax cache workaround
+- the announcement feature is now working again and supports html ('announcement' configuration element in config.yml)
-- categories are now deletable again
+- add support for MariaDB 11+
-- openshift support is back
+- fix entry header shortly rendered as mobile on desktop, causing a small visual glitch
-- youtube feeds now show user favicon instead of youtube favicon
+- fix an issue that could cause a feed to not refresh correctly if the url was very long
-
+- database cleanup batch size is now configurable
-## [2.0.2]
+- css parsing errors are no longer logged to the standard output
-
+- fix small errors in the api documentation
-- api using the api key is now working again
+
-- context path is now configurable in config.yml (see app.contextPath in config.yml.example)
+## [3.8.1]
-- fix login on firefox when fields are autofilled by the browser
+
-- fix scrolling of subscriptions list on mobile
+- in expanded mode, don't scroll when clicking on the body of the current entry
-- user is now logged in after registration
+- improve content cleanup task performance for instances with a very large number of feeds
-- fix link to documentation on home page and about page
+
-- fields autocomplete is disabled on the profile page
+## [3.8.0]
-- users are able to delete their account again
+
-- chinese and malaysian translation files are now correctly loaded
+- add previous and next buttons in the toolbar
-- software version in user-agent when fetching feeds is no longer hardcoded
+- add a setting to always scroll selected entry to the top of the page, even if it fits entirely on screen
-- admin settings page is now read only, settings are configured in config.yml
+- clicking on the body of an entry in expanded mode selects it and marks it as read
-- added link to metrics on the admin settings page
+- add rich text editor with autocomplete for custom css and js code in settings (desktop only)
-- Rome (rss library) upgrade to 1.5.0
+- dramatically improve performance while scrolling
-
+- fix broken welcome page mobile layout
-## [2.0.1]
+- format dates in user locale instead of GMT in relative date popups
-
+
-- the redis pool no longer throws an exception when it is unable to aquire a new connection
+## [3.7.0]
-
+
-## [2.0.0]
+- the sidebar is now resizable
-
+- added the "f" keyboard shortcut to hide the sidebar
-- The backend has been completely rewritten using Dropwizard instead of TomEE, resulting in a lot less memory
+- added tooltips to relative dates with the exact date
-  consumption and better overall performances.
+- add a setting to hide commafeed from search engines (exposes a robots.txt file, enabled by default)
-  See the README on how to build CommaFeed from now on.
+- the browser extension unread count now updates when articles are marked as read/unread in the app
-- CommaFeed should no longer fetch the same feed multiple times in a row
+- The "b" keyboard shortcut now works as expected on Chrome but requires the browser extension to be installed
-- Users can use their username or email to log in
+- dark mode has been disabled on the api documentation page as it was unreadable
+- improvement to the feed refresh queuing logic when "heavy load" mode is enabled
+- fix a bug that could prevent feeds and categories from being edited
+
+## [3.6.0]
+
+- add a button to open CommaFeed in a new tab and a button to open options when using the browser extension
+- clicking on the entry title in expanded mode now opens the link instead of doing nothing
+- add tooltips to buttons when the mobile layout is used on desktop
+- redirect the user to the welcome page if the user was deleted from the database
+- add link to api documentation on welcome page
+- the unread count is now correctly updated when using the "/next" bookmarklet while redis cache is enabled
+
+## [3.5.0]
+
+- add compatibility with the new version of the CommaFeed browser extension
+- disable pull-to-refresh on mobile as it messes with vertical scrolling
+- add css classes to feed entries to help with custom css rules
+- api documentation page no longer requires users to be authenticated
+- add a setting to limit the number of feeds a user can subscribe to
+- add a setting to disable strict password policy
+- add feed refresh engine metrics
+- fix redis timeouts
+
+## [3.4.0]
+
+- add support for arm64 docker images
+- add divider to visually separate read-only information from form on the profile settings page
+- reduce javascript bundle size by 30% by loading only the necessary translations
+- add a standalone donate page with all ways to support CommaFeed
+- fix an issue introduced in 3.1.0 that could make CommaFeed not refresh feeds as fast as before on instances with lots
+  of feeds
+- fix alignment of icon with text for category tree nodes
+- fix alignment of burger button with the rest of the header on mobile
+
+## [3.3.2]
+
+- restore entry selection indicator (left orange border) that was lost with the mantine 6.x upgrade (3.3.0)
+- add dividers to visually separate read-only information from forms on feed and category details pages
+- reduced javascript bundle size by 10%
+
+## [3.3.1]
+
+- fix long feed names not being shortened to respect tree max width
+
+## [3.3.0]
+
+- there are now database changes, rolling back to 2.x will no longer be possible
+- restore support for user custom CSS rules
+- add support for user custom JS code that will be executed on page load
+
+## [3.2.0]
+
+- restore the welcome page
+- only apply hover effect for unread entries (same as commafeed v2)
+- move notifications at the bottom of the screen
+- always use https for sharing urls
+- add support for redis ACLs
+- transition to google analytics v4
+
+## [3.1.0]
+
+- add an even more compact layout
+- restore hover effect from commafeed 2.x
+- view mode (compact, expanded, ...) is now stored on the device so you can have a different view mode on desktop and
+  mobile
+- fix for the "Illegal attempt to associate a collection with two open sessions." error
+- feed fetching workflow is now orchestrated with rxjava, removing a lot of code
+
+## [3.0.1]
+
+- allow env variable substitution in config.yml
+- e.g. having a custom config.yml file with `app.session.path=${SOME_ENV_VAR}` will substitute `SOME_ENV_VAR` with its
+  value
+- allow env variable prefixed with `CF_` to override config.yml properties
+- e.g. setting `CF_APP_ALLOWREGISTRATIONS=true` will set `app.allowRegistrations` to `true`
+
+## [3.0.0]
+
+- complete overhaul of the UI
+- backend and frontend are now in separate maven modules
+- no changes to the api or the database
+- Docker images are now automatically built and available at https://hub.docker.com/r/athou/commafeed
+
+## [2.6.0]
+
+- add support for media content as a backup for missing content (useful for youtube feeds)
+- correctly follow http error code 308 redirects
+- fixed a bug that prevented users from deleting their account
+- fixed a bug that made commafeed store entry contents multiple times
+- fixed a bug that prevented the app to be used as an installed app on mobile devices if the context path of commafeed
+  was not "/"
+- fixed a bug that prevented entries from being "marked as read older than xxx" for a feed that was just added
+- removed support for google+ and readability as those services no longer exist
+- removed support for deploying on openshift
+- removed alphabetical sorting of entries because of really poor performance (title cannot be indexed)
+- improve performance for instances with the heavy load setting enabled by preventing CommaFeed from fetching feeds from
+  users that did not log in for a long time
+- various dependencies upgrades (notably dropwizard from 1.3 to 2.1)
+- add support for mariadb
+- add support for java17+ runtime
+- various security improvements
+
+## [2.5.0]
+
+- unread count is now displayed in a favicon badge when supported
+- the user agent string for the bot fetching feeds is now configurable
+- feed parsing performance improvements
+- support for java9+ runtime
+- can now properly start from an empty postgresql database
+
+## [2.4.0]
+
+- users were not able to change password or delete account
+- fix api key generation
+- feed entries can now be sorted alphabetically
+- fix facebook sharing
+- fix layout on iOS
+- postgresql driver update (fix for postgres 9.6)
+- various internationalization fixes
+- security fixes
+
+## [2.3.0]
+
+- dropwizard upgrade 0.9.1
+- feed enclosures are hidden if they already displayed in the content
+- fix youtube favicons
+- various internationalization fixes
+
+## [2.2.0]
+
+- fix youtube and instagram favicon fetching
+- mark as read filter was lost when a feed was rearranged with drag&drop
+- feed entry categories are now displayed if available
+- various performance and dependencies upgrades
+- java8 is now required
+
+## [2.1.0]
+
+- dropwizard upgrade to 0.8.0
+- you have to remove the "app.contextPath" setting from your yml file, you can optionally use
+  server.applicationContextPath instead
+- new setting app.maxFeedCapacity for deleting old entries
+- ability to set filtering expressions for subscriptions to automatically mark new entries as read based on title,
+  content, author or url.
+- ability to use !keyword or -keyword to exclude a keyword from a search query
+- facebook feeds now show user favicon instead of facebook favicon
+- new dark theme 'nightsky'
+
+## [2.0.3]
+
+- internet explorer ajax cache workaround
+- categories are now deletable again
+- openshift support is back
+- youtube feeds now show user favicon instead of youtube favicon
+
+## [2.0.2]
+
+- api using the api key is now working again
+- context path is now configurable in config.yml (see app.contextPath in config.yml.example)
+- fix login on firefox when fields are autofilled by the browser
+- fix scrolling of subscriptions list on mobile
+- user is now logged in after registration
+- fix link to documentation on home page and about page
+- fields autocomplete is disabled on the profile page
+- users are able to delete their account again
+- chinese and malaysian translation files are now correctly loaded
+- software version in user-agent when fetching feeds is no longer hardcoded
+- admin settings page is now read only, settings are configured in config.yml
+- added link to metrics on the admin settings page
+- Rome (rss library) upgrade to 1.5.0
+
+## [2.0.1]
+
+- the redis pool no longer throws an exception when it is unable to aquire a new connection
+
+## [2.0.0]
+
+- The backend has been completely rewritten using Dropwizard instead of TomEE, resulting in a lot less memory
+  consumption and better overall performances.
+  See the README on how to build CommaFeed from now on.
+- CommaFeed should no longer fetch the same feed multiple times in a row
+- Users can use their username or email to log in

Dockerfile

@@ -1,12 +0,0 @@
-FROM eclipse-temurin:17-jre
-
-EXPOSE 8082
-
-RUN mkdir -p /commafeed/data
-VOLUME /commafeed/data
-
-COPY commafeed-server/config.yml.example config.yml
-COPY commafeed-server/target/commafeed.jar .
-
-ENV JAVA_TOOL_OPTIONS -Djava.net.preferIPv4Stack=true -Xms20m -XX:+UseG1GC -XX:-ShrinkHeapInSteps -XX:G1PeriodicGCInterval=10000 -XX:-G1PeriodicGCInvokesConcurrent -XX:MinHeapFreeRatio=5 -XX:MaxHeapFreeRatio=10
-CMD ["java", "-jar", "commafeed.jar", "server", "config.yml"]

LICENSE

@@ -1,31 +1,31 @@
-Apache License, Version 2.0 Apache License Version 2.0, January 2004 http://www.apache.org/licenses/
+Apache License, Version 2.0 Apache License Version 2.0, January 2004 http://www.apache.org/licenses/
-TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
-1. Definitions.
+1. Definitions.
-"License" shall mean the terms and conditions for use, reproduction, and distribution as defined by Sections 1 through 9 of this document.
+"License" shall mean the terms and conditions for use, reproduction, and distribution as defined by Sections 1 through 9 of this document.
-"Licensor" shall mean the copyright owner or entity authorized by the copyright owner that is granting the License.
+"Licensor" shall mean the copyright owner or entity authorized by the copyright owner that is granting the License.
-"Legal Entity" shall mean the union of the acting entity and all other entities that control, are controlled by, or are under common control with that entity. For the purposes of this definition, "control" means (i) the power, direct or indirect, to cause the direction or management of such entity, whether by contract or otherwise, or (ii) ownership of fifty percent (50%) or more of the outstanding shares, or (iii) beneficial ownership of such entity.
+"Legal Entity" shall mean the union of the acting entity and all other entities that control, are controlled by, or are under common control with that entity. For the purposes of this definition, "control" means (i) the power, direct or indirect, to cause the direction or management of such entity, whether by contract or otherwise, or (ii) ownership of fifty percent (50%) or more of the outstanding shares, or (iii) beneficial ownership of such entity.
-"You" (or "Your") shall mean an individual or Legal Entity exercising permissions granted by this License.
+"You" (or "Your") shall mean an individual or Legal Entity exercising permissions granted by this License.
-"Source" form shall mean the preferred form for making modifications, including but not limited to software source code, documentation source, and configuration files.
+"Source" form shall mean the preferred form for making modifications, including but not limited to software source code, documentation source, and configuration files.
-"Object" form shall mean any form resulting from mechanical transformation or translation of a Source form, including but not limited to compiled object code, generated documentation, and conversions to other media types.
+"Object" form shall mean any form resulting from mechanical transformation or translation of a Source form, including but not limited to compiled object code, generated documentation, and conversions to other media types.
-"Work" shall mean the work of authorship, whether in Source or Object form, made available under the License, as indicated by a copyright notice that is included in or attached to the work (an example is provided in the Appendix below).
+"Work" shall mean the work of authorship, whether in Source or Object form, made available under the License, as indicated by a copyright notice that is included in or attached to the work (an example is provided in the Appendix below).
-"Derivative Works" shall mean any work, whether in Source or Object form, that is based on (or derived from) the Work and for which the editorial revisions, annotations, elaborations, or other modifications represent, as a whole, an original work of authorship. For the purposes of this License, Derivative Works shall not include works that remain separable from, or merely link (or bind by name) to the interfaces of, the Work and Derivative Works thereof.
+"Derivative Works" shall mean any work, whether in Source or Object form, that is based on (or derived from) the Work and for which the editorial revisions, annotations, elaborations, or other modifications represent, as a whole, an original work of authorship. For the purposes of this License, Derivative Works shall not include works that remain separable from, or merely link (or bind by name) to the interfaces of, the Work and Derivative Works thereof.
-"Contribution" shall mean any work of authorship, including the original version of the Work and any modifications or additions to that Work or Derivative Works thereof, that is intentionally submitted to Licensor for inclusion in the Work by the copyright owner or by an individual or Legal Entity authorized to submit on behalf of the copyright owner. For the purposes of this definition, "submitted" means any form of electronic, verbal, or written communication sent to the Licensor or its representatives, including but not limited to communication on electronic mailing lists, source code control systems, and issue tracking systems that are managed by, or on behalf of, the Licensor for the purpose of discussing and improving the Work, but excluding communication that is conspicuously marked or otherwise designated in writing by the copyright owner as "Not a Contribution."
+"Contribution" shall mean any work of authorship, including the original version of the Work and any modifications or additions to that Work or Derivative Works thereof, that is intentionally submitted to Licensor for inclusion in the Work by the copyright owner or by an individual or Legal Entity authorized to submit on behalf of the copyright owner. For the purposes of this definition, "submitted" means any form of electronic, verbal, or written communication sent to the Licensor or its representatives, including but not limited to communication on electronic mailing lists, source code control systems, and issue tracking systems that are managed by, or on behalf of, the Licensor for the purpose of discussing and improving the Work, but excluding communication that is conspicuously marked or otherwise designated in writing by the copyright owner as "Not a Contribution."
-"Contributor" shall mean Licensor and any individual or Legal Entity on behalf of whom a Contribution has been received by Licensor and subsequently incorporated within the Work.
+"Contributor" shall mean Licensor and any individual or Legal Entity on behalf of whom a Contribution has been received by Licensor and subsequently incorporated within the Work.
-2. Grant of Copyright License.
+2. Grant of Copyright License.
-Subject to the terms and conditions of this License, each Contributor hereby grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable copyright license to reproduce, prepare Derivative Works of, publicly display, publicly perform, sublicense, and distribute the Work and such Derivative Works in Source or Object form.
+Subject to the terms and conditions of this License, each Contributor hereby grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable copyright license to reproduce, prepare Derivative Works of, publicly display, publicly perform, sublicense, and distribute the Work and such Derivative Works in Source or Object form.
-3. Grant of Patent License.
+3. Grant of Patent License.
-Subject to the terms and conditions of this License, each Contributor hereby grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable (except as stated in this section) patent license to make, have made, use, offer to sell, sell, import, and otherwise transfer the Work, where such license applies only to those patent claims licensable by such Contributor that are necessarily infringed by their Contribution(s) alone or by combination of their Contribution(s) with the Work to which such Contribution(s) was submitted. If You institute patent litigation against any entity (including a cross-claim or counterclaim in a lawsuit) alleging that the Work or a Contribution incorporated within the Work constitutes direct or contributory patent infringement, then any patent licenses granted to You under this License for that Work shall terminate as of the date such litigation is filed.
+Subject to the terms and conditions of this License, each Contributor hereby grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable (except as stated in this section) patent license to make, have made, use, offer to sell, sell, import, and otherwise transfer the Work, where such license applies only to those patent claims licensable by such Contributor that are necessarily infringed by their Contribution(s) alone or by combination of their Contribution(s) with the Work to which such Contribution(s) was submitted. If You institute patent litigation against any entity (including a cross-claim or counterclaim in a lawsuit) alleging that the Work or a Contribution incorporated within the Work constitutes direct or contributory patent infringement, then any patent licenses granted to You under this License for that Work shall terminate as of the date such litigation is filed.
-4. Redistribution.
+4. Redistribution.
-You may reproduce and distribute copies of the Work or Derivative Works thereof in any medium, with or without modifications, and in Source or Object form, provided that You meet the following conditions:
+You may reproduce and distribute copies of the Work or Derivative Works thereof in any medium, with or without modifications, and in Source or Object form, provided that You meet the following conditions:
-You must give any other recipients of the Work or Derivative Works a copy of this License; and You must cause any modified files to carry prominent notices stating that You changed the files; and You must retain, in the Source form of any Derivative Works that You distribute, all copyright, patent, trademark, and attribution notices from the Source form of the Work, excluding those notices that do not pertain to any part of the Derivative Works; and If the Work includes a "NOTICE" text file as part of its distribution, then any Derivative Works that You distribute must include a readable copy of the attribution notices contained within such NOTICE file, excluding those notices that do not pertain to any part of the Derivative Works, in at least one of the following places: within a NOTICE text file distributed as part of the Derivative Works; within the Source form or documentation, if provided along with the Derivative Works; or, within a display generated by the Derivative Works, if and wherever such third-party notices normally appear. The contents of the NOTICE file are for informational purposes only and do not modify the License. You may add Your own attribution notices within Derivative Works that You distribute, alongside or as an addendum to the NOTICE text from the Work, provided that such additional attribution notices cannot be construed as modifying the License. You may add Your own copyright statement to Your modifications and may provide additional or different license terms and conditions for use, reproduction, or distribution of Your modifications, or for any such Derivative Works as a whole, provided Your use, reproduction, and distribution of the Work otherwise complies with the conditions stated in this License.
+You must give any other recipients of the Work or Derivative Works a copy of this License; and You must cause any modified files to carry prominent notices stating that You changed the files; and You must retain, in the Source form of any Derivative Works that You distribute, all copyright, patent, trademark, and attribution notices from the Source form of the Work, excluding those notices that do not pertain to any part of the Derivative Works; and If the Work includes a "NOTICE" text file as part of its distribution, then any Derivative Works that You distribute must include a readable copy of the attribution notices contained within such NOTICE file, excluding those notices that do not pertain to any part of the Derivative Works, in at least one of the following places: within a NOTICE text file distributed as part of the Derivative Works; within the Source form or documentation, if provided along with the Derivative Works; or, within a display generated by the Derivative Works, if and wherever such third-party notices normally appear. The contents of the NOTICE file are for informational purposes only and do not modify the License. You may add Your own attribution notices within Derivative Works that You distribute, alongside or as an addendum to the NOTICE text from the Work, provided that such additional attribution notices cannot be construed as modifying the License. You may add Your own copyright statement to Your modifications and may provide additional or different license terms and conditions for use, reproduction, or distribution of Your modifications, or for any such Derivative Works as a whole, provided Your use, reproduction, and distribution of the Work otherwise complies with the conditions stated in this License.
-5. Submission of Contributions.
+5. Submission of Contributions.
-Unless You explicitly state otherwise, any Contribution intentionally submitted for inclusion in the Work by You to the Licensor shall be under the terms and conditions of this License, without any additional terms or conditions. Notwithstanding the above, nothing herein shall supersede or modify the terms of any separate license agreement you may have executed with Licensor regarding such Contributions.
+Unless You explicitly state otherwise, any Contribution intentionally submitted for inclusion in the Work by You to the Licensor shall be under the terms and conditions of this License, without any additional terms or conditions. Notwithstanding the above, nothing herein shall supersede or modify the terms of any separate license agreement you may have executed with Licensor regarding such Contributions.
-6. Trademarks.
+6. Trademarks.
-This License does not grant permission to use the trade names, trademarks, service marks, or product names of the Licensor, except as required for reasonable and customary use in describing the origin of the Work and reproducing the content of the NOTICE file.
+This License does not grant permission to use the trade names, trademarks, service marks, or product names of the Licensor, except as required for reasonable and customary use in describing the origin of the Work and reproducing the content of the NOTICE file.
-7. Disclaimer of Warranty.
+7. Disclaimer of Warranty.
-Unless required by applicable law or agreed to in writing, Licensor provides the Work (and each Contributor provides its Contributions) on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied, including, without limitation, any warranties or conditions of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A PARTICULAR PURPOSE. You are solely responsible for determining the appropriateness of using or redistributing the Work and assume any risks associated with Your exercise of permissions under this License.
+Unless required by applicable law or agreed to in writing, Licensor provides the Work (and each Contributor provides its Contributions) on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied, including, without limitation, any warranties or conditions of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A PARTICULAR PURPOSE. You are solely responsible for determining the appropriateness of using or redistributing the Work and assume any risks associated with Your exercise of permissions under this License.
-8. Limitation of Liability.
+8. Limitation of Liability.
-In no event and under no legal theory, whether in tort (including negligence), contract, or otherwise, unless required by applicable law (such as deliberate and grossly negligent acts) or agreed to in writing, shall any Contributor be liable to You for damages, including any direct, indirect, special, incidental, or consequential damages of any character arising as a result of this License or out of the use or inability to use the Work (including but not limited to damages for loss of goodwill, work stoppage, computer failure or malfunction, or any and all other commercial damages or losses), even if such Contributor has been advised of the possibility of such damages.
+In no event and under no legal theory, whether in tort (including negligence), contract, or otherwise, unless required by applicable law (such as deliberate and grossly negligent acts) or agreed to in writing, shall any Contributor be liable to You for damages, including any direct, indirect, special, incidental, or consequential damages of any character arising as a result of this License or out of the use or inability to use the Work (including but not limited to damages for loss of goodwill, work stoppage, computer failure or malfunction, or any and all other commercial damages or losses), even if such Contributor has been advised of the possibility of such damages.
-9. Accepting Warranty or Additional Liability.
+9. Accepting Warranty or Additional Liability.
-While redistributing the Work or Derivative Works thereof, You may choose to offer, and charge a fee for, acceptance of support, warranty, indemnity, or other liability obligations and/or rights consistent with this License. However, in accepting such obligations, You may act only on Your own behalf and on Your sole responsibility, not on behalf of any other Contributor, and only if You agree to indemnify, defend, and hold each Contributor harmless for any liability incurred by, or claims asserted against, such Contributor by reason of your accepting any such warranty or additional liability.
+While redistributing the Work or Derivative Works thereof, You may choose to offer, and charge a fee for, acceptance of support, warranty, indemnity, or other liability obligations and/or rights consistent with this License. However, in accepting such obligations, You may act only on Your own behalf and on Your sole responsibility, not on behalf of any other Contributor, and only if You agree to indemnify, defend, and hold each Contributor harmless for any liability incurred by, or claims asserted against, such Contributor by reason of your accepting any such warranty or additional liability.
 END OF TERMS AND CONDITIONS

README.md

@@ -1,6 +1,6 @@
 # CommaFeed
 
-Google Reader inspired self-hosted RSS reader, based on Dropwizard and React/TypeScript.
+Google Reader inspired self-hosted RSS reader, based on Quarkus and React/TypeScript.
 
 ![preview](https://user-images.githubusercontent.com/1256795/184886828-1973f148-58a9-4c6d-9587-ee5e5d3cc2cb.png)
 
@@ -8,14 +8,23 @@ Google Reader inspired self-hosted RSS reader, based on Dropwizard and React/Typ
 
 - 4 different layouts
 - Light/Dark theme
-- Fully responsive
+- Fully responsive, works great on both mobile and desktop
 - Keyboard shortcuts for almost everything
 - Support for right-to-left feeds
 - Translated in 25+ languages
 - Supports thousands of users and millions of feeds
 - OPML import/export
-- REST API and a Fever-compatible API for native mobile apps
+- REST API
+- Fever-compatible API for native mobile apps
+- Can automatically mark articles as read based on user-defined rules
+- Highly customizable with [custom CSS](https://athou.github.io/commafeed/documentation/custom-css) and JavaScript
 - [Browser extension](https://github.com/Athou/commafeed-browser-extension)
+- Compiles to native code for blazing fast startup and low memory usage
+- Supports 4 databases
+    - H2 (embedded database)
+    - PostgreSQL
+    - MySQL
+    - MariaDB
 
 ## Deployment
 
@@ -33,50 +42,116 @@ PikaPods shares 20% of the revenue back to CommaFeed.
 
 [![PikaPods](https://www.pikapods.com/static/run-button.svg)](https://www.pikapods.com/pods?run=commafeed)
 
-### Download precompiled package
+### Download a precompiled package
 
-    mkdir commafeed && cd commafeed
+Go to the [release page](https://github.com/Athou/commafeed/releases) and download the latest version for your operating
-    wget https://github.com/Athou/commafeed/releases/latest/download/commafeed.jar
+system and database of choice.
-    wget https://github.com/Athou/commafeed/releases/latest/download/config.yml.example -O config.yml
-    java -Djava.net.preferIPv4Stack=true -jar commafeed.jar server config.yml
 
-The server will listen on http://localhost:8082. The default
+There are two types of packages:
-user is `admin` and the default password is `admin`.
+
+- The `linux-x86_64`, `linux-aarch_64` and `windows-x86_64` packages are compiled natively and contain an executable that can be run
+  directly.
+- The `jvm` package is a zip file containing all `.jar` files required to run the application. This package works on all
+  platforms but requires a JRE and is started with `java -jar quarkus-run.jar`.
+
+If available for your operating system, the native package is recommended because it has a faster startup time and lower
+memory usage.
 
 ### Build from sources
 
-    git clone https://github.com/Athou/commafeed.git
+    ./mvnw clean package [-P<database> [-Pnative]] [-DskipTests]
-    cd commafeed
-    ./mvnw clean package
-    cp commafeed-server/config.yml.example config.yml
-    java -Djava.net.preferIPv4Stack=true -jar commafeed-server/target/commafeed.jar server config.yml
 
-The server will listen on http://localhost:8082. The default
+- `<database>` can be one of `h2`, `postgresql`, `mysql` or `mariadb`. The default is `h2`.
-user is `admin` and the default password is `admin`.
+- `-Pnative` compiles the application to native code. This requires GraalVM to be installed (`GRAALVM_HOME` environment
+  variable pointing to a GraalVM installation).
+- `-DskipTests` to speed up the build process by skipping tests.
+
+When the build is complete:
+
+- a zip containing all jars required to run the application is located at
+  `commafeed-server/target/commafeed-<version>-<database>-jvm.zip`. Extract it and run the application with
+  `java -jar quarkus-run.jar`
+- if you used the native profile, the executable is located at
+  `commafeed-server/target/commafeed-<version>-<database>-<platform>-<arch>-runner[.exe]`
+
+### Distribution packages
+
+- Arch Linux users can use [the CommaFeed package on AUR](https://aur.archlinux.org/pkgbase/commafeed), which builds native binaries with GraalVM for all supported databases.
+
+## Configuration
+
+CommaFeed doesn't require any configuration to run with its embedded database (H2). The database file will be stored in
+the `data` directory of the current directory.
+
+To use a different database, you will need to configure the following properties:
+
+- `quarkus.datasource.jdbc.url`
+    - e.g. for H2: `jdbc:h2:./data/db;DEFRAG_ALWAYS=TRUE`
+    - e.g. for PostgreSQL: `jdbc:postgresql://localhost:5432/commafeed`
+    - e.g. for MySQL:
+      `jdbc:mysql://localhost/commafeed?autoReconnect=true&failOverReadOnly=false&maxReconnects=20&rewriteBatchedStatements=true&timezone=UTC`
+    - e.g. for MariaDB:
+      `jdbc:mariadb://localhost/commafeed?autoReconnect=true&failOverReadOnly=false&maxReconnects=20&rewriteBatchedStatements=true&timezone=UTC`
+- `quarkus.datasource.username`
+- `quarkus.datasource.password`
+
+There are multiple ways to configure CommaFeed:
+
+- a `config/application.properties` [properties](https://en.wikipedia.org/wiki/.properties) file relative to the working
+  directory (keys in kebab-case)
+- Command line arguments each prefixed with `-D` (keys in kebab-case)
+- Environment variables (keys in UPPER_CASE)
+- a `.env` file in the working directory (keys in UPPER_CASE)
+
+The properties file is recommended because CommaFeed will be able to warn about invalid properties and typos.
+
+All [CommaFeed settings](https://athou.github.io/commafeed/documentation) are optional and have sensible default values.
+
+When logging in, credentials are stored in an encrypted cookie. The encryption key is randomly generated at startup,
+meaning that you will have to log back in after each restart of the application. To prevent this, you can set the
+`quarkus.http.auth.session.encryption-key` property to a fixed value (min. 16 characters).
+All other Quarkus settings can be found [here](https://quarkus.io/guides/all-config).
+
+When started, the server will listen on http://localhost:8082.
+The default user is `admin` and the default password is `admin`.
+
+### Updates
+
+When CommaFeed is up and running, you can subscribe to [this feed](https://github.com/Athou/commafeed/releases.atom) to be notified of new releases.
 
 ### Memory management
 
 The Java Virtual Machine (JVM) is rather greedy by default and will not release unused memory to the
 operating system. This is because acquiring memory from the operating system is a relatively expensive operation.
-However, this can be problematic on systems with limited memory.
+This can be problematic on systems with limited memory.
 
-#### Hard limit
+#### Hard limit (`native` and `jvm` packages)
 
 The JVM can be configured to use a maximum amount of memory with the `-Xmx` parameter.
 For example, to limit the JVM to 256MB of memory, use `-Xmx256m`.
 
-#### Dynamic sizing
+#### Dynamic sizing (`jvm` package)
 
-The JVM can be configured to release unused memory to the operating system with the following parameters:
+In addition to the previous setting, the JVM can be configured to release unused memory to the operating system with the
+following parameters:
 
-    -Xms20m -XX:+UseG1GC -XX:-ShrinkHeapInSteps -XX:G1PeriodicGCInterval=10000 -XX:-G1PeriodicGCInvokesConcurrent -XX:MinHeapFreeRatio=5 -XX:MaxHeapFreeRatio=10
+    -Xms20m -XX:+UseG1GC -XX:+UseStringDeduplication -XX:-ShrinkHeapInSteps -XX:G1PeriodicGCInterval=10000 -XX:-G1PeriodicGCInvokesConcurrent -XX:MinHeapFreeRatio=5 -XX:MaxHeapFreeRatio=10
 
-This is how the Docker image is configured.
 See [here](https://docs.oracle.com/en/java/javase/17/gctuning/garbage-first-g1-garbage-collector1.html)
 and [here](https://docs.oracle.com/en/java/javase/17/gctuning/factors-affecting-garbage-collection-performance.html) for
 more
 information.
 
+#### OpenJ9 (`jvm` package)
+
+The [OpenJ9](https://eclipse.dev/openj9/) JVM is a more memory-efficient alternative to the HotSpot JVM, at the cost of
+slightly slower throughput.
+
+IBM provides precompiled binaries for OpenJ9
+named [Semeru](https://developer.ibm.com/languages/java/semeru-runtimes/downloads/).
+This is the JVM used in
+the [Docker image](https://github.com/Athou/commafeed/blob/master/commafeed-server/src/main/docker/Dockerfile.jvm).
+
 ## Translation
 
 Files for internationalization are
@@ -99,7 +174,7 @@ two-letters [ISO-639-1 language code](http://en.wikipedia.org/wiki/List_of_ISO_6
 
 - Open `commafeed-server` in your preferred Java IDE.
     - CommaFeed uses Lombok, you need the Lombok plugin for your IDE.
-- Start `CommaFeedApplication.java` in debug mode with `server config.dev.yml` as arguments
+- run `./mvnw quarkus:dev`
 
 ### Frontend
 

commafeed-client/.eslintignore

@@ -1,8 +0,0 @@
-dist
-node_modules
-
-vite.config.ts
-
-# compiled linguijs locales
-# they no longer exist but we keep this to avoid issues with people still having those files on disk
-src/locales/**/*.ts

commafeed-client/.eslintrc.cjs

@@ -1,47 +0,0 @@
-module.exports = {
-    env: {
-        browser: true,
-        es2021: true,
-    },
-    extends: [
-        "eslint:recommended",
-        "standard",
-        "plugin:@typescript-eslint/strict-type-checked",
-        "plugin:@typescript-eslint/stylistic-type-checked",
-        "plugin:react/recommended",
-        "plugin:react-hooks/recommended",
-        "plugin:prettier/recommended",
-    ],
-    settings: {
-        react: {
-            version: "detect",
-        },
-    },
-    overrides: [
-        {
-            env: {
-                node: true,
-            },
-            files: [".eslintrc.{js,cjs}"],
-            parserOptions: {
-                sourceType: "script",
-            },
-        },
-    ],
-    parserOptions: {
-        project: true,
-        ecmaVersion: "latest",
-        sourceType: "module",
-    },
-    plugins: ["react"],
-    rules: {
-        "@typescript-eslint/consistent-type-assertions": ["error", { assertionStyle: "as" }],
-        "@typescript-eslint/no-confusing-void-expression": ["error", { ignoreArrowShorthand: true }],
-        "@typescript-eslint/no-floating-promises": "off",
-        "@typescript-eslint/no-misused-promises": "off",
-        "@typescript-eslint/prefer-nullish-coalescing": ["error", { ignoreConditionalTests: true }],
-        "react/no-unescaped-entities": "off",
-        "react/react-in-jsx-scope": "off",
-        "react-hooks/exhaustive-deps": "error",
-    },
-}

commafeed-client/.linguirc

@@ -1,52 +0,0 @@
-{
-    "locales": [
-        "ar",
-        "ca",
-        "cs",
-        "cy",
-        "da",
-        "de",
-        "en",
-        "es",
-        "fa",
-        "fi",
-        "fr",
-        "gl",
-        "hu",
-        "id",
-        "it",
-        "ja",
-        "ko",
-        "ms",
-        "nb",
-        "nl",
-        "nn",
-        "pl",
-        "pt",
-        "ru",
-        "sk",
-        "sv",
-        "tr",
-        "zh"
-    ],
-    "catalogs": [
-        {
-            "path": "src/locales/{locale}/messages",
-            "include": [
-                "src"
-            ],
-            "exclude": [
-                "src/locales/**"
-            ]
-        }
-    ],
-    "format": "po",
-    "formatOptions": {
-        "origins": true,
-        "lineNumbers": false
-    },
-    "sourceLocale": "en",
-    "fallbackLocales": {
-        "default": "en"
-    }
-}

commafeed-client/.prettierrc

@@ -1,8 +0,0 @@
-{
-    "printWidth": 140,
-    "semi": false,
-    "tabWidth": 4,
-    "arrowParens": "avoid",
-    "endOfLine": "auto",
-    "trailingComma": "es5"
-}

commafeed-client/biome.json

@@ -0,0 +1,27 @@
+{
+    "$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
+    "formatter": {
+        "indentStyle": "space",
+        "indentWidth": 4,
+        "lineEnding": "lf",
+        "lineWidth": 140
+    },
+    "javascript": {
+        "formatter": {
+            "trailingCommas": "es5",
+            "semicolons": "asNeeded",
+            "arrowParentheses": "asNeeded"
+        }
+    },
+    "linter": {
+        "rules": {
+            "correctness": {
+                "noUnusedImports": "error",
+                "noUnusedVariables": "error"
+            }
+        }
+    },
+    "files": {
+        "ignore": ["dist", "node_modules", "target", "target-ide"]
+    }
+}

commafeed-client/index.html

@@ -1,11 +1,13 @@
 <!DOCTYPE html>
 <html lang="en">
 <head>
-  <meta charset="UTF-8" />
+    <meta charset="UTF-8" />
-  <link rel="icon" type="image/x-icon" href="favicon.ico" />
+    <link rel="icon" type="image/x-icon" href="favicon.ico" />
-  <link rel="manifest" href="manifest.json" />
+    <link rel="manifest" href="manifest.json" />
-  <meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no" />
+    <meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no" />
-  <title>CommaFeed</title>
+    <meta name="referrer" content="no-referrer" />
+
+    <title>CommaFeed</title>
 </head>
 <body>
 <div id="root"></div>

commafeed-client/lingui.config.ts

@@ -0,0 +1,52 @@
+import type { LinguiConfig } from "@lingui/conf"
+
+const config: LinguiConfig = {
+    locales: [
+        "ar",
+        "ca",
+        "cs",
+        "cy",
+        "da",
+        "de",
+        "en",
+        "es",
+        "fa",
+        "fi",
+        "fr",
+        "gl",
+        "hu",
+        "id",
+        "it",
+        "ja",
+        "ko",
+        "ms",
+        "nb",
+        "nl",
+        "nn",
+        "pl",
+        "pt",
+        "ru",
+        "sk",
+        "sv",
+        "tr",
+        "zh",
+    ],
+    catalogs: [
+        {
+            path: "src/locales/{locale}/messages",
+            include: ["src"],
+            exclude: ["src/locales/**"],
+        },
+    ],
+    format: "po",
+    formatOptions: {
+        origins: true,
+        lineNumbers: false,
+    },
+    sourceLocale: "en",
+    fallbackLocales: {
+        default: "en",
+    },
+}
+
+export default config

commafeed-client/package.json

@@ -1,82 +1,85 @@
 {
-  "name": "commafeed-client",
+    "name": "commafeed-client",
-  "private": true,
+    "private": true,
-  "version": "0.0.0",
+    "version": "0.0.0",
-  "type": "module",
+    "type": "module",
-  "scripts": {
+    "scripts": {
-    "dev": "vite --host",
+        "dev": "vite",
-    "dev:typescript": "tsc --watch",
+        "dev:host": "vite --host",
-    "build": "tsc && vite build",
+        "build": "tsc && vite build",
-    "preview": "vite preview",
+        "preview": "vite preview",
-    "test": "vitest",
+        "test": "vitest",
-    "test:ci": "vitest run",
+        "test:ci": "vitest run",
-    "eslint": "eslint --ext=.js,.jsx,.ts,.tsx src",
+        "lint": "biome check",
-    "i18n:extract": "lingui extract --clean"
+        "lint:fix": "biome check --write",
-  },
+        "i18n:extract": "lingui extract --clean"
-  "dependencies": {
+    },
-    "@emotion/react": "^11.11.4",
+    "dependencies": {
-    "@fontsource/open-sans": "^5.0.25",
+        "@emotion/react": "^11.14.0",
-    "@lingui/core": "^4.7.1",
+        "@fontsource/open-sans": "^5.2.5",
-    "@lingui/macro": "^4.7.1",
+        "@lingui/core": "^5.3.1",
-    "@lingui/react": "^4.7.1",
+        "@lingui/react": "^5.3.1",
-    "@mantine/core": "^7.6.1",
+        "@mantine/core": "^8.0.2",
-    "@mantine/form": "^7.6.1",
+        "@mantine/form": "^8.0.2",
-    "@mantine/hooks": "^7.6.1",
+        "@mantine/hooks": "^8.0.2",
-    "@mantine/modals": "^7.6.1",
+        "@mantine/modals": "^8.0.2",
-    "@mantine/notifications": "^7.6.1",
+        "@mantine/notifications": "^8.0.2",
-    "@mantine/spotlight": "^7.6.1",
+        "@mantine/spotlight": "^8.0.2",
-    "@monaco-editor/react": "^4.6.0",
+        "@monaco-editor/react": "^4.7.0",
-    "@reduxjs/toolkit": "^2.2.1",
+        "@reduxjs/toolkit": "^2.8.2",
-    "axios": "^1.6.7",
+        "axios": "^1.9.0",
-    "dayjs": "^1.11.10",
+        "dayjs": "^1.11.13",
-    "escape-string-regexp": "^5.0.0",
+        "escape-string-regexp": "^5.0.0",
-    "interweave": "^13.1.0",
+        "interweave": "^13.1.1",
-    "monaco-editor": "^0.46.0",
+        "monaco-editor": "^0.52.2",
-    "mousetrap": "^1.6.5",
+        "mousetrap": "^1.6.5",
-    "react": "^18.2.0",
+        "react": "^19.1.0",
-    "react-async-hook": "^4.0.0",
+        "react-async-hook": "^4.0.0",
-    "react-contexify": "^6.0.0",
+        "react-contexify": "^6.0.0",
-    "react-dom": "^18.2.0",
+        "react-device-detect": "^2.2.3",
-    "react-draggable": "^4.4.6",
+        "react-dom": "^19.1.0",
-    "react-ga4": "^2.1.0",
+        "react-draggable": "^4.4.6",
-    "react-icons": "^5.0.1",
+        "react-ga4": "^2.1.0",
-    "react-infinite-scroller": "^1.2.6",
+        "react-icons": "^5.5.0",
-    "react-redux": "^9.1.0",
+        "react-infinite-scroller": "^1.2.6",
-    "react-router-dom": "^6.22.2",
+        "react-redux": "^9.2.0",
-    "react-swipeable": "^7.0.1",
+        "react-router-dom": "^7.6.1",
-    "redoc": "^2.1.3",
+        "react-swipeable": "^7.0.2",
-    "throttle-debounce": "^5.0.0",
+        "redoc": "^2.5.0",
-    "tinycon": "^0.6.8",
+        "style-to-object": "^1.0.8",
-    "tss-react": "^4.9.4",
+        "throttle-debounce": "^5.0.2",
-    "use-local-storage": "^3.0.0",
+        "tinycon": "^0.6.8",
-    "websocket-heartbeat-js": "^1.1.3"
+        "tss-react": "^4.9.18",
-  },
+        "websocket-heartbeat-js": "^1.1.3"
-  "devDependencies": {
+    },
-    "@lingui/cli": "^4.7.1",
+    "devDependencies": {
-    "@lingui/vite-plugin": "^4.7.1",
+        "@biomejs/biome": "^1.9.4",
-    "@types/mousetrap": "^1.6.15",
+        "@lingui/babel-plugin-lingui-macro": "^5.3.1",
-    "@types/react": "^18.2.61",
+        "@lingui/cli": "^5.3.1",
-    "@types/react-dom": "^18.2.19",
+        "@lingui/vite-plugin": "^5.3.1",
-    "@types/react-infinite-scroller": "^1.2.5",
+        "@testing-library/jest-dom": "^6.6.3",
-    "@types/swagger-ui-react": "^4.18.3",
+        "@testing-library/react": "^16.3.0",
-    "@types/throttle-debounce": "^5.0.2",
+        "@testing-library/user-event": "^14.6.1",
-    "@types/tinycon": "^0.6.5",
+        "@types/mousetrap": "^1.6.15",
-    "@typescript-eslint/eslint-plugin": "^7.1.0",
+        "@types/react": "^19.1.6",
-    "@vitejs/plugin-react": "^4.2.1",
+        "@types/react-dom": "^19.1.5",
-    "babel-plugin-macros": "^3.1.0",
+        "@types/react-infinite-scroller": "^1.2.5",
-    "eslint": "^8.57.0",
+        "@types/throttle-debounce": "^5.0.2",
-    "eslint-config-prettier": "^9.1.0",
+        "@types/tinycon": "^0.6.7",
-    "eslint-config-standard": "^17.1.0",
+        "@vitejs/plugin-react": "^4.5.0",
-    "eslint-plugin-prettier": "^5.1.3",
+        "babel-plugin-macros": "^3.1.0",
-    "eslint-plugin-react": "^7.34.0",
+        "babel-plugin-react-compiler": "^19.1.0-rc.2",
-    "eslint-plugin-react-hooks": "^4.6.0",
+        "jsdom": "^26.1.0",
-    "prettier": "^3.2.5",
+        "rollup-plugin-visualizer": "^6.0.0",
-    "rollup-plugin-visualizer": "^5.12.0",
+        "typescript": "^5.8.3",
-    "typescript": "^5.3.3",
+        "vite": "^6.3.5",
-    "vite": "^5.1.4",
+        "vite-plugin-checker": "^0.9.3",
-    "vite-plugin-eslint": "^1.8.1",
+        "vite-tsconfig-paths": "^5.1.4",
-    "vite-tsconfig-paths": "^4.3.1",
+        "vitest": "^3.1.4"
-    "vitest": "^1.3.1",
+    },
-    "vitest-mock-extended": "^1.3.1"
+    "overrides": {
-  }
+        "react-infinite-scroller": {
+            "react": "^19.1.0"
+        }
+    }
 }

commafeed-client/pom.xml

@@ -1,88 +1,97 @@
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-
+		 xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
-	<modelVersion>4.0.0</modelVersion>
+
-
+	<modelVersion>4.0.0</modelVersion>
-	<parent>
+
-		<groupId>com.commafeed</groupId>
+	<parent>
-		<artifactId>commafeed</artifactId>
+		<groupId>com.commafeed</groupId>
-		<version>4.3.2</version>
+		<artifactId>commafeed</artifactId>
-	</parent>
+		<version>5.10.0</version>
-	<artifactId>commafeed-client</artifactId>
+	</parent>
-	<name>CommaFeed Client</name>
+	<artifactId>commafeed-client</artifactId>
-
+	<name>CommaFeed Client</name>
-	<build>
+
-		<plugins>
+	<properties>
-			<plugin>
+		<!-- renovate: datasource=node-version depName=node -->
-				<groupId>com.github.eirslett</groupId>
+		<node.version>v22.16.0</node.version>
-				<artifactId>frontend-maven-plugin</artifactId>
+		<!-- renovate: datasource=npm depName=npm -->
-				<version>1.15.0</version>
+		<npm.version>11.4.1</npm.version>
-				<?m2e ignore?>
+	</properties>
-				<executions>
+
-					<execution>
+	<build>
-						<id>install node and npm</id>
+		<plugins>
-						<goals>
+			<plugin>
-							<goal>install-node-and-npm</goal>
+				<groupId>com.github.eirslett</groupId>
-						</goals>
+				<artifactId>frontend-maven-plugin</artifactId>
-						<phase>compile</phase>
+				<version>1.15.1</version>
-						<configuration>
+				<?m2e ignore?>
-							<nodeVersion>v20.10.0</nodeVersion>
+				<executions>
-							<npmVersion>10.2.5</npmVersion>
+					<execution>
-						</configuration>
+						<id>install node and npm</id>
-					</execution>
+						<goals>
-					<execution>
+							<goal>install-node-and-npm</goal>
-						<id>npm install</id>
+						</goals>
-						<goals>
+						<phase>compile</phase>
-							<goal>npm</goal>
+						<configuration>
-						</goals>
+							<nodeVersion>${node.version}</nodeVersion>
-						<phase>compile</phase>
+							<npmVersion>${npm.version}</npmVersion>
-						<configuration>
+						</configuration>
-							<arguments>ci</arguments>
+					</execution>
-						</configuration>
+					<execution>
-					</execution>
+						<id>npm install</id>
-					<execution>
+						<goals>
-						<id>npm run test</id>
+							<goal>npm</goal>
-						<goals>
+						</goals>
-							<goal>npm</goal>
+						<phase>compile</phase>
-						</goals>
+						<configuration>
-						<phase>compile</phase>
+							<arguments>ci</arguments>
-						<configuration>
+						</configuration>
-							<arguments>run test:ci</arguments>
+					</execution>
-						</configuration>
+					<execution>
-					</execution>
+						<id>npm run test</id>
-					<execution>
+						<goals>
-						<id>npm run build</id>
+							<goal>npm</goal>
-						<goals>
+						</goals>
-							<goal>npm</goal>
+						<phase>compile</phase>
-						</goals>
+						<configuration>
-						<phase>compile</phase>
+							<arguments>run test:ci</arguments>
-						<configuration>
+							<skip>${skipTests}</skip>
-							<arguments>run build</arguments>
+						</configuration>
-						</configuration>
+					</execution>
-					</execution>
+					<execution>
-				</executions>
+						<id>npm run build</id>
-			</plugin>
+						<goals>
-			<plugin>
+							<goal>npm</goal>
-				<artifactId>maven-resources-plugin</artifactId>
+						</goals>
-				<version>3.3.1</version>
+						<phase>compile</phase>
-				<executions>
+						<configuration>
-					<execution>
+							<arguments>run build</arguments>
-						<id>copy web interface to resources</id>
+						</configuration>
-						<phase>prepare-package</phase>
+					</execution>
-						<goals>
+				</executions>
-							<goal>copy-resources</goal>
+			</plugin>
-						</goals>
+			<plugin>
-						<configuration>
+				<artifactId>maven-resources-plugin</artifactId>
-							<outputDirectory>${project.build.directory}/classes/assets</outputDirectory>
+				<version>3.3.1</version>
-							<resources>
+				<executions>
-								<resource>
+					<execution>
-									<directory>dist</directory>
+						<id>copy web interface to resources</id>
-									<filtering>false</filtering>
+						<phase>prepare-package</phase>
-								</resource>
+						<goals>
-							</resources>
+							<goal>copy-resources</goal>
-						</configuration>
+						</goals>
-					</execution>
+						<configuration>
-				</executions>
+							<outputDirectory>${project.build.directory}/classes/META-INF/resources</outputDirectory>
-			</plugin>
+							<resources>
-		</plugins>
+								<resource>
-	</build>
+									<directory>dist</directory>
+									<filtering>false</filtering>
+								</resource>
+							</resources>
+						</configuration>
+					</execution>
+				</executions>
+			</plugin>
+		</plugins>
+	</build>
 </project>

commafeed-client/src/App.tsx

@@ -1,7 +1,6 @@
 import { i18n } from "@lingui/core"
 import { I18nProvider } from "@lingui/react"
 import { MantineProvider } from "@mantine/core"
-import { useDidUpdate } from "@mantine/hooks"
 import { ModalsProvider } from "@mantine/modals"
 import { Notifications } from "@mantine/notifications"
 import { Constants } from "app/constants"
@@ -9,11 +8,14 @@ import { redirectTo } from "app/redirect/slice"
 import { reloadServerInfos } from "app/server/thunks"
 import { useAppDispatch, useAppSelector } from "app/store"
 import { categoryUnreadCount } from "app/utils"
+import { DisablePullToRefresh } from "components/DisablePullToRefresh"
 import { ErrorBoundary } from "components/ErrorBoundary"
 import { Header } from "components/header/Header"
 import { Tree } from "components/sidebar/Tree"
+import { useAppLoading } from "hooks/useAppLoading"
 import { useBrowserExtension } from "hooks/useBrowserExtension"
 import { useI18n } from "i18n"
+import { WelcomePage } from "pages/WelcomePage"
 import { AdminUsersPage } from "pages/admin/AdminUsersPage"
 import { MetricsPage } from "pages/admin/MetricsPage"
 import { AboutPage } from "pages/app/AboutPage"
@@ -28,19 +30,20 @@ import { TagDetailsPage } from "pages/app/TagDetailsPage"
 import { LoginPage } from "pages/auth/LoginPage"
 import { PasswordRecoveryPage } from "pages/auth/PasswordRecoveryPage"
 import { RegistrationPage } from "pages/auth/RegistrationPage"
-import { WelcomePage } from "pages/WelcomePage"
+import React, { useEffect, useState } from "react"
-import React, { useEffect, useRef } from "react"
+import { isSafari } from "react-device-detect"
 import ReactGA from "react-ga4"
 import { HashRouter, Navigate, Route, Routes, useLocation, useNavigate } from "react-router-dom"
 import Tinycon from "tinycon"
 
 function Providers(props: { children: React.ReactNode }) {
+    const primaryColor = useAppSelector(state => state.user.settings?.primaryColor) || Constants.theme.defaultPrimaryColor
     return (
         <I18nProvider i18n={i18n}>
             <MantineProvider
                 defaultColorScheme="auto"
                 theme={{
-                    primaryColor: "orange",
+                    primaryColor: primaryColor,
                     fontFamily: "Open Sans",
                     colors: {
                         // keep using dark colors from mantine v6
@@ -69,7 +72,7 @@ function Providers(props: { children: React.ReactNode }) {
     )
 }
 
-// swagger-ui is very large, load only on-demand
+// api documentation page is very large, load only on-demand
 const ApiDocumentationPage = React.lazy(async () => await import("pages/app/ApiDocumentationPage"))
 
 function AppRoutes() {
@@ -140,16 +143,22 @@ function GoogleAnalyticsHandler() {
     return null
 }
 
-function FaviconHandler() {
+function UnreadCountTitleHandler({ enabled }: { enabled?: boolean }) {
     const root = useAppSelector(state => state.tree.rootCategory)
+    const unreadCount = categoryUnreadCount(root)
+    return <title>{enabled && unreadCount > 0 ? `(${unreadCount}) CommaFeed` : "CommaFeed"}</title>
+}
+
+function UnreadCountFaviconHandler({ enabled }: { enabled?: boolean }) {
+    const root = useAppSelector(state => state.tree.rootCategory)
+    const unreadCount = categoryUnreadCount(root)
     useEffect(() => {
-        const unreadCount = categoryUnreadCount(root)
+        if (enabled && unreadCount > 0) {
-        if (unreadCount === 0) {
-            Tinycon.reset()
-        } else {
             Tinycon.setBubble(unreadCount)
+        } else {
+            Tinycon.reset()
         }
-    }, [root])
+    }, [unreadCount, enabled])
 
     return null
 }
@@ -166,14 +175,12 @@ function BrowserExtensionBadgeUnreadCountHandler() {
     return null
 }
 
-function CustomJs() {
+function CustomJsHandler() {
-    const scriptLoaded = useRef(false)
+    const [scriptLoaded, setScriptLoaded] = useState(false)
+    const { loading } = useAppLoading()
 
-    // useDidUpdate is used instead of useEffect because we want to skip the first render
+    useEffect(() => {
-    // the first render is the render of react-router, the routes are actually loaded in a second render
+        if (scriptLoaded || loading) {
-    // we want the script to be executed when the first route is done loading
-    useDidUpdate(() => {
-        if (scriptLoaded.current) {
             return
         }
 
@@ -182,13 +189,13 @@ function CustomJs() {
         script.async = true
         document.body.appendChild(script)
 
-        scriptLoaded.current = true
+        setScriptLoaded(true)
-    })
+    }, [scriptLoaded, loading])
 
     return null
 }
 
-function CustomCss() {
+function CustomCssHandler() {
     useEffect(() => {
         const link = document.createElement("link")
         link.rel = "stylesheet"
@@ -202,6 +209,8 @@ function CustomCss() {
 
 export function App() {
     useI18n()
+    const unreadCountTitle = useAppSelector(state => state.user.settings?.unreadCountTitle)
+    const unreadCountFavicon = useAppSelector(state => state.user.settings?.unreadCountFavicon)
     const dispatch = useAppDispatch()
 
     useEffect(() => {
@@ -211,14 +220,22 @@ export function App() {
     return (
         <Providers>
             <>
-                <FaviconHandler />
+                <UnreadCountTitleHandler enabled={unreadCountTitle} />
+                <UnreadCountFaviconHandler enabled={unreadCountFavicon} />
                 <BrowserExtensionBadgeUnreadCountHandler />
+                <CustomJsHandler />
+                <CustomCssHandler />
+
+                {/* disable pull-to-refresh as it messes with vertical scrolling
+                        safari behaves weirdly when overscroll-behavior is set to none so we disable it only for other browsers
+                        https://github.com/Athou/commafeed/issues/1168
+                    */}
+                {!isSafari && <DisablePullToRefresh />}
+
                 <HashRouter>
                     <GoogleAnalyticsHandler />
                     <RedirectHandler />
                     <AppRoutes />
-                    <CustomJs />
-                    <CustomCss />
                 </HashRouter>
             </>
         </Providers>

commafeed-client/src/app/async-thunk.ts

@@ -1,7 +1,7 @@
-import { createAsyncThunk } from "@reduxjs/toolkit"
+import { createAsyncThunk } from "@reduxjs/toolkit"
-import { type AppDispatch, type RootState } from "app/store"
+import type { AppDispatch, RootState } from "app/store"
-
+
-export const createAppAsyncThunk = createAsyncThunk.withTypes<{
+export const createAppAsyncThunk = createAsyncThunk.withTypes<{
-    state: RootState
+    state: RootState
-    dispatch: AppDispatch
+    dispatch: AppDispatch
-}>()
+}>()

commafeed-client/src/app/client.ts

@@ -1,127 +1,137 @@
-import axios, { AxiosError } from "axios"
+import axios, { type AxiosError } from "axios"
-import {
+import type {
-    type AddCategoryRequest,
+    AddCategoryRequest,
-    type AdminSaveUserRequest,
+    AdminSaveUserRequest,
-    AuthenticationError,
+    AuthenticationError,
-    type Category,
+    Category,
-    type CategoryModificationRequest,
+    CategoryModificationRequest,
-    type CollapseRequest,
+    CollapseRequest,
-    type Entries,
+    Entries,
-    type FeedInfo,
+    FeedInfo,
-    type FeedInfoRequest,
+    FeedInfoRequest,
-    type FeedModificationRequest,
+    FeedModificationRequest,
-    type GetEntriesPaginatedRequest,
+    GetEntriesPaginatedRequest,
-    type IDRequest,
+    IDRequest,
-    type LoginRequest,
+    LoginRequest,
-    type MarkRequest,
+    MarkRequest,
-    type Metrics,
+    Metrics,
-    type MultipleMarkRequest,
+    MultipleMarkRequest,
-    type PasswordResetRequest,
+    PasswordResetRequest,
-    type ProfileModificationRequest,
+    ProfileModificationRequest,
-    type RegistrationRequest,
+    RegistrationRequest,
-    type ServerInfo,
+    ServerInfo,
-    type Settings,
+    Settings,
-    type StarRequest,
+    StarRequest,
-    type SubscribeRequest,
+    SubscribeRequest,
-    type Subscription,
+    Subscription,
-    type TagRequest,
+    TagRequest,
-    type UserModel,
+    UserModel,
-} from "./types"
+} from "./types"
-
+
-const axiosInstance = axios.create({ baseURL: "./rest", withCredentials: true })
+const axiosInstance = axios.create({ baseURL: "./rest", withCredentials: true })
-axiosInstance.interceptors.response.use(
+axiosInstance.interceptors.response.use(
-    response => response,
+    response => response,
-    error => {
+    error => {
-        if (isAuthenticationError(error)) {
+        if (isAuthenticationError(error)) {
-            const data = error.response?.data
+            const data = error.response?.data
-            window.location.hash = data?.allowRegistrations ? "/welcome" : "/login"
+            window.location.hash = data?.allowRegistrations ? "/welcome" : "/login"
-        }
+        }
-        throw error
+        throw error
-    }
+    }
-)
+)
-
+
-function isAuthenticationError(error: unknown): error is AxiosError<AuthenticationError> {
+function isAuthenticationError(error: unknown): error is AxiosError<AuthenticationError> {
-    return axios.isAxiosError(error) && !!error.response && [401, 403].includes(error.response.status)
+    return axios.isAxiosError(error) && !!error.response && [401, 403].includes(error.response.status)
-}
+}
-
+
-export const client = {
+export const client = {
-    category: {
+    category: {
-        getRoot: async () => await axiosInstance.get<Category>("category/get"),
+        getRoot: async () => await axiosInstance.get<Category>("category/get"),
-        modify: async (req: CategoryModificationRequest) => await axiosInstance.post("category/modify", req),
+        modify: async (req: CategoryModificationRequest) => await axiosInstance.post("category/modify", req),
-        collapse: async (req: CollapseRequest) => await axiosInstance.post("category/collapse", req),
+        collapse: async (req: CollapseRequest) => await axiosInstance.post("category/collapse", req),
-        getEntries: async (req: GetEntriesPaginatedRequest) => await axiosInstance.get<Entries>("category/entries", { params: req }),
+        getEntries: async (req: GetEntriesPaginatedRequest) => await axiosInstance.get<Entries>("category/entries", { params: req }),
-        markEntries: async (req: MarkRequest) => await axiosInstance.post("category/mark", req),
+        markEntries: async (req: MarkRequest) => await axiosInstance.post("category/mark", req),
-        add: async (req: AddCategoryRequest) => await axiosInstance.post("category/add", req),
+        add: async (req: AddCategoryRequest) => await axiosInstance.post("category/add", req),
-        delete: async (req: IDRequest) => await axiosInstance.post("category/delete", req),
+        delete: async (req: IDRequest) => await axiosInstance.post("category/delete", req),
-    },
+    },
-    entry: {
+    entry: {
-        mark: async (req: MarkRequest) => await axiosInstance.post("entry/mark", req),
+        mark: async (req: MarkRequest) => await axiosInstance.post("entry/mark", req),
-        markMultiple: async (req: MultipleMarkRequest) => await axiosInstance.post("entry/markMultiple", req),
+        markMultiple: async (req: MultipleMarkRequest) => await axiosInstance.post("entry/markMultiple", req),
-        star: async (req: StarRequest) => await axiosInstance.post("entry/star", req),
+        star: async (req: StarRequest) => await axiosInstance.post("entry/star", req),
-        getTags: async () => await axiosInstance.get<string[]>("entry/tags"),
+        getTags: async () => await axiosInstance.get<string[]>("entry/tags"),
-        tag: async (req: TagRequest) => await axiosInstance.post("entry/tag", req),
+        tag: async (req: TagRequest) => await axiosInstance.post("entry/tag", req),
-    },
+    },
-    feed: {
+    feed: {
-        get: async (id: string) => await axiosInstance.get<Subscription>(`feed/get/${id}`),
+        get: async (id: string) => await axiosInstance.get<Subscription>(`feed/get/${id}`),
-        modify: async (req: FeedModificationRequest) => await axiosInstance.post("feed/modify", req),
+        modify: async (req: FeedModificationRequest) => await axiosInstance.post("feed/modify", req),
-        getEntries: async (req: GetEntriesPaginatedRequest) => await axiosInstance.get<Entries>("feed/entries", { params: req }),
+        getEntries: async (req: GetEntriesPaginatedRequest) => await axiosInstance.get<Entries>("feed/entries", { params: req }),
-        markEntries: async (req: MarkRequest) => await axiosInstance.post("feed/mark", req),
+        markEntries: async (req: MarkRequest) => await axiosInstance.post("feed/mark", req),
-        fetchFeed: async (req: FeedInfoRequest) => await axiosInstance.post<FeedInfo>("feed/fetch", req),
+        fetchFeed: async (req: FeedInfoRequest) => await axiosInstance.post<FeedInfo>("feed/fetch", req),
-        refreshAll: async () => await axiosInstance.get("feed/refreshAll"),
+        refreshAll: async () => await axiosInstance.get("feed/refreshAll"),
-        subscribe: async (req: SubscribeRequest) => await axiosInstance.post<number>("feed/subscribe", req),
+        subscribe: async (req: SubscribeRequest) => await axiosInstance.post<number>("feed/subscribe", req),
-        unsubscribe: async (req: IDRequest) => await axiosInstance.post("feed/unsubscribe", req),
+        unsubscribe: async (req: IDRequest) => await axiosInstance.post("feed/unsubscribe", req),
-        importOpml: async (req: File) => {
+        importOpml: async (req: File) => {
-            const formData = new FormData()
+            const formData = new FormData()
-            formData.append("file", req)
+            formData.append("file", req)
-            return await axiosInstance.post("feed/import", formData, {
+            return await axiosInstance.post("feed/import", formData, {
-                headers: {
+                headers: {
-                    "Content-Type": "multipart/form-data",
+                    "Content-Type": "multipart/form-data",
-                },
+                },
-            })
+            })
-        },
+        },
-    },
+    },
-    user: {
+    user: {
-        login: async (req: LoginRequest) => await axiosInstance.post("user/login", req),
+        login: async (req: LoginRequest) => {
-        register: async (req: RegistrationRequest) => await axiosInstance.post("user/register", req),
+            const formData = new URLSearchParams()
-        passwordReset: async (req: PasswordResetRequest) => await axiosInstance.post("user/passwordReset", req),
+            formData.append("j_username", req.name)
-        getSettings: async () => await axiosInstance.get<Settings>("user/settings"),
+            formData.append("j_password", req.password)
-        saveSettings: async (settings: Settings) => await axiosInstance.post("user/settings", settings),
+            return await axiosInstance.post("j_security_check", formData, {
-        getProfile: async () => await axiosInstance.get<UserModel>("user/profile"),
+                baseURL: ".",
-        saveProfile: async (req: ProfileModificationRequest) => await axiosInstance.post("user/profile", req),
+                headers: {
-        deleteProfile: async () => await axiosInstance.post("user/profile/deleteAccount"),
+                    "Content-Type": "application/x-www-form-urlencoded",
-    },
+                },
-    server: {
+            })
-        getServerInfos: async () => await axiosInstance.get<ServerInfo>("server/get"),
+        },
-    },
+        register: async (req: RegistrationRequest) => await axiosInstance.post("user/register", req),
-    admin: {
+        passwordReset: async (req: PasswordResetRequest) => await axiosInstance.post("user/passwordReset", req),
-        getAllUsers: async () => await axiosInstance.get<UserModel[]>("admin/user/getAll"),
+        getSettings: async () => await axiosInstance.get<Settings>("user/settings"),
-        saveUser: async (req: AdminSaveUserRequest) => await axiosInstance.post("admin/user/save", req),
+        saveSettings: async (settings: Settings) => await axiosInstance.post("user/settings", settings),
-        deleteUser: async (req: IDRequest) => await axiosInstance.post("admin/user/delete", req),
+        getProfile: async () => await axiosInstance.get<UserModel>("user/profile"),
-        getMetrics: async () => await axiosInstance.get<Metrics>("admin/metrics"),
+        saveProfile: async (req: ProfileModificationRequest) => await axiosInstance.post("user/profile", req),
-    },
+        deleteProfile: async () => await axiosInstance.post("user/profile/deleteAccount"),
-}
+    },
-
+    server: {
-/**
+        getServerInfos: async () => await axiosInstance.get<ServerInfo>("server/get"),
- * transform an error object to an array of strings that can be displayed to the user
+    },
- * @param err an error object (e.g. from axios)
+    admin: {
- * @returns an array of messages to show the user
+        getAllUsers: async () => await axiosInstance.get<UserModel[]>("admin/user/getAll"),
- */
+        saveUser: async (req: AdminSaveUserRequest) => await axiosInstance.post("admin/user/save", req),
-export const errorToStrings = (err: unknown) => {
+        deleteUser: async (req: IDRequest) => await axiosInstance.post("admin/user/delete", req),
-    let strings: string[] = []
+        getMetrics: async () => await axiosInstance.get<Metrics>("admin/metrics"),
-
+    },
-    if (axios.isAxiosError(err) && err.response) {
+}
-        if (typeof err.response.data === "string") strings.push(err.response.data)
+
-        if (isMessageError(err)) strings.push(err.response.data.message)
+/**
-        if (isMessageArrayError(err)) strings = [...strings, ...err.response.data.errors]
+ * transform an error object to an array of strings that can be displayed to the user
-    }
+ * @param err an error object (e.g. from axios)
-
+ * @returns an array of messages to show the user
-    return strings
+ */
-}
+export const errorToStrings = (err: unknown) => {
-
+    let strings: string[] = []
-function isMessageError(err: AxiosError): err is AxiosError<{ message: string }> {
+
-    return !!err.response && !!err.response.data && typeof err.response.data === "object" && "message" in err.response.data
+    if (axios.isAxiosError(err) && err.response) {
-}
+        if (typeof err.response.data === "string") strings.push(err.response.data)
-
+        if (isMessageError(err)) strings.push(err.response.data.message)
-function isMessageArrayError(err: AxiosError): err is AxiosError<{ errors: string[] }> {
+        if (isMessageArrayError(err)) strings = [...strings, ...err.response.data.errors]
-    return !!err.response && !!err.response.data && typeof err.response.data === "object" && "errors" in err.response.data
+    }
-}
+
+    return strings
+}
+
+function isMessageError(err: AxiosError): err is AxiosError<{ message: string }> {
+    return !!err.response && !!err.response.data && typeof err.response.data === "object" && "message" in err.response.data
+}
+
+function isMessageArrayError(err: AxiosError): err is AxiosError<{ errors: string[] }> {
+    return !!err.response && !!err.response.data && typeof err.response.data === "object" && "errors" in err.response.data
+}

commafeed-client/src/app/constants.ts

@@ -1,109 +1,113 @@
-import { t } from "@lingui/macro"
+import type { IconType } from "react-icons"
-import { type IconType } from "react-icons"
+import { FaAt } from "react-icons/fa"
-import { FaAt } from "react-icons/fa"
+import { SiBuffer, SiFacebook, SiGmail, SiInstapaper, SiPocket, SiTumblr, SiX } from "react-icons/si"
-import { SiBuffer, SiFacebook, SiGmail, SiInstapaper, SiPocket, SiTumblr, SiTwitter } from "react-icons/si"
+import type { Category, Entry, SharingSettings } from "./types"
-import { type Category, type Entry, type SharingSettings } from "./types"
+
-
+const categories: Record<string, Omit<Category, "name">> = {
-const categories: Record<string, Category> = {
+    all: {
-    all: {
+        id: "all",
-        id: "all",
+        expanded: false,
-        name: t`All`,
+        children: [],
-        expanded: false,
+        feeds: [],
-        children: [],
+        position: 0,
-        feeds: [],
+    },
-        position: 0,
+    starred: {
-    },
+        id: "starred",
-    starred: {
+        expanded: false,
-        id: "starred",
+        children: [],
-        name: t`Starred`,
+        feeds: [],
-        expanded: false,
+        position: 1,
-        children: [],
+    },
-        feeds: [],
+}
-        position: 1,
+
-    },
+const sharing: {
-}
+    [key in keyof SharingSettings]: {
-
+        label: string
-const sharing: {
+        icon: IconType
-    [key in keyof SharingSettings]: {
+        color: `#${string}`
-        label: string
+        url: (url: string, description: string) => string
-        icon: IconType
+    }
-        color: `#${string}`
+} = {
-        url: (url: string, description: string) => string
+    email: {
-    }
+        label: "Email",
-} = {
+        icon: FaAt,
-    email: {
+        color: "#000000",
-        label: "Email",
+        url: (url, desc) => `mailto:?subject=${desc}&body=${url}`,
-        icon: FaAt,
+    },
-        color: "#000000",
+    gmail: {
-        url: (url, desc) => `mailto:?subject=${desc}&body=${url}`,
+        label: "Gmail",
-    },
+        icon: SiGmail,
-    gmail: {
+        color: "#EA4335",
-        label: "Gmail",
+        url: (url, desc) => `https://mail.google.com/mail/?view=cm&fs=1&tf=1&source=mailto&su=${desc}&body=${url}`,
-        icon: SiGmail,
+    },
-        color: "#EA4335",
+    facebook: {
-        url: (url, desc) => `https://mail.google.com/mail/?view=cm&fs=1&tf=1&source=mailto&su=${desc}&body=${url}`,
+        label: "Facebook",
-    },
+        icon: SiFacebook,
-    facebook: {
+        color: "#1B74E4",
-        label: "Facebook",
+        url: url => `https://www.facebook.com/sharer/sharer.php?u=${url}`,
-        icon: SiFacebook,
+    },
-        color: "#1B74E4",
+    twitter: {
-        url: url => `https://www.facebook.com/sharer/sharer.php?u=${url}`,
+        label: "X",
-    },
+        icon: SiX,
-    twitter: {
+        color: "#000000",
-        label: "Twitter",
+        url: (url, desc) => `https://x.com/share?text=${desc}&url=${url}`,
-        icon: SiTwitter,
+    },
-        color: "#1D9BF0",
+    tumblr: {
-        url: (url, desc) => `https://twitter.com/share?text=${desc}&url=${url}`,
+        label: "Tumblr",
-    },
+        icon: SiTumblr,
-    tumblr: {
+        color: "#375672",
-        label: "Tumblr",
+        url: (url, desc) => `https://www.tumblr.com/share/link?url=${url}&name=${desc}`,
-        icon: SiTumblr,
+    },
-        color: "#375672",
+    pocket: {
-        url: (url, desc) => `https://www.tumblr.com/share/link?url=${url}&name=${desc}`,
+        label: "Pocket",
-    },
+        icon: SiPocket,
-    pocket: {
+        color: "#EF4154",
-        label: "Pocket",
+        url: (url, desc) => `https://getpocket.com/save?url=${url}&title=${desc}`,
-        icon: SiPocket,
+    },
-        color: "#EF4154",
+    instapaper: {
-        url: (url, desc) => `https://getpocket.com/save?url=${url}&title=${desc}`,
+        label: "Instapaper",
-    },
+        icon: SiInstapaper,
-    instapaper: {
+        color: "#010101",
-        label: "Instapaper",
+        url: (url, desc) => `https://www.instapaper.com/hello2?url=${url}&title=${desc}`,
-        icon: SiInstapaper,
+    },
-        color: "#010101",
+    buffer: {
-        url: (url, desc) => `https://www.instapaper.com/hello2?url=${url}&title=${desc}`,
+        label: "Buffer",
-    },
+        icon: SiBuffer,
-    buffer: {
+        color: "#000000",
-        label: "Buffer",
+        url: (url, desc) => `https://bufferapp.com/add?url=${url}&text=${desc}`,
-        icon: SiBuffer,
+    },
-        color: "#000000",
+}
-        url: (url, desc) => `https://bufferapp.com/add?url=${url}&text=${desc}`,
+
-    },
+export const Constants = {
-}
+    categories,
-
+    sharing,
-export const Constants = {
+    layout: {
-    categories,
+        mobileBreakpoint: 992,
-    sharing,
+        mobileBreakpointName: "md",
-    layout: {
+        headerHeight: 60,
-        mobileBreakpoint: 992,
+        entryMaxWidth: 650,
-        mobileBreakpointName: "md",
+        isTopVisible: (div: HTMLElement) => {
-        headerHeight: 60,
+            const header = document.getElementById(Constants.dom.headerId)?.getBoundingClientRect()
-        entryMaxWidth: 650,
+            return div.getBoundingClientRect().top >= (header?.bottom ?? 0)
-        isTopVisible: (div: HTMLElement) => {
+        },
-            const header = document.getElementById(Constants.dom.headerId)?.getBoundingClientRect()
+        isBottomVisible: (div: HTMLElement) => {
-            return div.getBoundingClientRect().top >= (header?.bottom ?? 0)
+            const footer = document.getElementById(Constants.dom.footerId)?.getBoundingClientRect()
-        },
+            return div.getBoundingClientRect().bottom <= (footer?.top ?? window.innerHeight)
-        isBottomVisible: (div: HTMLElement) => {
+        },
-            const footer = document.getElementById(Constants.dom.footerId)?.getBoundingClientRect()
+    },
-            return div.getBoundingClientRect().bottom <= (footer?.top ?? window.innerHeight)
+    dom: {
-        },
+        headerId: "header",
-    },
+        footerId: "footer",
-    dom: {
+        entryId: (entry: Entry) => `entry-id-${entry.id}`,
-        headerId: "header",
+        entryContextMenuId: (entry: Entry) => entry.id,
-        footerId: "footer",
+    },
-        entryId: (entry: Entry) => `entry-id-${entry.id}`,
+    theme: {
-        entryContextMenuId: (entry: Entry) => entry.id,
+        defaultPrimaryColor: "orange",
-    },
+    },
-    browserExtensionUrl: "https://github.com/Athou/commafeed-browser-extension",
+    tooltip: {
-    bitcoinWalletAddress: "1dymfUxqCWpyD7a6rQSqNy4rLVDBsAr5e",
+        delay: 500,
-}
+    },
+    browserExtensionUrl: "https://github.com/Athou/commafeed-browser-extension",
+    customCssDocumentationUrl: "https://athou.github.io/commafeed/documentation/custom-css",
+    bitcoinWalletAddress: "1dymfUxqCWpyD7a6rQSqNy4rLVDBsAr5e",
+}

commafeed-client/src/app/entries/entries.test.ts

@@ -1,145 +1,140 @@
-import { configureStore } from "@reduxjs/toolkit"
+import { configureStore } from "@reduxjs/toolkit"
-import { type client } from "app/client"
+import { client } from "app/client"
-import { loadEntries, loadMoreEntries, markAllEntries, markEntry } from "app/entries/thunks"
+import { loadEntries, loadMoreEntries, markAllEntries, markEntry } from "app/entries/thunks"
-import { reducers, type RootState } from "app/store"
+import { type RootState, reducers } from "app/store"
-import { type Entries, type Entry } from "app/types"
+import type { Entries, Entry } from "app/types"
-import { type AxiosResponse } from "axios"
+import type { AxiosResponse } from "axios"
-import { beforeEach, describe, expect, it, vi } from "vitest"
+import { beforeEach, describe, expect, it, vi } from "vitest"
-import { mockReset } from "vitest-mock-extended"
+
-
+vi.mock(import("app/client"))
-const mockClient = await vi.hoisted(async () => {
+
-    const mockModule = await import("vitest-mock-extended")
+describe("entries", () => {
-    return mockModule.mockDeep<typeof client>()
+    beforeEach(() => {
-})
+        vi.resetAllMocks()
-vi.mock("app/client", () => ({ client: mockClient }))
+    })
-
+
-describe("entries", () => {
+    it("loads entries", async () => {
-    beforeEach(() => {
+        vi.mocked(client.feed.getEntries).mockResolvedValue({
-        mockReset(mockClient)
+            data: {
-    })
+                entries: [{ id: "3" } as Entry],
-
+                hasMore: false,
-    it("loads entries", async () => {
+                name: "my-feed",
-        mockClient.feed.getEntries.mockResolvedValue({
+                errorCount: 3,
-            data: {
+                feedLink: "https://mysite.com/feed",
-                entries: [{ id: "3" } as Entry],
+                timestamp: 123,
-                hasMore: false,
+                ignoredReadStatus: false,
-                name: "my-feed",
+            },
-                errorCount: 3,
+        } as AxiosResponse<Entries>)
-                feedLink: "https://mysite.com/feed",
+
-                timestamp: 123,
+        const store = configureStore({ reducer: reducers })
-                ignoredReadStatus: false,
+        const promise = store.dispatch(loadEntries({ source: { type: "feed", id: "feed-id" }, clearSearch: true }))
-            },
+
-        } as AxiosResponse<Entries>)
+        expect(store.getState().entries.source.type).toBe("feed")
-
+        expect(store.getState().entries.source.id).toBe("feed-id")
-        const store = configureStore({ reducer: reducers })
+        expect(store.getState().entries.entries).toStrictEqual([])
-        const promise = store.dispatch(loadEntries({ source: { type: "feed", id: "feed-id" }, clearSearch: true }))
+        expect(store.getState().entries.hasMore).toBe(true)
-
+        expect(store.getState().entries.sourceLabel).toBe("")
-        expect(store.getState().entries.source.type).toBe("feed")
+        expect(store.getState().entries.sourceWebsiteUrl).toBe("")
-        expect(store.getState().entries.source.id).toBe("feed-id")
+        expect(store.getState().entries.timestamp).toBeUndefined()
-        expect(store.getState().entries.entries).toStrictEqual([])
+
-        expect(store.getState().entries.hasMore).toBe(true)
+        await promise
-        expect(store.getState().entries.sourceLabel).toBe("")
+        expect(store.getState().entries.source.type).toBe("feed")
-        expect(store.getState().entries.sourceWebsiteUrl).toBe("")
+        expect(store.getState().entries.source.id).toBe("feed-id")
-        expect(store.getState().entries.timestamp).toBeUndefined()
+        expect(store.getState().entries.entries).toStrictEqual([{ id: "3" }])
-
+        expect(store.getState().entries.hasMore).toBe(false)
-        await promise
+        expect(store.getState().entries.sourceLabel).toBe("my-feed")
-        expect(store.getState().entries.source.type).toBe("feed")
+        expect(store.getState().entries.sourceWebsiteUrl).toBe("https://mysite.com/feed")
-        expect(store.getState().entries.source.id).toBe("feed-id")
+        expect(store.getState().entries.timestamp).toBe(123)
-        expect(store.getState().entries.entries).toStrictEqual([{ id: "3" }])
+    })
-        expect(store.getState().entries.hasMore).toBe(false)
+
-        expect(store.getState().entries.sourceLabel).toBe("my-feed")
+    it("loads more entries", async () => {
-        expect(store.getState().entries.sourceWebsiteUrl).toBe("https://mysite.com/feed")
+        vi.mocked(client.category.getEntries).mockResolvedValue({
-        expect(store.getState().entries.timestamp).toBe(123)
+            data: {
-    })
+                entries: [{ id: "4" } as Entry],
-
+                hasMore: false,
-    it("loads more entries", async () => {
+                name: "my-feed",
-        mockClient.category.getEntries.mockResolvedValue({
+                errorCount: 3,
-            data: {
+                feedLink: "https://mysite.com/feed",
-                entries: [{ id: "4" } as Entry],
+                timestamp: 123,
-                hasMore: false,
+                ignoredReadStatus: false,
-                name: "my-feed",
+            },
-                errorCount: 3,
+        } as AxiosResponse<Entries>)
-                feedLink: "https://mysite.com/feed",
+
-                timestamp: 123,
+        const store = configureStore({
-                ignoredReadStatus: false,
+            reducer: reducers,
-            },
+            preloadedState: {
-        } as AxiosResponse<Entries>)
+                entries: {
-
+                    source: {
-        const store = configureStore({
+                        type: "category",
-            reducer: reducers,
+                        id: "category-id",
-            preloadedState: {
+                    },
-                entries: {
+                    sourceLabel: "",
-                    source: {
+                    sourceWebsiteUrl: "",
-                        type: "category",
+                    entries: [{ id: "3" } as Entry],
-                        id: "category-id",
+                    hasMore: true,
-                    },
+                    loading: false,
-                    sourceLabel: "",
+                    scrollingToEntry: false,
-                    sourceWebsiteUrl: "",
+                },
-                    entries: [{ id: "3" } as Entry],
+            } as RootState,
-                    hasMore: true,
+        })
-                    loading: false,
+        const promise = store.dispatch(loadMoreEntries())
-                    scrollingToEntry: false,
+
-                },
+        await promise
-            } as RootState,
+        expect(store.getState().entries.entries).toStrictEqual([{ id: "3" }, { id: "4" }])
-        })
+        expect(store.getState().entries.hasMore).toBe(false)
-        const promise = store.dispatch(loadMoreEntries())
+    })
-
+
-        await promise
+    it("marks an entry as read", () => {
-        expect(store.getState().entries.entries).toStrictEqual([{ id: "3" }, { id: "4" }])
+        const store = configureStore({
-        expect(store.getState().entries.hasMore).toBe(false)
+            reducer: reducers,
-    })
+            preloadedState: {
-
+                entries: {
-    it("marks an entry as read", () => {
+                    source: {
-        const store = configureStore({
+                        type: "category",
-            reducer: reducers,
+                        id: "category-id",
-            preloadedState: {
+                    },
-                entries: {
+                    sourceLabel: "",
-                    source: {
+                    sourceWebsiteUrl: "",
-                        type: "category",
+                    entries: [{ id: "3", read: false } as Entry, { id: "4", read: false } as Entry],
-                        id: "category-id",
+                    hasMore: true,
-                    },
+                    loading: false,
-                    sourceLabel: "",
+                    scrollingToEntry: false,
-                    sourceWebsiteUrl: "",
+                },
-                    entries: [{ id: "3", read: false } as Entry, { id: "4", read: false } as Entry],
+            } as RootState,
-                    hasMore: true,
+        })
-                    loading: false,
+
-                    scrollingToEntry: false,
+        store.dispatch(markEntry({ entry: { id: "3" } as Entry, read: true }))
-                },
+        expect(store.getState().entries.entries).toStrictEqual([
-            } as RootState,
+            { id: "3", read: true },
-        })
+            { id: "4", read: false },
-
+        ])
-        store.dispatch(markEntry({ entry: { id: "3" } as Entry, read: true }))
+        expect(client.entry.mark).toHaveBeenCalledWith({ id: "3", read: true })
-        expect(store.getState().entries.entries).toStrictEqual([
+    })
-            { id: "3", read: true },
+
-            { id: "4", read: false },
+    it("marks all entries as read", () => {
-        ])
+        const store = configureStore({
-        expect(mockClient.entry.mark).toHaveBeenCalledWith({ id: "3", read: true })
+            reducer: reducers,
-    })
+            preloadedState: {
-
+                entries: {
-    it("marks all entries as read", () => {
+                    source: {
-        const store = configureStore({
+                        type: "category",
-            reducer: reducers,
+                        id: "category-id",
-            preloadedState: {
+                    },
-                entries: {
+                    sourceLabel: "",
-                    source: {
+                    sourceWebsiteUrl: "",
-                        type: "category",
+                    entries: [{ id: "3", read: false } as Entry, { id: "4", read: false } as Entry],
-                        id: "category-id",
+                    hasMore: true,
-                    },
+                    loading: false,
-                    sourceLabel: "",
+                    scrollingToEntry: false,
-                    sourceWebsiteUrl: "",
+                },
-                    entries: [{ id: "3", read: false } as Entry, { id: "4", read: false } as Entry],
+            } as RootState,
-                    hasMore: true,
+        })
-                    loading: false,
+
-                    scrollingToEntry: false,
+        store.dispatch(markAllEntries({ sourceType: "category", req: { id: "all", read: true } }))
-                },
+        expect(store.getState().entries.entries).toStrictEqual([
-            } as RootState,
+            { id: "3", read: true },
-        })
+            { id: "4", read: true },
-
+        ])
-        store.dispatch(markAllEntries({ sourceType: "category", req: { id: "all", read: true } }))
+        expect(client.category.markEntries).toHaveBeenCalledWith({ id: "all", read: true })
-        expect(store.getState().entries.entries).toStrictEqual([
+    })
-            { id: "3", read: true },
+})
-            { id: "4", read: true },
-        ])
-        expect(mockClient.category.markEntries).toHaveBeenCalledWith({ id: "all", read: true })
-    })
-})

commafeed-client/src/app/entries/slice.ts

@@ -1,134 +1,127 @@
-import { createSlice, type PayloadAction } from "@reduxjs/toolkit"
+import { type PayloadAction, createSlice } from "@reduxjs/toolkit"
-import { Constants } from "app/constants"
+import { Constants } from "app/constants"
-import { loadEntries, loadMoreEntries, markAllEntries, markEntry, markMultipleEntries, starEntry, tagEntry } from "app/entries/thunks"
+import { loadEntries, loadMoreEntries, markAllEntries, markEntry, markMultipleEntries, starEntry, tagEntry } from "app/entries/thunks"
-import { type Entry } from "app/types"
+import type { Entry } from "app/types"
-
+
-export type EntrySourceType = "category" | "feed" | "tag"
+export type EntrySourceType = "category" | "feed" | "tag"
-
+
-export interface EntrySource {
+export interface EntrySource {
-    type: EntrySourceType
+    type: EntrySourceType
-    id: string
+    id: string
-}
+}
-
+
-export type ExpendableEntry = Entry & { expanded?: boolean }
+export type ExpendableEntry = Entry & { expanded?: boolean }
-
+
-interface EntriesState {
+interface EntriesState {
-    /** selected source */
+    /** selected source */
-    source: EntrySource
+    source: EntrySource
-    sourceLabel: string
+    sourceLabel: string
-    sourceWebsiteUrl: string
+    sourceWebsiteUrl: string
-    entries: ExpendableEntry[]
+    entries: ExpendableEntry[]
-    /** stores when the first batch of entries were retrieved
+    /** stores when the first batch of entries were retrieved
-     *
+     *
-     * this is used when marking all entries of a feed/category to only mark entries up to that timestamp as newer entries were potentially never shown
+     * this is used when marking all entries of a feed/category to only mark entries up to that timestamp as newer entries were potentially never shown
-     */
+     */
-    timestamp?: number
+    timestamp?: number
-    selectedEntryId?: string
+    selectedEntryId?: string
-    hasMore: boolean
+    hasMore: boolean
-    loading: boolean
+    loading: boolean
-    search?: string
+    search?: string
-    scrollingToEntry: boolean
+    scrollingToEntry: boolean
-}
+    markAllAsReadConfirmationDialogOpen: boolean
-
+}
-const initialState: EntriesState = {
+
-    source: {
+const initialState: EntriesState = {
-        type: "category",
+    source: {
-        id: Constants.categories.all.id,
+        type: "category",
-    },
+        id: Constants.categories.all.id,
-    sourceLabel: "",
+    },
-    sourceWebsiteUrl: "",
+    sourceLabel: "",
-    entries: [],
+    sourceWebsiteUrl: "",
-    hasMore: true,
+    entries: [],
-    loading: false,
+    hasMore: true,
-    scrollingToEntry: false,
+    loading: false,
-}
+    scrollingToEntry: false,
-
+    markAllAsReadConfirmationDialogOpen: false,
-export const entriesSlice = createSlice({
+}
-    name: "entries",
+
-    initialState,
+export const entriesSlice = createSlice({
-    reducers: {
+    name: "entries",
-        setSelectedEntry: (state, action: PayloadAction<Entry>) => {
+    initialState,
-            state.selectedEntryId = action.payload.id
+    reducers: {
-        },
+        setSelectedEntry: (state, action: PayloadAction<Entry>) => {
-        setEntryExpanded: (state, action: PayloadAction<{ entry: Entry; expanded: boolean }>) => {
+            state.selectedEntryId = action.payload.id
-            state.entries
+        },
-                .filter(e => e.id === action.payload.entry.id)
+        setEntryExpanded: (state, action: PayloadAction<{ entry: Entry; expanded: boolean }>) => {
-                .forEach(e => {
+            for (const e of state.entries.filter(e => e.id === action.payload.entry.id)) {
-                    e.expanded = action.payload.expanded
+                e.expanded = action.payload.expanded
-                })
+            }
-        },
+        },
-        setScrollingToEntry: (state, action: PayloadAction<boolean>) => {
+        setScrollingToEntry: (state, action: PayloadAction<boolean>) => {
-            state.scrollingToEntry = action.payload
+            state.scrollingToEntry = action.payload
-        },
+        },
-        setSearch: (state, action: PayloadAction<string>) => {
+        setSearch: (state, action: PayloadAction<string>) => {
-            state.search = action.payload
+            state.search = action.payload
-        },
+        },
-    },
+        setMarkAllAsReadConfirmationDialogOpen: (state, action: PayloadAction<boolean>) => {
-    extraReducers: builder => {
+            state.markAllAsReadConfirmationDialogOpen = action.payload
-        builder.addCase(markEntry.pending, (state, action) => {
+        },
-            state.entries
+    },
-                .filter(e => e.id === action.meta.arg.entry.id)
+    extraReducers: builder => {
-                .forEach(e => {
+        builder.addCase(markEntry.pending, (state, action) => {
-                    e.read = action.meta.arg.read
+            for (const e of state.entries.filter(e => e.id === action.meta.arg.entry.id)) {
-                })
+                e.read = action.meta.arg.read
-        })
+            }
-        builder.addCase(markMultipleEntries.pending, (state, action) => {
+        })
-            state.entries
+        builder.addCase(markMultipleEntries.pending, (state, action) => {
-                .filter(e => action.meta.arg.entries.some(e2 => e2.id === e.id))
+            for (const e of state.entries.filter(e => action.meta.arg.entries.some(e2 => e2.id === e.id))) {
-                .forEach(e => {
+                e.read = action.meta.arg.read
-                    e.read = action.meta.arg.read
+            }
-                })
+        })
-        })
+        builder.addCase(markAllEntries.pending, (state, action) => {
-        builder.addCase(markAllEntries.pending, (state, action) => {
+            for (const e of state.entries.filter(e => (action.meta.arg.req.olderThan ? e.date < action.meta.arg.req.olderThan : true))) {
-            state.entries
+                e.read = true
-                .filter(e => (action.meta.arg.req.olderThan ? e.date < action.meta.arg.req.olderThan : true))
+            }
-                .forEach(e => {
+        })
-                    e.read = true
+        builder.addCase(starEntry.pending, (state, action) => {
-                })
+            for (const e of state.entries.filter(e => action.meta.arg.entry.id === e.id && action.meta.arg.entry.feedId === e.feedId)) {
-        })
+                e.starred = action.meta.arg.starred
-        builder.addCase(starEntry.pending, (state, action) => {
+            }
-            state.entries
+        })
-                .filter(e => action.meta.arg.entry.id === e.id && action.meta.arg.entry.feedId === e.feedId)
+        builder.addCase(loadEntries.pending, (state, action) => {
-                .forEach(e => {
+            state.source = action.meta.arg.source
-                    e.starred = action.meta.arg.starred
+            state.entries = []
-                })
+            state.timestamp = undefined
-        })
+            state.sourceLabel = ""
-        builder.addCase(loadEntries.pending, (state, action) => {
+            state.sourceWebsiteUrl = ""
-            state.source = action.meta.arg.source
+            state.hasMore = true
-            state.entries = []
+            state.selectedEntryId = undefined
-            state.timestamp = undefined
+            state.loading = true
-            state.sourceLabel = ""
+        })
-            state.sourceWebsiteUrl = ""
+        builder.addCase(loadMoreEntries.pending, state => {
-            state.hasMore = true
+            state.loading = true
-            state.selectedEntryId = undefined
+        })
-            state.loading = true
+        builder.addCase(loadEntries.fulfilled, (state, action) => {
-        })
+            state.entries = action.payload.entries
-        builder.addCase(loadMoreEntries.pending, state => {
+            state.timestamp = action.payload.timestamp
-            state.loading = true
+            state.sourceLabel = action.payload.name
-        })
+            state.sourceWebsiteUrl = action.payload.feedLink
-        builder.addCase(loadEntries.fulfilled, (state, action) => {
+            state.hasMore = action.payload.hasMore
-            state.entries = action.payload.entries
+            state.loading = false
-            state.timestamp = action.payload.timestamp
+        })
-            state.sourceLabel = action.payload.name
+        builder.addCase(loadMoreEntries.fulfilled, (state, action) => {
-            state.sourceWebsiteUrl = action.payload.feedLink
+            // remove already existing entries
-            state.hasMore = action.payload.hasMore
+            const entriesToAdd = action.payload.entries.filter(e => !state.entries.some(e2 => e.id === e2.id))
-            state.loading = false
+            state.entries = [...state.entries, ...entriesToAdd]
-        })
+            state.hasMore = action.payload.hasMore
-        builder.addCase(loadMoreEntries.fulfilled, (state, action) => {
+            state.loading = false
-            // remove already existing entries
+        })
-            const entriesToAdd = action.payload.entries.filter(e => !state.entries.some(e2 => e.id === e2.id))
+        builder.addCase(tagEntry.pending, (state, action) => {
-            state.entries = [...state.entries, ...entriesToAdd]
+            for (const e of state.entries.filter(e => +e.id === action.meta.arg.entryId)) {
-            state.hasMore = action.payload.hasMore
+                e.tags = action.meta.arg.tags
-            state.loading = false
+            }
-        })
+        })
-        builder.addCase(tagEntry.pending, (state, action) => {
+    },
-            state.entries
+})
-                .filter(e => +e.id === action.meta.arg.entryId)
+
-                .forEach(e => {
+export const { setSearch, setMarkAllAsReadConfirmationDialogOpen } = entriesSlice.actions
-                    e.tags = action.meta.arg.tags
-                })
-        })
-    },
-})
-
-export const { setSearch } = entriesSlice.actions

commafeed-client/src/app/entries/thunks.ts

@@ -1,241 +1,307 @@
-import { createAppAsyncThunk } from "app/async-thunk"
+import { createAppAsyncThunk } from "app/async-thunk"
-import { client } from "app/client"
+import { client } from "app/client"
-import { Constants } from "app/constants"
+import { Constants } from "app/constants"
-import { entriesSlice, type EntrySource, type EntrySourceType, setSearch } from "app/entries/slice"
+import { type EntrySource, type EntrySourceType, entriesSlice, setMarkAllAsReadConfirmationDialogOpen, setSearch } from "app/entries/slice"
-import type { RootState } from "app/store"
+import type { RootState } from "app/store"
-import { reloadTree } from "app/tree/thunks"
+import { reloadTree } from "app/tree/thunks"
-import type { Entry, MarkRequest, TagRequest } from "app/types"
+import type { Entry, MarkRequest, TagRequest } from "app/types"
-import { reloadTags } from "app/user/thunks"
+import { reloadTags } from "app/user/thunks"
-import { scrollToWithCallback } from "app/utils"
+import { scrollToWithCallback } from "app/utils"
-import { flushSync } from "react-dom"
+import { flushSync } from "react-dom"
-
+
-const getEndpoint = (sourceType: EntrySourceType) =>
+const getEndpoint = (sourceType: EntrySourceType) =>
-    sourceType === "category" || sourceType === "tag" ? client.category.getEntries : client.feed.getEntries
+    sourceType === "category" || sourceType === "tag" ? client.category.getEntries : client.feed.getEntries
-export const loadEntries = createAppAsyncThunk(
+
-    "entries/load",
+export const loadEntries = createAppAsyncThunk(
-    async (
+    "entries/load",
-        arg: {
+    async (
-            source: EntrySource
+        arg: {
-            clearSearch: boolean
+            source: EntrySource
-        },
+            clearSearch: boolean
-        thunkApi
+        },
-    ) => {
+        thunkApi
-        if (arg.clearSearch) thunkApi.dispatch(setSearch(""))
+    ) => {
-
+        if (arg.clearSearch) thunkApi.dispatch(setSearch(""))
-        const state = thunkApi.getState()
+
-        const endpoint = getEndpoint(arg.source.type)
+        const state = thunkApi.getState()
-        const result = await endpoint(buildGetEntriesPaginatedRequest(state, arg.source, 0))
+        const endpoint = getEndpoint(arg.source.type)
-        return result.data
+        const result = await endpoint(buildGetEntriesPaginatedRequest(state, arg.source, 0))
-    }
+        return result.data
-)
+    }
-export const loadMoreEntries = createAppAsyncThunk("entries/loadMore", async (_, thunkApi) => {
+)
-    const state = thunkApi.getState()
+
-    const { source } = state.entries
+export const loadMoreEntries = createAppAsyncThunk("entries/loadMore", async (_, thunkApi) => {
-    const offset =
+    const state = thunkApi.getState()
-        state.user.settings?.readingMode === "all" ? state.entries.entries.length : state.entries.entries.filter(e => !e.read).length
+    const { source } = state.entries
-    const endpoint = getEndpoint(state.entries.source.type)
+    const offset =
-    const result = await endpoint(buildGetEntriesPaginatedRequest(state, source, offset))
+        state.user.settings?.readingMode === "all" ? state.entries.entries.length : state.entries.entries.filter(e => !e.read).length
-    return result.data
+    const endpoint = getEndpoint(state.entries.source.type)
-})
+    const result = await endpoint(buildGetEntriesPaginatedRequest(state, source, offset))
-const buildGetEntriesPaginatedRequest = (state: RootState, source: EntrySource, offset: number) => ({
+    return result.data
-    id: source.type === "tag" ? Constants.categories.all.id : source.id,
+})
-    order: state.user.settings?.readingOrder,
+
-    readType: state.user.settings?.readingMode,
+const buildGetEntriesPaginatedRequest = (state: RootState, source: EntrySource, offset: number) => ({
-    offset,
+    id: source.type === "tag" ? Constants.categories.all.id : source.id,
-    limit: 50,
+    order: state.user.settings?.readingOrder,
-    tag: source.type === "tag" ? source.id : undefined,
+    readType: state.entries.search ? "all" : state.user.settings?.readingMode,
-    keywords: state.entries.search,
+    offset,
-})
+    limit: 50,
-export const reloadEntries = createAppAsyncThunk("entries/reload", (arg, thunkApi) => {
+    tag: source.type === "tag" ? source.id : undefined,
-    const state = thunkApi.getState()
+    keywords: state.entries.search,
-    thunkApi.dispatch(loadEntries({ source: state.entries.source, clearSearch: false }))
+})
-})
+
-export const search = createAppAsyncThunk("entries/search", (arg: string, thunkApi) => {
+export const reloadEntries = createAppAsyncThunk("entries/reload", (_, thunkApi) => {
-    const state = thunkApi.getState()
+    const state = thunkApi.getState()
-    thunkApi.dispatch(setSearch(arg))
+    thunkApi.dispatch(loadEntries({ source: state.entries.source, clearSearch: false }))
-    thunkApi.dispatch(loadEntries({ source: state.entries.source, clearSearch: false }))
+})
-})
+
-export const markEntry = createAppAsyncThunk(
+export const search = createAppAsyncThunk("entries/search", (arg: string, thunkApi) => {
-    "entries/entry/mark",
+    const state = thunkApi.getState()
-    (arg: { entry: Entry; read: boolean }) => {
+    thunkApi.dispatch(setSearch(arg))
-        client.entry.mark({
+    thunkApi.dispatch(loadEntries({ source: state.entries.source, clearSearch: false }))
-            id: arg.entry.id,
+})
-            read: arg.read,
+
-        })
+export const markEntry = createAppAsyncThunk(
-    },
+    "entries/entry/mark",
-    {
+    (arg: { entry: Entry; read: boolean }) => {
-        condition: arg => arg.entry.read !== arg.read,
+        client.entry.mark({
-    }
+            id: arg.entry.id,
-)
+            read: arg.read,
-export const markMultipleEntries = createAppAsyncThunk(
+        })
-    "entries/entry/markMultiple",
+    },
-    async (
+    {
-        arg: {
+        condition: arg => arg.entry.markable && arg.entry.read !== arg.read,
-            entries: Entry[]
+    }
-            read: boolean
+)
-        },
+
-        thunkApi
+export const markMultipleEntries = createAppAsyncThunk(
-    ) => {
+    "entries/entry/markMultiple",
-        const requests: MarkRequest[] = arg.entries.map(e => ({
+    async (
-            id: e.id,
+        arg: {
-            read: arg.read,
+            entries: Entry[]
-        }))
+            read: boolean
-        await client.entry.markMultiple({ requests })
+        },
-        thunkApi.dispatch(reloadTree())
+        thunkApi
-    }
+    ) => {
-)
+        const requests: MarkRequest[] = arg.entries.map(e => ({
-export const markEntriesUpToEntry = createAppAsyncThunk("entries/entry/upToEntry", (arg: Entry, thunkApi) => {
+            id: e.id,
-    const state = thunkApi.getState()
+            read: arg.read,
-    const { entries } = state.entries
+        }))
-
+        await client.entry.markMultiple({ requests })
-    const index = entries.findIndex(e => e.id === arg.id)
+        thunkApi.dispatch(reloadTree())
-    if (index === -1) return
+    }
-
+)
-    thunkApi.dispatch(
+
-        markMultipleEntries({
+export const markEntriesUpToEntry = createAppAsyncThunk("entries/entry/upToEntry", (arg: Entry, thunkApi) => {
-            entries: entries.slice(0, index + 1),
+    const state = thunkApi.getState()
-            read: true,
+    const { entries } = state.entries
-        })
+
-    )
+    const index = entries.findIndex(e => e.id === arg.id)
-})
+    if (index === -1) return
-export const markAllEntries = createAppAsyncThunk(
+
-    "entries/entry/markAll",
+    thunkApi.dispatch(
-    async (
+        markMultipleEntries({
-        arg: {
+            entries: entries.slice(0, index + 1),
-            sourceType: EntrySourceType
+            read: true,
-            req: MarkRequest
+        })
-        },
+    )
-        thunkApi
+})
-    ) => {
+
-        const endpoint = arg.sourceType === "category" ? client.category.markEntries : client.feed.markEntries
+export const markAllEntries = createAppAsyncThunk(
-        await endpoint(arg.req)
+    "entries/entry/markAll",
-        thunkApi.dispatch(reloadEntries())
+    async (
-        thunkApi.dispatch(reloadTree())
+        arg: {
-    }
+            sourceType: EntrySourceType
-)
+            req: MarkRequest
-export const starEntry = createAppAsyncThunk("entries/entry/star", (arg: { entry: Entry; starred: boolean }) => {
+        },
-    client.entry.star({
+        thunkApi
-        id: arg.entry.id,
+    ) => {
-        feedId: +arg.entry.feedId,
+        const endpoint = arg.sourceType === "category" ? client.category.markEntries : client.feed.markEntries
-        starred: arg.starred,
+        await endpoint(arg.req)
-    })
+        thunkApi.dispatch(reloadEntries())
-})
+        thunkApi.dispatch(reloadTree())
-export const selectEntry = createAppAsyncThunk(
+    }
-    "entries/entry/select",
+)
-    (
+
-        arg: {
+export const markAllAsReadWithConfirmationIfRequired = createAppAsyncThunk(
-            entry: Entry
+    "entries/entry/markAllAsReadWithConfirmationIfRequired",
-            expand: boolean
+    async (_, thunkApi) => {
-            markAsRead: boolean
+        const state = thunkApi.getState()
-            scrollToEntry: boolean
+        const source = state.entries.source
-        },
+        const entriesTimestamp = state.entries.timestamp ?? Date.now()
-        thunkApi
+        const markAllAsReadConfirmation = state.user.settings?.markAllAsReadConfirmation
-    ) => {
+
-        const state = thunkApi.getState()
+        if (markAllAsReadConfirmation) {
-        const entry = state.entries.entries.find(e => e.id === arg.entry.id)
+            thunkApi.dispatch(setMarkAllAsReadConfirmationDialogOpen(true))
-        if (!entry) return
+        } else {
-
+            thunkApi.dispatch(
-        // flushSync is required because we need the newly selected entry to be expanded
+                markAllEntries({
-        // and the previously selected entry to be collapsed to be able to scroll to the right position
+                    sourceType: source.type,
-        flushSync(() => {
+                    req: {
-            // mark as read if requested
+                        id: source.id,
-            if (arg.markAsRead) {
+                        read: true,
-                thunkApi.dispatch(markEntry({ entry, read: true }))
+                        olderThan: Date.now(),
-            }
+                        insertedBefore: entriesTimestamp,
-
+                    },
-            // set entry as selected
+                })
-            thunkApi.dispatch(entriesSlice.actions.setSelectedEntry(entry))
+            )
-
+        }
-            // expand if requested
+    }
-            const previouslySelectedEntry = state.entries.entries.find(e => e.id === state.entries.selectedEntryId)
+)
-            if (previouslySelectedEntry) {
+
-                thunkApi.dispatch(
+export const starEntry = createAppAsyncThunk(
-                    entriesSlice.actions.setEntryExpanded({
+    "entries/entry/star",
-                        entry: previouslySelectedEntry,
+    (arg: { entry: Entry; starred: boolean }) => {
-                        expanded: false,
+        client.entry.star({
-                    })
+            id: arg.entry.id,
-                )
+            feedId: +arg.entry.feedId,
-            }
+            starred: arg.starred,
-            thunkApi.dispatch(entriesSlice.actions.setEntryExpanded({ entry, expanded: arg.expand }))
+        })
-        })
+    },
-
+    {
-        if (arg.scrollToEntry) {
+        condition: arg => arg.entry.markable && arg.entry.starred !== arg.starred,
-            const entryElement = document.getElementById(Constants.dom.entryId(entry))
+    }
-            if (entryElement) {
+)
-                const scrollMode = state.user.settings?.scrollMode
+
-                const entryEntirelyVisible = Constants.layout.isTopVisible(entryElement) && Constants.layout.isBottomVisible(entryElement)
+export const selectEntry = createAppAsyncThunk(
-                if (scrollMode === "always" || (scrollMode === "if_needed" && !entryEntirelyVisible)) {
+    "entries/entry/select",
-                    const scrollSpeed = state.user.settings?.scrollSpeed
+    (
-                    thunkApi.dispatch(entriesSlice.actions.setScrollingToEntry(true))
+        arg: {
-                    scrollToEntry(entryElement, scrollSpeed, () => thunkApi.dispatch(entriesSlice.actions.setScrollingToEntry(false)))
+            entry: Entry
-                }
+            expand: boolean
-            }
+            markAsRead: boolean
-        }
+            scrollToEntry: boolean
-    }
+        },
-)
+        thunkApi
-const scrollToEntry = (entryElement: HTMLElement, scrollSpeed: number | undefined, onScrollEnded: () => void) => {
+    ) => {
-    const header = document.getElementById(Constants.dom.headerId)?.getBoundingClientRect()
+        const state = thunkApi.getState()
-    const offset = (header?.bottom ?? 0) + 3
+        const entry = state.entries.entries.find(e => e.id === arg.entry.id)
-    scrollToWithCallback({
+        if (!entry) return
-        options: {
+
-            top: entryElement.offsetTop - offset,
+        // flushSync is required because we need the newly selected entry to be expanded
-            behavior: scrollSpeed && scrollSpeed > 0 ? "smooth" : "auto",
+        // and the previously selected entry to be collapsed to be able to scroll to the right position
-        },
+        flushSync(() => {
-        onScrollEnded,
+            // mark as read if requested
-    })
+            if (arg.markAsRead) {
-}
+                thunkApi.dispatch(markEntry({ entry, read: true }))
-
+            }
-export const selectPreviousEntry = createAppAsyncThunk(
+
-    "entries/entry/selectPrevious",
+            // set entry as selected
-    (
+            thunkApi.dispatch(entriesSlice.actions.setSelectedEntry(entry))
-        arg: {
+
-            expand: boolean
+            // expand if requested
-            markAsRead: boolean
+            const previouslySelectedEntry = state.entries.entries.find(e => e.id === state.entries.selectedEntryId)
-            scrollToEntry: boolean
+            if (previouslySelectedEntry) {
-        },
+                thunkApi.dispatch(
-        thunkApi
+                    entriesSlice.actions.setEntryExpanded({
-    ) => {
+                        entry: previouslySelectedEntry,
-        const state = thunkApi.getState()
+                        expanded: false,
-        const { entries } = state.entries
+                    })
-        const previousIndex = entries.findIndex(e => e.id === state.entries.selectedEntryId) - 1
+                )
-        if (previousIndex >= 0) {
+            }
-            thunkApi.dispatch(
+            thunkApi.dispatch(entriesSlice.actions.setEntryExpanded({ entry, expanded: arg.expand }))
-                selectEntry({
+        })
-                    entry: entries[previousIndex],
+
-                    expand: arg.expand,
+        if (arg.scrollToEntry) {
-                    markAsRead: arg.markAsRead,
+            const viewMode = state.user.localSettings.viewMode
-                    scrollToEntry: arg.scrollToEntry,
+
-                })
+            const entryIndex = state.entries.entries.indexOf(entry)
-            )
+            const entriesToKeepOnTopWhenScrolling =
-        }
+                viewMode === "expanded" ? 0 : Math.min(state.user.settings?.entriesToKeepOnTopWhenScrolling ?? 0, entryIndex)
-    }
+            const entryToScrollTo = state.entries.entries[entryIndex - entriesToKeepOnTopWhenScrolling]
-)
+
-export const selectNextEntry = createAppAsyncThunk(
+            const entryElement = document.getElementById(Constants.dom.entryId(entry))
-    "entries/entry/selectNext",
+            const entryElementToScrollTo = document.getElementById(Constants.dom.entryId(entryToScrollTo))
-    (
+            if (entryElement && entryElementToScrollTo) {
-        arg: {
+                const scrollMode = state.user.settings?.scrollMode
-            expand: boolean
+                const entryEntirelyVisible =
-            markAsRead: boolean
+                    Constants.layout.isTopVisible(entryElementToScrollTo) && Constants.layout.isBottomVisible(entryElement)
-            scrollToEntry: boolean
+                if (scrollMode === "always" || (scrollMode === "if_needed" && !entryEntirelyVisible)) {
-        },
+                    const scrollSpeed = state.user.settings?.scrollSpeed
-        thunkApi
+                    const margin = viewMode === "detailed" ? 8 : 3
-    ) => {
+                    thunkApi.dispatch(entriesSlice.actions.setScrollingToEntry(true))
-        const state = thunkApi.getState()
+                    scrollToEntry(entryElementToScrollTo, margin, scrollSpeed, () =>
-        const { entries } = state.entries
+                        thunkApi.dispatch(entriesSlice.actions.setScrollingToEntry(false))
-        const nextIndex = entries.findIndex(e => e.id === state.entries.selectedEntryId) + 1
+                    )
-        if (nextIndex < entries.length) {
+                }
-            thunkApi.dispatch(
+            }
-                selectEntry({
+        }
-                    entry: entries[nextIndex],
+    }
-                    expand: arg.expand,
+)
-                    markAsRead: arg.markAsRead,
+
-                    scrollToEntry: arg.scrollToEntry,
+const scrollToEntry = (entryElement: HTMLElement, margin: number, scrollSpeed: number | undefined, onScrollEnded: () => void) => {
-                })
+    const header = document.getElementById(Constants.dom.headerId)?.getBoundingClientRect()
-            )
+    const offset = (header?.bottom ?? 0) + margin
-        }
+    scrollToWithCallback({
-    }
+        options: {
-)
+            top: entryElement.offsetTop - offset,
-export const tagEntry = createAppAsyncThunk("entries/entry/tag", async (arg: TagRequest, thunkApi) => {
+            behavior: scrollSpeed && scrollSpeed > 0 ? "smooth" : "auto",
-    await client.entry.tag(arg)
+        },
-    thunkApi.dispatch(reloadTags())
+        onScrollEnded,
-})
+    })
+}
+
+export const selectPreviousEntry = createAppAsyncThunk(
+    "entries/entry/selectPrevious",
+    (
+        arg: {
+            expand: boolean
+            markAsRead: boolean
+            scrollToEntry: boolean
+        },
+        thunkApi
+    ) => {
+        const state = thunkApi.getState()
+        const { entries } = state.entries
+        const previousIndex = entries.findIndex(e => e.id === state.entries.selectedEntryId) - 1
+        if (previousIndex >= 0) {
+            thunkApi.dispatch(
+                selectEntry({
+                    entry: entries[previousIndex],
+                    expand: arg.expand,
+                    markAsRead: arg.markAsRead,
+                    scrollToEntry: arg.scrollToEntry,
+                })
+            )
+        }
+    }
+)
+
+export const selectNextEntry = createAppAsyncThunk(
+    "entries/entry/selectNext",
+    async (
+        arg: {
+            expand: boolean
+            markAsRead: boolean
+            scrollToEntry: boolean
+        },
+        thunkApi
+    ) => {
+        const state = thunkApi.getState()
+        const { entries, hasMore, loading } = state.entries
+        const nextIndex = entries.findIndex(e => e.id === state.entries.selectedEntryId) + 1
+
+        // load more entries if needed
+        // this can happen if the last entry is too large to fit on the screen and the infinite loader doesn't trigger
+        if (nextIndex >= entries.length && hasMore && !loading) {
+            await thunkApi.dispatch(loadMoreEntries())
+        }
+
+        const entriesAfterLoading = thunkApi.getState().entries.entries
+        if (nextIndex < entriesAfterLoading.length) {
+            thunkApi.dispatch(
+                selectEntry({
+                    entry: entriesAfterLoading[nextIndex],
+                    expand: arg.expand,
+                    markAsRead: arg.markAsRead,
+                    scrollToEntry: arg.scrollToEntry,
+                })
+            )
+        }
+    }
+)
+
+export const tagEntry = createAppAsyncThunk("entries/entry/tag", async (arg: TagRequest, thunkApi) => {
+    await client.entry.tag(arg)
+    thunkApi.dispatch(reloadTags())
+})

commafeed-client/src/app/redirect/redirect.test.ts

@@ -1,10 +1,10 @@
-import { redirectToCategory } from "app/redirect/thunks"
+import { redirectToCategory } from "app/redirect/thunks"
-import { store } from "app/store"
+import { store } from "app/store"
-import { describe, expect, it } from "vitest"
+import { describe, expect, it } from "vitest"
-
+
-describe("redirects", () => {
+describe("redirects", () => {
-    it("redirects to category", async () => {
+    it("redirects to category", async () => {
-        await store.dispatch(redirectToCategory("1"))
+        await store.dispatch(redirectToCategory("1"))
-        expect(store.getState().redirect.to).toBe("/app/category/1")
+        expect(store.getState().redirect.to).toBe("/app/category/1")
-    })
+    })
-})
+})

commafeed-client/src/app/redirect/slice.ts

@@ -1,19 +1,19 @@
-import { createSlice, type PayloadAction } from "@reduxjs/toolkit"
+import { type PayloadAction, createSlice } from "@reduxjs/toolkit"
-
+
-interface RedirectState {
+interface RedirectState {
-    to?: string
+    to?: string
-}
+}
-
+
-const initialState: RedirectState = {}
+const initialState: RedirectState = {}
-
+
-export const redirectSlice = createSlice({
+export const redirectSlice = createSlice({
-    name: "redirect",
+    name: "redirect",
-    initialState,
+    initialState,
-    reducers: {
+    reducers: {
-        redirectTo: (state, action: PayloadAction<string | undefined>) => {
+        redirectTo: (state, action: PayloadAction<string | undefined>) => {
-            state.to = action.payload
+            state.to = action.payload
-        },
+        },
-    },
+    },
-})
+})
-
+
-export const { redirectTo } = redirectSlice.actions
+export const { redirectTo } = redirectSlice.actions

commafeed-client/src/app/redirect/thunks.ts

@@ -1,45 +1,57 @@
-import { createAppAsyncThunk } from "app/async-thunk"
+import { createAppAsyncThunk } from "app/async-thunk"
-import { Constants } from "app/constants"
+import { Constants } from "app/constants"
-import { redirectTo } from "app/redirect/slice"
+import { redirectTo } from "app/redirect/slice"
-
+
-export const redirectToLogin = createAppAsyncThunk("redirect/login", (_, thunkApi) => thunkApi.dispatch(redirectTo("/login")))
+export const redirectToLogin = createAppAsyncThunk("redirect/login", (_, thunkApi) => thunkApi.dispatch(redirectTo("/login")))
-export const redirectToRegistration = createAppAsyncThunk("redirect/register", (_, thunkApi) => thunkApi.dispatch(redirectTo("/register")))
+
-export const redirectToPasswordRecovery = createAppAsyncThunk("redirect/passwordRecovery", (_, thunkApi) =>
+export const redirectToRegistration = createAppAsyncThunk("redirect/register", (_, thunkApi) => thunkApi.dispatch(redirectTo("/register")))
-    thunkApi.dispatch(redirectTo("/passwordRecovery"))
+
-)
+export const redirectToApiDocumentation = createAppAsyncThunk("redirect/api", (_, thunkApi) => thunkApi.dispatch(redirectTo("/api")))
-export const redirectToApiDocumentation = createAppAsyncThunk("redirect/api", (_, thunkApi) => thunkApi.dispatch(redirectTo("/api")))
+
-
+export const redirectToSelectedSource = createAppAsyncThunk("redirect/selectedSource", (_, thunkApi) => {
-export const redirectToSelectedSource = createAppAsyncThunk("redirect/selectedSource", (_, thunkApi) => {
+    const { source } = thunkApi.getState().entries
-    const { source } = thunkApi.getState().entries
+    thunkApi.dispatch(redirectTo(`/app/${source.type}/${source.id}`))
-    thunkApi.dispatch(redirectTo(`/app/${source.type}/${source.id}`))
+})
-})
+
-export const redirectToCategory = createAppAsyncThunk("redirect/category", (id: string, thunkApi) =>
+export const redirectToCategory = createAppAsyncThunk("redirect/category", (id: string, thunkApi) =>
-    thunkApi.dispatch(redirectTo(`/app/category/${id}`))
+    thunkApi.dispatch(redirectTo(`/app/category/${id}`))
-)
+)
-export const redirectToRootCategory = createAppAsyncThunk(
+
-    "redirect/category/root",
+export const redirectToRootCategory = createAppAsyncThunk(
-    async (_, thunkApi) => await thunkApi.dispatch(redirectToCategory(Constants.categories.all.id))
+    "redirect/category/root",
-)
+    async (_, thunkApi) => await thunkApi.dispatch(redirectToCategory(Constants.categories.all.id))
-export const redirectToCategoryDetails = createAppAsyncThunk("redirect/category/details", (id: string, thunkApi) =>
+)
-    thunkApi.dispatch(redirectTo(`/app/category/${id}/details`))
+
-)
+export const redirectToCategoryDetails = createAppAsyncThunk("redirect/category/details", (id: string, thunkApi) =>
-export const redirectToFeed = createAppAsyncThunk("redirect/feed", (id: string | number, thunkApi) =>
+    thunkApi.dispatch(redirectTo(`/app/category/${id}/details`))
-    thunkApi.dispatch(redirectTo(`/app/feed/${id}`))
+)
-)
+
-export const redirectToFeedDetails = createAppAsyncThunk("redirect/feed/details", (id: string, thunkApi) =>
+export const redirectToFeed = createAppAsyncThunk("redirect/feed", (id: string | number, thunkApi) =>
-    thunkApi.dispatch(redirectTo(`/app/feed/${id}/details`))
+    thunkApi.dispatch(redirectTo(`/app/feed/${id}`))
-)
+)
-export const redirectToTag = createAppAsyncThunk("redirect/tag", (id: string, thunkApi) => thunkApi.dispatch(redirectTo(`/app/tag/${id}`)))
+
-export const redirectToTagDetails = createAppAsyncThunk("redirect/tag/details", (id: string, thunkApi) =>
+export const redirectToFeedDetails = createAppAsyncThunk("redirect/feed/details", (id: string, thunkApi) =>
-    thunkApi.dispatch(redirectTo(`/app/tag/${id}/details`))
+    thunkApi.dispatch(redirectTo(`/app/feed/${id}/details`))
-)
+)
-export const redirectToAdd = createAppAsyncThunk("redirect/add", (_, thunkApi) => thunkApi.dispatch(redirectTo("/app/add")))
+
-export const redirectToSettings = createAppAsyncThunk("redirect/settings", (_, thunkApi) => thunkApi.dispatch(redirectTo("/app/settings")))
+export const redirectToTag = createAppAsyncThunk("redirect/tag", (id: string, thunkApi) => thunkApi.dispatch(redirectTo(`/app/tag/${id}`)))
-export const redirectToAdminUsers = createAppAsyncThunk("redirect/admin/users", (_, thunkApi) =>
+
-    thunkApi.dispatch(redirectTo("/app/admin/users"))
+export const redirectToTagDetails = createAppAsyncThunk("redirect/tag/details", (id: string, thunkApi) =>
-)
+    thunkApi.dispatch(redirectTo(`/app/tag/${id}/details`))
-export const redirectToMetrics = createAppAsyncThunk("redirect/admin/metrics", (_, thunkApi) =>
+)
-    thunkApi.dispatch(redirectTo("/app/admin/metrics"))
+
-)
+export const redirectToAdd = createAppAsyncThunk("redirect/add", (_, thunkApi) => thunkApi.dispatch(redirectTo("/app/add")))
-export const redirectToDonate = createAppAsyncThunk("redirect/donate", (_, thunkApi) => thunkApi.dispatch(redirectTo("/app/donate")))
+
-export const redirectToAbout = createAppAsyncThunk("redirect/about", (_, thunkApi) => thunkApi.dispatch(redirectTo("/app/about")))
+export const redirectToSettings = createAppAsyncThunk("redirect/settings", (_, thunkApi) => thunkApi.dispatch(redirectTo("/app/settings")))
+
+export const redirectToAdminUsers = createAppAsyncThunk("redirect/admin/users", (_, thunkApi) =>
+    thunkApi.dispatch(redirectTo("/app/admin/users"))
+)
+
+export const redirectToMetrics = createAppAsyncThunk("redirect/admin/metrics", (_, thunkApi) =>
+    thunkApi.dispatch(redirectTo("/app/admin/metrics"))
+)
+
+export const redirectToDonate = createAppAsyncThunk("redirect/donate", (_, thunkApi) => thunkApi.dispatch(redirectTo("/app/donate")))
+
+export const redirectToAbout = createAppAsyncThunk("redirect/about", (_, thunkApi) => thunkApi.dispatch(redirectTo("/app/about")))

commafeed-client/src/app/server/slice.ts

@@ -1,29 +1,29 @@
-import { createSlice, type PayloadAction } from "@reduxjs/toolkit"
+import { type PayloadAction, createSlice } from "@reduxjs/toolkit"
-import { reloadServerInfos } from "app/server/thunks"
+import { reloadServerInfos } from "app/server/thunks"
-import { type ServerInfo } from "app/types"
+import type { ServerInfo } from "app/types"
-
+
-interface ServerState {
+interface ServerState {
-    serverInfos?: ServerInfo
+    serverInfos?: ServerInfo
-    webSocketConnected: boolean
+    webSocketConnected: boolean
-}
+}
-
+
-const initialState: ServerState = {
+const initialState: ServerState = {
-    webSocketConnected: false,
+    webSocketConnected: false,
-}
+}
-
+
-export const serverSlice = createSlice({
+export const serverSlice = createSlice({
-    name: "server",
+    name: "server",
-    initialState,
+    initialState,
-    reducers: {
+    reducers: {
-        setWebSocketConnected: (state, action: PayloadAction<boolean>) => {
+        setWebSocketConnected: (state, action: PayloadAction<boolean>) => {
-            state.webSocketConnected = action.payload
+            state.webSocketConnected = action.payload
-        },
+        },
-    },
+    },
-    extraReducers: builder => {
+    extraReducers: builder => {
-        builder.addCase(reloadServerInfos.fulfilled, (state, action) => {
+        builder.addCase(reloadServerInfos.fulfilled, (state, action) => {
-            state.serverInfos = action.payload
+            state.serverInfos = action.payload
-        })
+        })
-    },
+    },
-})
+})
-
+
-export const { setWebSocketConnected } = serverSlice.actions
+export const { setWebSocketConnected } = serverSlice.actions

commafeed-client/src/app/server/thunks.ts

@@ -1,4 +1,4 @@
-import { createAppAsyncThunk } from "app/async-thunk"
+import { createAppAsyncThunk } from "app/async-thunk"
-import { client } from "app/client"
+import { client } from "app/client"
-
+
-export const reloadServerInfos = createAppAsyncThunk("server/infos", async () => await client.server.getServerInfos().then(r => r.data))
+export const reloadServerInfos = createAppAsyncThunk("server/infos", async () => await client.server.getServerInfos().then(r => r.data))

commafeed-client/src/app/store.ts

@@ -1,23 +1,43 @@
-import { configureStore } from "@reduxjs/toolkit"
+import { configureStore } from "@reduxjs/toolkit"
-import { entriesSlice } from "app/entries/slice"
+import { entriesSlice } from "app/entries/slice"
-import { redirectSlice } from "app/redirect/slice"
+import { redirectSlice } from "app/redirect/slice"
-import { serverSlice } from "app/server/slice"
+import { serverSlice } from "app/server/slice"
-import { treeSlice } from "app/tree/slice"
+import { treeSlice } from "app/tree/slice"
-import { userSlice } from "app/user/slice"
+import type { LocalSettings } from "app/types"
-import { type TypedUseSelectorHook, useDispatch, useSelector } from "react-redux"
+import { initialLocalSettings, userSlice } from "app/user/slice"
-
+import { type TypedUseSelectorHook, useDispatch, useSelector } from "react-redux"
-export const reducers = {
+
-    entries: entriesSlice.reducer,
+export const reducers = {
-    redirect: redirectSlice.reducer,
+    entries: entriesSlice.reducer,
-    tree: treeSlice.reducer,
+    redirect: redirectSlice.reducer,
-    server: serverSlice.reducer,
+    tree: treeSlice.reducer,
-    user: userSlice.reducer,
+    server: serverSlice.reducer,
-}
+    user: userSlice.reducer,
-
+}
-export const store = configureStore({ reducer: reducers })
+
-
+const loadLocalSettings = (): LocalSettings => {
-export type RootState = ReturnType<typeof store.getState>
+    const json = localStorage.getItem("commafeed-local-settings")
-export type AppDispatch = typeof store.dispatch
+    return {
-
+        ...initialLocalSettings,
-export const useAppDispatch: () => AppDispatch = useDispatch
+        ...(json ? JSON.parse(json) : {}),
-export const useAppSelector: TypedUseSelectorHook<RootState> = useSelector
+    }
+}
+
+export const store = configureStore({
+    reducer: reducers,
+    preloadedState: {
+        user: {
+            localSettings: loadLocalSettings(),
+        },
+    },
+})
+store.subscribe(() => {
+    const localSettings = store.getState().user.localSettings
+    localStorage.setItem("commafeed-local-settings", JSON.stringify(localSettings))
+})
+
+export type RootState = ReturnType<typeof store.getState>
+export type AppDispatch = typeof store.dispatch
+
+export const useAppDispatch: () => AppDispatch = useDispatch
+export const useAppSelector: TypedUseSelectorHook<RootState> = useSelector

commafeed-client/src/app/tree/slice.ts

@@ -1,72 +1,112 @@
-import { createSlice, type PayloadAction } from "@reduxjs/toolkit"
+import { type PayloadAction, createSlice } from "@reduxjs/toolkit"
-import { markEntry } from "app/entries/thunks"
+import { loadEntries, markEntry } from "app/entries/thunks"
-import { redirectTo } from "app/redirect/slice"
+import { redirectTo } from "app/redirect/slice"
-import { collapseTreeCategory, reloadTree } from "app/tree/thunks"
+import { collapseTreeCategory, reloadTree } from "app/tree/thunks"
-import { type Category } from "app/types"
+import type { Category, Subscription } from "app/types"
-import { visitCategoryTree } from "app/utils"
+import { flattenCategoryTree, visitCategoryTree } from "app/utils"
-
+
-interface TreeState {
+export interface TreeSubscription extends Subscription {
-    rootCategory?: Category
+    // client-side only flag
-    mobileMenuOpen: boolean
+    hasNewEntries?: boolean
-    sidebarVisible: boolean
+}
-}
+
-
+export interface TreeCategory extends Category {
-const initialState: TreeState = {
+    feeds: TreeSubscription[]
-    mobileMenuOpen: false,
+    children: TreeCategory[]
-    sidebarVisible: true,
+}
-}
+
-
+interface TreeState {
-export const treeSlice = createSlice({
+    rootCategory?: TreeCategory
-    name: "tree",
+    mobileMenuOpen: boolean
-    initialState,
+    sidebarVisible: boolean
-    reducers: {
+}
-        setMobileMenuOpen: (state, action: PayloadAction<boolean>) => {
+
-            state.mobileMenuOpen = action.payload
+const initialState: TreeState = {
-        },
+    mobileMenuOpen: false,
-        toggleSidebar: state => {
+    sidebarVisible: true,
-            state.sidebarVisible = !state.sidebarVisible
+}
-        },
+
-        incrementUnreadCount: (
+export const treeSlice = createSlice({
-            state,
+    name: "tree",
-            action: PayloadAction<{
+    initialState,
-                feedId: number
+    reducers: {
-                amount: number
+        setMobileMenuOpen: (state, action: PayloadAction<boolean>) => {
-            }>
+            state.mobileMenuOpen = action.payload
-        ) => {
+        },
-            if (!state.rootCategory) return
+        toggleSidebar: state => {
-            visitCategoryTree(state.rootCategory, c =>
+            state.sidebarVisible = !state.sidebarVisible
-                c.feeds
+        },
-                    .filter(f => f.id === action.payload.feedId)
+        incrementUnreadCount: (
-                    .forEach(f => {
+            state,
-                        f.unread += action.payload.amount
+            action: PayloadAction<{
-                    })
+                feedId: number
-            )
+                amount: number
-        },
+            }>
-    },
+        ) => {
-    extraReducers: builder => {
+            if (!state.rootCategory) return
-        builder.addCase(reloadTree.fulfilled, (state, action) => {
+            visitCategoryTree(state.rootCategory, c => {
-            state.rootCategory = action.payload
+                for (const f of c.feeds.filter(f => f.id === action.payload.feedId)) {
-        })
+                    f.unread += action.payload.amount
-        builder.addCase(collapseTreeCategory.pending, (state, action) => {
+                    f.hasNewEntries = true
-            if (!state.rootCategory) return
+                }
-            visitCategoryTree(state.rootCategory, c => {
+            })
-                if (+c.id === action.meta.arg.id) c.expanded = !action.meta.arg.collapse
+        },
-            })
+    },
-        })
+    extraReducers: builder => {
-        builder.addCase(markEntry.pending, (state, action) => {
+        builder.addCase(reloadTree.fulfilled, (state, action) => {
-            if (!state.rootCategory) return
+            // set hasNewEntries to true if new unread > previous unread
-            visitCategoryTree(state.rootCategory, c =>
+            if (state.rootCategory) {
-                c.feeds
+                const oldFeeds = flattenCategoryTree(state.rootCategory).flatMap(c => c.feeds)
-                    .filter(f => f.id === +action.meta.arg.entry.feedId)
+                const oldFeedsById = new Map(oldFeeds.map(f => [f.id, f]))
-                    .forEach(f => {
+
-                        f.unread = action.meta.arg.read ? f.unread - 1 : f.unread + 1
+                const newFeeds = flattenCategoryTree(action.payload).flatMap(c => c.feeds)
-                    })
+                for (const newFeed of newFeeds) {
-            )
+                    const oldFeed = oldFeedsById.get(newFeed.id)
-        })
+                    if (oldFeed && newFeed.unread > oldFeed.unread) {
-        builder.addCase(redirectTo, state => {
+                        newFeed.hasNewEntries = true
-            state.mobileMenuOpen = false
+                    }
-        })
+                }
-    },
+            }
-})
+
-
+            state.rootCategory = action.payload
-export const { setMobileMenuOpen, toggleSidebar, incrementUnreadCount } = treeSlice.actions
+        })
+        builder.addCase(collapseTreeCategory.pending, (state, action) => {
+            if (!state.rootCategory) return
+            visitCategoryTree(state.rootCategory, c => {
+                if (+c.id === action.meta.arg.id) c.expanded = !action.meta.arg.collapse
+            })
+        })
+        builder.addCase(markEntry.pending, (state, action) => {
+            if (!state.rootCategory) return
+            visitCategoryTree(state.rootCategory, c => {
+                for (const f of c.feeds.filter(f => f.id === +action.meta.arg.entry.feedId)) {
+                    f.unread = action.meta.arg.read ? f.unread - 1 : f.unread + 1
+                }
+            })
+        })
+        builder.addCase(loadEntries.fulfilled, (state, action) => {
+            if (!state.rootCategory) return
+
+            const { source } = action.meta.arg
+            if (source.type === "category") {
+                visitCategoryTree(state.rootCategory, c => {
+                    if (c.id === source.id) {
+                        for (const f of flattenCategoryTree(c).flatMap(c => c.feeds)) {
+                            f.hasNewEntries = false
+                        }
+                    }
+                })
+            } else if (source.type === "feed") {
+                const feeds = flattenCategoryTree(state.rootCategory).flatMap(c => c.feeds)
+                for (const f of feeds.filter(f => f.id === +source.id)) {
+                    f.hasNewEntries = false
+                }
+            }
+        })
+        builder.addCase(redirectTo, state => {
+            state.mobileMenuOpen = false
+        })
+    },
+})
+
+export const { setMobileMenuOpen, toggleSidebar, incrementUnreadCount } = treeSlice.actions

commafeed-client/src/app/tree/thunks.ts

@@ -1,9 +1,80 @@
-import { createAppAsyncThunk } from "app/async-thunk"
+import { createAppAsyncThunk } from "app/async-thunk"
-import { client } from "app/client"
+import { client } from "app/client"
-import type { CollapseRequest } from "app/types"
+import { redirectToCategory, redirectToFeed } from "app/redirect/thunks"
-
+import { incrementUnreadCount } from "app/tree/slice"
-export const reloadTree = createAppAsyncThunk("tree/reload", async () => await client.category.getRoot().then(r => r.data))
+import type { CollapseRequest, Subscription } from "app/types"
-export const collapseTreeCategory = createAppAsyncThunk(
+import { flattenCategoryTree, visitCategoryTree } from "app/utils"
-    "tree/category/collapse",
+
-    async (req: CollapseRequest) => await client.category.collapse(req)
+export const reloadTree = createAppAsyncThunk("tree/reload", async () => await client.category.getRoot().then(r => r.data))
-)
+
+export const collapseTreeCategory = createAppAsyncThunk(
+    "tree/category/collapse",
+    async (req: CollapseRequest) => await client.category.collapse(req).then(r => r.data)
+)
+
+export const selectNextUnreadTreeItem = createAppAsyncThunk(
+    "tree/selectNextUnreadItem",
+    (
+        arg: {
+            direction: "forward" | "backward"
+        },
+        thunkApi
+    ) => {
+        const state = thunkApi.getState()
+        const root = state.tree.rootCategory
+        if (!root) return
+
+        const { source } = state.entries
+        if (source.type === "category") {
+            const categories = flattenCategoryTree(root)
+            if (arg.direction === "backward") categories.reverse()
+
+            const index = categories.findIndex(c => c.id === source.id)
+            if (index === -1) return
+
+            for (let i = index + 1; i < categories.length; i++) {
+                const c = categories[i]
+                if (c.feeds.some(f => f.unread > 0)) {
+                    return thunkApi.dispatch(redirectToCategory(String(c.id)))
+                }
+            }
+        } else if (source.type === "feed") {
+            const feeds: Subscription[] = []
+            visitCategoryTree(root, c => feeds.push(...c.feeds), { childrenFirst: true })
+            if (arg.direction === "backward") feeds.reverse()
+
+            const index = feeds.findIndex(f => f.id === +source.id)
+            if (index === -1) return
+
+            for (let i = index + 1; i < feeds.length; i++) {
+                const f = feeds[i]
+                if (f.unread > 0) {
+                    return thunkApi.dispatch(redirectToFeed(String(f.id)))
+                }
+            }
+        }
+    }
+)
+
+export const newFeedEntriesDiscovered = createAppAsyncThunk(
+    "tree/new-feed-entries-discovered",
+    async ({ feedId, amount }: { feedId: number; amount: number }, thunkApi) => {
+        const root = thunkApi.getState().tree.rootCategory
+        if (!root) return
+
+        const feed = flattenCategoryTree(root)
+            .flatMap(c => c.feeds)
+            .some(f => f.id === feedId)
+        if (!feed) {
+            // feed not found in the tree, reload the tree completely
+            thunkApi.dispatch(reloadTree())
+        } else {
+            thunkApi.dispatch(
+                incrementUnreadCount({
+                    feedId,
+                    amount,
+                })
+            )
+        }
+    }
+)

commafeed-client/src/app/tree/tree.test.ts

@@ -0,0 +1,172 @@
+import { configureStore } from "@reduxjs/toolkit"
+import { client } from "app/client"
+import { loadEntries } from "app/entries/thunks"
+import { type RootState, reducers } from "app/store"
+import { newFeedEntriesDiscovered, selectNextUnreadTreeItem } from "app/tree/thunks"
+import type { Category, Entries, Entry, Subscription } from "app/types"
+import type { AxiosResponse } from "axios"
+import { beforeEach, describe, expect, it, vi } from "vitest"
+
+vi.mock(import("app/client"))
+
+const createCategory = (id: string): Category => ({
+    id,
+    name: id,
+    children: [],
+    feeds: [],
+    expanded: true,
+    position: 0,
+})
+
+const createFeed = (id: number, unread: number): Subscription => ({
+    id,
+    name: String(id),
+    unread,
+    errorCount: 0,
+    position: 0,
+    feedUrl: "",
+    feedLink: "",
+    iconUrl: "",
+})
+
+const root = createCategory("root")
+
+const catA = createCategory("catA")
+catA.feeds.push(createFeed(1, 0), createFeed(2, 0), createFeed(3, 1))
+
+const catB = createCategory("catB")
+
+const catC = createCategory("catC")
+catC.feeds.push(createFeed(4, 1))
+
+root.children.push(catA, catB, catC)
+
+describe("selectNextUnreadTreeItem", () => {
+    it("selects the next unread category", async () => {
+        const store = configureStore({
+            reducer: reducers,
+            preloadedState: {
+                tree: {
+                    rootCategory: root,
+                },
+                entries: {
+                    source: {
+                        type: "category",
+                        id: "catA",
+                    },
+                },
+            } as RootState,
+        })
+
+        await store.dispatch(selectNextUnreadTreeItem({ direction: "forward" }))
+        expect(store.getState().redirect.to).toBe("/app/category/catC")
+    })
+
+    it("selects the previous unread category", async () => {
+        const store = configureStore({
+            reducer: reducers,
+            preloadedState: {
+                tree: {
+                    rootCategory: root,
+                },
+                entries: {
+                    source: {
+                        type: "category",
+                        id: "catC",
+                    },
+                },
+            } as RootState,
+        })
+
+        await store.dispatch(selectNextUnreadTreeItem({ direction: "backward" }))
+        expect(store.getState().redirect.to).toBe("/app/category/catA")
+    })
+
+    it("selects the next unread feed", async () => {
+        const store = configureStore({
+            reducer: reducers,
+            preloadedState: {
+                tree: {
+                    rootCategory: root,
+                },
+                entries: {
+                    source: {
+                        type: "feed",
+                        id: "1",
+                    },
+                },
+            } as RootState,
+        })
+
+        await store.dispatch(selectNextUnreadTreeItem({ direction: "forward" }))
+        expect(store.getState().redirect.to).toBe("/app/feed/3")
+    })
+
+    it("selects the previous unread feed", async () => {
+        const store = configureStore({
+            reducer: reducers,
+            preloadedState: {
+                tree: {
+                    rootCategory: root,
+                },
+                entries: {
+                    source: {
+                        type: "feed",
+                        id: "4",
+                    },
+                },
+            } as RootState,
+        })
+
+        await store.dispatch(selectNextUnreadTreeItem({ direction: "backward" }))
+        expect(store.getState().redirect.to).toBe("/app/feed/3")
+    })
+})
+
+describe("hasNewEntries", () => {
+    beforeEach(() => {
+        vi.resetAllMocks()
+    })
+
+    it("sets and clear flag for a feed", async () => {
+        vi.mocked(client.feed.getEntries).mockResolvedValue({
+            data: {
+                entries: [{ id: "3" } as Entry],
+                hasMore: false,
+                name: "my-feed",
+                errorCount: 3,
+                feedLink: "https://mysite.com/feed",
+                timestamp: 123,
+                ignoredReadStatus: false,
+            },
+        } as AxiosResponse<Entries>)
+
+        const store = configureStore({
+            reducer: reducers,
+            preloadedState: {
+                tree: {
+                    rootCategory: root,
+                },
+                entries: {
+                    source: {
+                        type: "feed",
+                        id: "1",
+                    },
+                },
+            } as RootState,
+        })
+
+        // initial state
+        expect(store.getState().tree.rootCategory?.children[0].feeds[0].unread).toBe(0)
+        expect(store.getState().tree.rootCategory?.children[0].feeds[0].hasNewEntries).toBeFalsy()
+
+        // increments unread count and sets hasNewEntries to true
+        await store.dispatch(newFeedEntriesDiscovered({ feedId: 1, amount: 3 }))
+        expect(store.getState().tree.rootCategory?.children[0].feeds[0].unread).toBe(3)
+        expect(store.getState().tree.rootCategory?.children[0].feeds[0].hasNewEntries).toBe(true)
+
+        // reload entries and sets hasNewEntries to false
+        await store.dispatch(loadEntries({ source: { type: "feed", id: "1" }, clearSearch: true }))
+        expect(store.getState().tree.rootCategory?.children[0].feeds[0].hasNewEntries).toBe(false)
+    })
+})

commafeed-client/src/app/types.ts

@@ -1,292 +1,308 @@
-export type ReadingMode = "all" | "unread"
+export type ReadingMode = "all" | "unread"
-
+
-export type ReadingOrder = "asc" | "desc"
+export type ReadingOrder = "asc" | "desc"
-
+
-export type ViewMode = "title" | "cozy" | "detailed" | "expanded"
+export type ViewMode = "title" | "cozy" | "detailed" | "expanded"
-
+
-export type ScrollMode = "always" | "never" | "if_needed"
+export type ScrollMode = "always" | "never" | "if_needed"
-
+
-export interface AddCategoryRequest {
+export type IconDisplayMode = "always" | "never" | "on_desktop" | "on_mobile"
-    name: string
+
-    parentId?: string
+export interface AddCategoryRequest {
-}
+    name: string
-
+    parentId?: string
-export interface Subscription {
+}
-    id: number
+
-    name: string
+export interface Subscription {
-    message?: string
+    id: number
-    errorCount: number
+    name: string
-    lastRefresh?: number
+    message?: string
-    nextRefresh?: number
+    errorCount: number
-    feedUrl: string
+    lastRefresh?: number
-    feedLink: string
+    nextRefresh?: number
-    iconUrl: string
+    feedUrl: string
-    unread: number
+    feedLink: string
-    categoryId?: string
+    iconUrl: string
-    position: number
+    unread: number
-    newestItemTime?: number
+    categoryId?: string
-    filter?: string
+    position: number
-}
+    newestItemTime?: number
-
+    filter?: string
-export interface Category {
+}
-    id: string
+
-    parentId?: string
+export interface Category {
-    parentName?: string
+    id: string
-    name: string
+    parentId?: string
-    children: Category[]
+    parentName?: string
-    feeds: Subscription[]
+    name: string
-    expanded: boolean
+    children: Category[]
-    position: number
+    feeds: Subscription[]
-}
+    expanded: boolean
-
+    position: number
-export interface CategoryModificationRequest {
+}
-    id: number
+
-    name?: string
+export interface CategoryModificationRequest {
-    parentId?: string
+    id: number
-    position?: number
+    name?: string
-}
+    parentId?: string
-
+    position?: number
-export interface CollapseRequest {
+}
-    id: number
+
-    collapse: boolean
+export interface CollapseRequest {
-}
+    id: number
-
+    collapse: boolean
-export interface Entry {
+}
-    id: string
+
-    guid: string
+export interface Entry {
-    title: string
+    id: string
-    content: string
+    guid: string
-    categories?: string
+    title: string
-    rtl: boolean
+    content: string
-    author?: string
+    categories?: string
-    enclosureUrl?: string
+    rtl: boolean
-    enclosureType?: string
+    author?: string
-    mediaDescription?: string
+    enclosureUrl?: string
-    mediaThumbnailUrl?: string
+    enclosureType?: string
-    mediaThumbnailWidth?: number
+    mediaDescription?: string
-    mediaThumbnailHeight?: number
+    mediaThumbnailUrl?: string
-    date: number
+    mediaThumbnailWidth?: number
-    insertedDate: number
+    mediaThumbnailHeight?: number
-    feedId: string
+    date: number
-    feedName: string
+    insertedDate: number
-    feedUrl: string
+    feedId: string
-    feedLink: string
+    feedName: string
-    iconUrl: string
+    feedUrl: string
-    url: string
+    feedLink: string
-    read: boolean
+    iconUrl: string
-    starred: boolean
+    url: string
-    markable: boolean
+    read: boolean
-    tags: string[]
+    starred: boolean
-}
+    markable: boolean
-
+    tags: string[]
-export interface Entries {
+}
-    name: string
+
-    message?: string
+export interface Entries {
-    errorCount: number
+    name: string
-    feedLink: string
+    message?: string
-    timestamp: number
+    errorCount: number
-    hasMore: boolean
+    feedLink: string
-    offset?: number
+    timestamp: number
-    limit?: number
+    hasMore: boolean
-    entries: Entry[]
+    offset?: number
-    ignoredReadStatus: boolean
+    limit?: number
-}
+    entries: Entry[]
-
+    ignoredReadStatus: boolean
-export interface FeedInfo {
+}
-    url: string
+
-    title: string
+export interface FeedInfo {
-}
+    url: string
-
+    title: string
-export interface FeedInfoRequest {
+}
-    url: string
+
-}
+export interface FeedInfoRequest {
-
+    url: string
-export interface FeedModificationRequest {
+}
-    id: number
+
-    name?: string
+export interface FeedModificationRequest {
-    categoryId?: string
+    id: number
-    position?: number
+    name?: string
-    filter?: string
+    categoryId?: string
-}
+    position?: number
-
+    filter?: string
-export interface GetEntriesRequest {
+}
-    id: string
+
-    readType?: ReadingMode
+export interface GetEntriesRequest {
-    newerThan?: number
+    id: string
-    order?: ReadingOrder
+    readType?: ReadingMode
-    keywords?: string
+    newerThan?: number
-    onlyIds?: boolean
+    order?: ReadingOrder
-    excludedSubscriptionIds?: string
+    keywords?: string
-    tag?: string
+    excludedSubscriptionIds?: string
-}
+    tag?: string
-
+}
-export interface GetEntriesPaginatedRequest extends GetEntriesRequest {
+
-    offset: number
+export interface GetEntriesPaginatedRequest extends GetEntriesRequest {
-    limit: number
+    offset: number
-}
+    limit: number
-
+}
-export interface IDRequest {
+
-    id: number
+export interface IDRequest {
-}
+    id: number
-
+}
-export interface LoginRequest {
+
-    name: string
+export interface LoginRequest {
-    password: string
+    name: string
-}
+    password: string
-
+}
-export interface MarkRequest {
+
-    id: string
+export interface MarkRequest {
-    read: boolean
+    id: string
-    olderThan?: number
+    read: boolean
-    insertedBefore?: number
+    olderThan?: number
-    keywords?: string
+    insertedBefore?: number
-    excludedSubscriptions?: number[]
+    keywords?: string
-}
+    excludedSubscriptions?: number[]
-
+}
-export interface MetricCounter {
+
-    count: number
+export interface MetricCounter {
-}
+    count: number
-
+}
-export interface MetricGauge {
+
-    value: number
+export interface MetricGauge {
-}
+    value: number
-
+}
-export interface MetricMeter {
+
-    count: number
+export interface MetricMeter {
-    m15_rate: number
+    count: number
-    m1_rate: number
+    m15_rate: number
-    m5_rate: number
+    m1_rate: number
-    mean_rate: number
+    m5_rate: number
-    units: string
+    mean_rate: number
-}
+    units: string
-
+}
-export interface MetricTimer {
+
-    count: number
+export interface MetricTimer {
-    max: number
+    count: number
-    mean: number
+    max: number
-    min: number
+    mean: number
-    p50: number
+    min: number
-    p75: number
+    p50: number
-    p95: number
+    p75: number
-    p98: number
+    p95: number
-    p99: number
+    p98: number
-    p999: number
+    p99: number
-    stddev: number
+    p999: number
-    m15_rate: number
+    stddev: number
-    m1_rate: number
+    m15_rate: number
-    m5_rate: number
+    m1_rate: number
-    mean_rate: number
+    m5_rate: number
-    duration_units: string
+    mean_rate: number
-    rate_units: string
+    duration_units: string
-}
+    rate_units: string
-
+}
-export interface Metrics {
+
-    counters: Record<string, MetricCounter>
+export interface Metrics {
-    gauges: Record<string, MetricGauge>
+    counters: Record<string, MetricCounter>
-    meters: Record<string, MetricMeter>
+    gauges: Record<string, MetricGauge>
-    timers: Record<string, MetricTimer>
+    meters: Record<string, MetricMeter>
-}
+    timers: Record<string, MetricTimer>
-
+}
-export interface MultipleMarkRequest {
+
-    requests: MarkRequest[]
+export interface MultipleMarkRequest {
-}
+    requests: MarkRequest[]
-
+}
-export interface PasswordResetRequest {
+
-    email: string
+export interface PasswordResetRequest {
-}
+    email: string
-
+}
-export interface ProfileModificationRequest {
+
-    currentPassword: string
+export interface ProfileModificationRequest {
-    email: string
+    currentPassword: string
-    newPassword?: string
+    email: string
-    newApiKey?: boolean
+    newPassword?: string
-}
+    newApiKey?: boolean
-
+}
-export interface RegistrationRequest {
+
-    name: string
+export interface RegistrationRequest {
-    password: string
+    name: string
-    email: string
+    password: string
-}
+    email: string
-
+}
-export interface ServerInfo {
+
-    announcement?: string
+export interface ServerInfo {
-    version: string
+    announcement?: string
-    gitCommit: string
+    version: string
-    allowRegistrations: boolean
+    gitCommit: string
-    googleAnalyticsCode?: string
+    allowRegistrations: boolean
-    smtpEnabled: boolean
+    googleAnalyticsCode?: string
-    demoAccountEnabled: boolean
+    smtpEnabled: boolean
-    websocketEnabled: boolean
+    demoAccountEnabled: boolean
-    websocketPingInterval: number
+    websocketEnabled: boolean
-    treeReloadInterval: number
+    websocketPingInterval: number
-}
+    treeReloadInterval: number
-
+    forceRefreshCooldownDuration: number
-export interface SharingSettings {
+}
-    email: boolean
+
-    gmail: boolean
+export interface SharingSettings {
-    facebook: boolean
+    email: boolean
-    twitter: boolean
+    gmail: boolean
-    tumblr: boolean
+    facebook: boolean
-    pocket: boolean
+    twitter: boolean
-    instapaper: boolean
+    tumblr: boolean
-    buffer: boolean
+    pocket: boolean
-}
+    instapaper: boolean
-
+    buffer: boolean
-export interface Settings {
+}
-    language: string
+
-    readingMode: ReadingMode
+export interface Settings {
-    readingOrder: ReadingOrder
+    language: string
-    showRead: boolean
+    readingMode: ReadingMode
-    scrollMarks: boolean
+    readingOrder: ReadingOrder
-    customCss?: string
+    showRead: boolean
-    customJs?: string
+    scrollMarks: boolean
-    scrollSpeed: number
+    customCss?: string
-    scrollMode: ScrollMode
+    customJs?: string
-    markAllAsReadConfirmation: boolean
+    scrollSpeed: number
-    customContextMenu: boolean
+    scrollMode: ScrollMode
-    mobileFooter: boolean
+    entriesToKeepOnTopWhenScrolling: number
-    sharingSettings: SharingSettings
+    starIconDisplayMode: IconDisplayMode
-}
+    externalLinkIconDisplayMode: IconDisplayMode
-
+    markAllAsReadConfirmation: boolean
-export interface StarRequest {
+    customContextMenu: boolean
-    id: string
+    mobileFooter: boolean
-    feedId: number
+    unreadCountTitle: boolean
-    starred: boolean
+    unreadCountFavicon: boolean
-}
+    primaryColor?: string
-
+    sharingSettings: SharingSettings
-export interface SubscribeRequest {
+}
-    url: string
+
-    title: string
+export interface LocalSettings {
-    categoryId?: string
+    viewMode: ViewMode
-}
+    sidebarWidth: number
-
+    announcementHash: string
-export interface TagRequest {
+    fontSizePercentage: number
-    entryId: number
+}
-    tags: string[]
+
-}
+export interface StarRequest {
-
+    id: string
-export interface UserModel {
+    feedId: number
-    id: number
+    starred: boolean
-    name: string
+}
-    email?: string
+
-    apiKey?: string
+export interface SubscribeRequest {
-    password?: string
+    url: string
-    enabled: boolean
+    title: string
-    created: number
+    categoryId?: string
-    lastLogin?: number
+}
-    admin: boolean
+
-}
+export interface TagRequest {
-
+    entryId: number
-export interface AdminSaveUserRequest {
+    tags: string[]
-    id?: number
+}
-    name: string
+
-    email?: string
+export interface UserModel {
-    password?: string
+    id: number
-    enabled: boolean
+    name: string
-    admin: boolean
+    email?: string
-}
+    apiKey?: string
-
+    password?: string
-export interface AuthenticationError {
+    enabled: boolean
-    message: string
+    created: number
-    allowRegistrations: boolean
+    lastLogin?: number
-}
+    admin: boolean
+    lastForceRefresh?: number
+}
+
+export interface AdminSaveUserRequest {
+    id?: number
+    name: string
+    email?: string
+    password?: string
+    enabled: boolean
+    admin: boolean
+}
+
+export interface AuthenticationError {
+    message: string
+    allowRegistrations: boolean
+}

commafeed-client/src/app/user/slice.ts

@@ -1,108 +1,169 @@
-import { t } from "@lingui/macro"
+import { t } from "@lingui/core/macro"
-import { showNotification } from "@mantine/notifications"
+import { showNotification } from "@mantine/notifications"
-import { createSlice, isAnyOf } from "@reduxjs/toolkit"
+import { type PayloadAction, createSlice, isAnyOf } from "@reduxjs/toolkit"
-import { type Settings, type UserModel } from "app/types"
+import type { LocalSettings, Settings, UserModel, ViewMode } from "app/types"
-import {
+import {
-    changeCustomContextMenu,
+    changeCustomContextMenu,
-    changeLanguage,
+    changeEntriesToKeepOnTopWhenScrolling,
-    changeMarkAllAsReadConfirmation,
+    changeExternalLinkIconDisplayMode,
-    changeMobileFooter,
+    changeLanguage,
-    changeReadingMode,
+    changeMarkAllAsReadConfirmation,
-    changeReadingOrder,
+    changeMobileFooter,
-    changeScrollMarks,
+    changePrimaryColor,
-    changeScrollMode,
+    changeReadingMode,
-    changeScrollSpeed,
+    changeReadingOrder,
-    changeSharingSetting,
+    changeScrollMarks,
-    changeShowRead,
+    changeScrollMode,
-    reloadProfile,
+    changeScrollSpeed,
-    reloadSettings,
+    changeSharingSetting,
-    reloadTags,
+    changeShowRead,
-} from "./thunks"
+    changeStarIconDisplayMode,
-
+    changeUnreadCountFavicon,
-interface UserState {
+    changeUnreadCountTitle,
-    settings?: Settings
+    reloadProfile,
-    profile?: UserModel
+    reloadSettings,
-    tags?: string[]
+    reloadTags,
-}
+} from "./thunks"
-
+
-const initialState: UserState = {}
+interface UserState {
-
+    settings?: Settings
-export const userSlice = createSlice({
+    localSettings: LocalSettings
-    name: "user",
+    profile?: UserModel
-    initialState,
+    tags?: string[]
-    reducers: {},
+}
-    extraReducers: builder => {
+
-        builder.addCase(reloadSettings.fulfilled, (state, action) => {
+export const initialLocalSettings: LocalSettings = {
-            state.settings = action.payload
+    viewMode: "detailed",
-        })
+    sidebarWidth: 360,
-        builder.addCase(reloadProfile.fulfilled, (state, action) => {
+    announcementHash: "no-hash",
-            state.profile = action.payload
+    fontSizePercentage: 100,
-        })
+}
-        builder.addCase(reloadTags.fulfilled, (state, action) => {
+
-            state.tags = action.payload
+const initialState: UserState = {
-        })
+    localSettings: initialLocalSettings,
-        builder.addCase(changeReadingMode.pending, (state, action) => {
+}
-            if (!state.settings) return
+
-            state.settings.readingMode = action.meta.arg
+export const userSlice = createSlice({
-        })
+    name: "user",
-        builder.addCase(changeReadingOrder.pending, (state, action) => {
+    initialState,
-            if (!state.settings) return
+    reducers: {
-            state.settings.readingOrder = action.meta.arg
+        setViewMode: (state, action: PayloadAction<ViewMode>) => {
-        })
+            state.localSettings.viewMode = action.payload
-        builder.addCase(changeLanguage.pending, (state, action) => {
+        },
-            if (!state.settings) return
+        setFontSizePercentage: (state, action: PayloadAction<number>) => {
-            state.settings.language = action.meta.arg
+            state.localSettings.fontSizePercentage = action.payload
-        })
+        },
-        builder.addCase(changeScrollSpeed.pending, (state, action) => {
+        setSidebarWidth: (state, action: PayloadAction<number>) => {
-            if (!state.settings) return
+            state.localSettings.sidebarWidth = action.payload
-            state.settings.scrollSpeed = action.meta.arg ? 400 : 0
+        },
-        })
+        setAnnouncementHash: (state, action: PayloadAction<string>) => {
-        builder.addCase(changeShowRead.pending, (state, action) => {
+            state.localSettings.announcementHash = action.payload
-            if (!state.settings) return
+        },
-            state.settings.showRead = action.meta.arg
+    },
-        })
+    extraReducers: builder => {
-        builder.addCase(changeScrollMarks.pending, (state, action) => {
+        builder.addCase(reloadSettings.fulfilled, (state, action) => {
-            if (!state.settings) return
+            state.settings = action.payload
-            state.settings.scrollMarks = action.meta.arg
+        })
-        })
+        builder.addCase(reloadProfile.fulfilled, (state, action) => {
-        builder.addCase(changeScrollMode.pending, (state, action) => {
+            state.profile = action.payload
-            if (!state.settings) return
+        })
-            state.settings.scrollMode = action.meta.arg
+        builder.addCase(reloadTags.fulfilled, (state, action) => {
-        })
+            state.tags = action.payload
-        builder.addCase(changeMarkAllAsReadConfirmation.pending, (state, action) => {
+        })
-            if (!state.settings) return
+        builder.addCase(changeReadingMode.pending, (state, action) => {
-            state.settings.markAllAsReadConfirmation = action.meta.arg
+            if (!state.settings) return
-        })
+            state.settings.readingMode = action.meta.arg
-        builder.addCase(changeCustomContextMenu.pending, (state, action) => {
+        })
-            if (!state.settings) return
+        builder.addCase(changeReadingOrder.pending, (state, action) => {
-            state.settings.customContextMenu = action.meta.arg
+            if (!state.settings) return
-        })
+            state.settings.readingOrder = action.meta.arg
-        builder.addCase(changeMobileFooter.pending, (state, action) => {
+        })
-            if (!state.settings) return
+        builder.addCase(changeLanguage.pending, (state, action) => {
-            state.settings.mobileFooter = action.meta.arg
+            if (!state.settings) return
-        })
+            state.settings.language = action.meta.arg
-        builder.addCase(changeSharingSetting.pending, (state, action) => {
+        })
-            if (!state.settings) return
+        builder.addCase(changeScrollSpeed.pending, (state, action) => {
-            state.settings.sharingSettings[action.meta.arg.site] = action.meta.arg.value
+            if (!state.settings) return
-        })
+            state.settings.scrollSpeed = action.meta.arg ? 400 : 0
-        builder.addMatcher(
+        })
-            isAnyOf(
+        builder.addCase(changeShowRead.pending, (state, action) => {
-                changeLanguage.fulfilled,
+            if (!state.settings) return
-                changeScrollSpeed.fulfilled,
+            state.settings.showRead = action.meta.arg
-                changeShowRead.fulfilled,
+        })
-                changeScrollMarks.fulfilled,
+        builder.addCase(changeScrollMarks.pending, (state, action) => {
-                changeScrollMode.fulfilled,
+            if (!state.settings) return
-                changeMarkAllAsReadConfirmation.fulfilled,
+            state.settings.scrollMarks = action.meta.arg
-                changeCustomContextMenu.fulfilled,
+        })
-                changeMobileFooter.fulfilled,
+        builder.addCase(changeScrollMode.pending, (state, action) => {
-                changeSharingSetting.fulfilled
+            if (!state.settings) return
-            ),
+            state.settings.scrollMode = action.meta.arg
-            () => {
+        })
-                showNotification({
+        builder.addCase(changeEntriesToKeepOnTopWhenScrolling.pending, (state, action) => {
-                    message: t`Settings saved.`,
+            if (!state.settings) return
-                    color: "green",
+            state.settings.entriesToKeepOnTopWhenScrolling = action.meta.arg
-                })
+        })
-            }
+        builder.addCase(changeStarIconDisplayMode.pending, (state, action) => {
-        )
+            if (!state.settings) return
-    },
+            state.settings.starIconDisplayMode = action.meta.arg
-})
+        })
+        builder.addCase(changeExternalLinkIconDisplayMode.pending, (state, action) => {
+            if (!state.settings) return
+            state.settings.externalLinkIconDisplayMode = action.meta.arg
+        })
+        builder.addCase(changeMarkAllAsReadConfirmation.pending, (state, action) => {
+            if (!state.settings) return
+            state.settings.markAllAsReadConfirmation = action.meta.arg
+        })
+        builder.addCase(changeCustomContextMenu.pending, (state, action) => {
+            if (!state.settings) return
+            state.settings.customContextMenu = action.meta.arg
+        })
+        builder.addCase(changeMobileFooter.pending, (state, action) => {
+            if (!state.settings) return
+            state.settings.mobileFooter = action.meta.arg
+        })
+        builder.addCase(changeUnreadCountTitle.pending, (state, action) => {
+            if (!state.settings) return
+            state.settings.unreadCountTitle = action.meta.arg
+        })
+        builder.addCase(changeUnreadCountFavicon.pending, (state, action) => {
+            if (!state.settings) return
+            state.settings.unreadCountFavicon = action.meta.arg
+        })
+        builder.addCase(changePrimaryColor.pending, (state, action) => {
+            if (!state.settings) return
+            state.settings.primaryColor = action.meta.arg
+        })
+        builder.addCase(changeSharingSetting.pending, (state, action) => {
+            if (!state.settings) return
+            state.settings.sharingSettings[action.meta.arg.site] = action.meta.arg.value
+        })
+        builder.addMatcher(
+            isAnyOf(
+                changeLanguage.fulfilled,
+                changeScrollSpeed.fulfilled,
+                changeShowRead.fulfilled,
+                changeScrollMarks.fulfilled,
+                changeScrollMode.fulfilled,
+                changeEntriesToKeepOnTopWhenScrolling.fulfilled,
+                changeStarIconDisplayMode.fulfilled,
+                changeExternalLinkIconDisplayMode.fulfilled,
+                changeMarkAllAsReadConfirmation.fulfilled,
+                changeCustomContextMenu.fulfilled,
+                changeMobileFooter.fulfilled,
+                changeUnreadCountTitle.fulfilled,
+                changeUnreadCountFavicon.fulfilled,
+                changePrimaryColor.fulfilled,
+                changeSharingSetting.fulfilled
+            ),
+            () => {
+                showNotification({
+                    message: t`Settings saved.`,
+                    color: "green",
+                })
+            }
+        )
+    },
+})
+
+export const { setViewMode, setSidebarWidth, setAnnouncementHash, setFontSizePercentage } = userSlice.actions

commafeed-client/src/app/user/thunks.ts

@@ -1,83 +1,141 @@
-import { createAppAsyncThunk } from "app/async-thunk"
+import { createAppAsyncThunk } from "app/async-thunk"
-import { client } from "app/client"
+import { client } from "app/client"
-import { reloadEntries } from "app/entries/thunks"
+import { reloadEntries } from "app/entries/thunks"
-import type { ReadingMode, ReadingOrder, ScrollMode, SharingSettings } from "app/types"
+import type { IconDisplayMode, ReadingMode, ReadingOrder, ScrollMode, SharingSettings } from "app/types"
-
+
-export const reloadSettings = createAppAsyncThunk("settings/reload", async () => await client.user.getSettings().then(r => r.data))
+export const reloadSettings = createAppAsyncThunk("settings/reload", async () => await client.user.getSettings().then(r => r.data))
-export const reloadProfile = createAppAsyncThunk("profile/reload", async () => await client.user.getProfile().then(r => r.data))
+
-export const reloadTags = createAppAsyncThunk("entries/tags", async () => await client.entry.getTags().then(r => r.data))
+export const reloadProfile = createAppAsyncThunk("profile/reload", async () => await client.user.getProfile().then(r => r.data))
-export const changeReadingMode = createAppAsyncThunk("settings/readingMode", (readingMode: ReadingMode, thunkApi) => {
+
-    const { settings } = thunkApi.getState().user
+export const reloadTags = createAppAsyncThunk("entries/tags", async () => await client.entry.getTags().then(r => r.data))
-    if (!settings) return
+
-    client.user.saveSettings({ ...settings, readingMode })
+export const changeReadingMode = createAppAsyncThunk("settings/readingMode", (readingMode: ReadingMode, thunkApi) => {
-    thunkApi.dispatch(reloadEntries())
+    const { settings } = thunkApi.getState().user
-})
+    if (!settings) return
-export const changeReadingOrder = createAppAsyncThunk("settings/readingOrder", (readingOrder: ReadingOrder, thunkApi) => {
+    client.user.saveSettings({ ...settings, readingMode })
-    const { settings } = thunkApi.getState().user
+    thunkApi.dispatch(reloadEntries())
-    if (!settings) return
+})
-    client.user.saveSettings({ ...settings, readingOrder })
+
-    thunkApi.dispatch(reloadEntries())
+export const changeReadingOrder = createAppAsyncThunk("settings/readingOrder", (readingOrder: ReadingOrder, thunkApi) => {
-})
+    const { settings } = thunkApi.getState().user
-export const changeLanguage = createAppAsyncThunk("settings/language", (language: string, thunkApi) => {
+    if (!settings) return
-    const { settings } = thunkApi.getState().user
+    client.user.saveSettings({ ...settings, readingOrder })
-    if (!settings) return
+    thunkApi.dispatch(reloadEntries())
-    client.user.saveSettings({ ...settings, language })
+})
-})
+
-export const changeScrollSpeed = createAppAsyncThunk("settings/scrollSpeed", (speed: boolean, thunkApi) => {
+export const changeLanguage = createAppAsyncThunk("settings/language", (language: string, thunkApi) => {
-    const { settings } = thunkApi.getState().user
+    const { settings } = thunkApi.getState().user
-    if (!settings) return
+    if (!settings) return
-    client.user.saveSettings({ ...settings, scrollSpeed: speed ? 400 : 0 })
+    client.user.saveSettings({ ...settings, language })
-})
+})
-export const changeShowRead = createAppAsyncThunk("settings/showRead", (showRead: boolean, thunkApi) => {
+
-    const { settings } = thunkApi.getState().user
+export const changeScrollSpeed = createAppAsyncThunk("settings/scrollSpeed", (speed: boolean, thunkApi) => {
-    if (!settings) return
+    const { settings } = thunkApi.getState().user
-    client.user.saveSettings({ ...settings, showRead })
+    if (!settings) return
-})
+    client.user.saveSettings({ ...settings, scrollSpeed: speed ? 400 : 0 })
-export const changeScrollMarks = createAppAsyncThunk("settings/scrollMarks", (scrollMarks: boolean, thunkApi) => {
+})
-    const { settings } = thunkApi.getState().user
+
-    if (!settings) return
+export const changeShowRead = createAppAsyncThunk("settings/showRead", (showRead: boolean, thunkApi) => {
-    client.user.saveSettings({ ...settings, scrollMarks })
+    const { settings } = thunkApi.getState().user
-})
+    if (!settings) return
-export const changeScrollMode = createAppAsyncThunk("settings/scrollMode", (scrollMode: ScrollMode, thunkApi) => {
+    client.user.saveSettings({ ...settings, showRead })
-    const { settings } = thunkApi.getState().user
+})
-    if (!settings) return
+
-    client.user.saveSettings({ ...settings, scrollMode })
+export const changeScrollMarks = createAppAsyncThunk("settings/scrollMarks", (scrollMarks: boolean, thunkApi) => {
-})
+    const { settings } = thunkApi.getState().user
-export const changeMarkAllAsReadConfirmation = createAppAsyncThunk(
+    if (!settings) return
-    "settings/markAllAsReadConfirmation",
+    client.user.saveSettings({ ...settings, scrollMarks })
-    (markAllAsReadConfirmation: boolean, thunkApi) => {
+})
-        const { settings } = thunkApi.getState().user
+
-        if (!settings) return
+export const changeScrollMode = createAppAsyncThunk("settings/scrollMode", (scrollMode: ScrollMode, thunkApi) => {
-        client.user.saveSettings({ ...settings, markAllAsReadConfirmation })
+    const { settings } = thunkApi.getState().user
-    }
+    if (!settings) return
-)
+    client.user.saveSettings({ ...settings, scrollMode })
-export const changeCustomContextMenu = createAppAsyncThunk("settings/customContextMenu", (customContextMenu: boolean, thunkApi) => {
+})
-    const { settings } = thunkApi.getState().user
+
-    if (!settings) return
+export const changeEntriesToKeepOnTopWhenScrolling = createAppAsyncThunk(
-    client.user.saveSettings({ ...settings, customContextMenu })
+    "settings/entriesToKeepOnTopWhenScrolling",
-})
+    (entriesToKeepOnTopWhenScrolling: number, thunkApi) => {
-export const changeMobileFooter = createAppAsyncThunk("settings/mobileFooter", (mobileFooter: boolean, thunkApi) => {
+        const { settings } = thunkApi.getState().user
-    const { settings } = thunkApi.getState().user
+        if (!settings) return
-    if (!settings) return
+        client.user.saveSettings({ ...settings, entriesToKeepOnTopWhenScrolling })
-    client.user.saveSettings({ ...settings, mobileFooter })
+    }
-})
+)
-export const changeSharingSetting = createAppAsyncThunk(
+
-    "settings/sharingSetting",
+export const changeStarIconDisplayMode = createAppAsyncThunk(
-    (
+    "settings/starIconDisplayMode",
-        sharingSetting: {
+    (starIconDisplayMode: IconDisplayMode, thunkApi) => {
-            site: keyof SharingSettings
+        const { settings } = thunkApi.getState().user
-            value: boolean
+        if (!settings) return
-        },
+        client.user.saveSettings({ ...settings, starIconDisplayMode })
-        thunkApi
+    }
-    ) => {
+)
-        const { settings } = thunkApi.getState().user
+
-        if (!settings) return
+export const changeExternalLinkIconDisplayMode = createAppAsyncThunk(
-        client.user.saveSettings({
+    "settings/externalLinkIconDisplayMode",
-            ...settings,
+    (externalLinkIconDisplayMode: IconDisplayMode, thunkApi) => {
-            sharingSettings: {
+        const { settings } = thunkApi.getState().user
-                ...settings.sharingSettings,
+        if (!settings) return
-                [sharingSetting.site]: sharingSetting.value,
+        client.user.saveSettings({ ...settings, externalLinkIconDisplayMode })
-            },
+    }
-        })
+)
-    }
+
-)
+export const changeMarkAllAsReadConfirmation = createAppAsyncThunk(
+    "settings/markAllAsReadConfirmation",
+    (markAllAsReadConfirmation: boolean, thunkApi) => {
+        const { settings } = thunkApi.getState().user
+        if (!settings) return
+        client.user.saveSettings({ ...settings, markAllAsReadConfirmation })
+    }
+)
+
+export const changeCustomContextMenu = createAppAsyncThunk("settings/customContextMenu", (customContextMenu: boolean, thunkApi) => {
+    const { settings } = thunkApi.getState().user
+    if (!settings) return
+    client.user.saveSettings({ ...settings, customContextMenu })
+})
+
+export const changeMobileFooter = createAppAsyncThunk("settings/mobileFooter", (mobileFooter: boolean, thunkApi) => {
+    const { settings } = thunkApi.getState().user
+    if (!settings) return
+    client.user.saveSettings({ ...settings, mobileFooter })
+})
+
+export const changeUnreadCountTitle = createAppAsyncThunk("settings/unreadCountTitle", (unreadCountTitle: boolean, thunkApi) => {
+    const { settings } = thunkApi.getState().user
+    if (!settings) return
+    client.user.saveSettings({ ...settings, unreadCountTitle })
+})
+
+export const changeUnreadCountFavicon = createAppAsyncThunk("settings/unreadCountFavicon", (unreadCountFavicon: boolean, thunkApi) => {
+    const { settings } = thunkApi.getState().user
+    if (!settings) return
+    client.user.saveSettings({ ...settings, unreadCountFavicon })
+})
+
+export const changePrimaryColor = createAppAsyncThunk("settings/primaryColor", (primaryColor: string, thunkApi) => {
+    const { settings } = thunkApi.getState().user
+    if (!settings) return
+    client.user.saveSettings({ ...settings, primaryColor })
+})
+
+export const changeSharingSetting = createAppAsyncThunk(
+    "settings/sharingSetting",
+    (
+        sharingSetting: {
+            site: keyof SharingSettings
+            value: boolean
+        },
+        thunkApi
+    ) => {
+        const { settings } = thunkApi.getState().user
+        if (!settings) return
+        client.user.saveSettings({
+            ...settings,
+            sharingSettings: {
+                ...settings.sharingSettings,
+                [sharingSetting.site]: sharingSetting.value,
+            },
+        })
+    }
+)

commafeed-client/src/app/utils.ts

@@ -1,47 +1,69 @@
-import { throttle } from "throttle-debounce"
+import type { TreeCategory } from "app/tree/slice"
-import { type Category } from "./types"
+import { throttle } from "throttle-debounce"
-
+import type { Category } from "./types"
-export function visitCategoryTree(category: Category, visitor: (category: Category) => void): void {
+
-    visitor(category)
+export function visitCategoryTree(
-    category.children.forEach(child => visitCategoryTree(child, visitor))
+    category: TreeCategory,
-}
+    visitor: (category: TreeCategory) => void,
-
+    options?: {
-export function flattenCategoryTree(category: Category): Category[] {
+        childrenFirst?: boolean
-    const categories: Category[] = []
+    }
-    visitCategoryTree(category, c => categories.push(c))
+): void {
-    return categories
+    const childrenFirst = options?.childrenFirst
-}
+
-
+    if (!childrenFirst) visitor(category)
-export function categoryUnreadCount(category?: Category): number {
+
-    if (!category) return 0
+    for (const child of category.children) {
-
+        visitCategoryTree(child, visitor, options)
-    return flattenCategoryTree(category)
+    }
-        .flatMap(c => c.feeds)
+
-        .map(f => f.unread)
+    if (childrenFirst) visitor(category)
-        .reduce((total, current) => total + current, 0)
+}
-}
+
-
+export function flattenCategoryTree(category: TreeCategory): TreeCategory[] {
-export const calculatePlaceholderSize = ({ width, height, maxWidth }: { width?: number; height?: number; maxWidth: number }) => {
+    const categories: Category[] = []
-    const placeholderWidth = width && Math.min(width, maxWidth)
+    visitCategoryTree(category, c => categories.push(c))
-    const placeholderHeight = height && width && width > maxWidth ? height * (maxWidth / width) : height
+    return categories
-    return { width: placeholderWidth, height: placeholderHeight }
+}
-}
+
-
+export function categoryUnreadCount(category?: TreeCategory): number {
-export const scrollToWithCallback = ({ options, onScrollEnded }: { options: ScrollToOptions; onScrollEnded: () => void }) => {
+    if (!category) return 0
-    const offset = (options.top ?? 0).toFixed()
+
-
+    return flattenCategoryTree(category)
-    const onScroll = throttle(100, () => {
+        .flatMap(c => c.feeds)
-        if (window.scrollY.toFixed() === offset) {
+        .map(f => f.unread)
-            window.removeEventListener("scroll", onScroll)
+        .reduce((total, current) => total + current, 0)
-            onScrollEnded()
+}
-        }
+
-    })
+export function categoryHasNewEntries(category?: TreeCategory): boolean {
-    window.addEventListener("scroll", onScroll)
+    if (!category) return false
-
+
-    // scrollTo does not trigger if there's nothing to do, trigger it manually
+    return flattenCategoryTree(category)
-    onScroll()
+        .flatMap(c => c.feeds)
-
+        .some(f => f.hasNewEntries)
-    window.scrollTo(options)
+}
-}
+
-
+export const calculatePlaceholderSize = ({ width, height, maxWidth }: { width?: number; height?: number; maxWidth: number }) => {
-export const truncate = (str: string, n: number) => (str.length > n ? `${str.slice(0, n - 1)}\u2026` : str)
+    const placeholderWidth = width && Math.min(width, maxWidth)
+    const placeholderHeight = height && width && width > maxWidth ? height * (maxWidth / width) : height
+    return { width: placeholderWidth, height: placeholderHeight }
+}
+
+export const scrollToWithCallback = ({ options, onScrollEnded }: { options: ScrollToOptions; onScrollEnded: () => void }) => {
+    const offset = (options.top ?? 0).toFixed()
+
+    const onScroll = throttle(100, () => {
+        if (window.scrollY.toFixed() === offset) {
+            window.removeEventListener("scroll", onScroll)
+            onScrollEnded()
+        }
+    })
+    window.addEventListener("scroll", onScroll)
+
+    // scrollTo does not trigger if there's nothing to do, trigger it manually
+    onScroll()
+
+    window.scrollTo(options)
+}
+
+export const truncate = (str: string, n: number) => (str.length > n ? `${str.slice(0, n - 1)}\u2026` : str)

commafeed-client/src/components/ActionButton.test.tsx

@@ -0,0 +1,47 @@
+import type { I18nContext } from "@lingui/react"
+import { MantineProvider } from "@mantine/core"
+import { fireEvent, render, screen, waitFor } from "@testing-library/react"
+import { useActionButton } from "hooks/useActionButton"
+import { describe, expect, it, vi } from "vitest"
+import { ActionButton } from "./ActionButton"
+
+vi.mock(import("@lingui/react"), () => ({
+    useLingui: vi.fn().mockReturnValue({
+        _: msg => msg,
+    } as I18nContext),
+}))
+vi.mock(import("hooks/useActionButton"))
+
+const label = "Test Label"
+const icon = "Test Icon"
+describe("ActionButton", () => {
+    it("renders Button with label on desktop", () => {
+        vi.mocked(useActionButton).mockReturnValue({ mobile: false, spacing: 0 })
+
+        render(<ActionButton label={label} icon={icon} />, { wrapper: MantineProvider })
+        expect(screen.getByText(label)).toBeInTheDocument()
+        expect(screen.getByText(icon)).toBeInTheDocument()
+    })
+
+    it("renders ActionIcon with tooltip on mobile", async () => {
+        vi.mocked(useActionButton).mockReturnValue({ mobile: true, spacing: 0 })
+
+        render(<ActionButton label={label} icon={icon} />, { wrapper: MantineProvider })
+        expect(screen.queryByText(label)).not.toBeInTheDocument()
+        expect(screen.getByText(icon)).toBeInTheDocument()
+
+        fireEvent.mouseEnter(screen.getByRole("button"))
+        const tooltip = await waitFor(() => screen.getByRole("tooltip"))
+        expect(tooltip).toContainHTML(label)
+    })
+
+    it("calls onClick handler when clicked", () => {
+        vi.mocked(useActionButton).mockReturnValue({ mobile: false, spacing: 0 })
+        const clickListener = vi.fn()
+
+        render(<ActionButton label={label} icon={icon} onClick={clickListener} />, { wrapper: MantineProvider })
+        fireEvent.click(screen.getByRole("button"))
+
+        expect(clickListener).toHaveBeenCalled()
+    })
+})

commafeed-client/src/components/ActionButton.tsx

@@ -1,36 +1,62 @@
-import { ActionIcon, Button, type ButtonVariant, Tooltip, useMantineTheme } from "@mantine/core"
+import type { MessageDescriptor } from "@lingui/core"
-import { type ActionIconVariant } from "@mantine/core/lib/components/ActionIcon/ActionIcon"
+import { useLingui } from "@lingui/react"
-import { useActionButton } from "hooks/useActionButton"
+import { ActionIcon, Box, Button, type ButtonVariant, Tooltip, useMantineTheme } from "@mantine/core"
-import { forwardRef, type MouseEventHandler, type ReactNode } from "react"
+import type { ActionIconVariant } from "@mantine/core/lib/components/ActionIcon/ActionIcon"
-
+import { Constants } from "app/constants"
-interface ActionButtonProps {
+import { useActionButton } from "hooks/useActionButton"
-    className?: string
+import { type MouseEventHandler, type ReactNode, forwardRef } from "react"
-    icon?: ReactNode
+
-    label: ReactNode
+interface ActionButtonProps {
-    onClick?: MouseEventHandler
+    icon: ReactNode
-    variant?: ActionIconVariant & ButtonVariant
+    className?: string
-    hideLabelOnDesktop?: boolean
+    label?: string | MessageDescriptor
-    showLabelOnMobile?: boolean
+    onClick?: MouseEventHandler
-}
+    variant?: ActionIconVariant & ButtonVariant
-
+    hideLabelOnDesktop?: boolean
-/**
+    showLabelOnMobile?: boolean
- * Switches between Button with label (desktop) and ActionIcon (mobile)
+}
- */
+
-export const ActionButton = forwardRef<HTMLButtonElement, ActionButtonProps>((props: ActionButtonProps, ref) => {
+/**
-    const { mobile } = useActionButton()
+ * Switches between Button with label (desktop) and ActionIcon (mobile)
-    const theme = useMantineTheme()
+ */
-    const variant = props.variant ?? "subtle"
+export const ActionButton = forwardRef<HTMLDivElement, ActionButtonProps>((props: ActionButtonProps, ref) => {
-    const iconOnly = (mobile && !props.showLabelOnMobile) || (!mobile && props.hideLabelOnDesktop)
+    const { mobile } = useActionButton()
-    return iconOnly ? (
+    const theme = useMantineTheme()
-        <Tooltip label={props.label} openDelay={500}>
+    const { _ } = useLingui()
-            <ActionIcon ref={ref} color={theme.primaryColor} variant={variant} className={props.className} onClick={props.onClick}>
+
-                {props.icon}
+    const label = typeof props.label === "string" ? props.label : props.label && _(props.label)
-            </ActionIcon>
+    const variant = props.variant ?? "subtle"
-        </Tooltip>
+    const iconOnly = (mobile && !props.showLabelOnMobile) || (!mobile && props.hideLabelOnDesktop)
-    ) : (
+
-        <Button ref={ref} variant={variant} size="xs" className={props.className} leftSection={props.icon} onClick={props.onClick}>
+    return (
-            {props.label}
+        <Box ref={ref} className="cf-action-button">
-        </Button>
+            {iconOnly && (
-    )
+                <Tooltip label={label} openDelay={Constants.tooltip.delay}>
-})
+                    <ActionIcon
-ActionButton.displayName = "HeaderButton"
+                        color={theme.primaryColor}
+                        variant={variant}
+                        className={props.className}
+                        onClick={props.onClick}
+                        aria-label={label}
+                    >
+                        {props.icon}
+                    </ActionIcon>
+                </Tooltip>
+            )}
+            {!iconOnly && (
+                <Button
+                    variant={variant}
+                    size="xs"
+                    className={props.className}
+                    leftSection={props.icon}
+                    onClick={props.onClick}
+                    aria-label={label}
+                >
+                    {label}
+                </Button>
+            )}
+        </Box>
+    )
+})
+
+ActionButton.displayName = "HeaderButton"

commafeed-client/src/components/Alert.tsx

@@ -1,47 +1,47 @@
-import { Trans } from "@lingui/macro"
+import { Trans } from "@lingui/react/macro"
-import { Alert as MantineAlert, Box } from "@mantine/core"
+import { Box, Alert as MantineAlert } from "@mantine/core"
-import { Fragment } from "react"
+import { Fragment } from "react"
-import { TbAlertCircle, TbAlertTriangle, TbCircleCheck } from "react-icons/tb"
+import { TbAlertCircle, TbAlertTriangle, TbCircleCheck } from "react-icons/tb"
-
+
-type Level = "error" | "warning" | "success"
+type Level = "error" | "warning" | "success"
-
+
-export interface ErrorsAlertProps {
+export interface ErrorsAlertProps {
-    level?: Level
+    level?: Level
-    messages: string[]
+    messages: string[]
-}
+}
-
+
-export function Alert(props: ErrorsAlertProps) {
+export function Alert(props: ErrorsAlertProps) {
-    let title: React.ReactNode
+    let title: React.ReactNode
-    let color: string
+    let color: string
-    let icon: React.ReactNode
+    let icon: React.ReactNode
-
+
-    const level = props.level ?? "error"
+    const level = props.level ?? "error"
-    switch (level) {
+    switch (level) {
-        case "error":
+        case "error":
-            title = <Trans>Error</Trans>
+            title = <Trans>Error</Trans>
-            color = "red"
+            color = "red"
-            icon = <TbAlertCircle />
+            icon = <TbAlertCircle />
-            break
+            break
-        case "warning":
+        case "warning":
-            title = <Trans>Warning</Trans>
+            title = <Trans>Warning</Trans>
-            color = "orange"
+            color = "orange"
-            icon = <TbAlertTriangle />
+            icon = <TbAlertTriangle />
-            break
+            break
-        case "success":
+        case "success":
-            title = <Trans>Success</Trans>
+            title = <Trans>Success</Trans>
-            color = "green"
+            color = "green"
-            icon = <TbCircleCheck />
+            icon = <TbCircleCheck />
-            break
+            break
-    }
+    }
-
+
-    return (
+    return (
-        <MantineAlert title={title} color={color} icon={icon}>
+        <MantineAlert title={title} color={color} icon={icon}>
-            {props.messages.map((m, i) => (
+            {props.messages.map((m, i) => (
-                <Fragment key={m}>
+                <Fragment key={m}>
-                    <Box>{m}</Box>
+                    <Box>{m}</Box>
-                    {i !== props.messages.length - 1 && <br />}
+                    {i !== props.messages.length - 1 && <br />}
-                </Fragment>
+                </Fragment>
-            ))}
+            ))}
-        </MantineAlert>
+        </MantineAlert>
-    )
+    )
-}
+}

commafeed-client/src/components/AnnouncementDialog.tsx

@@ -1,9 +1,9 @@
-import { Trans } from "@lingui/macro"
+import { Trans } from "@lingui/react/macro"
 import { Box, Dialog, Text } from "@mantine/core"
-import { useAppSelector } from "app/store"
+import { useAppDispatch, useAppSelector } from "app/store"
+import { setAnnouncementHash } from "app/user/slice"
 import { Content } from "components/content/Content"
 import { useAsync } from "react-async-hook"
-import useLocalStorage from "use-local-storage"
 
 const sha256Hex = async (input: string | undefined) => {
     const data = new TextEncoder().encode(input)
@@ -15,10 +15,11 @@ const sha256Hex = async (input: string | undefined) => {
 export function AnnouncementDialog() {
     const announcement = useAppSelector(state => state.server.serverInfos?.announcement)
     const announcementHash = useAsync(sha256Hex, [announcement]).result
-    const [localStorageHash, setLocalStorageHash] = useLocalStorage("announcement-hash", "no-hash")
+    const existingAnnouncementHash = useAppSelector(state => state.user.localSettings.announcementHash)
+    const dispatch = useAppDispatch()
 
-    const opened = !!announcementHash && announcementHash !== localStorageHash
+    const opened = !!announcementHash && announcementHash !== existingAnnouncementHash
-    const onClosed = () => setLocalStorageHash(announcementHash)
+    const onClosed = () => announcementHash && dispatch(setAnnouncementHash(announcementHash))
 
     if (!announcement) return null
     return (

commafeed-client/src/components/DisablePullToRefresh.css

@@ -0,0 +1,4 @@
+html,
+body {
+    overscroll-behavior: none;
+}

commafeed-client/src/components/DisablePullToRefresh.tsx

@@ -0,0 +1,4 @@
+export const DisablePullToRefresh = () => {
+    import("./DisablePullToRefresh.css")
+    return <></>
+}

commafeed-client/src/components/ErrorBoundary.tsx

@@ -1,26 +1,26 @@
-import { ErrorPage } from "pages/ErrorPage"
+import { ErrorPage } from "pages/ErrorPage"
-import React, { type ReactNode } from "react"
+import React, { type ReactNode } from "react"
-
+
-interface ErrorBoundaryProps {
+interface ErrorBoundaryProps {
-    children?: ReactNode
+    children?: ReactNode
-}
+}
-
+
-interface ErrorBoundaryState {
+interface ErrorBoundaryState {
-    error?: Error
+    error?: Error
-}
+}
-
+
-export class ErrorBoundary extends React.Component<ErrorBoundaryProps, ErrorBoundaryState> {
+export class ErrorBoundary extends React.Component<ErrorBoundaryProps, ErrorBoundaryState> {
-    constructor(props: ErrorBoundaryProps) {
+    constructor(props: ErrorBoundaryProps) {
-        super(props)
+        super(props)
-        this.state = {}
+        this.state = {}
-    }
+    }
-
+
-    componentDidCatch(error: Error) {
+    componentDidCatch(error: Error) {
-        this.setState({ error })
+        this.setState({ error })
-    }
+    }
-
+
-    render() {
+    render() {
-        if (this.state.error) return <ErrorPage error={this.state.error} />
+        if (this.state.error) return <ErrorPage error={this.state.error} />
-        return this.props.children
+        return this.props.children
-    }
+    }
-}
+}

commafeed-client/src/components/ImageWithPlaceholderWhileLoading.tsx

@@ -1,75 +1,81 @@
-import { Box, Center } from "@mantine/core"
+import { Box, Center } from "@mantine/core"
-import { useState } from "react"
+import { useState } from "react"
-import { TbPhoto } from "react-icons/tb"
+import { TbPhoto } from "react-icons/tb"
-import { tss } from "tss"
+import { tss } from "tss"
-
+
-interface ImageWithPlaceholderWhileLoadingProps {
+interface ImageWithPlaceholderWhileLoadingProps {
-    src: string
+    src: string
-    alt: string
+    alt: string
-    title?: string
+    title?: string
-    width?: number
+    width?: number
-    height?: number | "auto"
+    height?: number | "auto"
-    placeholderWidth?: number
+    style?: React.CSSProperties
-    placeholderHeight?: number
+    placeholderWidth?: number
-    placeholderBackgroundColor?: string
+    placeholderHeight?: number
-    placeholderIconSize?: number
+    placeholderBackgroundColor?: string
-}
+    placeholderIconSize?: number
-
+}
-const useStyles = tss
+
-    .withParams<{
+const useStyles = tss
-        placeholderWidth?: number
+    .withParams<{
-        placeholderHeight?: number
+        placeholderWidth?: number
-        placeholderBackgroundColor?: string
+        placeholderHeight?: number
-    }>()
+        placeholderBackgroundColor?: string
-    .create(props => ({
+    }>()
-        placeholder: {
+    .create(props => ({
-            width: props.placeholderWidth ?? 400,
+        placeholder: {
-            height: props.placeholderHeight ?? 600,
+            width: props.placeholderWidth ?? 400,
-            maxWidth: "100%",
+            height: props.placeholderHeight ?? 600,
-            backgroundColor:
+            maxWidth: "100%",
-                props.placeholderBackgroundColor ??
+            backgroundColor:
-                (props.colorScheme === "dark" ? props.theme.colors.dark[5] : props.theme.colors.gray[1]),
+                props.placeholderBackgroundColor ??
-        },
+                (props.colorScheme === "dark" ? props.theme.colors.dark[5] : props.theme.colors.gray[1]),
-    }))
+        },
-
+    }))
-export function ImageWithPlaceholderWhileLoading({
+
-    alt,
+export function ImageWithPlaceholderWhileLoading({
-    height,
+    alt,
-    placeholderBackgroundColor,
+    height,
-    placeholderHeight,
+    placeholderBackgroundColor,
-    placeholderIconSize,
+    placeholderHeight,
-    placeholderWidth,
+    placeholderIconSize,
-    src,
+    placeholderWidth,
-    title,
+    src,
-    width,
+    title,
-}: ImageWithPlaceholderWhileLoadingProps) {
+    width,
-    const { classes } = useStyles({
+    style,
-        placeholderWidth,
+}: ImageWithPlaceholderWhileLoadingProps) {
-        placeholderHeight,
+    const { classes } = useStyles({
-        placeholderBackgroundColor,
+        placeholderWidth,
-    })
+        placeholderHeight,
-    const [loading, setLoading] = useState(true)
+        placeholderBackgroundColor,
-
+    })
-    return (
+    const [loading, setLoading] = useState(true)
-        <>
+
-            {loading && (
+    return (
-                <Box>
+        <>
-                    <Center className={classes.placeholder}>
+            {loading && (
-                        <div>
+                <Box>
-                            <TbPhoto size={placeholderIconSize ?? 48} />
+                    <Center className={classes.placeholder}>
-                        </div>
+                        <div>
-                    </Center>
+                            <TbPhoto size={placeholderIconSize ?? 48} />
-                </Box>
+                        </div>
-            )}
+                    </Center>
-            <img
+                </Box>
-                src={src}
+            )}
-                alt={alt}
+            <img
-                title={title}
+                src={src}
-                width={width}
+                alt={alt}
-                height={height}
+                title={title}
-                onLoad={() => setLoading(false)}
+                width={width}
-                style={{ display: loading ? "none" : "block" }}
+                height={height}
-            />
+                onLoad={() => setLoading(false)}
-        </>
+                style={{
-    )
+                    ...style,
-}
+                    display: loading ? "none" : (style?.display ?? "initial"),
+                    height: style?.width ? "auto" : style?.height,
+                }}
+            />
+        </>
+    )
+}

commafeed-client/src/components/KeyboardShortcutsHelp.tsx

@@ -1,222 +1,242 @@
-import { Trans } from "@lingui/macro"
+import { Trans } from "@lingui/react/macro"
-import { Anchor, Box, Kbd, Stack, Table } from "@mantine/core"
+import { Anchor, Box, Kbd, Stack, Table } from "@mantine/core"
-import { Constants } from "app/constants"
+import { useOs } from "@mantine/hooks"
-
+import { Constants } from "app/constants"
-export function KeyboardShortcutsHelp() {
+
-    return (
+export function KeyboardShortcutsHelp() {
-        <Stack gap="xs">
+    const isMacOS = useOs() === "macos"
-            <Table striped highlightOnHover>
+    return (
-                <Table.Tbody>
+        <Stack gap="xs">
-                    <Table.Tr>
+            <Table striped highlightOnHover>
-                        <Table.Td>
+                <Table.Tbody>
-                            <Trans>Refresh</Trans>
+                    <Table.Tr>
-                        </Table.Td>
+                        <Table.Td>
-                        <Table.Td>
+                            <Trans>Refresh</Trans>
-                            <Kbd>R</Kbd>
+                        </Table.Td>
-                        </Table.Td>
+                        <Table.Td>
-                    </Table.Tr>
+                            <Kbd>R</Kbd>
-                    <Table.Tr>
+                        </Table.Td>
-                        <Table.Td>
+                    </Table.Tr>
-                            <Trans>Open next entry</Trans>
+                    <Table.Tr>
-                        </Table.Td>
+                        <Table.Td>
-                        <Table.Td>
+                            <Trans>Open next entry</Trans>
-                            <Kbd>J</Kbd>
+                        </Table.Td>
-                        </Table.Td>
+                        <Table.Td>
-                    </Table.Tr>
+                            <Kbd>J</Kbd>
-                    <Table.Tr>
+                        </Table.Td>
-                        <Table.Td>
+                    </Table.Tr>
-                            <Trans>Open previous entry</Trans>
+                    <Table.Tr>
-                        </Table.Td>
+                        <Table.Td>
-                        <Table.Td>
+                            <Trans>Open previous entry</Trans>
-                            <Kbd>K</Kbd>
+                        </Table.Td>
-                        </Table.Td>
+                        <Table.Td>
-                    </Table.Tr>
+                            <Kbd>K</Kbd>
-                    <Table.Tr>
+                        </Table.Td>
-                        <Table.Td>
+                    </Table.Tr>
-                            <Trans>Set focus on next entry without opening it</Trans>
+                    <Table.Tr>
-                        </Table.Td>
+                        <Table.Td>
-                        <Table.Td>
+                            <Trans>Select next unread feed/category</Trans>
-                            <Kbd>N</Kbd>
+                        </Table.Td>
-                        </Table.Td>
+                        <Table.Td>
-                    </Table.Tr>
+                            <Kbd>Shift</Kbd>
-                    <Table.Tr>
+                            <span> + </span>
-                        <Table.Td>
+                            <Kbd>J</Kbd>
-                            <Trans>Set focus on previous entry without opening it</Trans>
+                        </Table.Td>
-                        </Table.Td>
+                    </Table.Tr>
-                        <Table.Td>
+                    <Table.Tr>
-                            <Kbd>P</Kbd>
+                        <Table.Td>
-                        </Table.Td>
+                            <Trans>Select previous unread feed/category</Trans>
-                    </Table.Tr>
+                        </Table.Td>
-                    <Table.Tr>
+                        <Table.Td>
-                        <Table.Td>
+                            <Kbd>Shift</Kbd>
-                            <Trans>Move the page down</Trans>
+                            <span> + </span>
-                        </Table.Td>
+                            <Kbd>K</Kbd>
-                        <Table.Td>
+                        </Table.Td>
-                            <Kbd>
+                    </Table.Tr>
-                                <Trans>Space</Trans>
+                    <Table.Tr>
-                            </Kbd>
+                        <Table.Td>
-                        </Table.Td>
+                            <Trans>Set focus on next entry without opening it</Trans>
-                    </Table.Tr>
+                        </Table.Td>
-                    <Table.Tr>
+                        <Table.Td>
-                        <Table.Td>
+                            <Kbd>N</Kbd>
-                            <Trans>Move the page up</Trans>
+                        </Table.Td>
-                        </Table.Td>
+                    </Table.Tr>
-                        <Table.Td>
+                    <Table.Tr>
-                            <Kbd>
+                        <Table.Td>
-                                <Trans>Shift</Trans>
+                            <Trans>Set focus on previous entry without opening it</Trans>
-                            </Kbd>
+                        </Table.Td>
-                            <span> + </span>
+                        <Table.Td>
-                            <Kbd>
+                            <Kbd>P</Kbd>
-                                <Trans>Space</Trans>
+                        </Table.Td>
-                            </Kbd>
+                    </Table.Tr>
-                        </Table.Td>
+                    <Table.Tr>
-                    </Table.Tr>
+                        <Table.Td>
-                    <Table.Tr>
+                            <Trans>Move the page down</Trans>
-                        <Table.Td>
+                        </Table.Td>
-                            <Trans>Open/close current entry</Trans>
+                        <Table.Td>
-                        </Table.Td>
+                            <Kbd>
-                        <Table.Td>
+                                <Trans>Space</Trans>
-                            <Kbd>O</Kbd>
+                            </Kbd>
-                            <span>, </span>
+                        </Table.Td>
-                            <Kbd>
+                    </Table.Tr>
-                                <Trans>Enter</Trans>
+                    <Table.Tr>
-                            </Kbd>
+                        <Table.Td>
-                        </Table.Td>
+                            <Trans>Move the page up</Trans>
-                    </Table.Tr>
+                        </Table.Td>
-                    <Table.Tr>
+                        <Table.Td>
-                        <Table.Td>
+                            <Kbd>
-                            <Trans>Open current entry in a new tab</Trans>
+                                <Trans>Shift</Trans>
-                        </Table.Td>
+                            </Kbd>
-                        <Table.Td>
+                            <span> + </span>
-                            <Kbd>V</Kbd>
+                            <Kbd>
-                        </Table.Td>
+                                <Trans>Space</Trans>
-                    </Table.Tr>
+                            </Kbd>
-                    <Table.Tr>
+                        </Table.Td>
-                        <Table.Td>
+                    </Table.Tr>
-                            <Trans>Open current entry in a new tab in the background</Trans>
+                    <Table.Tr>
-                        </Table.Td>
+                        <Table.Td>
-                        <Table.Td>
+                            <Trans>Open/close current entry</Trans>
-                            <Kbd>B</Kbd>
+                        </Table.Td>
-                            <span>*, </span>
+                        <Table.Td>
-                            <Kbd>
+                            <Kbd>O</Kbd>
-                                <Trans>Middle click</Trans>
+                            <span>, </span>
-                            </Kbd>
+                            <Kbd>
-                        </Table.Td>
+                                <Trans>Enter</Trans>
-                    </Table.Tr>
+                            </Kbd>
-                    <Table.Tr>
+                        </Table.Td>
-                        <Table.Td>
+                    </Table.Tr>
-                            <Trans>Toggle read status of current entry</Trans>
+                    <Table.Tr>
-                        </Table.Td>
+                        <Table.Td>
-                        <Table.Td>
+                            <Trans>Open current entry in a new tab</Trans>
-                            <Kbd>M</Kbd>
+                        </Table.Td>
-                            <span>, </span>
+                        <Table.Td>
-                            <Trans>Swipe header to the left</Trans>
+                            <Kbd>V</Kbd>
-                        </Table.Td>
+                        </Table.Td>
-                    </Table.Tr>
+                    </Table.Tr>
-                    <Table.Tr>
+                    <Table.Tr>
-                        <Table.Td>
+                        <Table.Td>
-                            <Trans>Toggle starred status of current entry</Trans>
+                            <Trans>Open current entry in a new tab in the background</Trans>
-                        </Table.Td>
+                        </Table.Td>
-                        <Table.Td>
+                        <Table.Td>
-                            <Kbd>S</Kbd>
+                            <Kbd>B</Kbd>
-                        </Table.Td>
+                            <span>*, </span>
-                    </Table.Tr>
+                            <Kbd>
-                    <Table.Tr>
+                                <Trans>Middle click</Trans>
-                        <Table.Td>
+                            </Kbd>
-                            <Trans>Mark all entries as read</Trans>
+                        </Table.Td>
-                        </Table.Td>
+                    </Table.Tr>
-                        <Table.Td>
+                    <Table.Tr>
-                            <Kbd>
+                        <Table.Td>
-                                <Trans>Shift</Trans>
+                            <Trans>Toggle read status of current entry</Trans>
-                            </Kbd>
+                        </Table.Td>
-                            <span> + </span>
+                        <Table.Td>
-                            <Kbd>A</Kbd>
+                            <Kbd>M</Kbd>
-                        </Table.Td>
+                            <span>, </span>
-                    </Table.Tr>
+                            <Trans>Swipe header to the left</Trans>
-                    <Table.Tr>
+                        </Table.Td>
-                        <Table.Td>
+                    </Table.Tr>
-                            <Trans>Go to the All view</Trans>
+                    <Table.Tr>
-                        </Table.Td>
+                        <Table.Td>
-                        <Table.Td>
+                            <Trans>Toggle starred status of current entry</Trans>
-                            <Kbd>G</Kbd>
+                        </Table.Td>
-                            <span> </span>
+                        <Table.Td>
-                            <Kbd>A</Kbd>
+                            <Kbd>S</Kbd>
-                        </Table.Td>
+                        </Table.Td>
-                    </Table.Tr>
+                    </Table.Tr>
-                    <Table.Tr>
+                    <Table.Tr>
-                        <Table.Td>
+                        <Table.Td>
-                            <Trans>Navigate to a subscription by entering its name</Trans>
+                            <Trans>Mark all entries as read</Trans>
-                        </Table.Td>
+                        </Table.Td>
-                        <Table.Td>
+                        <Table.Td>
-                            <Kbd>
+                            <Kbd>
-                                <Trans>Ctrl</Trans>
+                                <Trans>Shift</Trans>
-                            </Kbd>
+                            </Kbd>
-                            <span> + </span>
+                            <span> + </span>
-                            <Kbd>K</Kbd>
+                            <Kbd>A</Kbd>
-                            <span>, </span>
+                        </Table.Td>
-                            <Kbd>G</Kbd>
+                    </Table.Tr>
-                            <span> </span>
+                    <Table.Tr>
-                            <Kbd>U</Kbd>
+                        <Table.Td>
-                        </Table.Td>
+                            <Trans>Go to the All view</Trans>
-                    </Table.Tr>
+                        </Table.Td>
-                    <Table.Tr>
+                        <Table.Td>
-                        <Table.Td>
+                            <Kbd>G</Kbd>
-                            <Trans>Show entry menu (desktop)</Trans>
+                            <span> </span>
-                        </Table.Td>
+                            <Kbd>A</Kbd>
-                        <Table.Td>
+                        </Table.Td>
-                            <Kbd>
+                    </Table.Tr>
-                                <Trans>Right click</Trans>
+                    <Table.Tr>
-                            </Kbd>
+                        <Table.Td>
-                        </Table.Td>
+                            <Trans>Navigate to a subscription by entering its name</Trans>
-                    </Table.Tr>
+                        </Table.Td>
-                    <Table.Tr>
+                        <Table.Td>
-                        <Table.Td>
+                            <Kbd>{isMacOS ? <Trans>Cmd</Trans> : <Trans>Ctrl</Trans>}</Kbd>
-                            <Trans>Show native menu (desktop)</Trans>
+                            <span> + </span>
-                        </Table.Td>
+                            <Kbd>K</Kbd>
-                        <Table.Td>
+                            <span>, </span>
-                            <Kbd>
+                            <Kbd>G</Kbd>
-                                <Trans>Shift</Trans>
+                            <span> </span>
-                            </Kbd>
+                            <Kbd>U</Kbd>
-                            <span> + </span>
+                        </Table.Td>
-                            <Kbd>
+                    </Table.Tr>
-                                <Trans>Right click</Trans>
+                    <Table.Tr>
-                            </Kbd>
+                        <Table.Td>
-                        </Table.Td>
+                            <Trans>Show entry menu (desktop)</Trans>
-                    </Table.Tr>
+                        </Table.Td>
-                    <Table.Tr>
+                        <Table.Td>
-                        <Table.Td>
+                            <Kbd>
-                            <Trans>Show entry menu (mobile)</Trans>
+                                <Trans>Right click</Trans>
-                        </Table.Td>
+                            </Kbd>
-                        <Table.Td>
+                        </Table.Td>
-                            <Kbd>
+                    </Table.Tr>
-                                <Trans>Long press</Trans>
+                    <Table.Tr>
-                            </Kbd>
+                        <Table.Td>
-                        </Table.Td>
+                            <Trans>Show native menu (desktop)</Trans>
-                    </Table.Tr>
+                        </Table.Td>
-                    <Table.Tr>
+                        <Table.Td>
-                        <Table.Td>
+                            <Kbd>
-                            <Trans>Toggle sidebar</Trans>
+                                <Trans>Shift</Trans>
-                        </Table.Td>
+                            </Kbd>
-                        <Table.Td>
+                            <span> + </span>
-                            <Kbd>F</Kbd>
+                            <Kbd>
-                        </Table.Td>
+                                <Trans>Right click</Trans>
-                    </Table.Tr>
+                            </Kbd>
-                    <Table.Tr>
+                        </Table.Td>
-                        <Table.Td>
+                    </Table.Tr>
-                            <Trans>Show keyboard shortcut help</Trans>
+                    <Table.Tr>
-                        </Table.Td>
+                        <Table.Td>
-                        <Table.Td>
+                            <Trans>Show entry menu (mobile)</Trans>
-                            <Kbd>?</Kbd>
+                        </Table.Td>
-                        </Table.Td>
+                        <Table.Td>
-                    </Table.Tr>
+                            <Kbd>
-                </Table.Tbody>
+                                <Trans>Long press</Trans>
-            </Table>
+                            </Kbd>
-            <Box>
+                        </Table.Td>
-                <span>* </span>
+                    </Table.Tr>
-                <Anchor href={Constants.browserExtensionUrl} target="_blank" rel="noreferrer">
+                    <Table.Tr>
-                    <Trans>Browser extension required for Chrome</Trans>
+                        <Table.Td>
-                </Anchor>
+                            <Trans>Toggle sidebar</Trans>
-            </Box>
+                        </Table.Td>
-        </Stack>
+                        <Table.Td>
-    )
+                            <Kbd>F</Kbd>
-}
+                        </Table.Td>
+                    </Table.Tr>
+                    <Table.Tr>
+                        <Table.Td>
+                            <Trans>Show keyboard shortcut help</Trans>
+                        </Table.Td>
+                        <Table.Td>
+                            <Kbd>?</Kbd>
+                        </Table.Td>
+                    </Table.Tr>
+                </Table.Tbody>
+            </Table>
+            <Box>
+                <span>* </span>
+                <Anchor href={Constants.browserExtensionUrl} target="_blank" rel="noreferrer">
+                    <Trans>Browser extension required for Chrome</Trans>
+                </Anchor>
+            </Box>
+        </Stack>
+    )
+}

commafeed-client/src/components/Loader.tsx

@@ -1,9 +1,9 @@
-import { Center, Loader as MantineLoader } from "@mantine/core"
+import { Center, Loader as MantineLoader } from "@mantine/core"
-
+
-export function Loader() {
+export function Loader() {
-    return (
+    return (
-        <Center>
+        <Center>
-            <MantineLoader size="lg" type="bars" />
+            <MantineLoader size="lg" type="bars" />
-        </Center>
+        </Center>
-    )
+    )
-}
+}

commafeed-client/src/components/Logo.tsx

@@ -1,10 +1,10 @@
-import { Image } from "@mantine/core"
+import { Image } from "@mantine/core"
-import logo from "assets/logo.svg"
+import logo from "assets/logo.svg"
-
+
-export interface LogoProps {
+export interface LogoProps {
-    size: number
+    size: number
-}
+}
-
+
-export function Logo(props: LogoProps) {
+export function Logo(props: LogoProps) {
-    return <Image src={logo} w={props.size} />
+    return <Image src={logo} w={props.size} />
-}
+}

commafeed-client/src/components/MarkAllAsReadConfirmationDialog.tsx

@@ -0,0 +1,77 @@
+import { Trans } from "@lingui/react/macro"
+import { Button, Code, Group, Modal, Slider, Stack, Text } from "@mantine/core"
+import { setMarkAllAsReadConfirmationDialogOpen } from "app/entries/slice"
+import { markAllEntries } from "app/entries/thunks"
+import { useAppDispatch, useAppSelector } from "app/store"
+import { useState } from "react"
+
+export function MarkAllAsReadConfirmationDialog() {
+    const [threshold, setThreshold] = useState(0)
+    const open = useAppSelector(state => state.entries.markAllAsReadConfirmationDialogOpen)
+    const source = useAppSelector(state => state.entries.source)
+    const sourceLabel = useAppSelector(state => state.entries.sourceLabel)
+    const entriesTimestamp = useAppSelector(state => state.entries.timestamp) ?? Date.now()
+    const dispatch = useAppDispatch()
+
+    const onConfirm = () => {
+        dispatch(
+            markAllEntries({
+                sourceType: source.type,
+                req: {
+                    id: source.id,
+                    read: true,
+                    olderThan: Date.now() - threshold * 24 * 60 * 60 * 1000,
+                    insertedBefore: entriesTimestamp,
+                },
+            })
+        )
+        dispatch(setMarkAllAsReadConfirmationDialogOpen(false))
+    }
+
+    return (
+        <Modal
+            opened={open}
+            onClose={() => dispatch(setMarkAllAsReadConfirmationDialogOpen(false))}
+            title={<Trans>Mark all entries as read</Trans>}
+        >
+            <Stack>
+                <Text size="sm">
+                    {threshold === 0 && (
+                        <Trans>
+                            Are you sure you want to mark all entries of <Code>{sourceLabel}</Code> as read?
+                        </Trans>
+                    )}
+                    {threshold > 0 && (
+                        <Trans>
+                            Are you sure you want to mark entries older than {threshold} days of <Code>{sourceLabel}</Code> as read?
+                        </Trans>
+                    )}
+                </Text>
+                <Slider
+                    py="xl"
+                    min={0}
+                    max={28}
+                    marks={[
+                        { value: 0, label: "0" },
+                        { value: 7, label: "7" },
+                        { value: 14, label: "14" },
+                        { value: 21, label: "21" },
+                        { value: 28, label: "28" },
+                    ]}
+                    value={threshold}
+                    onChange={setThreshold}
+                    data-autofocus
+                    onKeyDown={e => e.key === "Enter" && onConfirm()}
+                />
+                <Group justify="flex-end">
+                    <Button variant="default" onClick={() => dispatch(setMarkAllAsReadConfirmationDialogOpen(false))}>
+                        <Trans>Cancel</Trans>
+                    </Button>
+                    <Button color="red" onClick={onConfirm}>
+                        <Trans>Confirm</Trans>
+                    </Button>
+                </Group>
+            </Stack>
+        </Modal>
+    )
+}

commafeed-client/src/components/RelativeDate.tsx

@@ -1,20 +1,17 @@
-import { Trans } from "@lingui/macro"
+import { Trans } from "@lingui/react/macro"
-import { Tooltip } from "@mantine/core"
+import { Tooltip } from "@mantine/core"
-import dayjs from "dayjs"
+import { Constants } from "app/constants"
-import { useEffect, useState } from "react"
+import dayjs from "dayjs"
-
+import { useNow } from "hooks/useNow"
-export function RelativeDate(props: { date: Date | number | undefined }) {
+
-    const [now, setNow] = useState(new Date())
+export function RelativeDate(props: { date: Date | number | undefined }) {
-    useEffect(() => {
+    const now = useNow(60 * 1000)
-        const interval = setInterval(() => setNow(new Date()), 60 * 1000)
+
-        return () => clearInterval(interval)
+    if (!props.date) return <Trans>N/A</Trans>
-    }, [])
+    const date = dayjs(props.date)
-
+    return (
-    if (!props.date) return <Trans>N/A</Trans>
+        <Tooltip label={date.toDate().toLocaleString()} openDelay={Constants.tooltip.delay}>
-    const date = dayjs(props.date)
+            <span>{date.from(dayjs(now))}</span>
-    return (
+        </Tooltip>
-        <Tooltip label={date.toDate().toLocaleString()} openDelay={500}>
+    )
-            <span>{date.from(dayjs(now))}</span>
+}
-        </Tooltip>
-    )
-}

commafeed-client/src/components/admin/UserEdit.tsx

@@ -1,54 +1,54 @@
-import { Trans } from "@lingui/macro"
+import { Trans } from "@lingui/react/macro"
-import { Box, Button, Checkbox, Group, PasswordInput, Stack, TextInput } from "@mantine/core"
+import { Box, Button, Checkbox, Group, PasswordInput, Stack, TextInput } from "@mantine/core"
-import { useForm } from "@mantine/form"
+import { useForm } from "@mantine/form"
-import { client, errorToStrings } from "app/client"
+import { client, errorToStrings } from "app/client"
-import { type AdminSaveUserRequest, type UserModel } from "app/types"
+import type { AdminSaveUserRequest, UserModel } from "app/types"
-import { Alert } from "components/Alert"
+import { Alert } from "components/Alert"
-import { useAsyncCallback } from "react-async-hook"
+import { useAsyncCallback } from "react-async-hook"
-import { TbDeviceFloppy } from "react-icons/tb"
+import { TbDeviceFloppy } from "react-icons/tb"
-
+
-interface UserEditProps {
+interface UserEditProps {
-    user?: UserModel
+    user?: UserModel
-    onCancel: () => void
+    onCancel: () => void
-    onSave: () => void
+    onSave: () => void
-}
+}
-
+
-export function UserEdit(props: UserEditProps) {
+export function UserEdit(props: UserEditProps) {
-    const form = useForm<AdminSaveUserRequest>({
+    const form = useForm<AdminSaveUserRequest>({
-        initialValues: props.user ?? {
+        initialValues: props.user ?? {
-            name: "",
+            name: "",
-            enabled: true,
+            enabled: true,
-            admin: false,
+            admin: false,
-        },
+        },
-    })
+    })
-    const saveUser = useAsyncCallback(client.admin.saveUser, { onSuccess: props.onSave })
+    const saveUser = useAsyncCallback(client.admin.saveUser, { onSuccess: props.onSave })
-
+
-    return (
+    return (
-        <>
+        <>
-            {saveUser.error && (
+            {saveUser.error && (
-                <Box mb="md">
+                <Box mb="md">
-                    <Alert messages={errorToStrings(saveUser.error)} />
+                    <Alert messages={errorToStrings(saveUser.error)} />
-                </Box>
+                </Box>
-            )}
+            )}
-
+
-            <form onSubmit={form.onSubmit(saveUser.execute)}>
+            <form onSubmit={form.onSubmit(saveUser.execute)}>
-                <Stack>
+                <Stack>
-                    <TextInput label={<Trans>Name</Trans>} {...form.getInputProps("name")} required />
+                    <TextInput label={<Trans>Name</Trans>} {...form.getInputProps("name")} required />
-                    <PasswordInput label={<Trans>Password</Trans>} {...form.getInputProps("password")} required={!props.user} />
+                    <PasswordInput label={<Trans>Password</Trans>} {...form.getInputProps("password")} required={!props.user} />
-                    <TextInput type="email" label={<Trans>E-mail</Trans>} {...form.getInputProps("email")} />
+                    <TextInput type="email" label={<Trans>E-mail</Trans>} {...form.getInputProps("email")} />
-                    <Checkbox label={<Trans>Admin</Trans>} {...form.getInputProps("admin", { type: "checkbox" })} />
+                    <Checkbox label={<Trans>Admin</Trans>} {...form.getInputProps("admin", { type: "checkbox" })} />
-                    <Checkbox label={<Trans>Enabled</Trans>} {...form.getInputProps("enabled", { type: "checkbox" })} />
+                    <Checkbox label={<Trans>Enabled</Trans>} {...form.getInputProps("enabled", { type: "checkbox" })} />
-
+
-                    <Group justify="right">
+                    <Group justify="right">
-                        <Button variant="default" onClick={props.onCancel}>
+                        <Button variant="default" onClick={props.onCancel}>
-                            <Trans>Cancel</Trans>
+                            <Trans>Cancel</Trans>
-                        </Button>
+                        </Button>
-                        <Button type="submit" leftSection={<TbDeviceFloppy size={16} />} loading={saveUser.loading}>
+                        <Button type="submit" leftSection={<TbDeviceFloppy size={16} />} loading={saveUser.loading}>
-                            <Trans>Save</Trans>
+                            <Trans>Save</Trans>
-                        </Button>
+                        </Button>
-                    </Group>
+                    </Group>
-                </Stack>
+                </Stack>
-            </form>
+            </form>
-        </>
+        </>
-    )
+    )
-}
+}

commafeed-client/src/components/code/CodeEditor.tsx

@@ -1,36 +1,38 @@
-import { Input, Textarea } from "@mantine/core"
+import { Input, Textarea } from "@mantine/core"
-import RichCodeEditor from "components/code/RichCodeEditor"
+import RichCodeEditor from "components/code/RichCodeEditor"
-import { useMobile } from "hooks/useMobile"
+import { useMobile } from "hooks/useMobile"
-import { type ReactNode } from "react"
+import type { ReactNode } from "react"
-
+
-interface CodeEditorProps {
+interface CodeEditorProps {
-    description?: ReactNode
+    label?: ReactNode
-    language: "css" | "javascript"
+    description?: ReactNode
-    value?: string
+    language: "css" | "javascript"
-    onChange: (value: string | undefined) => void
+    value?: string
-}
+    onChange: (value: string | undefined) => void
-
+}
-export function CodeEditor(props: CodeEditorProps) {
+
-    const mobile = useMobile()
+export function CodeEditor(props: CodeEditorProps) {
-
+    const mobile = useMobile()
-    return mobile ? (
+
-        // monaco mobile support is poor, fallback to textarea
+    return mobile ? (
-        <Textarea
+        // monaco mobile support is poor, fallback to textarea
-            autosize
+        <Textarea
-            minRows={4}
+            autosize
-            maxRows={15}
+            minRows={4}
-            description={props.description}
+            maxRows={15}
-            styles={{
+            label={props.label}
-                input: {
+            description={props.description}
-                    fontFamily: "monospace",
+            styles={{
-                },
+                input: {
-            }}
+                    fontFamily: "monospace",
-            value={props.value}
+                },
-            onChange={e => props.onChange(e.currentTarget.value)}
+            }}
-        />
+            value={props.value}
-    ) : (
+            onChange={e => props.onChange(e.currentTarget.value)}
-        <Input.Wrapper description={props.description}>
+        />
-            <RichCodeEditor height="30vh" language={props.language} value={props.value} onChange={props.onChange} />
+    ) : (
-        </Input.Wrapper>
+        <Input.Wrapper label={props.label} description={props.description}>
-    )
+            <RichCodeEditor height="30vh" language={props.language} value={props.value} onChange={props.onChange} />
-}
+        </Input.Wrapper>
+    )
+}

commafeed-client/src/components/code/RichCodeEditor.tsx

@@ -1,52 +1,51 @@
-import { Loader } from "components/Loader"
+import { Loader } from "components/Loader"
-import { useColorScheme } from "hooks/useColorScheme"
+import { useColorScheme } from "hooks/useColorScheme"
-import { useAsync } from "react-async-hook"
+import { useAsync } from "react-async-hook"
-
+
-const init = async () => {
+const init = async () => {
-    window.MonacoEnvironment = {
+    window.MonacoEnvironment = {
-        async getWorker(_, label) {
+        async getWorker(_, label) {
-            let worker
+            let worker: typeof import("*?worker")
-            if (label === "css") {
+            if (label === "css") {
-                worker = await import("monaco-editor/esm/vs/language/css/css.worker?worker")
+                worker = await import("monaco-editor/esm/vs/language/css/css.worker?worker")
-            } else if (label === "javascript") {
+            } else if (label === "javascript") {
-                worker = await import("monaco-editor/esm/vs/language/typescript/ts.worker?worker")
+                worker = await import("monaco-editor/esm/vs/language/typescript/ts.worker?worker")
-            } else {
+            } else {
-                worker = await import("monaco-editor/esm/vs/editor/editor.worker?worker")
+                worker = await import("monaco-editor/esm/vs/editor/editor.worker?worker")
-            }
+            }
-            // eslint-disable-next-line new-cap
+            return new worker.default()
-            return new worker.default()
+        },
-        },
+    }
-    }
+
-
+    const monacoReact = await import("@monaco-editor/react")
-    const monacoReact = await import("@monaco-editor/react")
+    const monaco = await import("monaco-editor")
-    const monaco = await import("monaco-editor")
+    monacoReact.loader.config({ monaco })
-    monacoReact.loader.config({ monaco })
+    return monacoReact.Editor
-    return monacoReact.Editor
+}
-}
+
-
+interface RichCodeEditorProps {
-interface RichCodeEditorProps {
+    height: number | string
-    height: number | string
+    language: "css" | "javascript"
-    language: "css" | "javascript"
+    value?: string
-    value?: string
+    onChange: (value: string | undefined) => void
-    onChange: (value: string | undefined) => void
+}
-}
+
-
+function RichCodeEditor(props: RichCodeEditorProps) {
-function RichCodeEditor(props: RichCodeEditorProps) {
+    const colorScheme = useColorScheme()
-    const colorScheme = useColorScheme()
+    const editorTheme = colorScheme === "dark" ? "vs-dark" : "light"
-    const editorTheme = colorScheme === "dark" ? "vs-dark" : "light"
+
-
+    const { result: Editor } = useAsync(init, [])
-    const { result: Editor } = useAsync(init, [])
+    if (!Editor) return <Loader />
-    if (!Editor) return <Loader />
+    return (
-    return (
+        <Editor
-        <Editor
+            height={props.height}
-            height={props.height}
+            defaultLanguage={props.language}
-            defaultLanguage={props.language}
+            theme={editorTheme}
-            theme={editorTheme}
+            options={{ minimap: { enabled: false } }}
-            options={{ minimap: { enabled: false } }}
+            value={props.value}
-            value={props.value}
+            onChange={props.onChange}
-            onChange={props.onChange}
+        />
-        />
+    )
-    )
+}
-}
+
-
+export default RichCodeEditor
-export default RichCodeEditor

commafeed-client/src/components/content/BasicHtmlStyles.tsx

@@ -1,11 +1,24 @@
-import { TypographyStylesProvider } from "@mantine/core"
+import { TypographyStylesProvider } from "@mantine/core"
-import { type ReactNode } from "react"
+import type { ReactNode } from "react"
-
+import { tss } from "tss"
-/**
+
- * This component is used to provide basic styles to html typography elements.
+/**
- *
+ * This component is used to provide basic styles to html typography elements.
- * see https://mantine.dev/core/typography-styles-provider/
+ *
- */
+ * see https://mantine.dev/core/typography-styles-provider/
-export const BasicHtmlStyles = (props: { children: ReactNode }) => {
+ */
-    return <TypographyStylesProvider pl={0}>{props.children}</TypographyStylesProvider>
+
-}
+const useStyles = tss.create(() => ({
+    // override mantine default typography styles
+    content: {
+        paddingLeft: 0,
+        "& img": {
+            marginBottom: 0,
+        },
+    },
+}))
+
+export const BasicHtmlStyles = (props: { children: ReactNode }) => {
+    const { classes } = useStyles()
+    return <TypographyStylesProvider className={classes.content}>{props.children}</TypographyStylesProvider>
+}

commafeed-client/src/components/content/Content.test.tsx

@@ -0,0 +1,26 @@
+import { MantineProvider } from "@mantine/core"
+import { render } from "@testing-library/react"
+import { Content } from "components/content/Content"
+import { describe, expect, it } from "vitest"
+
+describe("Content component", () => {
+    it("renders basic content", () => {
+        const { container } = render(<Content content="<p>Hello World</p>" />, { wrapper: MantineProvider })
+        expect(container.querySelector("p")).toHaveTextContent("Hello World")
+    })
+
+    it("renders highlighted text when highlight prop is provided", () => {
+        const { container } = render(<Content content="Hello World" highlight="World" />, { wrapper: MantineProvider })
+        expect(container.querySelector("mark")).toHaveTextContent("World")
+    })
+
+    it("renders iframe tag when included in content", () => {
+        const { container } = render(<Content content='<iframe src="https://example.com"></iframe>' />, { wrapper: MantineProvider })
+        expect(container.querySelector("iframe")).toHaveAttribute("src", "https://example.com")
+    })
+
+    it("does not render unsupported tags", () => {
+        const { container } = render(<Content content='<script>alert("test")</script>' />, { wrapper: MantineProvider })
+        expect(container.querySelector("script")).toBeNull()
+    })
+})

commafeed-client/src/components/content/Content.tsx

@@ -1,103 +1,108 @@
-import { Box, Mark } from "@mantine/core"
+import { Box, Mark } from "@mantine/core"
-import { Constants } from "app/constants"
+import { Constants } from "app/constants"
-import { calculatePlaceholderSize } from "app/utils"
+import { calculatePlaceholderSize } from "app/utils"
-import { BasicHtmlStyles } from "components/content/BasicHtmlStyles"
+import { ImageWithPlaceholderWhileLoading } from "components/ImageWithPlaceholderWhileLoading"
-import { ImageWithPlaceholderWhileLoading } from "components/ImageWithPlaceholderWhileLoading"
+import { BasicHtmlStyles } from "components/content/BasicHtmlStyles"
-import escapeStringRegexp from "escape-string-regexp"
+import escapeStringRegexp from "escape-string-regexp"
-import { type ChildrenNode, Interweave, Matcher, type MatchResponse, type Node, type TransformCallback } from "interweave"
+import { ALLOWED_TAG_LIST, type ChildrenNode, Interweave, type MatchResponse, Matcher, type Node, type TransformCallback } from "interweave"
-import React from "react"
+import React from "react"
-import { tss } from "tss"
+import styleToObject from "style-to-object"
-
+import { tss } from "tss"
-export interface ContentProps {
+
-    content: string
+export interface ContentProps {
-    highlight?: string
+    content: string
-}
+    highlight?: string
-
+}
-const useStyles = tss.create(() => ({
+
-    content: {
+const useStyles = tss.create(() => ({
-        // break long links or long words
+    content: {
-        overflowWrap: "anywhere",
+        // break long links or long words
-        "& a": {
+        overflowWrap: "anywhere",
-            color: "inherit",
+        "& a": {
-            textDecoration: "underline",
+            color: "inherit",
-        },
+            textDecoration: "underline",
-        "& iframe": {
+        },
-            maxWidth: "100%",
+        "& iframe": {
-        },
+            maxWidth: "100%",
-        "& pre, & code": {
+        },
-            whiteSpace: "pre-wrap",
+        "& pre, & code": {
-        },
+            whiteSpace: "pre-wrap",
-    },
+        },
-}))
+    },
-
+}))
-const transform: TransformCallback = node => {
+
-    if (node.tagName === "IMG") {
+const transform: TransformCallback = node => {
-        // show placeholders for loading img tags, this allows the entry to have its final height immediately
+    if (node.tagName === "IMG") {
-        const src = node.getAttribute("src") ?? undefined
+        // show placeholders for loading img tags, this allows the entry to have its final height immediately
-        if (!src) return undefined
+        const src = node.getAttribute("src") ?? undefined
-
+        if (!src) return undefined
-        const alt = node.getAttribute("alt") ?? "image"
+
-        const title = node.getAttribute("title") ?? undefined
+        const alt = node.getAttribute("alt") ?? "image"
-        const nodeWidth = node.getAttribute("width")
+        const title = node.getAttribute("title") ?? undefined
-        const nodeHeight = node.getAttribute("height")
+        const nodeWidth = node.getAttribute("width")
-        const width = nodeWidth ? parseInt(nodeWidth, 10) : undefined
+        const nodeHeight = node.getAttribute("height")
-        const height = nodeHeight ? parseInt(nodeHeight, 10) : undefined
+        const width = nodeWidth ? Number.parseInt(nodeWidth, 10) : undefined
-        const placeholderSize = calculatePlaceholderSize({
+        const height = nodeHeight ? Number.parseInt(nodeHeight, 10) : undefined
-            width,
+        const style = styleToObject(node.getAttribute("style") ?? "") ?? undefined
-            height,
+        const placeholderSize = calculatePlaceholderSize({
-            maxWidth: Constants.layout.entryMaxWidth,
+            width,
-        })
+            height,
-
+            maxWidth: Constants.layout.entryMaxWidth,
-        return (
+        })
-            <ImageWithPlaceholderWhileLoading
+
-                src={src}
+        return (
-                alt={alt}
+            <ImageWithPlaceholderWhileLoading
-                title={title}
+                src={src}
-                width={width}
+                alt={alt}
-                height="auto"
+                title={title}
-                placeholderWidth={placeholderSize.width}
+                width={width}
-                placeholderHeight={placeholderSize.height}
+                height="auto"
-            />
+                style={style}
-        )
+                placeholderWidth={placeholderSize.width}
-    }
+                placeholderHeight={placeholderSize.height}
-    return undefined
+            />
-}
+        )
-
+    }
-class HighlightMatcher extends Matcher {
+    return undefined
-    private readonly search: string
+}
-
+
-    constructor(search: string) {
+class HighlightMatcher extends Matcher {
-        super("highlight")
+    private readonly regexp: RegExp
-        this.search = escapeStringRegexp(search)
+
-    }
+    constructor(search: string) {
-
+        super("highlight")
-    match(string: string): MatchResponse<unknown> | null {
+        this.regexp = new RegExp(escapeStringRegexp(search).split(" ").join("|"), "i")
-        const pattern = this.search.split(" ").join("|")
+    }
-        return this.doMatch(string, new RegExp(pattern, "i"), () => ({}))
+
-    }
+    match(string: string): MatchResponse<unknown> | null {
-
+        return this.doMatch(string, this.regexp, () => ({}))
-    replaceWith(children: ChildrenNode): Node {
+    }
-        return <Mark>{children}</Mark>
+
-    }
+    replaceWith(children: ChildrenNode): Node {
-
+        return <Mark key={0}>{children}</Mark>
-    asTag(): string {
+    }
-        return "span"
+
-    }
+    asTag(): string {
-}
+        return "span"
-
+    }
-// memoize component because Interweave is costly
+}
-const Content = React.memo((props: ContentProps) => {
+
-    const { classes } = useStyles()
+// allow iframe tag
-    const matchers = props.highlight ? [new HighlightMatcher(props.highlight)] : []
+const allowList = [...ALLOWED_TAG_LIST, "iframe"]
-
+
-    return (
+// memoize component because Interweave is costly
-        <BasicHtmlStyles>
+const Content = React.memo((props: ContentProps) => {
-            <Box className={classes.content}>
+    const { classes } = useStyles()
-                <Interweave content={props.content} transform={transform} matchers={matchers} />
+    const matchers = props.highlight ? [new HighlightMatcher(props.highlight)] : []
-            </Box>
+
-        </BasicHtmlStyles>
+    return (
-    )
+        <BasicHtmlStyles>
-})
+            <Box className={classes.content}>
-Content.displayName = "Content"
+                <Interweave content={props.content} transform={transform} matchers={matchers} allowList={allowList} />
-
+            </Box>
-export { Content }
+        </BasicHtmlStyles>
+    )
+})
+Content.displayName = "Content"
+
+export { Content }

commafeed-client/src/components/content/Enclosure.tsx

@@ -1,24 +1,29 @@
-import { BasicHtmlStyles } from "components/content/BasicHtmlStyles"
+import { ImageWithPlaceholderWhileLoading } from "components/ImageWithPlaceholderWhileLoading"
-import { ImageWithPlaceholderWhileLoading } from "components/ImageWithPlaceholderWhileLoading"
+import { BasicHtmlStyles } from "components/content/BasicHtmlStyles"
-
+
-export function Enclosure(props: { enclosureType: string; enclosureUrl: string }) {
+export function Enclosure(props: {
-    const hasVideo = props.enclosureType.startsWith("video")
+    enclosureType: string
-    const hasAudio = props.enclosureType.startsWith("audio")
+    enclosureUrl: string
-    const hasImage = props.enclosureType.startsWith("image")
+}) {
-
+    const hasVideo = props.enclosureType.startsWith("video")
-    return (
+    const hasAudio = props.enclosureType.startsWith("audio")
-        <BasicHtmlStyles>
+    const hasImage = props.enclosureType.startsWith("image")
-            {hasVideo && (
+
-                <video controls width="100%">
+    return (
-                    <source src={props.enclosureUrl} type={props.enclosureType} />
+        <BasicHtmlStyles>
-                </video>
+            {hasVideo && (
-            )}
+                // biome-ignore lint/a11y/useMediaCaption: we don't have any captions for videos
-            {hasAudio && (
+                <video controls width="100%">
-                <audio controls>
+                    <source src={props.enclosureUrl} type={props.enclosureType} />
-                    <source src={props.enclosureUrl} type={props.enclosureType} />
+                </video>
-                </audio>
+            )}
-            )}
+            {hasAudio && (
-            {hasImage && <ImageWithPlaceholderWhileLoading src={props.enclosureUrl} alt="enclosure" />}
+                // biome-ignore lint/a11y/useMediaCaption: we don't have any captions for audio
-        </BasicHtmlStyles>
+                <audio controls style={{ width: "100%" }}>
-    )
+                    <source src={props.enclosureUrl} type={props.enclosureType} />
-}
+                </audio>
+            )}
+            {hasImage && <ImageWithPlaceholderWhileLoading src={props.enclosureUrl} alt="enclosure" />}
+        </BasicHtmlStyles>
+    )
+}

commafeed-client/src/components/content/FeedEntries.tsx

@@ -1,329 +1,313 @@
-import { Trans } from "@lingui/macro"
+import { Trans } from "@lingui/react/macro"
-import { Box } from "@mantine/core"
+import { Box } from "@mantine/core"
-import { openModal } from "@mantine/modals"
+import { openModal } from "@mantine/modals"
-import { Constants } from "app/constants"
+import { Constants } from "app/constants"
-import { type ExpendableEntry } from "app/entries/slice"
+import type { ExpendableEntry } from "app/entries/slice"
-import {
+import {
-    loadMoreEntries,
+    loadMoreEntries,
-    markAllEntries,
+    markAllAsReadWithConfirmationIfRequired,
-    markEntry,
+    markEntry,
-    reloadEntries,
+    reloadEntries,
-    selectEntry,
+    selectEntry,
-    selectNextEntry,
+    selectNextEntry,
-    selectPreviousEntry,
+    selectPreviousEntry,
-    starEntry,
+    starEntry,
-} from "app/entries/thunks"
+} from "app/entries/thunks"
-import { redirectToRootCategory } from "app/redirect/thunks"
+import { redirectToRootCategory } from "app/redirect/thunks"
-import { useAppDispatch, useAppSelector } from "app/store"
+import { useAppDispatch, useAppSelector } from "app/store"
-import { toggleSidebar } from "app/tree/slice"
+import { toggleSidebar } from "app/tree/slice"
-import { KeyboardShortcutsHelp } from "components/KeyboardShortcutsHelp"
+import { selectNextUnreadTreeItem } from "app/tree/thunks"
-import { Loader } from "components/Loader"
+import { KeyboardShortcutsHelp } from "components/KeyboardShortcutsHelp"
-import { useBrowserExtension } from "hooks/useBrowserExtension"
+import { Loader } from "components/Loader"
-import { useMousetrap } from "hooks/useMousetrap"
+import { useBrowserExtension } from "hooks/useBrowserExtension"
-import { useViewMode } from "hooks/useViewMode"
+import { useMousetrap } from "hooks/useMousetrap"
-import { useEffect } from "react"
+import { useEffect } from "react"
-import { useContextMenu } from "react-contexify"
+import { useContextMenu } from "react-contexify"
-import InfiniteScroll from "react-infinite-scroller"
+import InfiniteScroll from "react-infinite-scroller"
-import { throttle } from "throttle-debounce"
+import { throttle } from "throttle-debounce"
-import { FeedEntry } from "./FeedEntry"
+import { FeedEntry } from "./FeedEntry"
-
+
-export function FeedEntries() {
+export function FeedEntries() {
-    const source = useAppSelector(state => state.entries.source)
+    const entries = useAppSelector(state => state.entries.entries)
-    const entries = useAppSelector(state => state.entries.entries)
+    const selectedEntryId = useAppSelector(state => state.entries.selectedEntryId)
-    const entriesTimestamp = useAppSelector(state => state.entries.timestamp)
+    const hasMore = useAppSelector(state => state.entries.hasMore)
-    const selectedEntryId = useAppSelector(state => state.entries.selectedEntryId)
+    const loading = useAppSelector(state => state.entries.loading)
-    const hasMore = useAppSelector(state => state.entries.hasMore)
+    const scrollMarks = useAppSelector(state => state.user.settings?.scrollMarks)
-    const loading = useAppSelector(state => state.entries.loading)
+    const scrollingToEntry = useAppSelector(state => state.entries.scrollingToEntry)
-    const scrollMarks = useAppSelector(state => state.user.settings?.scrollMarks)
+    const sidebarVisible = useAppSelector(state => state.tree.sidebarVisible)
-    const scrollingToEntry = useAppSelector(state => state.entries.scrollingToEntry)
+    const customContextMenu = useAppSelector(state => state.user.settings?.customContextMenu)
-    const sidebarVisible = useAppSelector(state => state.tree.sidebarVisible)
+    const viewMode = useAppSelector(state => state.user.localSettings.viewMode)
-    const customContextMenu = useAppSelector(state => state.user.settings?.customContextMenu)
+    const dispatch = useAppDispatch()
-    const { viewMode } = useViewMode()
+    const { openLinkInBackgroundTab } = useBrowserExtension()
-    const dispatch = useAppDispatch()
+
-    const { openLinkInBackgroundTab } = useBrowserExtension()
+    const selectedEntry = entries.find(e => e.id === selectedEntryId)
-
+
-    const selectedEntry = entries.find(e => e.id === selectedEntryId)
+    const headerClicked = (entry: ExpendableEntry, event: React.MouseEvent) => {
-
+        const middleClick = event.button === 1 || event.ctrlKey || event.metaKey
-    const headerClicked = (entry: ExpendableEntry, event: React.MouseEvent) => {
+        if (middleClick || viewMode === "expanded") {
-        const middleClick = event.button === 1 || event.ctrlKey || event.metaKey
+            dispatch(markEntry({ entry, read: true }))
-        if (middleClick || viewMode === "expanded") {
+        } else if (event.button === 0) {
-            dispatch(markEntry({ entry, read: true }))
+            // main click
-        } else if (event.button === 0) {
+            // don't trigger the link
-            // main click
+            event.preventDefault()
-            // don't trigger the link
+
-            event.preventDefault()
+            dispatch(
-
+                selectEntry({
-            dispatch(
+                    entry,
-                selectEntry({
+                    expand: !entry.expanded,
-                    entry,
+                    markAsRead: !entry.expanded,
-                    expand: !entry.expanded,
+                    scrollToEntry: true,
-                    markAsRead: !entry.expanded,
+                })
-                    scrollToEntry: true,
+            )
-                })
+        }
-            )
+    }
-        }
+
-    }
+    const contextMenu = useContextMenu()
-
+    const headerRightClicked = (entry: ExpendableEntry, event: React.MouseEvent) => {
-    const contextMenu = useContextMenu()
+        if (event.shiftKey || !customContextMenu) return
-    const headerRightClicked = (entry: ExpendableEntry, event: React.MouseEvent) => {
+
-        if (event.shiftKey || !customContextMenu) return
+        event.preventDefault()
-
+        contextMenu.show({
-        event.preventDefault()
+            id: Constants.dom.entryContextMenuId(entry),
-        contextMenu.show({
+            event,
-            id: Constants.dom.entryContextMenuId(entry),
+        })
-            event,
+    }
-        })
+
-    }
+    const bodyClicked = (entry: ExpendableEntry) => {
-
+        if (viewMode !== "expanded") return
-    const bodyClicked = (entry: ExpendableEntry) => {
+
-        if (viewMode !== "expanded") return
+        // entry is already selected
-
+        if (entry.id === selectedEntryId) return
-        // entry is already selected
+
-        if (entry.id === selectedEntryId) return
+        dispatch(
-
+            selectEntry({
-        dispatch(
+                entry,
-            selectEntry({
+                expand: true,
-                entry,
+                markAsRead: true,
-                expand: true,
+                scrollToEntry: true,
-                markAsRead: true,
+            })
-                scrollToEntry: true,
+        )
-            })
+    }
-        )
+
-    }
+    const swipedLeft = async (entry: ExpendableEntry) => await dispatch(markEntry({ entry, read: !entry.read }))
-
+
-    const swipedLeft = async (entry: ExpendableEntry) => await dispatch(markEntry({ entry, read: !entry.read }))
+    // close context menu on scroll
-
+    useEffect(() => {
-    // close context menu on scroll
+        const listener = throttle(100, () => contextMenu.hideAll())
-    useEffect(() => {
+        window.addEventListener("scroll", listener)
-        const listener = throttle(100, () => contextMenu.hideAll())
+        return () => window.removeEventListener("scroll", listener)
-        window.addEventListener("scroll", listener)
+    }, [contextMenu])
-        return () => window.removeEventListener("scroll", listener)
+
-    }, [contextMenu])
+    useEffect(() => {
-
+        const listener = throttle(100, () => {
-    useEffect(() => {
+            if (viewMode !== "expanded") return
-        const listener = throttle(100, () => {
+            if (scrollingToEntry) return
-            if (viewMode !== "expanded") return
+
-            if (scrollingToEntry) return
+            const currentEntry = entries
-
+                // use slice to get a copy of the array because reverse mutates the array in-place
-            const currentEntry = entries
+                .slice()
-                // use slice to get a copy of the array because reverse mutates the array in-place
+                .reverse()
-                .slice()
+                .find(e => {
-                .reverse()
+                    const el = document.getElementById(Constants.dom.entryId(e))
-                .find(e => {
+                    return el && !Constants.layout.isTopVisible(el)
-                    const el = document.getElementById(Constants.dom.entryId(e))
+                })
-                    return el && !Constants.layout.isTopVisible(el)
+            if (currentEntry) {
-                })
+                dispatch(
-            if (currentEntry) {
+                    selectEntry({
-                dispatch(
+                        entry: currentEntry,
-                    selectEntry({
+                        expand: false,
-                        entry: currentEntry,
+                        markAsRead: !!scrollMarks,
-                        expand: false,
+                        scrollToEntry: false,
-                        markAsRead: !!scrollMarks,
+                    })
-                        scrollToEntry: false,
+                )
-                    })
+            }
-                )
+        })
-            }
+        window.addEventListener("scroll", listener)
-        })
+        return () => window.removeEventListener("scroll", listener)
-        window.addEventListener("scroll", listener)
+    }, [dispatch, entries, viewMode, scrollMarks, scrollingToEntry])
-        return () => window.removeEventListener("scroll", listener)
+
-    }, [dispatch, contextMenu, entries, viewMode, scrollMarks, scrollingToEntry])
+    useMousetrap("r", async () => await dispatch(reloadEntries()))
-
+    useMousetrap(
-    useMousetrap("r", async () => await dispatch(reloadEntries()))
+        "j",
-    useMousetrap(
+        async () =>
-        "j",
+            await dispatch(
-        async () =>
+                selectNextEntry({
-            await dispatch(
+                    expand: true,
-                selectNextEntry({
+                    markAsRead: true,
-                    expand: true,
+                    scrollToEntry: true,
-                    markAsRead: true,
+                })
-                    scrollToEntry: true,
+            )
-                })
+    )
-            )
+    useMousetrap(
-    )
+        "n",
-    useMousetrap(
+        async () =>
-        "n",
+            await dispatch(
-        async () =>
+                selectNextEntry({
-            await dispatch(
+                    expand: false,
-                selectNextEntry({
+                    markAsRead: false,
-                    expand: false,
+                    scrollToEntry: true,
-                    markAsRead: false,
+                })
-                    scrollToEntry: true,
+            )
-                })
+    )
-            )
+    useMousetrap(
-    )
+        "k",
-    useMousetrap(
+        async () =>
-        "k",
+            await dispatch(
-        async () =>
+                selectPreviousEntry({
-            await dispatch(
+                    expand: true,
-                selectPreviousEntry({
+                    markAsRead: true,
-                    expand: true,
+                    scrollToEntry: true,
-                    markAsRead: true,
+                })
-                    scrollToEntry: true,
+            )
-                })
+    )
-            )
+    useMousetrap(
-    )
+        "p",
-    useMousetrap(
+        async () =>
-        "p",
+            await dispatch(
-        async () =>
+                selectPreviousEntry({
-            await dispatch(
+                    expand: false,
-                selectPreviousEntry({
+                    markAsRead: false,
-                    expand: false,
+                    scrollToEntry: true,
-                    markAsRead: false,
+                })
-                    scrollToEntry: true,
+            )
-                })
+    )
-            )
+    useMousetrap("shift+j", async () => await dispatch(selectNextUnreadTreeItem({ direction: "forward" })))
-    )
+    useMousetrap("shift+k", async () => await dispatch(selectNextUnreadTreeItem({ direction: "backward" })))
-    useMousetrap("space", () => {
+    useMousetrap("space", () => {
-        if (selectedEntry) {
+        if (selectedEntry) {
-            if (selectedEntry.expanded) {
+            if (selectedEntry.expanded) {
-                const entryElement = document.getElementById(Constants.dom.entryId(selectedEntry))
+                const entryElement = document.getElementById(Constants.dom.entryId(selectedEntry))
-                if (entryElement && Constants.layout.isBottomVisible(entryElement)) {
+                if (entryElement && Constants.layout.isBottomVisible(entryElement)) {
-                    dispatch(
+                    dispatch(
-                        selectNextEntry({
+                        selectNextEntry({
-                            expand: true,
+                            expand: true,
-                            markAsRead: true,
+                            markAsRead: true,
-                            scrollToEntry: true,
+                            scrollToEntry: true,
-                        })
+                        })
-                    )
+                    )
-                } else {
+                } else {
-                    window.scrollTo({
+                    window.scrollTo({
-                        top: window.scrollY + document.documentElement.clientHeight * 0.8,
+                        top: window.scrollY + document.documentElement.clientHeight * 0.8,
-                        behavior: "smooth",
+                        behavior: "smooth",
-                    })
+                    })
-                }
+                }
-            } else {
+            } else {
-                dispatch(
+                dispatch(
-                    selectEntry({
+                    selectEntry({
-                        entry: selectedEntry,
+                        entry: selectedEntry,
-                        expand: true,
+                        expand: true,
-                        markAsRead: true,
+                        markAsRead: true,
-                        scrollToEntry: true,
+                        scrollToEntry: true,
-                    })
+                    })
-                )
+                )
-            }
+            }
-        } else {
+        } else {
-            dispatch(
+            dispatch(
-                selectNextEntry({
+                selectNextEntry({
-                    expand: true,
+                    expand: true,
-                    markAsRead: true,
+                    markAsRead: true,
-                    scrollToEntry: true,
+                    scrollToEntry: true,
-                })
+                })
-            )
+            )
-        }
+        }
-    })
+    })
-    useMousetrap("shift+space", () => {
+    useMousetrap("shift+space", () => {
-        if (selectedEntry) {
+        if (selectedEntry) {
-            if (selectedEntry.expanded) {
+            if (selectedEntry.expanded) {
-                const entryElement = document.getElementById(Constants.dom.entryId(selectedEntry))
+                const entryElement = document.getElementById(Constants.dom.entryId(selectedEntry))
-                if (entryElement && Constants.layout.isTopVisible(entryElement)) {
+                if (entryElement && Constants.layout.isTopVisible(entryElement)) {
-                    dispatch(
+                    dispatch(
-                        selectPreviousEntry({
+                        selectPreviousEntry({
-                            expand: true,
+                            expand: true,
-                            markAsRead: true,
+                            markAsRead: true,
-                            scrollToEntry: true,
+                            scrollToEntry: true,
-                        })
+                        })
-                    )
+                    )
-                } else {
+                } else {
-                    window.scrollTo({
+                    window.scrollTo({
-                        top: window.scrollY - document.documentElement.clientHeight * 0.8,
+                        top: window.scrollY - document.documentElement.clientHeight * 0.8,
-                        behavior: "smooth",
+                        behavior: "smooth",
-                    })
+                    })
-                }
+                }
-            } else {
+            } else {
-                dispatch(
+                dispatch(
-                    selectPreviousEntry({
+                    selectPreviousEntry({
-                        expand: true,
+                        expand: true,
-                        markAsRead: true,
+                        markAsRead: true,
-                        scrollToEntry: true,
+                        scrollToEntry: true,
-                    })
+                    })
-                )
+                )
-            }
+            }
-        }
+        }
-    })
+    })
-    useMousetrap(["o", "enter"], () => {
+    useMousetrap(["o", "enter"], () => {
-        // toggle expanded status
+        // toggle expanded status
-        if (!selectedEntry) return
+        if (!selectedEntry) return
-        dispatch(
+        dispatch(
-            selectEntry({
+            selectEntry({
-                entry: selectedEntry,
+                entry: selectedEntry,
-                expand: !selectedEntry.expanded,
+                expand: !selectedEntry.expanded,
-                markAsRead: !selectedEntry.expanded,
+                markAsRead: !selectedEntry.expanded,
-                scrollToEntry: true,
+                scrollToEntry: true,
-            })
+            })
-        )
+        )
-    })
+    })
-    useMousetrap("v", () => {
+    useMousetrap("v", () => {
-        // open tab in foreground
+        // open tab in foreground
-        if (!selectedEntry) return
+        if (!selectedEntry) return
-        window.open(selectedEntry.url, "_blank", "noreferrer")
+        window.open(selectedEntry.url, "_blank", "noreferrer")
-    })
+    })
-    useMousetrap("b", () => {
+    useMousetrap("b", () => {
-        if (!selectedEntry) return
+        if (!selectedEntry) return
-        openLinkInBackgroundTab(selectedEntry.url)
+        openLinkInBackgroundTab(selectedEntry.url)
-    })
+    })
-    useMousetrap("m", () => {
+    useMousetrap("m", () => {
-        // toggle read status
+        // toggle read status
-        if (!selectedEntry) return
+        if (!selectedEntry) return
-        dispatch(markEntry({ entry: selectedEntry, read: !selectedEntry.read }))
+        dispatch(markEntry({ entry: selectedEntry, read: !selectedEntry.read }))
-    })
+    })
-    useMousetrap("s", () => {
+    useMousetrap("s", () => {
-        // toggle starred status
+        // toggle starred status
-        if (!selectedEntry) return
+        if (!selectedEntry) return
-        dispatch(starEntry({ entry: selectedEntry, starred: !selectedEntry.starred }))
+        dispatch(starEntry({ entry: selectedEntry, starred: !selectedEntry.starred }))
-    })
+    })
-    useMousetrap("shift+a", () => {
+    useMousetrap("shift+a", () => {
-        // mark all entries as read
+        // mark all entries as read
-        dispatch(
+        dispatch(markAllAsReadWithConfirmationIfRequired())
-            markAllEntries({
+    })
-                sourceType: source.type,
+    useMousetrap("g a", async () => await dispatch(redirectToRootCategory()))
-                req: {
+    useMousetrap("f", () => dispatch(toggleSidebar()))
-                    id: source.id,
+    useMousetrap("?", () =>
-                    read: true,
+        openModal({
-                    olderThan: Date.now(),
+            title: <Trans>Keyboard shortcuts</Trans>,
-                    insertedBefore: entriesTimestamp,
+            size: "xl",
-                },
+            children: <KeyboardShortcutsHelp />,
-            })
+        })
-        )
+    )
-    })
+
-    useMousetrap("g a", async () => await dispatch(redirectToRootCategory()))
+    return (
-    useMousetrap("f", () => dispatch(toggleSidebar()))
+        <InfiniteScroll
-    useMousetrap("?", () =>
+            id="entries"
-        openModal({
+            className={`cf-entries cf-view-mode-${viewMode}`}
-            title: <Trans>Keyboard shortcuts</Trans>,
+            initialLoad={false}
-            size: "xl",
+            loadMore={async () => await (!loading && dispatch(loadMoreEntries()))}
-            children: <KeyboardShortcutsHelp />,
+            hasMore={hasMore}
-        })
+            loader={<Box key={0}>{loading && <Loader />}</Box>}
-    )
+        >
-
+            {entries.map(entry => (
-    return (
+                <FeedEntry
-        <InfiniteScroll
+                    key={entry.id}
-            id="entries"
+                    entry={entry}
-            className={`view-mode-${viewMode}`}
+                    expanded={!!entry.expanded || viewMode === "expanded"}
-            initialLoad={false}
+                    selected={entry.id === selectedEntryId}
-            loadMore={async () => await (!loading && dispatch(loadMoreEntries()))}
+                    showSelectionIndicator={entry.id === selectedEntryId && (!entry.expanded || viewMode === "expanded")}
-            hasMore={hasMore}
+                    maxWidth={sidebarVisible ? Constants.layout.entryMaxWidth : undefined}
-            loader={<Box key={0}>{loading && <Loader />}</Box>}
+                    onHeaderClick={event => headerClicked(entry, event)}
-        >
+                    onHeaderRightClick={event => headerRightClicked(entry, event)}
-            {entries.map(entry => (
+                    onBodyClick={() => bodyClicked(entry)}
-                <div
+                    onSwipedLeft={async () => await swipedLeft(entry)}
-                    key={entry.id}
+                />
-                    ref={el => {
+            ))}
-                        if (el) el.id = Constants.dom.entryId(entry)
+        </InfiniteScroll>
-                    }}
+    )
-                >
+}
-                    <FeedEntry
-                        entry={entry}
-                        expanded={!!entry.expanded || viewMode === "expanded"}
-                        selected={entry.id === selectedEntryId}
-                        showSelectionIndicator={entry.id === selectedEntryId && (!entry.expanded || viewMode === "expanded")}
-                        maxWidth={sidebarVisible ? Constants.layout.entryMaxWidth : undefined}
-                        onHeaderClick={event => headerClicked(entry, event)}
-                        onHeaderRightClick={event => headerRightClicked(entry, event)}
-                        onBodyClick={() => bodyClicked(entry)}
-                        onSwipedLeft={async () => await swipedLeft(entry)}
-                    />
-                </div>
-            ))}
-        </InfiniteScroll>
-    )
-}

commafeed-client/src/components/content/FeedEntry.tsx

@@ -1,167 +1,198 @@
-import { Box, Divider, type MantineRadius, type MantineSpacing, Paper } from "@mantine/core"
+import { Box, Divider, type MantineRadius, type MantineSpacing, Paper } from "@mantine/core"
-import { Constants } from "app/constants"
+import { Constants } from "app/constants"
-import { type Entry, type ViewMode } from "app/types"
+import { useAppSelector } from "app/store"
-import { useViewMode } from "hooks/useViewMode"
+import type { Entry, ViewMode } from "app/types"
-import React from "react"
+import { FeedEntryCompactHeader } from "components/content/header/FeedEntryCompactHeader"
-import { useSwipeable } from "react-swipeable"
+import { FeedEntryHeader } from "components/content/header/FeedEntryHeader"
-import { tss } from "tss"
+import { useMobile } from "hooks/useMobile"
-import { FeedEntryBody } from "./FeedEntryBody"
+import type React from "react"
-import { FeedEntryCompactHeader } from "./FeedEntryCompactHeader"
+import { useSwipeable } from "react-swipeable"
-import { FeedEntryContextMenu } from "./FeedEntryContextMenu"
+import { tss } from "tss"
-import { FeedEntryFooter } from "./FeedEntryFooter"
+import { FeedEntryBody } from "./FeedEntryBody"
-import { FeedEntryHeader } from "./FeedEntryHeader"
+import { FeedEntryContextMenu } from "./FeedEntryContextMenu"
-
+import { FeedEntryFooter } from "./FeedEntryFooter"
-interface FeedEntryProps {
+
-    entry: Entry
+interface FeedEntryProps {
-    expanded: boolean
+    entry: Entry
-    selected: boolean
+    expanded: boolean
-    showSelectionIndicator: boolean
+    selected: boolean
-    maxWidth?: number
+    showSelectionIndicator: boolean
-    onHeaderClick: (e: React.MouseEvent) => void
+    maxWidth?: number
-    onHeaderRightClick: (e: React.MouseEvent) => void
+    onHeaderClick: (e: React.MouseEvent) => void
-    onBodyClick: (e: React.MouseEvent) => void
+    onHeaderRightClick: (e: React.MouseEvent) => void
-    onSwipedLeft: () => void
+    onBodyClick: (e: React.MouseEvent) => void
-}
+    onSwipedLeft: () => void
-
+}
-const useStyles = tss
+
-    .withParams<{
+const useStyles = tss
-        read: boolean
+    .withParams<{
-        expanded: boolean
+        read: boolean
-        viewMode: ViewMode
+        expanded: boolean
-        rtl: boolean
+        viewMode: ViewMode
-        showSelectionIndicator: boolean
+        rtl: boolean
-        maxWidth?: number
+        showSelectionIndicator: boolean
-    }>()
+        maxWidth?: number
-    .create(({ theme, colorScheme, read, expanded, viewMode, rtl, showSelectionIndicator, maxWidth }) => {
+        fontSizePercentage: number
-        let backgroundColor
+    }>()
-        if (colorScheme === "dark") {
+    .create(({ theme, colorScheme, read, expanded, viewMode, rtl, showSelectionIndicator, maxWidth, fontSizePercentage }) => {
-            backgroundColor = read ? "inherit" : theme.colors.dark[5]
+        let backgroundColor: string
-        } else {
+        if (colorScheme === "dark") {
-            backgroundColor = read && !expanded ? theme.colors.gray[0] : "inherit"
+            backgroundColor = read ? "inherit" : theme.colors.dark[5]
-        }
+        } else {
-
+            backgroundColor = read && !expanded ? theme.colors.gray[0] : "inherit"
-        let marginY = 10
+        }
-        if (viewMode === "title") {
+
-            marginY = 2
+        let marginY = 10
-        } else if (viewMode === "cozy") {
+        if (viewMode === "title") {
-            marginY = 6
+            marginY = 2
-        }
+        } else if (viewMode === "cozy") {
-
+            marginY = 6
-        let mobileMarginY = 6
+        }
-        if (viewMode === "title") {
+
-            mobileMarginY = 2
+        let mobileMarginY = 6
-        } else if (viewMode === "cozy") {
+        if (viewMode === "title") {
-            mobileMarginY = 4
+            mobileMarginY = 2
-        }
+        } else if (viewMode === "cozy") {
-
+            mobileMarginY = 4
-        let backgroundHoverColor = backgroundColor
+        }
-        if (!expanded && !read) {
+
-            backgroundHoverColor = colorScheme === "dark" ? theme.colors.dark[6] : theme.colors.gray[1]
+        let backgroundHoverColor = backgroundColor
-        }
+        if (!expanded && !read) {
-
+            backgroundHoverColor = colorScheme === "dark" ? theme.colors.dark[6] : theme.colors.gray[1]
-        let paperBorderLeftColor
+        }
-        if (showSelectionIndicator) {
+
-            const borderLeftColor = colorScheme === "dark" ? theme.colors[theme.primaryColor][4] : theme.colors[theme.primaryColor][6]
+        let paperBorderLeftColor = ""
-            paperBorderLeftColor = `${borderLeftColor} !important`
+        if (showSelectionIndicator) {
-        }
+            const borderLeftColor = colorScheme === "dark" ? theme.colors[theme.primaryColor][4] : theme.colors[theme.primaryColor][6]
-
+            paperBorderLeftColor = `${borderLeftColor} !important`
-        return {
+        }
-            paper: {
+
-                backgroundColor,
+        return {
-                borderLeftColor: paperBorderLeftColor,
+            paper: {
-                marginTop: marginY,
+                backgroundColor,
-                marginBottom: marginY,
+                borderLeftColor: paperBorderLeftColor,
-                [`@media (max-width: ${Constants.layout.mobileBreakpoint}px)`]: {
+                marginTop: marginY,
-                    marginTop: mobileMarginY,
+                marginBottom: marginY,
-                    marginBottom: mobileMarginY,
+                [`@media (max-width: ${Constants.layout.mobileBreakpoint}px)`]: {
-                },
+                    marginTop: mobileMarginY,
-                "@media (hover: hover)": {
+                    marginBottom: mobileMarginY,
-                    "&:hover": {
+                },
-                        backgroundColor: backgroundHoverColor,
+                "@media (hover: hover)": {
-                    },
+                    "&:hover": {
-                },
+                        backgroundColor: backgroundHoverColor,
-            },
+                    },
-            headerLink: {
+                },
-                color: "inherit",
+            },
-                textDecoration: "none",
+            headerLink: {
-            },
+                fontSize: `${fontSizePercentage}%`,
-            body: {
+                color: "inherit",
-                direction: rtl ? "rtl" : "ltr",
+                textDecoration: "none",
-                maxWidth: maxWidth ?? "100%",
+            },
-            },
+            body: {
-        }
+                fontSize: `${fontSizePercentage}%`,
-    })
+                direction: rtl ? "rtl" : "ltr",
-
+                maxWidth: maxWidth ?? "100%",
-export function FeedEntry(props: FeedEntryProps) {
+            },
-    const { viewMode } = useViewMode()
+        }
-    const { classes, cx } = useStyles({
+    })
-        read: props.entry.read,
+
-        expanded: props.expanded,
+export function FeedEntry(props: FeedEntryProps) {
-        viewMode,
+    const viewMode = useAppSelector(state => state.user.localSettings.viewMode)
-        rtl: props.entry.rtl,
+    const fontSizePercentage = useAppSelector(state => state.user.localSettings.fontSizePercentage)
-        showSelectionIndicator: props.showSelectionIndicator,
+    const { classes, cx } = useStyles({
-        maxWidth: props.maxWidth,
+        read: props.entry.read,
-    })
+        expanded: props.expanded,
-
+        viewMode,
-    const swipeHandlers = useSwipeable({
+        rtl: props.entry.rtl,
-        onSwipedLeft: props.onSwipedLeft,
+        showSelectionIndicator: props.showSelectionIndicator,
-    })
+        maxWidth: props.maxWidth,
-
+        fontSizePercentage,
-    let paddingX: MantineSpacing = "xs"
+    })
-    if (viewMode === "title" || viewMode === "cozy") paddingX = 6
+
-
+    const externalLinkDisplayMode = useAppSelector(state => state.user.settings?.externalLinkIconDisplayMode)
-    let paddingY: MantineSpacing = "xs"
+    const starIconDisplayMode = useAppSelector(state => state.user.settings?.starIconDisplayMode)
-    if (viewMode === "title") {
+    const mobile = useMobile()
-        paddingY = 4
+
-    } else if (viewMode === "cozy") {
+    const showExternalLinkIcon =
-        paddingY = 8
+        externalLinkDisplayMode && ["always", mobile ? "on_mobile" : "on_desktop"].includes(externalLinkDisplayMode)
-    }
+    const showStarIcon =
-
+        props.entry.markable && starIconDisplayMode && ["always", mobile ? "on_mobile" : "on_desktop"].includes(starIconDisplayMode)
-    let borderRadius: MantineRadius = "sm"
+
-    if (viewMode === "title") {
+    const swipeHandlers = useSwipeable({
-        borderRadius = 0
+        onSwipedLeft: props.onSwipedLeft,
-    } else if (viewMode === "cozy") {
+    })
-        borderRadius = "xs"
+
-    }
+    let paddingX: MantineSpacing = "xs"
-
+    if (viewMode === "title" || viewMode === "cozy") paddingX = 6
-    const compactHeader = !props.expanded && (viewMode === "title" || viewMode === "cozy")
+
-    return (
+    let paddingY: MantineSpacing = "xs"
-        <Paper
+    if (viewMode === "title") {
-            withBorder
+        paddingY = 4
-            radius={borderRadius}
+    } else if (viewMode === "cozy") {
-            className={cx(classes.paper, {
+        paddingY = 8
-                read: props.entry.read,
+    }
-                unread: !props.entry.read,
+
-                expanded: props.expanded,
+    let borderRadius: MantineRadius = "sm"
-                selected: props.selected,
+    if (viewMode === "title") {
-                "show-selection-indicator": props.showSelectionIndicator,
+        borderRadius = 0
-            })}
+    } else if (viewMode === "cozy") {
-        >
+        borderRadius = "xs"
-            <a
+    }
-                className={classes.headerLink}
+
-                href={props.entry.url}
+    const compactHeader = !props.expanded && (viewMode === "title" || viewMode === "cozy")
-                target="_blank"
+    return (
-                rel="noreferrer"
+        <Paper
-                onClick={props.onHeaderClick}
+            component="article"
-                onAuxClick={props.onHeaderClick}
+            id={Constants.dom.entryId(props.entry)}
-                onContextMenu={props.onHeaderRightClick}
+            data-id={props.entry.id}
-            >
+            withBorder
-                <Box px={paddingX} py={paddingY} {...swipeHandlers}>
+            radius={borderRadius}
-                    {compactHeader && <FeedEntryCompactHeader entry={props.entry} />}
+            className={cx(classes.paper, {
-                    {!compactHeader && <FeedEntryHeader entry={props.entry} expanded={props.expanded} />}
+                read: props.entry.read,
-                </Box>
+                unread: !props.entry.read,
-            </a>
+                expanded: props.expanded,
-            {props.expanded && (
+                selected: props.selected,
-                <Box px={paddingX} pb={paddingY} onClick={props.onBodyClick}>
+                "show-selection-indicator": props.showSelectionIndicator,
-                    <Box className={classes.body}>
+            })}
-                        <FeedEntryBody entry={props.entry} />
+        >
-                    </Box>
+            <a
-                    <Divider variant="dashed" my={paddingY} />
+                className={classes.headerLink}
-                    <FeedEntryFooter entry={props.entry} />
+                href={props.entry.url}
-                </Box>
+                target="_blank"
-            )}
+                rel="noreferrer"
-
+                onClick={props.onHeaderClick}
-            <FeedEntryContextMenu entry={props.entry} />
+                onAuxClick={props.onHeaderClick}
-        </Paper>
+                onContextMenu={props.onHeaderRightClick}
-    )
+            >
-}
+                <Box px={paddingX} py={paddingY} {...swipeHandlers}>
+                    {compactHeader && (
+                        <FeedEntryCompactHeader
+                            entry={props.entry}
+                            showStarIcon={showStarIcon}
+                            showExternalLinkIcon={showExternalLinkIcon}
+                        />
+                    )}
+                    {!compactHeader && (
+                        <FeedEntryHeader
+                            entry={props.entry}
+                            expanded={props.expanded}
+                            showStarIcon={showStarIcon}
+                            showExternalLinkIcon={showExternalLinkIcon}
+                        />
+                    )}
+                </Box>
+            </a>
+            {props.expanded && (
+                <Box px={paddingX} pb={paddingY} onClick={props.onBodyClick}>
+                    <Box className={`${classes.body} cf-content`}>
+                        <FeedEntryBody entry={props.entry} />
+                    </Box>
+                    <Divider variant="dashed" my={paddingY} className="cf-footer-divider" />
+                    <FeedEntryFooter entry={props.entry} />
+                </Box>
+            )}
+
+            <FeedEntryContextMenu entry={props.entry} />
+        </Paper>
+    )
+}

commafeed-client/src/components/content/FeedEntryBody.tsx

@@ -1,37 +1,37 @@
-import { Box } from "@mantine/core"
+import { Box } from "@mantine/core"
-import { useAppSelector } from "app/store"
+import { useAppSelector } from "app/store"
-import { type Entry } from "app/types"
+import type { Entry } from "app/types"
-import { Content } from "./Content"
+import { Content } from "./Content"
-import { Enclosure } from "./Enclosure"
+import { Enclosure } from "./Enclosure"
-import { Media } from "./Media"
+import { Media } from "./Media"
-
+
-export interface FeedEntryBodyProps {
+export interface FeedEntryBodyProps {
-    entry: Entry
+    entry: Entry
-}
+}
-
+
-export function FeedEntryBody(props: FeedEntryBodyProps) {
+export function FeedEntryBody(props: FeedEntryBodyProps) {
-    const search = useAppSelector(state => state.entries.search)
+    const search = useAppSelector(state => state.entries.search)
-    return (
+    return (
-        <Box>
+        <Box>
-            <Box>
+            <Box>
-                <Content content={props.entry.content} highlight={search} />
+                <Content content={props.entry.content} highlight={search} />
-            </Box>
+            </Box>
-            {props.entry.enclosureType && props.entry.enclosureUrl && (
+            {props.entry.enclosureType && props.entry.enclosureUrl && (
-                <Box pt="md">
+                <Box pt="md">
-                    <Enclosure enclosureType={props.entry.enclosureType} enclosureUrl={props.entry.enclosureUrl} />
+                    <Enclosure enclosureType={props.entry.enclosureType} enclosureUrl={props.entry.enclosureUrl} />
-                </Box>
+                </Box>
-            )}
+            )}
-            {/* show media only if we don't have content to avoid duplicate content */}
+            {/* show media only if we don't have content to avoid duplicate content */}
-            {!props.entry.content && props.entry.mediaThumbnailUrl && (
+            {!props.entry.content && props.entry.mediaThumbnailUrl && (
-                <Box pt="md">
+                <Box pt="md">
-                    <Media
+                    <Media
-                        thumbnailUrl={props.entry.mediaThumbnailUrl}
+                        thumbnailUrl={props.entry.mediaThumbnailUrl}
-                        thumbnailWidth={props.entry.mediaThumbnailWidth}
+                        thumbnailWidth={props.entry.mediaThumbnailWidth}
-                        thumbnailHeight={props.entry.mediaThumbnailHeight}
+                        thumbnailHeight={props.entry.mediaThumbnailHeight}
-                        description={props.entry.mediaDescription}
+                        description={props.entry.mediaDescription}
-                    />
+                    />
-                </Box>
+                </Box>
-            )}
+            )}
-        </Box>
+        </Box>
-    )
+    )
-}
+}

commafeed-client/src/components/content/FeedEntryContextMenu.tsx

@@ -1,101 +1,103 @@
-import { Trans } from "@lingui/macro"
+import { Trans } from "@lingui/react/macro"
-import { Group } from "@mantine/core"
+import { Group } from "@mantine/core"
-import { Constants } from "app/constants"
+import { Constants } from "app/constants"
-import { markEntriesUpToEntry, markEntry, starEntry } from "app/entries/thunks"
+import { markEntriesUpToEntry, markEntry, starEntry } from "app/entries/thunks"
-import { redirectToFeed } from "app/redirect/thunks"
+import { redirectToFeed } from "app/redirect/thunks"
-import { useAppDispatch, useAppSelector } from "app/store"
+import { useAppDispatch, useAppSelector } from "app/store"
-import { type Entry } from "app/types"
+import type { Entry } from "app/types"
-import { truncate } from "app/utils"
+import { truncate } from "app/utils"
-import { useBrowserExtension } from "hooks/useBrowserExtension"
+import { useBrowserExtension } from "hooks/useBrowserExtension"
-import { useColorScheme } from "hooks/useColorScheme"
+import { useColorScheme } from "hooks/useColorScheme"
-import { Item, Menu, Separator } from "react-contexify"
+import { Item, Menu, Separator } from "react-contexify"
-import { TbArrowBarToDown, TbExternalLink, TbEyeCheck, TbEyeOff, TbRss, TbStar, TbStarOff } from "react-icons/tb"
+import { TbArrowBarToDown, TbExternalLink, TbMail, TbMailOpened, TbRss, TbStar, TbStarOff } from "react-icons/tb"
-import { tss } from "tss"
+import { tss } from "tss"
-
+
-interface FeedEntryContextMenuProps {
+interface FeedEntryContextMenuProps {
-    entry: Entry
+    entry: Entry
-}
+}
-
+
-const iconSize = 16
+const iconSize = 16
-const useStyles = tss.create(({ theme, colorScheme }) => ({
+const useStyles = tss.create(({ theme, colorScheme }) => ({
-    menu: {
+    menu: {
-        // apply mantine theme from MenuItem.styles.ts
+        // apply mantine theme from MenuItem.styles.ts
-        fontSize: theme.fontSizes.sm,
+        fontSize: theme.fontSizes.sm,
-        "--contexify-item-color": `${colorScheme === "dark" ? theme.colors.dark[0] : theme.black} !important`,
+        "--contexify-item-color": `${colorScheme === "dark" ? theme.colors.dark[0] : theme.black} !important`,
-        "--contexify-activeItem-color": `${colorScheme === "dark" ? theme.colors.dark[0] : theme.black} !important`,
+        "--contexify-activeItem-color": `${colorScheme === "dark" ? theme.colors.dark[0] : theme.black} !important`,
-        "--contexify-activeItem-bgColor": `${colorScheme === "dark" ? theme.colors.dark[4] : theme.colors.gray[1]} !important`,
+        "--contexify-activeItem-bgColor": `${colorScheme === "dark" ? theme.colors.dark[4] : theme.colors.gray[1]} !important`,
-    },
+    },
-}))
+}))
-
+
-export function FeedEntryContextMenu(props: FeedEntryContextMenuProps) {
+export function FeedEntryContextMenu(props: FeedEntryContextMenuProps) {
-    const colorScheme = useColorScheme()
+    const colorScheme = useColorScheme()
-    const { classes } = useStyles()
+    const { classes } = useStyles()
-    const sourceType = useAppSelector(state => state.entries.source.type)
+    const sourceType = useAppSelector(state => state.entries.source.type)
-    const dispatch = useAppDispatch()
+    const dispatch = useAppDispatch()
-    const { openLinkInBackgroundTab } = useBrowserExtension()
+    const { openLinkInBackgroundTab } = useBrowserExtension()
-
+
-    return (
+    return (
-        <Menu id={Constants.dom.entryContextMenuId(props.entry)} theme={colorScheme} animation={false} className={classes.menu}>
+        <Menu id={Constants.dom.entryContextMenuId(props.entry)} theme={colorScheme} animation={false} className={classes.menu}>
-            <Item
+            <Item
-                onClick={() => {
+                onClick={() => {
-                    window.open(props.entry.url, "_blank", "noreferrer")
+                    window.open(props.entry.url, "_blank", "noreferrer")
-                    dispatch(markEntry({ entry: props.entry, read: true }))
+                    dispatch(markEntry({ entry: props.entry, read: true }))
-                }}
+                }}
-            >
+            >
-                <Group>
+                <Group>
-                    <TbExternalLink size={iconSize} />
+                    <TbExternalLink size={iconSize} />
-                    <Trans>Open link in new tab</Trans>
+                    <Trans>Open link in new tab</Trans>
-                </Group>
+                </Group>
-            </Item>
+            </Item>
-            <Item
+            <Item
-                onClick={() => {
+                onClick={() => {
-                    openLinkInBackgroundTab(props.entry.url)
+                    openLinkInBackgroundTab(props.entry.url)
-                    dispatch(markEntry({ entry: props.entry, read: true }))
+                    dispatch(markEntry({ entry: props.entry, read: true }))
-                }}
+                }}
-            >
+            >
-                <Group>
+                <Group>
-                    <TbExternalLink size={iconSize} />
+                    <TbExternalLink size={iconSize} />
-                    <Trans>Open link in new background tab</Trans>
+                    <Trans>Open link in new background tab</Trans>
-                </Group>
+                </Group>
-            </Item>
+            </Item>
-
+
-            <Separator />
+            <Separator />
-
+
-            <Item onClick={async () => await dispatch(starEntry({ entry: props.entry, starred: !props.entry.starred }))}>
+            <Item onClick={async () => await dispatch(starEntry({ entry: props.entry, starred: !props.entry.starred }))}>
-                <Group>
+                <Group>
-                    {props.entry.starred ? <TbStarOff size={iconSize} /> : <TbStar size={iconSize} />}
+                    {props.entry.starred ? <TbStarOff size={iconSize} /> : <TbStar size={iconSize} />}
-                    {props.entry.starred ? <Trans>Unstar</Trans> : <Trans>Star</Trans>}
+                    {props.entry.starred ? <Trans>Unstar</Trans> : <Trans>Star</Trans>}
-                </Group>
+                </Group>
-            </Item>
+            </Item>
-            <Item onClick={async () => await dispatch(markEntry({ entry: props.entry, read: !props.entry.read }))}>
+            {props.entry.markable && (
-                <Group>
+                <Item onClick={async () => await dispatch(markEntry({ entry: props.entry, read: !props.entry.read }))}>
-                    {props.entry.read ? <TbEyeOff size={iconSize} /> : <TbEyeCheck size={iconSize} />}
+                    <Group>
-                    {props.entry.read ? <Trans>Keep unread</Trans> : <Trans>Mark as read</Trans>}
+                        {props.entry.read ? <TbMail size={iconSize} /> : <TbMailOpened size={iconSize} />}
-                </Group>
+                        {props.entry.read ? <Trans>Keep unread</Trans> : <Trans>Mark as read</Trans>}
-            </Item>
+                    </Group>
-            <Item onClick={async () => await dispatch(markEntriesUpToEntry(props.entry))}>
+                </Item>
-                <Group>
+            )}
-                    <TbArrowBarToDown size={iconSize} />
+            <Item onClick={async () => await dispatch(markEntriesUpToEntry(props.entry))}>
-                    <Trans>Mark as read up to here</Trans>
+                <Group>
-                </Group>
+                    <TbArrowBarToDown size={iconSize} />
-            </Item>
+                    <Trans>Mark as read up to here</Trans>
-
+                </Group>
-            {sourceType === "category" && (
+            </Item>
-                <>
+
-                    <Separator />
+            {sourceType === "category" && (
-
+                <>
-                    <Item
+                    <Separator />
-                        onClick={() => {
+
-                            dispatch(redirectToFeed(props.entry.feedId))
+                    <Item
-                        }}
+                        onClick={() => {
-                    >
+                            dispatch(redirectToFeed(props.entry.feedId))
-                        <Group>
+                        }}
-                            <TbRss size={iconSize} />
+                    >
-                            <Trans>Go to {truncate(props.entry.feedName, 30)}</Trans>
+                        <Group>
-                        </Group>
+                            <TbRss size={iconSize} />
-                    </Item>
+                            <Trans>Go to {truncate(props.entry.feedName, 30)}</Trans>
-                </>
+                        </Group>
-            )}
+                    </Item>
-        </Menu>
+                </>
-    )
+            )}
-}
+        </Menu>
+    )
+}

commafeed-client/src/components/content/FeedEntryFooter.tsx

@@ -1,107 +1,104 @@
-import { t, Trans } from "@lingui/macro"
+import { msg } from "@lingui/core/macro"
-import { Group, Indicator, Popover, TagsInput } from "@mantine/core"
+import { useLingui } from "@lingui/react"
-import { markEntriesUpToEntry, markEntry, starEntry, tagEntry } from "app/entries/thunks"
+import { Group, Indicator, Popover, TagsInput } from "@mantine/core"
-import { useAppDispatch, useAppSelector } from "app/store"
+import { markEntriesUpToEntry, markEntry, starEntry, tagEntry } from "app/entries/thunks"
-import { type Entry } from "app/types"
+import { useAppDispatch, useAppSelector } from "app/store"
-import { ActionButton } from "components/ActionButton"
+import type { Entry } from "app/types"
-import { useActionButton } from "hooks/useActionButton"
+import { ActionButton } from "components/ActionButton"
-import { useMobile } from "hooks/useMobile"
+import { useActionButton } from "hooks/useActionButton"
-import { TbArrowBarToDown, TbExternalLink, TbEyeCheck, TbEyeOff, TbShare, TbStar, TbStarOff, TbTag } from "react-icons/tb"
+import { useMobile } from "hooks/useMobile"
-import { ShareButtons } from "./ShareButtons"
+import { TbArrowBarToDown, TbExternalLink, TbMail, TbMailOpened, TbShare, TbStar, TbStarOff, TbTag } from "react-icons/tb"
-
+import { ShareButtons } from "./ShareButtons"
-interface FeedEntryFooterProps {
+
-    entry: Entry
+interface FeedEntryFooterProps {
-}
+    entry: Entry
-
+}
-export function FeedEntryFooter(props: FeedEntryFooterProps) {
+
-    const sharingSettings = useAppSelector(state => state.user.settings?.sharingSettings)
+export function FeedEntryFooter(props: FeedEntryFooterProps) {
-    const tags = useAppSelector(state => state.user.tags)
+    const tags = useAppSelector(state => state.user.tags)
-    const mobile = useMobile()
+    const mobile = useMobile()
-    const { spacing } = useActionButton()
+    const { spacing } = useActionButton()
-    const dispatch = useAppDispatch()
+    const dispatch = useAppDispatch()
-
+    const { _ } = useLingui()
-    const showSharingButtons = sharingSettings && Object.values(sharingSettings).some(v => v)
+
-
+    const readStatusButtonClicked = async () =>
-    const readStatusButtonClicked = async () =>
+        await dispatch(
-        await dispatch(
+            markEntry({
-            markEntry({
+                entry: props.entry,
-                entry: props.entry,
+                read: !props.entry.read,
-                read: !props.entry.read,
+            })
-            })
+        )
-        )
+    const onTagsChange = async (values: string[]) =>
-    const onTagsChange = async (values: string[]) =>
+        await dispatch(
-        await dispatch(
+            tagEntry({
-            tagEntry({
+                entryId: +props.entry.id,
-                entryId: +props.entry.id,
+                tags: values,
-                tags: values,
+            })
-            })
+        )
-        )
+
-
+    return (
-    return (
+        <Group justify="space-between" className="cf-footer">
-        <Group justify="space-between">
+            <Group gap={spacing}>
-            <Group gap={spacing}>
+                {props.entry.markable && (
-                {props.entry.markable && (
+                    <ActionButton
-                    <ActionButton
+                        icon={props.entry.read ? <TbMail size={18} /> : <TbMailOpened size={18} />}
-                        icon={props.entry.read ? <TbEyeOff size={18} /> : <TbEyeCheck size={18} />}
+                        label={props.entry.read ? msg`Keep unread` : msg`Mark as read`}
-                        label={props.entry.read ? <Trans>Keep unread</Trans> : <Trans>Mark as read</Trans>}
+                        onClick={readStatusButtonClicked}
-                        onClick={readStatusButtonClicked}
+                    />
-                    />
+                )}
-                )}
+                <ActionButton
-                <ActionButton
+                    icon={props.entry.starred ? <TbStarOff size={18} /> : <TbStar size={18} />}
-                    icon={props.entry.starred ? <TbStarOff size={18} /> : <TbStar size={18} />}
+                    label={props.entry.starred ? msg`Unstar` : msg`Star`}
-                    label={props.entry.starred ? <Trans>Unstar</Trans> : <Trans>Star</Trans>}
+                    onClick={async () =>
-                    onClick={async () =>
+                        await dispatch(
-                        await dispatch(
+                            starEntry({
-                            starEntry({
+                                entry: props.entry,
-                                entry: props.entry,
+                                starred: !props.entry.starred,
-                                starred: !props.entry.starred,
+                            })
-                            })
+                        )
-                        )
+                    }
-                    }
+                />
-                />
+
-
+                <Popover withArrow withinPortal shadow="md" closeOnClickOutside={!mobile}>
-                {showSharingButtons && (
+                    <Popover.Target>
-                    <Popover withArrow withinPortal shadow="md" closeOnClickOutside={!mobile}>
+                        <ActionButton icon={<TbShare size={18} />} label={msg`Share`} />
-                        <Popover.Target>
+                    </Popover.Target>
-                            <ActionButton icon={<TbShare size={18} />} label={<Trans>Share</Trans>} />
+                    <Popover.Dropdown>
-                        </Popover.Target>
+                        <ShareButtons url={props.entry.url} description={props.entry.title} />
-                        <Popover.Dropdown>
+                    </Popover.Dropdown>
-                            <ShareButtons url={props.entry.url} description={props.entry.title} />
+                </Popover>
-                        </Popover.Dropdown>
+
-                    </Popover>
+                {tags && (
-                )}
+                    <Popover withArrow shadow="md" closeOnClickOutside={!mobile}>
-
+                        <Popover.Target>
-                {tags && (
+                            <Indicator label={props.entry.tags.length} disabled={props.entry.tags.length === 0} inline size={16}>
-                    <Popover withArrow shadow="md" closeOnClickOutside={!mobile}>
+                                <ActionButton icon={<TbTag size={18} />} label={msg`Tags`} />
-                        <Popover.Target>
+                            </Indicator>
-                            <Indicator label={props.entry.tags.length} disabled={props.entry.tags.length === 0} inline size={16}>
+                        </Popover.Target>
-                                <ActionButton icon={<TbTag size={18} />} label={<Trans>Tags</Trans>} />
+                        <Popover.Dropdown>
-                            </Indicator>
+                            <TagsInput
-                        </Popover.Target>
+                                placeholder={_(msg`Tags`)}
-                        <Popover.Dropdown>
+                                data={tags}
-                            <TagsInput
+                                value={props.entry.tags}
-                                placeholder={t`Tags`}
+                                onChange={onTagsChange}
-                                data={tags}
+                                comboboxProps={{
-                                value={props.entry.tags}
+                                    withinPortal: false,
-                                onChange={onTagsChange}
+                                }}
-                                comboboxProps={{
+                            />
-                                    withinPortal: false,
+                        </Popover.Dropdown>
-                                }}
+                    </Popover>
-                            />
+                )}
-                        </Popover.Dropdown>
+
-                    </Popover>
+                <a href={props.entry.url} target="_blank" rel="noreferrer">
-                )}
+                    <ActionButton icon={<TbExternalLink size={18} />} label={msg`Open link`} />
-
+                </a>
-                <a href={props.entry.url} target="_blank" rel="noreferrer">
+            </Group>
-                    <ActionButton icon={<TbExternalLink size={18} />} label={<Trans>Open link</Trans>} />
+
-                </a>
+            <ActionButton
-            </Group>
+                icon={<TbArrowBarToDown size={18} />}
-
+                label={msg`Mark as read up to here`}
-            <ActionButton
+                onClick={async () => await dispatch(markEntriesUpToEntry(props.entry))}
-                icon={<TbArrowBarToDown size={18} />}
+            />
-                label={<Trans>Mark as read up to here</Trans>}
+        </Group>
-                onClick={async () => await dispatch(markEntriesUpToEntry(props.entry))}
+    )
-            />
+}
-        </Group>
-    )
-}

commafeed-client/src/components/content/FeedEntryHeader.tsx

@@ -1,57 +0,0 @@
-import { Box, Space, Text } from "@mantine/core"
-import { type Entry } from "app/types"
-import { RelativeDate } from "components/RelativeDate"
-import { tss } from "tss"
-import { FeedEntryTitle } from "./FeedEntryTitle"
-import { FeedFavicon } from "./FeedFavicon"
-
-export interface FeedEntryHeaderProps {
-    entry: Entry
-    expanded: boolean
-}
-
-const useStyles = tss
-    .withParams<{
-        read: boolean
-    }>()
-    .create(({ colorScheme, read }) => ({
-        headerText: {
-            fontWeight: colorScheme === "light" && !read ? "bold" : "inherit",
-        },
-        headerSubtext: {
-            display: "flex",
-            alignItems: "center",
-            fontSize: "90%",
-        },
-    }))
-
-export function FeedEntryHeader(props: FeedEntryHeaderProps) {
-    const { classes } = useStyles({
-        read: props.entry.read,
-    })
-    return (
-        <Box>
-            <Box className={classes.headerText}>
-                <FeedEntryTitle entry={props.entry} />
-            </Box>
-            <Box className={classes.headerSubtext}>
-                <FeedFavicon url={props.entry.iconUrl} />
-                <Space w={6} />
-                <Text c="dimmed">
-                    {props.entry.feedName}
-                    <span> · </span>
-                    <RelativeDate date={props.entry.date} />
-                </Text>
-            </Box>
-            {props.expanded && (
-                <Box className={classes.headerSubtext}>
-                    <Text c="dimmed">
-                        {props.entry.author && <span>by {props.entry.author}</span>}
-                        {props.entry.author && props.entry.categories && <span>&nbsp;·&nbsp;</span>}
-                        {props.entry.categories && <span>{props.entry.categories}</span>}
-                    </Text>
-                </Box>
-            )}
-        </Box>
-    )
-}

commafeed-client/src/components/content/FeedFavicon.tsx

@@ -1,21 +1,21 @@
-import { ImageWithPlaceholderWhileLoading } from "components/ImageWithPlaceholderWhileLoading"
+import { ImageWithPlaceholderWhileLoading } from "components/ImageWithPlaceholderWhileLoading"
-
+
-export interface FeedFaviconProps {
+export interface FeedFaviconProps {
-    url: string
+    url: string
-    size?: number
+    size?: number
-}
+}
-
+
-export function FeedFavicon({ url, size = 18 }: FeedFaviconProps) {
+export function FeedFavicon({ url, size = 18 }: FeedFaviconProps) {
-    return (
+    return (
-        <ImageWithPlaceholderWhileLoading
+        <ImageWithPlaceholderWhileLoading
-            src={url}
+            src={url}
-            alt="feed favicon"
+            alt="feed favicon"
-            width={size}
+            width={size}
-            height={size}
+            height={size}
-            placeholderWidth={size}
+            placeholderWidth={size}
-            placeholderHeight={size}
+            placeholderHeight={size}
-            placeholderBackgroundColor="inherit"
+            placeholderBackgroundColor="inherit"
-            placeholderIconSize={size}
+            placeholderIconSize={size}
-        />
+        />
-    )
+    )
-}
+}

commafeed-client/src/components/content/Media.tsx

@@ -1,40 +1,40 @@
-import { Box } from "@mantine/core"
+import { Box } from "@mantine/core"
-import { Constants } from "app/constants"
+import { Constants } from "app/constants"
-import { calculatePlaceholderSize } from "app/utils"
+import { calculatePlaceholderSize } from "app/utils"
-import { BasicHtmlStyles } from "components/content/BasicHtmlStyles"
+import { ImageWithPlaceholderWhileLoading } from "components/ImageWithPlaceholderWhileLoading"
-import { ImageWithPlaceholderWhileLoading } from "components/ImageWithPlaceholderWhileLoading"
+import { BasicHtmlStyles } from "components/content/BasicHtmlStyles"
-import { Content } from "./Content"
+import { Content } from "./Content"
-
+
-export interface MediaProps {
+export interface MediaProps {
-    thumbnailUrl: string
+    thumbnailUrl: string
-    thumbnailWidth?: number
+    thumbnailWidth?: number
-    thumbnailHeight?: number
+    thumbnailHeight?: number
-    description?: string
+    description?: string
-}
+}
-
+
-export function Media(props: MediaProps) {
+export function Media(props: MediaProps) {
-    const width = props.thumbnailWidth
+    const width = props.thumbnailWidth
-    const height = props.thumbnailHeight
+    const height = props.thumbnailHeight
-    const placeholderSize = calculatePlaceholderSize({
+    const placeholderSize = calculatePlaceholderSize({
-        width,
+        width,
-        height,
+        height,
-        maxWidth: Constants.layout.entryMaxWidth,
+        maxWidth: Constants.layout.entryMaxWidth,
-    })
+    })
-    return (
+    return (
-        <BasicHtmlStyles>
+        <BasicHtmlStyles>
-            <ImageWithPlaceholderWhileLoading
+            <ImageWithPlaceholderWhileLoading
-                src={props.thumbnailUrl}
+                src={props.thumbnailUrl}
-                alt="media thumbnail"
+                alt="media thumbnail"
-                width={props.thumbnailWidth}
+                width={props.thumbnailWidth}
-                height={props.thumbnailHeight}
+                height={props.thumbnailHeight}
-                placeholderWidth={placeholderSize.width}
+                placeholderWidth={placeholderSize.width}
-                placeholderHeight={placeholderSize.height}
+                placeholderHeight={placeholderSize.height}
-            />
+            />
-            {props.description && (
+            {props.description && (
-                <Box pt="md">
+                <Box pt="md">
-                    <Content content={props.description} />
+                    <Content content={props.description} />
-                </Box>
+                </Box>
-            )}
+            )}
-        </BasicHtmlStyles>
+        </BasicHtmlStyles>
-    )
+    )
-}
+}

commafeed-client/src/components/content/ShareButtons.tsx

@@ -1,62 +1,113 @@
-import { ActionIcon, Box, SimpleGrid } from "@mantine/core"
+import { Trans } from "@lingui/react/macro"
-import { Constants } from "app/constants"
+import { ActionIcon, Box, CopyButton, Divider, SimpleGrid } from "@mantine/core"
-import { useAppSelector } from "app/store"
+import { Constants } from "app/constants"
-import { type SharingSettings } from "app/types"
+import { useAppSelector } from "app/store"
-import { type IconType } from "react-icons"
+import type { SharingSettings } from "app/types"
-import { tss } from "tss"
+import { useBrowserExtension } from "hooks/useBrowserExtension"
-
+import { useMobile } from "hooks/useMobile"
-type Color = `#${string}`
+import type { IconType } from "react-icons"
-
+import { TbCheck, TbCopy, TbDeviceDesktopShare, TbDeviceMobileShare } from "react-icons/tb"
-const useStyles = tss
+import { tss } from "tss"
-    .withParams<{
+
-        color: Color
+type Color = `#${string}`
-    }>()
+
-    .create(({ theme, colorScheme, color }) => ({
+const useStyles = tss
-        socialIcon: {
+    .withParams<{
-            color,
+        color: Color
-            backgroundColor: colorScheme === "dark" ? theme.colors.gray[2] : "white",
+    }>()
-            borderRadius: "50%",
+    .create(({ theme, colorScheme, color }) => ({
-        },
+        icon: {
-    }))
+            color,
-
+            backgroundColor: colorScheme === "dark" ? theme.colors.gray[2] : "white",
-function ShareButton({ url, icon, color }: { url: string; icon: IconType; color: Color }) {
+        },
-    const { classes } = useStyles({
+    }))
-        color,
+
-    })
+function ShareButton({ icon, color, onClick }: { icon: IconType; color: Color; onClick: () => void }) {
-
+    const { classes } = useStyles({
-    const onClick = (e: React.MouseEvent) => {
+        color,
-        e.preventDefault()
+    })
-        window.open(url, "", "menubar=no,toolbar=no,resizable=yes,scrollbars=yes,width=800,height=600")
+
-    }
+    return (
-
+        <ActionIcon variant="transparent" radius="xl" size={32}>
-    return (
+            <Box p={6} className={classes.icon} onClick={onClick}>
-        <ActionIcon variant="transparent">
+                {icon({ size: 18 })}
-            <a href={url} target="_blank" rel="noreferrer" onClick={onClick}>
+            </Box>
-                <Box p={6} className={classes.socialIcon}>
+        </ActionIcon>
-                    {icon({ size: 18 })}
+    )
-                </Box>
+}
-            </a>
+
-        </ActionIcon>
+function SiteShareButton({ url, icon, color }: { icon: IconType; color: Color; url: string }) {
-    )
+    const onClick = () => {
-}
+        window.open(url, "", "menubar=no,toolbar=no,resizable=yes,scrollbars=yes,width=800,height=600")
-
+    }
-export function ShareButtons(props: { url: string; description: string }) {
+
-    const sharingSettings = useAppSelector(state => state.user.settings?.sharingSettings)
+    return <ShareButton icon={icon} color={color} onClick={onClick} />
-    const url = encodeURIComponent(props.url)
+}
-    const desc = encodeURIComponent(props.description)
+
-
+function CopyUrlButton({ url }: { url: string }) {
-    return (
+    return (
-        <SimpleGrid cols={4}>
+        <CopyButton value={url}>
-            {(Object.keys(Constants.sharing) as (keyof SharingSettings)[])
+            {({ copied, copy }) => <ShareButton icon={copied ? TbCheck : TbCopy} color="#000" onClick={copy} />}
-                .filter(site => sharingSettings?.[site])
+        </CopyButton>
-                .map(site => (
+    )
-                    <ShareButton
+}
-                        key={site}
+
-                        icon={Constants.sharing[site].icon}
+function BrowserNativeShareButton({ url, description }: { url: string; description: string }) {
-                        color={Constants.sharing[site].color}
+    const mobile = useMobile()
-                        url={Constants.sharing[site].url(url, desc)}
+    const { isBrowserExtensionPopup } = useBrowserExtension()
-                    />
+    const onClick = () => {
-                ))}
+        navigator.share({
-        </SimpleGrid>
+            title: description,
-    )
+            url,
-}
+        })
+    }
+
+    return (
+        <ShareButton
+            icon={mobile && !isBrowserExtensionPopup ? TbDeviceMobileShare : TbDeviceDesktopShare}
+            color="#000"
+            onClick={onClick}
+        />
+    )
+}
+
+export function ShareButtons(props: { url: string; description: string }) {
+    const sharingSettings = useAppSelector(state => state.user.settings?.sharingSettings)
+    const enabledSharingSites = (Object.keys(Constants.sharing) as Array<keyof SharingSettings>).filter(site => sharingSettings?.[site])
+    const url = encodeURIComponent(props.url)
+    const desc = encodeURIComponent(props.description)
+    const clipboardAvailable = typeof navigator.clipboard !== "undefined"
+    const nativeSharingAvailable = typeof navigator.share !== "undefined"
+    const showNativeSection = clipboardAvailable || nativeSharingAvailable
+    const showSharingSites = enabledSharingSites.length > 0
+    const showDivider = showNativeSection && showSharingSites
+    const showNoSharingOptionsAvailable = !showNativeSection && !showSharingSites
+
+    return (
+        <>
+            {showNativeSection && (
+                <SimpleGrid cols={4}>
+                    {clipboardAvailable && <CopyUrlButton url={props.url} />}
+                    {nativeSharingAvailable && <BrowserNativeShareButton url={props.url} description={props.description} />}
+                </SimpleGrid>
+            )}
+
+            {showDivider && <Divider my="xs" />}
+
+            {showSharingSites && (
+                <SimpleGrid cols={4}>
+                    {enabledSharingSites.map(site => (
+                        <SiteShareButton
+                            key={site}
+                            icon={Constants.sharing[site].icon}
+                            color={Constants.sharing[site].color}
+                            url={Constants.sharing[site].url(url, desc)}
+                        />
+                    ))}
+                </SimpleGrid>
+            )}
+
+            {showNoSharingOptionsAvailable && <Trans>No sharing options available.</Trans>}
+        </>
+    )
+}

commafeed-client/src/components/content/add/AddCategory.tsx

@@ -1,50 +1,53 @@
-import { t, Trans } from "@lingui/macro"
+import { msg } from "@lingui/core/macro"
-import { Box, Button, Group, Stack, TextInput } from "@mantine/core"
+import { useLingui } from "@lingui/react"
-import { useForm } from "@mantine/form"
+import { Trans } from "@lingui/react/macro"
-import { client, errorToStrings } from "app/client"
+import { Box, Button, Group, Stack, TextInput } from "@mantine/core"
-import { redirectToSelectedSource } from "app/redirect/thunks"
+import { useForm } from "@mantine/form"
-import { useAppDispatch } from "app/store"
+import { client, errorToStrings } from "app/client"
-import { reloadTree } from "app/tree/thunks"
+import { redirectToSelectedSource } from "app/redirect/thunks"
-import { type AddCategoryRequest } from "app/types"
+import { useAppDispatch } from "app/store"
-import { Alert } from "components/Alert"
+import { reloadTree } from "app/tree/thunks"
-import { useAsyncCallback } from "react-async-hook"
+import type { AddCategoryRequest } from "app/types"
-import { TbFolderPlus } from "react-icons/tb"
+import { Alert } from "components/Alert"
-import { CategorySelect } from "./CategorySelect"
+import { useAsyncCallback } from "react-async-hook"
-
+import { TbFolderPlus } from "react-icons/tb"
-export function AddCategory() {
+import { CategorySelect } from "./CategorySelect"
-    const dispatch = useAppDispatch()
+
-
+export function AddCategory() {
-    const form = useForm<AddCategoryRequest>()
+    const dispatch = useAppDispatch()
-
+    const { _ } = useLingui()
-    const addCategory = useAsyncCallback(client.category.add, {
+
-        onSuccess: () => {
+    const form = useForm<AddCategoryRequest>()
-            dispatch(reloadTree())
+
-            dispatch(redirectToSelectedSource())
+    const addCategory = useAsyncCallback(client.category.add, {
-        },
+        onSuccess: () => {
-    })
+            dispatch(reloadTree())
-
+            dispatch(redirectToSelectedSource())
-    return (
+        },
-        <>
+    })
-            {addCategory.error && (
+
-                <Box mb="md">
+    return (
-                    <Alert messages={errorToStrings(addCategory.error)} />
+        <>
-                </Box>
+            {addCategory.error && (
-            )}
+                <Box mb="md">
-
+                    <Alert messages={errorToStrings(addCategory.error)} />
-            <form onSubmit={form.onSubmit(addCategory.execute)}>
+                </Box>
-                <Stack>
+            )}
-                    <TextInput label={<Trans>Category</Trans>} placeholder={t`Category`} {...form.getInputProps("name")} required />
+
-                    <CategorySelect label={<Trans>Parent</Trans>} {...form.getInputProps("parentId")} clearable />
+            <form onSubmit={form.onSubmit(addCategory.execute)}>
-                    <Group justify="center">
+                <Stack>
-                        <Button variant="default" onClick={async () => await dispatch(redirectToSelectedSource())}>
+                    <TextInput label={<Trans>Category</Trans>} placeholder={_(msg`Category`)} {...form.getInputProps("name")} required />
-                            <Trans>Cancel</Trans>
+                    <CategorySelect label={<Trans>Parent</Trans>} {...form.getInputProps("parentId")} clearable />
-                        </Button>
+                    <Group justify="center">
-                        <Button type="submit" leftSection={<TbFolderPlus size={16} />} loading={addCategory.loading}>
+                        <Button variant="default" onClick={async () => await dispatch(redirectToSelectedSource())}>
-                            <Trans>Add</Trans>
+                            <Trans>Cancel</Trans>
-                        </Button>
+                        </Button>
-                    </Group>
+                        <Button type="submit" leftSection={<TbFolderPlus size={16} />} loading={addCategory.loading}>
-                </Stack>
+                            <Trans>Add</Trans>
-            </form>
+                        </Button>
-        </>
+                    </Group>
-    )
+                </Stack>
-}
+            </form>
+        </>
+    )
+}

commafeed-client/src/components/content/add/CategorySelect.tsx

@@ -1,51 +1,55 @@
-import { t } from "@lingui/macro"
+import { msg } from "@lingui/core/macro"
-import { Select, type SelectProps } from "@mantine/core"
+import { useLingui } from "@lingui/react"
-import { type ComboboxItem } from "@mantine/core/lib/components/Combobox/Combobox.types"
+import { Select, type SelectProps } from "@mantine/core"
-import { Constants } from "app/constants"
+import type { ComboboxItem } from "@mantine/core/lib/components/Combobox/Combobox.types"
-import { useAppSelector } from "app/store"
+import { Constants } from "app/constants"
-import { type Category } from "app/types"
+import { useAppSelector } from "app/store"
-import { flattenCategoryTree } from "app/utils"
+import type { Category } from "app/types"
-
+import { flattenCategoryTree } from "app/utils"
-type CategorySelectProps = Partial<SelectProps> & {
+
-    withAll?: boolean
+type CategorySelectProps = Partial<SelectProps> & {
-    withoutCategoryIds?: string[]
+    withAll?: boolean
-}
+    withoutCategoryIds?: string[]
-
+}
-export function CategorySelect(props: CategorySelectProps) {
+
-    const rootCategory = useAppSelector(state => state.tree.rootCategory)
+export function CategorySelect(props: CategorySelectProps) {
-    const categories = rootCategory && flattenCategoryTree(rootCategory)
+    const rootCategory = useAppSelector(state => state.tree.rootCategory)
-    const categoriesById = categories?.reduce((map, c) => {
+    const { _ } = useLingui()
-        map.set(c.id, c)
+
-        return map
+    const categories = rootCategory && flattenCategoryTree(rootCategory)
-    }, new Map<string, Category>())
+    const categoriesById = categories?.reduce((map, c) => {
-    const categoryLabel = (cat: Category) => {
+        map.set(c.id, c)
-        let label = cat.name
+        return map
-
+    }, new Map<string, Category>())
-        while (cat.parentId) {
+    const categoryLabel = (category: Category) => {
-            const parent = categoriesById?.get(cat.parentId)
+        let cat = category
-            if (!parent) {
+        let label = cat.name
-                break
+
-            }
+        while (cat.parentId) {
-            label = `${parent.name} → ${label}`
+            const parent = categoriesById?.get(cat.parentId)
-            cat = parent
+            if (!parent) {
-        }
+                break
-
+            }
-        return label
+            label = `${parent.name} → ${label}`
-    }
+            cat = parent
-    const selectData: ComboboxItem[] | undefined = categories
+        }
-        ?.filter(c => c.id !== Constants.categories.all.id)
+
-        .filter(c => !props.withoutCategoryIds?.includes(c.id))
+        return label
-        .map(c => ({
+    }
-            label: categoryLabel(c),
+    const selectData: ComboboxItem[] | undefined = categories
-            value: c.id,
+        ?.filter(c => c.id !== Constants.categories.all.id)
-        }))
+        .filter(c => !props.withoutCategoryIds?.includes(c.id))
-        .sort((c1, c2) => c1.label.localeCompare(c2.label))
+        .map(c => ({
-    if (props.withAll) {
+            label: categoryLabel(c),
-        selectData?.unshift({
+            value: c.id,
-            label: t`All`,
+        }))
-            value: Constants.categories.all.id,
+        .sort((c1, c2) => c1.label.localeCompare(c2.label))
-        })
+    if (props.withAll) {
-    }
+        selectData?.unshift({
-
+            label: _(msg`All`),
-    return <Select {...props} data={selectData ?? []} disabled={!selectData} />
+            value: Constants.categories.all.id,
-}
+        })
+    }
+
+    return <Select {...props} data={selectData ?? []} disabled={!selectData} />
+}

commafeed-client/src/components/content/add/ImportOpml.tsx

@@ -1,65 +1,67 @@
-import { t, Trans } from "@lingui/macro"
+import { msg } from "@lingui/core/macro"
-import { Box, Button, FileInput, Group, Stack } from "@mantine/core"
+import { useLingui } from "@lingui/react"
-import { useForm } from "@mantine/form"
+import { Trans } from "@lingui/react/macro"
-import { client, errorToStrings } from "app/client"
+import { Box, Button, FileInput, Group, Stack } from "@mantine/core"
-import { redirectToSelectedSource } from "app/redirect/thunks"
+import { isNotEmpty, useForm } from "@mantine/form"
-import { useAppDispatch } from "app/store"
+import { client, errorToStrings } from "app/client"
-import { reloadTree } from "app/tree/thunks"
+import { redirectToSelectedSource } from "app/redirect/thunks"
-import { Alert } from "components/Alert"
+import { useAppDispatch } from "app/store"
-import { useAsyncCallback } from "react-async-hook"
+import { reloadTree } from "app/tree/thunks"
-import { TbFileImport } from "react-icons/tb"
+import { Alert } from "components/Alert"
-
+import { useAsyncCallback } from "react-async-hook"
-export function ImportOpml() {
+import { TbFileImport } from "react-icons/tb"
-    const dispatch = useAppDispatch()
+
-
+export function ImportOpml() {
-    const form = useForm<{ file: File }>({
+    const dispatch = useAppDispatch()
-        validate: {
+    const { _ } = useLingui()
-            file: () => t`file is required`,
+
-        },
+    const form = useForm<{ file: File }>({
-    })
+        validate: {
-
+            file: isNotEmpty(_(msg`OPML file is required`)),
-    const importOpml = useAsyncCallback(client.feed.importOpml, {
+        },
-        onSuccess: () => {
+    })
-            dispatch(reloadTree())
+
-            dispatch(redirectToSelectedSource())
+    const importOpml = useAsyncCallback(client.feed.importOpml, {
-        },
+        onSuccess: () => {
-    })
+            dispatch(reloadTree())
-
+            dispatch(redirectToSelectedSource())
-    return (
+        },
-        <>
+    })
-            {importOpml.error && (
+
-                <Box mb="md">
+    return (
-                    <Alert messages={errorToStrings(importOpml.error)} />
+        <>
-                </Box>
+            {importOpml.error && (
-            )}
+                <Box mb="md">
-
+                    <Alert messages={errorToStrings(importOpml.error)} />
-            <form onSubmit={form.onSubmit(async v => await importOpml.execute(v.file))}>
+                </Box>
-                <Stack>
+            )}
-                    <FileInput
+
-                        label={<Trans>OPML file</Trans>}
+            <form onSubmit={form.onSubmit(async v => await importOpml.execute(v.file))}>
-                        leftSection={<TbFileImport />}
+                <Stack>
-                        // https://github.com/mantinedev/mantine/issues/5401
+                    <FileInput
-                        {...{ placeholder: t`OPML file` }}
+                        label={<Trans>OPML file</Trans>}
-                        description={
+                        leftSection={<TbFileImport />}
-                            <Trans>
+                        placeholder={_(msg`OPML file`)}
-                                An opml file is an XML file containing feed URLs and categories. You can get an OPML file by exporting your
+                        description={
-                                data from other feed reading services.
+                            <Trans>
-                            </Trans>
+                                An opml file is an XML file containing feed URLs and categories. You can get an OPML file by exporting your
-                        }
+                                data from other feed reading services.
-                        {...form.getInputProps("file")}
+                            </Trans>
-                        required
+                        }
-                        accept="application/xml"
+                        {...form.getInputProps("file")}
-                    />
+                        required
-                    <Group justify="center">
+                        accept=".xml,.opml"
-                        <Button variant="default" onClick={async () => await dispatch(redirectToSelectedSource())}>
+                    />
-                            <Trans>Cancel</Trans>
+                    <Group justify="center">
-                        </Button>
+                        <Button variant="default" onClick={async () => await dispatch(redirectToSelectedSource())}>
-                        <Button type="submit" leftSection={<TbFileImport size={16} />} loading={importOpml.loading}>
+                            <Trans>Cancel</Trans>
-                            <Trans>Import</Trans>
+                        </Button>
-                        </Button>
+                        <Button type="submit" leftSection={<TbFileImport size={16} />} loading={importOpml.loading}>
-                    </Group>
+                            <Trans>Import</Trans>
-                </Stack>
+                        </Button>
-            </form>
+                    </Group>
-        </>
+                </Stack>
-    )
+            </form>
-}
+        </>
+    )
+}

commafeed-client/src/components/content/add/Subscribe.tsx

@@ -1,129 +1,129 @@
-import { Trans } from "@lingui/macro"
+import { Trans } from "@lingui/react/macro"
-import { Box, Button, Group, Stack, Stepper, TextInput } from "@mantine/core"
+import { Box, Button, Group, Stack, Stepper, TextInput } from "@mantine/core"
-import { useForm } from "@mantine/form"
+import { useForm } from "@mantine/form"
-import { client, errorToStrings } from "app/client"
+import { client, errorToStrings } from "app/client"
-import { Constants } from "app/constants"
+import { Constants } from "app/constants"
-import { redirectToFeed, redirectToSelectedSource } from "app/redirect/thunks"
+import { redirectToFeed, redirectToSelectedSource } from "app/redirect/thunks"
-import { useAppDispatch } from "app/store"
+import { useAppDispatch } from "app/store"
-import { reloadTree } from "app/tree/thunks"
+import { reloadTree } from "app/tree/thunks"
-import { type FeedInfoRequest, type SubscribeRequest } from "app/types"
+import type { FeedInfoRequest, SubscribeRequest } from "app/types"
-import { Alert } from "components/Alert"
+import { Alert } from "components/Alert"
-import { useState } from "react"
+import { useState } from "react"
-import { useAsyncCallback } from "react-async-hook"
+import { useAsyncCallback } from "react-async-hook"
-import { TbRss } from "react-icons/tb"
+import { TbRss } from "react-icons/tb"
-import { CategorySelect } from "./CategorySelect"
+import { CategorySelect } from "./CategorySelect"
-
+
-export function Subscribe() {
+export function Subscribe() {
-    const [activeStep, setActiveStep] = useState(0)
+    const [activeStep, setActiveStep] = useState(0)
-    const dispatch = useAppDispatch()
+    const dispatch = useAppDispatch()
-
+
-    const step0Form = useForm<FeedInfoRequest>({
+    const step0Form = useForm<FeedInfoRequest>({
-        initialValues: {
+        initialValues: {
-            url: "",
+            url: "",
-        },
+        },
-    })
+    })
-
+
-    const step1Form = useForm<SubscribeRequest>({
+    const step1Form = useForm<SubscribeRequest>({
-        initialValues: {
+        initialValues: {
-            url: "",
+            url: "",
-            title: "",
+            title: "",
-            categoryId: Constants.categories.all.id,
+            categoryId: Constants.categories.all.id,
-        },
+        },
-    })
+    })
-
+
-    const fetchFeed = useAsyncCallback(client.feed.fetchFeed, {
+    const fetchFeed = useAsyncCallback(client.feed.fetchFeed, {
-        onSuccess: ({ data }) => {
+        onSuccess: ({ data }) => {
-            step1Form.setFieldValue("url", data.url)
+            step1Form.setFieldValue("url", data.url)
-            step1Form.setFieldValue("title", data.title)
+            step1Form.setFieldValue("title", data.title)
-            setActiveStep(step => step + 1)
+            setActiveStep(step => step + 1)
-        },
+        },
-    })
+    })
-    const subscribe = useAsyncCallback(client.feed.subscribe, {
+    const subscribe = useAsyncCallback(client.feed.subscribe, {
-        onSuccess: sub => {
+        onSuccess: async sub => {
-            dispatch(reloadTree())
+            await dispatch(reloadTree())
-            dispatch(redirectToFeed(sub.data))
+            dispatch(redirectToFeed(sub.data))
-        },
+        },
-    })
+    })
-
+
-    const previousStep = () => {
+    const previousStep = () => {
-        if (activeStep === 0) {
+        if (activeStep === 0) {
-            dispatch(redirectToSelectedSource())
+            dispatch(redirectToSelectedSource())
-        } else {
+        } else {
-            setActiveStep(activeStep - 1)
+            setActiveStep(activeStep - 1)
-        }
+        }
-    }
+    }
-    const nextStep = (e: React.FormEvent<HTMLFormElement>) => {
+    const nextStep = (e: React.FormEvent<HTMLFormElement>) => {
-        if (activeStep === 0) {
+        if (activeStep === 0) {
-            step0Form.onSubmit(fetchFeed.execute)(e)
+            step0Form.onSubmit(fetchFeed.execute)(e)
-        } else if (activeStep === 1) {
+        } else if (activeStep === 1) {
-            step1Form.onSubmit(subscribe.execute)(e)
+            step1Form.onSubmit(subscribe.execute)(e)
-        }
+        }
-    }
+    }
-
+
-    return (
+    return (
-        <>
+        <>
-            {fetchFeed.error && (
+            {fetchFeed.error && (
-                <Box mb="md">
+                <Box mb="md">
-                    <Alert messages={errorToStrings(fetchFeed.error)} />
+                    <Alert messages={errorToStrings(fetchFeed.error)} />
-                </Box>
+                </Box>
-            )}
+            )}
-
+
-            {subscribe.error && (
+            {subscribe.error && (
-                <Box mb="md">
+                <Box mb="md">
-                    <Alert messages={errorToStrings(subscribe.error)} />
+                    <Alert messages={errorToStrings(subscribe.error)} />
-                </Box>
+                </Box>
-            )}
+            )}
-
+
-            <form onSubmit={nextStep}>
+            <form onSubmit={nextStep}>
-                <Stepper active={activeStep} onStepClick={setActiveStep}>
+                <Stepper active={activeStep} onStepClick={setActiveStep}>
-                    <Stepper.Step
+                    <Stepper.Step
-                        label={<Trans>Analyze feed</Trans>}
+                        label={<Trans>Analyze feed</Trans>}
-                        description={<Trans>Check that the feed is working</Trans>}
+                        description={<Trans>Check that the feed is working</Trans>}
-                        allowStepSelect={activeStep === 1}
+                        allowStepSelect={activeStep === 1}
-                    >
+                    >
-                        <TextInput
+                        <TextInput
-                            label={<Trans>Feed URL</Trans>}
+                            label={<Trans>Feed URL</Trans>}
-                            placeholder="https://www.mysite.com/rss"
+                            placeholder="https://www.mysite.com/rss"
-                            description={
+                            description={
-                                <Trans>
+                                <Trans>
-                                    The URL for the feed you want to subscribe to. You can also use the website's url directly and CommaFeed
+                                    The URL for the feed you want to subscribe to. You can also use the website's url directly and CommaFeed
-                                    will try to find the feed in the page.
+                                    will try to find the feed in the page.
-                                </Trans>
+                                </Trans>
-                            }
+                            }
-                            required
+                            required
-                            autoFocus
+                            autoFocus
-                            {...step0Form.getInputProps("url")}
+                            {...step0Form.getInputProps("url")}
-                        />
+                        />
-                    </Stepper.Step>
+                    </Stepper.Step>
-                    <Stepper.Step
+                    <Stepper.Step
-                        label={<Trans>Subscribe</Trans>}
+                        label={<Trans>Subscribe</Trans>}
-                        description={<Trans>Subscribe to the feed</Trans>}
+                        description={<Trans>Subscribe to the feed</Trans>}
-                        allowStepSelect={false}
+                        allowStepSelect={false}
-                    >
+                    >
-                        <Stack>
+                        <Stack>
-                            <TextInput label={<Trans>Feed URL</Trans>} {...step1Form.getInputProps("url")} disabled />
+                            <TextInput label={<Trans>Feed URL</Trans>} {...step1Form.getInputProps("url")} disabled />
-                            <TextInput label={<Trans>Feed name</Trans>} {...step1Form.getInputProps("title")} required autoFocus />
+                            <TextInput label={<Trans>Feed name</Trans>} {...step1Form.getInputProps("title")} required autoFocus />
-                            <CategorySelect label={<Trans>Category</Trans>} {...step1Form.getInputProps("categoryId")} clearable />
+                            <CategorySelect label={<Trans>Category</Trans>} {...step1Form.getInputProps("categoryId")} clearable />
-                        </Stack>
+                        </Stack>
-                    </Stepper.Step>
+                    </Stepper.Step>
-                </Stepper>
+                </Stepper>
-
+
-                <Group justify="center" mt="xl">
+                <Group justify="center" mt="xl">
-                    <Button variant="default" onClick={previousStep}>
+                    <Button variant="default" onClick={previousStep}>
-                        <Trans>Back</Trans>
+                        <Trans>Back</Trans>
-                    </Button>
+                    </Button>
-                    {activeStep === 0 && (
+                    {activeStep === 0 && (
-                        <Button type="submit" loading={fetchFeed.loading}>
+                        <Button type="submit" loading={fetchFeed.loading}>
-                            <Trans>Next</Trans>
+                            <Trans>Next</Trans>
-                        </Button>
+                        </Button>
-                    )}
+                    )}
-                    {activeStep === 1 && (
+                    {activeStep === 1 && (
-                        <Button type="submit" leftSection={<TbRss size={16} />} loading={fetchFeed.loading || subscribe.loading}>
+                        <Button type="submit" leftSection={<TbRss size={16} />} loading={fetchFeed.loading || subscribe.loading}>
-                            <Trans>Subscribe</Trans>
+                            <Trans>Subscribe</Trans>
-                        </Button>
+                        </Button>
-                    )}
+                    )}
-                </Group>
+                </Group>
-            </form>
+            </form>
-        </>
+        </>
-    )
+    )
-}
+}

commafeed-client/src/components/content/header/FeedEntryCompactHeader.tsx

@@ -1,66 +1,72 @@
-import { Box, Text } from "@mantine/core"
+import { Box } from "@mantine/core"
-import { type Entry } from "app/types"
+import type { Entry } from "app/types"
-import { RelativeDate } from "components/RelativeDate"
+import { RelativeDate } from "components/RelativeDate"
-import { OnDesktop } from "components/responsive/OnDesktop"
+import { FeedFavicon } from "components/content/FeedFavicon"
-import { tss } from "tss"
+import { OpenExternalLink } from "components/content/header/OpenExternalLink"
-import { FeedEntryTitle } from "./FeedEntryTitle"
+import { Star } from "components/content/header/Star"
-import { FeedFavicon } from "./FeedFavicon"
+import { OnDesktop } from "components/responsive/OnDesktop"
-
+import { tss } from "tss"
-export interface FeedEntryHeaderProps {
+import { FeedEntryTitle } from "./FeedEntryTitle"
-    entry: Entry
+
-}
+export interface FeedEntryHeaderProps {
-
+    entry: Entry
-const useStyles = tss
+    showStarIcon?: boolean
-    .withParams<{
+    showExternalLinkIcon?: boolean
-        read: boolean
+}
-    }>()
+
-    .create(({ colorScheme, read }) => ({
+const useStyles = tss
-        wrapper: {
+    .withParams<{
-            display: "flex",
+        read: boolean
-            alignItems: "center",
+    }>()
-            columnGap: "10px",
+    .create(({ colorScheme, read }) => ({
-        },
+        wrapper: {
-        title: {
+            display: "flex",
-            flexGrow: 1,
+            alignItems: "center",
-            fontWeight: colorScheme === "light" && !read ? "bold" : "inherit",
+            columnGap: "10px",
-            whiteSpace: "nowrap",
+        },
-            overflow: "hidden",
+        title: {
-            textOverflow: "ellipsis",
+            flexGrow: 1,
-        },
+            fontWeight: colorScheme === "light" && !read ? "bold" : "inherit",
-        feedName: {
+            whiteSpace: "nowrap",
-            width: "145px",
+            overflow: "hidden",
-            minWidth: "145px",
+            textOverflow: "ellipsis",
-            whiteSpace: "nowrap",
+        },
-            overflow: "hidden",
+        feedName: {
-            textOverflow: "ellipsis",
+            width: "145px",
-        },
+            minWidth: "145px",
-        date: {
+            whiteSpace: "nowrap",
-            whiteSpace: "nowrap",
+            overflow: "hidden",
-        },
+            textOverflow: "ellipsis",
-    }))
+        },
-
+        date: {
-export function FeedEntryCompactHeader(props: FeedEntryHeaderProps) {
+            whiteSpace: "nowrap",
-    const { classes } = useStyles({
+        },
-        read: props.entry.read,
+    }))
-    })
+
-    return (
+export function FeedEntryCompactHeader(props: FeedEntryHeaderProps) {
-        <Box className={classes.wrapper}>
+    const { classes } = useStyles({
-            <Box>
+        read: props.entry.read,
-                <FeedFavicon url={props.entry.iconUrl} />
+    })
-            </Box>
+    return (
-            <OnDesktop>
+        <Box className={classes.wrapper}>
-                <Text c="dimmed" className={classes.feedName}>
+            {props.showStarIcon && <Star entry={props.entry} />}
-                    {props.entry.feedName}
+            <Box>
-                </Text>
+                <FeedFavicon url={props.entry.iconUrl} />
-            </OnDesktop>
+            </Box>
-            <Box className={classes.title}>
+            <OnDesktop>
-                <FeedEntryTitle entry={props.entry} />
+                <Box c="dimmed" className={classes.feedName}>
-            </Box>
+                    {props.entry.feedName}
-            <OnDesktop>
+                </Box>
-                <Text c="dimmed" className={classes.date}>
+            </OnDesktop>
-                    <RelativeDate date={props.entry.date} />
+            <Box className={classes.title}>
-                </Text>
+                <FeedEntryTitle entry={props.entry} />
-            </OnDesktop>
+            </Box>
-        </Box>
+            <OnDesktop>
-    )
+                <Box c="dimmed" className={classes.date}>
-}
+                    <RelativeDate date={props.entry.date} />
+                </Box>
+            </OnDesktop>
+            {props.showExternalLinkIcon && <OpenExternalLink entry={props.entry} />}
+        </Box>
+    )
+}

commafeed-client/src/components/content/header/FeedEntryHeader.tsx

@@ -0,0 +1,62 @@
+import { Box, Flex, Space } from "@mantine/core"
+import type { Entry } from "app/types"
+import { RelativeDate } from "components/RelativeDate"
+import { FeedFavicon } from "components/content/FeedFavicon"
+import { OpenExternalLink } from "components/content/header/OpenExternalLink"
+import { Star } from "components/content/header/Star"
+import { tss } from "tss"
+import { FeedEntryTitle } from "./FeedEntryTitle"
+
+export interface FeedEntryHeaderProps {
+    entry: Entry
+    expanded: boolean
+    showStarIcon?: boolean
+    showExternalLinkIcon?: boolean
+}
+
+const useStyles = tss
+    .withParams<{
+        read: boolean
+    }>()
+    .create(({ colorScheme, read }) => ({
+        main: {
+            fontWeight: colorScheme === "light" && !read ? "bold" : "inherit",
+        },
+    }))
+
+export function FeedEntryHeader(props: FeedEntryHeaderProps) {
+    const { classes } = useStyles({
+        read: props.entry.read,
+    })
+    return (
+        <Box className="cf-header">
+            <Flex align="flex-start" justify="space-between" className="cf-header-title">
+                <Flex align="flex-start" className={classes.main}>
+                    {props.showStarIcon && (
+                        <Box ml={-5}>
+                            <Star entry={props.entry} />
+                        </Box>
+                    )}
+                    <FeedEntryTitle entry={props.entry} />
+                </Flex>
+                {props.showExternalLinkIcon && <OpenExternalLink entry={props.entry} />}
+            </Flex>
+            <Flex align="center" className="cf-header-subtitle">
+                <FeedFavicon url={props.entry.iconUrl} />
+                <Space w={6} />
+                <Box c="dimmed">
+                    {props.entry.feedName}
+                    <span> · </span>
+                    <RelativeDate date={props.entry.date} />
+                </Box>
+            </Flex>
+            {props.expanded && (
+                <Box className="cf-header-details">
+                    {props.entry.author && <span>by {props.entry.author}</span>}
+                    {props.entry.author && props.entry.categories && <span>&nbsp;·&nbsp;</span>}
+                    {props.entry.categories && <span>{props.entry.categories}</span>}
+                </Box>
+            )}
+        </Box>
+    )
+}

commafeed-client/src/components/content/header/FeedEntryTitle.tsx

@@ -1,22 +1,22 @@
-import { Highlight } from "@mantine/core"
+import { Highlight } from "@mantine/core"
-import { useAppSelector } from "app/store"
+import { useAppSelector } from "app/store"
-import { type Entry } from "app/types"
+import type { Entry } from "app/types"
-
+
-export interface FeedEntryTitleProps {
+export interface FeedEntryTitleProps {
-    entry: Entry
+    entry: Entry
-}
+}
-
+
-export function FeedEntryTitle(props: FeedEntryTitleProps) {
+export function FeedEntryTitle(props: FeedEntryTitleProps) {
-    const search = useAppSelector(state => state.entries.search)
+    const search = useAppSelector(state => state.entries.search)
-    const keywords = search?.split(" ")
+    const keywords = search?.split(" ")
-    return (
+    return (
-        <Highlight
+        <Highlight
-            inherit
+            inherit
-            highlight={keywords ?? ""}
+            highlight={keywords ?? ""}
-            // make sure ellipsis is shown when title is too long
+            // make sure ellipsis is shown when title is too long
-            span
+            span
-        >
+        >
-            {props.entry.title}
+            {props.entry.title}
-        </Highlight>
+        </Highlight>
-    )
+    )
-}
+}

commafeed-client/src/components/content/header/OpenExternalLink.tsx

@@ -0,0 +1,30 @@
+import { Trans } from "@lingui/react/macro"
+import { ActionIcon, Anchor, Tooltip } from "@mantine/core"
+import { Constants } from "app/constants"
+import { markEntry } from "app/entries/thunks"
+import { useAppDispatch } from "app/store"
+import type { Entry } from "app/types"
+import { TbExternalLink } from "react-icons/tb"
+
+export function OpenExternalLink(props: { entry: Entry }) {
+    const dispatch = useAppDispatch()
+    const onClick = (e: React.MouseEvent) => {
+        e.stopPropagation()
+        dispatch(
+            markEntry({
+                entry: props.entry,
+                read: true,
+            })
+        )
+    }
+
+    return (
+        <Anchor href={props.entry.url} target="_blank" rel="noreferrer" onClick={onClick}>
+            <Tooltip label={<Trans>Open link</Trans>} openDelay={Constants.tooltip.delay}>
+                <ActionIcon variant="transparent" c="dimmed">
+                    <TbExternalLink size={18} />
+                </ActionIcon>
+            </Tooltip>
+        </Anchor>
+    )
+}

commafeed-client/src/components/content/header/Star.tsx

@@ -0,0 +1,29 @@
+import { Trans } from "@lingui/react/macro"
+import { ActionIcon, Tooltip } from "@mantine/core"
+import { Constants } from "app/constants"
+import { starEntry } from "app/entries/thunks"
+import { useAppDispatch } from "app/store"
+import type { Entry } from "app/types"
+import { TbStar, TbStarFilled } from "react-icons/tb"
+
+export function Star(props: { entry: Entry }) {
+    const dispatch = useAppDispatch()
+    const onClick = (e: React.MouseEvent) => {
+        e.stopPropagation()
+        e.preventDefault()
+        dispatch(
+            starEntry({
+                entry: props.entry,
+                starred: !props.entry.starred,
+            })
+        )
+    }
+
+    return (
+        <Tooltip label={props.entry.starred ? <Trans>Unstar</Trans> : <Trans>Star</Trans>} openDelay={Constants.tooltip.delay}>
+            <ActionIcon variant="transparent" onClick={onClick}>
+                {props.entry.starred ? <TbStarFilled size={18} /> : <TbStar size={18} />}
+            </ActionIcon>
+        </Tooltip>
+    )
+}

commafeed-client/src/components/header/Header.tsx

@@ -1,169 +1,178 @@
-import { t, Trans } from "@lingui/macro"
+import { msg } from "@lingui/core/macro"
-import { Box, Center, CloseButton, Divider, Group, Indicator, Popover, TextInput } from "@mantine/core"
+import { useLingui } from "@lingui/react"
-import { useForm } from "@mantine/form"
+import { Box, Center, CloseButton, Divider, Group, Indicator, Popover, TextInput } from "@mantine/core"
-import { reloadEntries, search, selectNextEntry, selectPreviousEntry } from "app/entries/thunks"
+import { useForm } from "@mantine/form"
-import { useAppDispatch, useAppSelector } from "app/store"
+import { markAllAsReadWithConfirmationIfRequired, reloadEntries, search, selectNextEntry, selectPreviousEntry } from "app/entries/thunks"
-import { changeReadingMode, changeReadingOrder } from "app/user/thunks"
+import { useAppDispatch, useAppSelector } from "app/store"
-import { ActionButton } from "components/ActionButton"
+import { changeReadingMode, changeReadingOrder } from "app/user/thunks"
-import { Loader } from "components/Loader"
+import { ActionButton } from "components/ActionButton"
-import { useActionButton } from "hooks/useActionButton"
+import { Loader } from "components/Loader"
-import { useBrowserExtension } from "hooks/useBrowserExtension"
+import { useActionButton } from "hooks/useActionButton"
-import { useMobile } from "hooks/useMobile"
+import { useBrowserExtension } from "hooks/useBrowserExtension"
-import { useEffect } from "react"
+import { useMobile } from "hooks/useMobile"
-import {
+import { useEffect } from "react"
-    TbArrowDown,
+import {
-    TbArrowUp,
+    TbArrowDown,
-    TbExternalLink,
+    TbArrowUp,
-    TbEye,
+    TbChecks,
-    TbEyeOff,
+    TbExternalLink,
-    TbRefresh,
+    TbEye,
-    TbSearch,
+    TbEyeOff,
-    TbSettings,
+    TbRefresh,
-    TbSortAscending,
+    TbSearch,
-    TbSortDescending,
+    TbSettings,
-    TbUser,
+    TbSortAscending,
-} from "react-icons/tb"
+    TbSortDescending,
-import { MarkAllAsReadButton } from "./MarkAllAsReadButton"
+    TbUser,
-import { ProfileMenu } from "./ProfileMenu"
+} from "react-icons/tb"
-
+import { ProfileMenu } from "./ProfileMenu"
-function HeaderDivider() {
+
-    return <Divider orientation="vertical" />
+function HeaderDivider() {
-}
+    return <Divider orientation="vertical" />
-
+}
-function HeaderToolbar(props: { children: React.ReactNode }) {
+
-    const { spacing } = useActionButton()
+function HeaderToolbar(props: { children: React.ReactNode }) {
-    const mobile = useMobile("480px")
+    const { spacing } = useActionButton()
-    return mobile ? (
+    const mobile = useMobile("480px")
-        // on mobile use all available width
+    return mobile ? (
-        <Box
+        // on mobile use all available width
-            style={{
+        <Box
-                width: "100%",
+            style={{
-                display: "flex",
+                width: "100%",
-                justifyContent: "space-between",
+                display: "flex",
-            }}
+                justifyContent: "space-between",
-        >
+            }}
-            {props.children}
+            className="cf-toolbar"
-        </Box>
+        >
-    ) : (
+            {props.children}
-        <Group gap={spacing}>{props.children}</Group>
+        </Box>
-    )
+    ) : (
-}
+        <Group gap={spacing} className="cf-toolbar">
-
+            {props.children}
-const iconSize = 18
+        </Group>
-
+    )
-export function Header() {
+}
-    const settings = useAppSelector(state => state.user.settings)
+
-    const profile = useAppSelector(state => state.user.profile)
+const iconSize = 18
-    const searchFromStore = useAppSelector(state => state.entries.search)
+
-    const { isBrowserExtensionPopup, openSettingsPage, openAppInNewTab } = useBrowserExtension()
+export function Header() {
-    const dispatch = useAppDispatch()
+    const settings = useAppSelector(state => state.user.settings)
-
+    const profile = useAppSelector(state => state.user.profile)
-    const searchForm = useForm<{ search: string }>({
+    const searchFromStore = useAppSelector(state => state.entries.search)
-        validate: {
+    const { isBrowserExtensionPopup, openSettingsPage, openAppInNewTab } = useBrowserExtension()
-            search: value => (value.length > 0 && value.length < 3 ? t`Search requires at least 3 characters` : null),
+    const dispatch = useAppDispatch()
-        },
+    const { _ } = useLingui()
-    })
+
-    const { setValues } = searchForm
+    const searchForm = useForm<{ search: string }>({
-
+        validate: {
-    useEffect(() => {
+            search: value => (value.length > 0 && value.length < 3 ? _(msg`Search requires at least 3 characters`) : null),
-        setValues({
+        },
-            search: searchFromStore,
+    })
-        })
+    const { setValues } = searchForm
-    }, [setValues, searchFromStore])
+
-
+    useEffect(() => {
-    if (!settings) return <Loader />
+        setValues({
-    return (
+            search: searchFromStore,
-        <Center>
+        })
-            <HeaderToolbar>
+    }, [setValues, searchFromStore])
-                <ActionButton
+
-                    icon={<TbArrowUp size={iconSize} />}
+    if (!settings) return <Loader />
-                    label={<Trans>Previous</Trans>}
+    return (
-                    onClick={async () =>
+        <Center className="cf-toolbar-wrapper">
-                        await dispatch(
+            <HeaderToolbar>
-                            selectPreviousEntry({
+                <ActionButton
-                                expand: true,
+                    icon={<TbArrowUp size={iconSize} />}
-                                markAsRead: true,
+                    label={msg`Previous`}
-                                scrollToEntry: true,
+                    onClick={async () =>
-                            })
+                        await dispatch(
-                        )
+                            selectPreviousEntry({
-                    }
+                                expand: true,
-                />
+                                markAsRead: true,
-                <ActionButton
+                                scrollToEntry: true,
-                    icon={<TbArrowDown size={iconSize} />}
+                            })
-                    label={<Trans>Next</Trans>}
+                        )
-                    onClick={async () =>
+                    }
-                        await dispatch(
+                />
-                            selectNextEntry({
+                <ActionButton
-                                expand: true,
+                    icon={<TbArrowDown size={iconSize} />}
-                                markAsRead: true,
+                    label={msg`Next`}
-                                scrollToEntry: true,
+                    onClick={async () =>
-                            })
+                        await dispatch(
-                        )
+                            selectNextEntry({
-                    }
+                                expand: true,
-                />
+                                markAsRead: true,
-
+                                scrollToEntry: true,
-                <HeaderDivider />
+                            })
-
+                        )
-                <ActionButton
+                    }
-                    icon={<TbRefresh size={iconSize} />}
+                />
-                    label={<Trans>Refresh</Trans>}
+
-                    onClick={async () => await dispatch(reloadEntries())}
+                <HeaderDivider />
-                />
+
-                <MarkAllAsReadButton iconSize={iconSize} />
+                <ActionButton
-
+                    icon={<TbRefresh size={iconSize} />}
-                <HeaderDivider />
+                    label={msg`Refresh`}
-
+                    onClick={async () => await dispatch(reloadEntries())}
-                <ActionButton
+                />
-                    icon={settings.readingMode === "all" ? <TbEye size={iconSize} /> : <TbEyeOff size={iconSize} />}
+                <ActionButton
-                    label={settings.readingMode === "all" ? <Trans>All</Trans> : <Trans>Unread</Trans>}
+                    icon={<TbChecks size={iconSize} />}
-                    onClick={async () => await dispatch(changeReadingMode(settings.readingMode === "all" ? "unread" : "all"))}
+                    label={msg`Mark all as read`}
-                />
+                    onClick={() => dispatch(markAllAsReadWithConfirmationIfRequired())}
-                <ActionButton
+                />
-                    icon={settings.readingOrder === "asc" ? <TbSortAscending size={iconSize} /> : <TbSortDescending size={iconSize} />}
+
-                    label={settings.readingOrder === "asc" ? <Trans>Asc</Trans> : <Trans>Desc</Trans>}
+                <HeaderDivider />
-                    onClick={async () => await dispatch(changeReadingOrder(settings.readingOrder === "asc" ? "desc" : "asc"))}
+
-                />
+                <ActionButton
-
+                    icon={settings.readingMode === "all" ? <TbEye size={iconSize} /> : <TbEyeOff size={iconSize} />}
-                <Popover>
+                    label={settings.readingMode === "all" ? msg`All` : msg`Unread`}
-                    <Popover.Target>
+                    onClick={async () => await dispatch(changeReadingMode(settings.readingMode === "all" ? "unread" : "all"))}
-                        <Indicator disabled={!searchFromStore}>
+                />
-                            <ActionButton icon={<TbSearch size={iconSize} />} label={<Trans>Search</Trans>} />
+                <ActionButton
-                        </Indicator>
+                    icon={settings.readingOrder === "asc" ? <TbSortAscending size={iconSize} /> : <TbSortDescending size={iconSize} />}
-                    </Popover.Target>
+                    label={settings.readingOrder === "asc" ? msg`Asc` : msg`Desc`}
-                    <Popover.Dropdown>
+                    onClick={async () => await dispatch(changeReadingOrder(settings.readingOrder === "asc" ? "desc" : "asc"))}
-                        <form onSubmit={searchForm.onSubmit(async values => await dispatch(search(values.search)))}>
+                />
-                            <TextInput
+
-                                placeholder={t`Search`}
+                <Popover>
-                                {...searchForm.getInputProps("search")}
+                    <Popover.Target>
-                                leftSection={<TbSearch size={iconSize} />}
+                        <Indicator disabled={!searchFromStore}>
-                                rightSection={<CloseButton onClick={async () => await (searchFromStore && dispatch(search("")))} />}
+                            <ActionButton icon={<TbSearch size={iconSize} />} label={msg`Search`} />
-                                autoFocus
+                        </Indicator>
-                            />
+                    </Popover.Target>
-                        </form>
+                    <Popover.Dropdown>
-                    </Popover.Dropdown>
+                        <form onSubmit={searchForm.onSubmit(async values => await dispatch(search(values.search)))}>
-                </Popover>
+                            <TextInput
-
+                                placeholder={_(msg`Search`)}
-                <HeaderDivider />
+                                {...searchForm.getInputProps("search")}
-
+                                leftSection={<TbSearch size={iconSize} />}
-                <ProfileMenu control={<ActionButton icon={<TbUser size={iconSize} />} label={profile?.name} />} />
+                                rightSection={<CloseButton onClick={async () => await (searchFromStore && dispatch(search("")))} />}
-
+                                autoFocus
-                {isBrowserExtensionPopup && (
+                            />
-                    <>
+                        </form>
-                        <HeaderDivider />
+                    </Popover.Dropdown>
-
+                </Popover>
-                        <ActionButton
+
-                            icon={<TbSettings size={iconSize} />}
+                <HeaderDivider />
-                            label={<Trans>Extension options</Trans>}
+
-                            onClick={() => openSettingsPage()}
+                <ProfileMenu control={<ActionButton icon={<TbUser size={iconSize} />} label={profile?.name} />} />
-                        />
+
-                        <ActionButton
+                {isBrowserExtensionPopup && (
-                            icon={<TbExternalLink size={iconSize} />}
+                    <>
-                            label={<Trans>Open CommaFeed</Trans>}
+                        <HeaderDivider />
-                            onClick={() => openAppInNewTab()}
+
-                        />
+                        <ActionButton
-                    </>
+                            icon={<TbSettings size={iconSize} />}
-                )}
+                            label={msg`Extension options`}
-            </HeaderToolbar>
+                            onClick={() => openSettingsPage()}
-        </Center>
+                        />
-    )
+                        <ActionButton
-}
+                            icon={<TbExternalLink size={iconSize} />}
+                            label={msg`Open CommaFeed`}
+                            onClick={() => openAppInNewTab()}
+                        />
+                    </>
+                )}
+            </HeaderToolbar>
+        </Center>
+    )
+}

commafeed-client/src/components/header/MarkAllAsReadButton.tsx

@@ -1,97 +0,0 @@
-import { Trans } from "@lingui/macro"
-
-import { Button, Code, Group, Modal, Slider, Stack, Text } from "@mantine/core"
-import { markAllEntries } from "app/entries/thunks"
-import { useAppDispatch, useAppSelector } from "app/store"
-import { ActionButton } from "components/ActionButton"
-import { useState } from "react"
-import { TbChecks } from "react-icons/tb"
-
-export function MarkAllAsReadButton(props: { iconSize: number }) {
-    const [opened, setOpened] = useState(false)
-    const [threshold, setThreshold] = useState(0)
-    const source = useAppSelector(state => state.entries.source)
-    const sourceLabel = useAppSelector(state => state.entries.sourceLabel)
-    const entriesTimestamp = useAppSelector(state => state.entries.timestamp) ?? Date.now()
-    const markAllAsReadConfirmation = useAppSelector(state => state.user.settings?.markAllAsReadConfirmation)
-    const dispatch = useAppDispatch()
-
-    const buttonClicked = () => {
-        if (markAllAsReadConfirmation) {
-            setThreshold(0)
-            setOpened(true)
-        } else {
-            dispatch(
-                markAllEntries({
-                    sourceType: source.type,
-                    req: {
-                        id: source.id,
-                        read: true,
-                        olderThan: Date.now(),
-                        insertedBefore: entriesTimestamp,
-                    },
-                })
-            )
-        }
-    }
-
-    return (
-        <>
-            <Modal opened={opened} onClose={() => setOpened(false)} title={<Trans>Mark all entries as read</Trans>}>
-                <Stack>
-                    <Text size="sm">
-                        {threshold === 0 && (
-                            <Trans>
-                                Are you sure you want to mark all entries of <Code>{sourceLabel}</Code> as read?
-                            </Trans>
-                        )}
-                        {threshold > 0 && (
-                            <Trans>
-                                Are you sure you want to mark entries older than {threshold} days of <Code>{sourceLabel}</Code> as read?
-                            </Trans>
-                        )}
-                    </Text>
-                    <Slider
-                        py="xl"
-                        min={0}
-                        max={28}
-                        marks={[
-                            { value: 0, label: "0" },
-                            { value: 7, label: "7" },
-                            { value: 14, label: "14" },
-                            { value: 21, label: "21" },
-                            { value: 28, label: "28" },
-                        ]}
-                        value={threshold}
-                        onChange={setThreshold}
-                    />
-                    <Group justify="flex-end">
-                        <Button variant="default" onClick={() => setOpened(false)}>
-                            <Trans>Cancel</Trans>
-                        </Button>
-                        <Button
-                            color="red"
-                            onClick={() => {
-                                setOpened(false)
-                                dispatch(
-                                    markAllEntries({
-                                        sourceType: source.type,
-                                        req: {
-                                            id: source.id,
-                                            read: true,
-                                            olderThan: Date.now() - threshold * 24 * 60 * 60 * 1000,
-                                            insertedBefore: entriesTimestamp,
-                                        },
-                                    })
-                                )
-                            }}
-                        >
-                            <Trans>Confirm</Trans>
-                        </Button>
-                    </Group>
-                </Stack>
-            </Modal>
-            <ActionButton icon={<TbChecks size={props.iconSize} />} label={<Trans>Mark all as read</Trans>} onClick={buttonClicked} />
-        </>
-    )
-}

commafeed-client/src/components/header/ProfileMenu.tsx

@@ -1,217 +1,259 @@
-import { Trans } from "@lingui/macro"
+import { Trans } from "@lingui/react/macro"
-import {
+import {
-    Box,
+    Box,
-    Divider,
+    Divider,
-    Group,
+    Group,
-    type MantineColorScheme,
+    type MantineColorScheme,
-    Menu,
+    Menu,
-    SegmentedControl,
+    SegmentedControl,
-    type SegmentedControlItem,
+    type SegmentedControlItem,
-    useMantineColorScheme,
+    Slider,
-} from "@mantine/core"
+    useMantineColorScheme,
-import { showNotification } from "@mantine/notifications"
+} from "@mantine/core"
-import { client } from "app/client"
+import { showNotification } from "@mantine/notifications"
-import { redirectToAbout, redirectToAdminUsers, redirectToDonate, redirectToMetrics, redirectToSettings } from "app/redirect/thunks"
+import { client } from "app/client"
-import { useAppDispatch, useAppSelector } from "app/store"
+import { redirectToAbout, redirectToAdminUsers, redirectToDonate, redirectToMetrics, redirectToSettings } from "app/redirect/thunks"
-import { type ViewMode } from "app/types"
+import { useAppDispatch, useAppSelector } from "app/store"
-import { useViewMode } from "hooks/useViewMode"
+import type { ViewMode } from "app/types"
-import { type ReactNode, useState } from "react"
+import { setFontSizePercentage, setViewMode } from "app/user/slice"
-import {
+import { reloadProfile } from "app/user/thunks"
-    TbChartLine,
+import dayjs from "dayjs"
-    TbHeartFilled,
+import { useNow } from "hooks/useNow"
-    TbHelp,
+import { type ReactNode, useState } from "react"
-    TbLayoutList,
+import {
-    TbList,
+    TbChartLine,
-    TbListDetails,
+    TbHeartFilled,
-    TbMoon,
+    TbHelp,
-    TbNotes,
+    TbLayoutList,
-    TbPower,
+    TbList,
-    TbSettings,
+    TbListDetails,
-    TbSun,
+    TbMoon,
-    TbSunMoon,
+    TbNotes,
-    TbUsers,
+    TbPower,
-    TbWorldDownload,
+    TbSettings,
-} from "react-icons/tb"
+    TbSun,
-
+    TbSunMoon,
-interface ProfileMenuProps {
+    TbUsers,
-    control: React.ReactElement
+    TbWorldDownload,
-}
+} from "react-icons/tb"
-
+
-const ProfileMenuControlItem = ({ icon, label }: { icon: ReactNode; label: ReactNode }) => {
+interface ProfileMenuProps {
-    return (
+    control: React.ReactElement
-        <Group>
+}
-            {icon}
+
-            <Box ml={6}>{label}</Box>
+const ProfileMenuControlItem = ({ icon, label }: { icon: ReactNode; label: ReactNode }) => {
-        </Group>
+    return (
-    )
+        <Group>
-}
+            {icon}
-
+            <Box ml={6}>{label}</Box>
-const iconSize = 16
+        </Group>
-
+    )
-interface ColorSchemeControlItem extends SegmentedControlItem {
+}
-    value: MantineColorScheme
+
-}
+const iconSize = 16
-
+
-const colorSchemeData: ColorSchemeControlItem[] = [
+interface ColorSchemeControlItem extends SegmentedControlItem {
-    {
+    value: MantineColorScheme
-        value: "light",
+}
-        label: <ProfileMenuControlItem icon={<TbSun size={iconSize} />} label={<Trans>Light</Trans>} />,
+
-    },
+const colorSchemeData: ColorSchemeControlItem[] = [
-    {
+    {
-        value: "dark",
+        value: "light",
-        label: <ProfileMenuControlItem icon={<TbMoon size={iconSize} />} label={<Trans>Dark</Trans>} />,
+        label: <ProfileMenuControlItem icon={<TbSun size={iconSize} />} label={<Trans>Light</Trans>} />,
-    },
+    },
-    {
+    {
-        value: "auto",
+        value: "dark",
-        label: <ProfileMenuControlItem icon={<TbSunMoon size={iconSize} />} label={<Trans>System</Trans>} />,
+        label: <ProfileMenuControlItem icon={<TbMoon size={iconSize} />} label={<Trans>Dark</Trans>} />,
-    },
+    },
-]
+    {
-
+        value: "auto",
-interface ViewModeControlItem extends SegmentedControlItem {
+        label: <ProfileMenuControlItem icon={<TbSunMoon size={iconSize} />} label={<Trans>System</Trans>} />,
-    value: ViewMode
+    },
-}
+]
-
+
-const viewModeData: ViewModeControlItem[] = [
+interface ViewModeControlItem extends SegmentedControlItem {
-    {
+    value: ViewMode
-        value: "title",
+}
-        label: <ProfileMenuControlItem icon={<TbList size={iconSize} />} label={<Trans>Compact</Trans>} />,
+
-    },
+const viewModeData: ViewModeControlItem[] = [
-    {
+    {
-        value: "cozy",
+        value: "title",
-        label: <ProfileMenuControlItem icon={<TbLayoutList size={iconSize} />} label={<Trans>Cozy</Trans>} />,
+        label: <ProfileMenuControlItem icon={<TbList size={iconSize} />} label={<Trans>Compact</Trans>} />,
-    },
+    },
-    {
+    {
-        value: "detailed",
+        value: "cozy",
-        label: <ProfileMenuControlItem icon={<TbListDetails size={iconSize} />} label={<Trans>Detailed</Trans>} />,
+        label: <ProfileMenuControlItem icon={<TbLayoutList size={iconSize} />} label={<Trans>Cozy</Trans>} />,
-    },
+    },
-    {
+    {
-        value: "expanded",
+        value: "detailed",
-        label: <ProfileMenuControlItem icon={<TbNotes size={iconSize} />} label={<Trans>Expanded</Trans>} />,
+        label: <ProfileMenuControlItem icon={<TbListDetails size={iconSize} />} label={<Trans>Detailed</Trans>} />,
-    },
+    },
-]
+    {
-
+        value: "expanded",
-export function ProfileMenu(props: ProfileMenuProps) {
+        label: <ProfileMenuControlItem icon={<TbNotes size={iconSize} />} label={<Trans>Expanded</Trans>} />,
-    const [opened, setOpened] = useState(false)
+    },
-    const { viewMode, setViewMode } = useViewMode()
+]
-    const profile = useAppSelector(state => state.user.profile)
+
-    const admin = useAppSelector(state => state.user.profile?.admin)
+export function ProfileMenu(props: ProfileMenuProps) {
-    const dispatch = useAppDispatch()
+    const [opened, setOpened] = useState(false)
-    const { colorScheme, setColorScheme } = useMantineColorScheme()
+    const now = useNow()
-
+    const profile = useAppSelector(state => state.user.profile)
-    const logout = () => {
+    const admin = useAppSelector(state => state.user.profile?.admin)
-        window.location.href = "logout"
+    const viewMode = useAppSelector(state => state.user.localSettings.viewMode)
-    }
+    const forceRefreshCooldownDuration = useAppSelector(state => state.server.serverInfos?.forceRefreshCooldownDuration)
-
+    const fontSizePercentage = useAppSelector(state => state.user.localSettings.fontSizePercentage)
-    return (
+    const dispatch = useAppDispatch()
-        <Menu position="bottom-end" closeOnItemClick={false} opened={opened} onChange={setOpened}>
+    const { colorScheme, setColorScheme } = useMantineColorScheme()
-            <Menu.Target>{props.control}</Menu.Target>
+
-            <Menu.Dropdown>
+    const nextAvailableForceRefresh = profile?.lastForceRefresh
-                {profile && <Menu.Label>{profile.name}</Menu.Label>}
+        ? profile.lastForceRefresh + (forceRefreshCooldownDuration ?? 0)
-                <Menu.Item
+        : now.getTime()
-                    leftSection={<TbSettings size={iconSize} />}
+    const forceRefreshEnabled = nextAvailableForceRefresh <= now.getTime()
-                    onClick={() => {
+
-                        dispatch(redirectToSettings())
+    const logout = () => {
-                        setOpened(false)
+        window.location.href = "logout"
-                    }}
+    }
-                >
+
-                    <Trans>Settings</Trans>
+    return (
-                </Menu.Item>
+        <Menu position="bottom-end" closeOnItemClick={false} opened={opened} onChange={setOpened}>
-                <Menu.Item
+            <Menu.Target>{props.control}</Menu.Target>
-                    leftSection={<TbWorldDownload size={iconSize} />}
+            <Menu.Dropdown>
-                    onClick={async () =>
+                {profile && <Menu.Label>{profile.name}</Menu.Label>}
-                        await client.feed.refreshAll().then(() => {
+                <Menu.Item
-                            showNotification({
+                    leftSection={<TbSettings size={iconSize} />}
-                                message: <Trans>Your feeds have been queued for refresh.</Trans>,
+                    onClick={() => {
-                                color: "green",
+                        dispatch(redirectToSettings())
-                                autoClose: 1000,
+                        setOpened(false)
-                            })
+                    }}
-                            setOpened(false)
+                >
-                        })
+                    <Trans>Settings</Trans>
-                    }
+                </Menu.Item>
-                >
+                <Menu.Item
-                    <Trans>Fetch all my feeds now</Trans>
+                    leftSection={<TbWorldDownload size={iconSize} />}
-                </Menu.Item>
+                    disabled={!forceRefreshEnabled}
-
+                    onClick={async () => {
-                <Divider />
+                        setOpened(false)
-
+
-                <Menu.Label>
+                        try {
-                    <Trans>Theme</Trans>
+                            await client.feed.refreshAll()
-                </Menu.Label>
+
-                <SegmentedControl
+                            // reload profile to update last force refresh timestamp
-                    fullWidth
+                            await dispatch(reloadProfile())
-                    orientation="vertical"
+
-                    data={colorSchemeData}
+                            showNotification({
-                    value={colorScheme}
+                                message: <Trans>Your feeds have been queued for refresh.</Trans>,
-                    onChange={e => setColorScheme(e as MantineColorScheme)}
+                                color: "green",
-                    mb="xs"
+                                autoClose: 1000,
-                />
+                            })
-
+                        } catch (_) {
-                <Divider />
+                            showNotification({
-
+                                message: <Trans>Force fetching feeds is not yet available.</Trans>,
-                <Menu.Label>
+                                color: "red",
-                    <Trans>Display</Trans>
+                                autoClose: 2000,
-                </Menu.Label>
+                            })
-                <SegmentedControl
+                        }
-                    fullWidth
+                    }}
-                    orientation="vertical"
+                >
-                    data={viewModeData}
+                    <Trans>Fetch all my feeds now</Trans>
-                    value={viewMode}
+                    {!forceRefreshEnabled && <span> ({dayjs.duration(nextAvailableForceRefresh - now.getTime()).format("HH:mm:ss")})</span>}
-                    onChange={e => setViewMode(e as ViewMode)}
+                </Menu.Item>
-                    mb="xs"
+
-                />
+                <Divider />
-
+
-                {admin && (
+                <Menu.Label>
-                    <>
+                    <Trans>Theme</Trans>
-                        <Divider />
+                </Menu.Label>
-                        <Menu.Label>
+                <SegmentedControl
-                            <Trans>Admin</Trans>
+                    fullWidth
-                        </Menu.Label>
+                    orientation="vertical"
-                        <Menu.Item
+                    data={colorSchemeData}
-                            leftSection={<TbUsers size={iconSize} />}
+                    value={colorScheme}
-                            onClick={() => {
+                    onChange={e => setColorScheme(e as MantineColorScheme)}
-                                dispatch(redirectToAdminUsers())
+                    mb="xs"
-                                setOpened(false)
+                />
-                            }}
+
-                        >
+                <Divider />
-                            <Trans>Manage users</Trans>
+
-                        </Menu.Item>
+                <Menu.Label>
-                        <Menu.Item
+                    <Trans>Display</Trans>
-                            leftSection={<TbChartLine size={iconSize} />}
+                </Menu.Label>
-                            onClick={() => {
+                <SegmentedControl
-                                dispatch(redirectToMetrics())
+                    fullWidth
-                                setOpened(false)
+                    orientation="vertical"
-                            }}
+                    data={viewModeData}
-                        >
+                    value={viewMode}
-                            <Trans>Metrics</Trans>
+                    onChange={e => dispatch(setViewMode(e as ViewMode))}
-                        </Menu.Item>
+                    mb="xs"
-                    </>
+                />
-                )}
+
-
+                <Divider />
-                <Divider />
+
-
+                <Menu.Label>
-                <Menu.Item
+                    <Trans>Font size</Trans>
-                    leftSection={<TbHeartFilled size={iconSize} color="red" />}
+                </Menu.Label>
-                    onClick={() => {
+                <Slider
-                        dispatch(redirectToDonate())
+                    min={50}
-                        setOpened(false)
+                    max={150}
-                    }}
+                    step={5}
-                >
+                    marks={[{ value: 100 }]}
-                    <Trans>Donate</Trans>
+                    label={v => `${v}%`}
-                </Menu.Item>
+                    mb="xs"
-
+                    value={fontSizePercentage}
-                <Menu.Item
+                    onChange={value => dispatch(setFontSizePercentage(value))}
-                    leftSection={<TbHelp size={iconSize} />}
+                />
-                    onClick={() => {
+
-                        dispatch(redirectToAbout())
+                {admin && (
-                        setOpened(false)
+                    <>
-                    }}
+                        <Divider />
-                >
+                        <Menu.Label>
-                    <Trans>About</Trans>
+                            <Trans>Admin</Trans>
-                </Menu.Item>
+                        </Menu.Label>
-                <Menu.Item leftSection={<TbPower size={iconSize} />} onClick={logout}>
+                        <Menu.Item
-                    <Trans>Logout</Trans>
+                            leftSection={<TbUsers size={iconSize} />}
-                </Menu.Item>
+                            onClick={() => {
-            </Menu.Dropdown>
+                                dispatch(redirectToAdminUsers())
-        </Menu>
+                                setOpened(false)
-    )
+                            }}
-}
+                        >
+                            <Trans>Manage users</Trans>
+                        </Menu.Item>
+                        <Menu.Item
+                            leftSection={<TbChartLine size={iconSize} />}
+                            onClick={() => {
+                                dispatch(redirectToMetrics())
+                                setOpened(false)
+                            }}
+                        >
+                            <Trans>Metrics</Trans>
+                        </Menu.Item>
+                    </>
+                )}
+
+                <Divider />
+
+                <Menu.Item
+                    leftSection={<TbHeartFilled size={iconSize} color="red" />}
+                    onClick={() => {
+                        dispatch(redirectToDonate())
+                        setOpened(false)
+                    }}
+                >
+                    <Trans>Donate</Trans>
+                </Menu.Item>
+
+                <Menu.Item
+                    leftSection={<TbHelp size={iconSize} />}
+                    onClick={() => {
+                        dispatch(redirectToAbout())
+                        setOpened(false)
+                    }}
+                >
+                    <Trans>About</Trans>
+                </Menu.Item>
+                <Menu.Item leftSection={<TbPower size={iconSize} />} onClick={logout}>
+                    <Trans>Logout</Trans>
+                </Menu.Item>
+            </Menu.Dropdown>
+        </Menu>
+    )
+}

commafeed-client/src/components/metrics/Gauge.tsx

@@ -1,9 +1,10 @@
-import { type MetricGauge } from "app/types"
+import { NumberFormatter } from "@mantine/core"
-
+import type { MetricGauge } from "app/types"
-interface MeterProps {
+
-    gauge: MetricGauge
+interface MeterProps {
-}
+    gauge: MetricGauge
-
+}
-export function Gauge(props: MeterProps) {
+
-    return <span>{props.gauge.value}</span>
+export function Gauge(props: MeterProps) {
-}
+    return <NumberFormatter value={props.gauge.value} thousandSeparator />
+}

commafeed-client/src/components/metrics/Meter.tsx

@@ -1,19 +1,19 @@
-import { Box } from "@mantine/core"
+import { Box } from "@mantine/core"
-import { type MetricMeter } from "app/types"
+import type { MetricMeter } from "app/types"
-
+
-interface MeterProps {
+interface MeterProps {
-    meter: MetricMeter
+    meter: MetricMeter
-}
+}
-
+
-export function Meter(props: MeterProps) {
+export function Meter(props: MeterProps) {
-    return (
+    return (
-        <Box>
+        <Box>
-            <Box>Mean: {props.meter.mean_rate.toFixed(2)}</Box>
+            <Box>Mean: {props.meter.mean_rate.toFixed(2)}</Box>
-            <Box>Last minute: {props.meter.m1_rate.toFixed(2)}</Box>
+            <Box>Last minute: {props.meter.m1_rate.toFixed(2)}</Box>
-            <Box>Last 5 minutes: {props.meter.m5_rate.toFixed(2)}</Box>
+            <Box>Last 5 minutes: {props.meter.m5_rate.toFixed(2)}</Box>
-            <Box>Last 15 minutes: {props.meter.m15_rate.toFixed(2)}</Box>
+            <Box>Last 15 minutes: {props.meter.m15_rate.toFixed(2)}</Box>
-            <Box>Units: {props.meter.units}</Box>
+            <Box>Units: {props.meter.units}</Box>
-            <Box>Total: {props.meter.count}</Box>
+            <Box>Total: {props.meter.count}</Box>
-        </Box>
+        </Box>
-    )
+    )
-}
+}

commafeed-client/src/components/metrics/MetricAccordionItem.tsx

@@ -1,22 +1,22 @@
-import { Accordion, Box, Group } from "@mantine/core"
+import { Accordion, Box, Group } from "@mantine/core"
-
+
-interface MetricAccordionItemProps {
+interface MetricAccordionItemProps {
-    metricKey: string
+    metricKey: string
-    name: string
+    name: string
-    headerValue: number
+    headerValue: number
-    children: React.ReactNode
+    children: React.ReactNode
-}
+}
-
+
-export function MetricAccordionItem({ metricKey, name, headerValue, children }: MetricAccordionItemProps) {
+export function MetricAccordionItem({ metricKey, name, headerValue, children }: MetricAccordionItemProps) {
-    return (
+    return (
-        <Accordion.Item value={metricKey} key={metricKey}>
+        <Accordion.Item value={metricKey} key={metricKey}>
-            <Accordion.Control>
+            <Accordion.Control>
-                <Group justify="space-between">
+                <Group justify="space-between">
-                    <Box>{name}</Box>
+                    <Box>{name}</Box>
-                    <Box>{headerValue}</Box>
+                    <Box>{headerValue}</Box>
-                </Group>
+                </Group>
-            </Accordion.Control>
+            </Accordion.Control>
-            <Accordion.Panel>{children}</Accordion.Panel>
+            <Accordion.Panel>{children}</Accordion.Panel>
-        </Accordion.Item>
+        </Accordion.Item>
-    )
+    )
-}
+}

commafeed-client/src/components/metrics/Timer.tsx

@@ -1,19 +1,19 @@
-import { Box } from "@mantine/core"
+import { Box } from "@mantine/core"
-import { type MetricTimer } from "app/types"
+import type { MetricTimer } from "app/types"
-
+
-interface MetricTimerProps {
+interface MetricTimerProps {
-    timer: MetricTimer
+    timer: MetricTimer
-}
+}
-
+
-export function Timer(props: MetricTimerProps) {
+export function Timer(props: MetricTimerProps) {
-    return (
+    return (
-        <Box>
+        <Box>
-            <Box>Mean: {props.timer.mean_rate.toFixed(2)}</Box>
+            <Box>Mean: {props.timer.mean_rate.toFixed(2)}</Box>
-            <Box>Last minute: {props.timer.m1_rate.toFixed(2)}</Box>
+            <Box>Last minute: {props.timer.m1_rate.toFixed(2)}</Box>
-            <Box>Last 5 minutes: {props.timer.m5_rate.toFixed(2)}</Box>
+            <Box>Last 5 minutes: {props.timer.m5_rate.toFixed(2)}</Box>
-            <Box>Last 15 minutes: {props.timer.m15_rate.toFixed(2)}</Box>
+            <Box>Last 15 minutes: {props.timer.m15_rate.toFixed(2)}</Box>
-            <Box>Units: {props.timer.rate_units}</Box>
+            <Box>Units: {props.timer.rate_units}</Box>
-            <Box>Total: {props.timer.count}</Box>
+            <Box>Total: {props.timer.count}</Box>
-        </Box>
+        </Box>
-    )
+    )
-}
+}

commafeed-client/src/components/responsive/OnDesktop.tsx

@@ -1,8 +1,8 @@
-import { Box } from "@mantine/core"
+import { Box } from "@mantine/core"
-import { useMobile } from "hooks/useMobile"
+import { useMobile } from "hooks/useMobile"
-import React from "react"
+import type React from "react"
-
+
-export function OnDesktop(props: { children: React.ReactNode }) {
+export function OnDesktop(props: { children: React.ReactNode }) {
-    const mobile = useMobile()
+    const mobile = useMobile()
-    return <Box>{!mobile && props.children}</Box>
+    return <Box>{!mobile && props.children}</Box>
-}
+}

commafeed-client/src/components/responsive/OnMobile.tsx

@@ -1,8 +1,8 @@
-import { Box } from "@mantine/core"
+import { Box } from "@mantine/core"
-import { useMobile } from "hooks/useMobile"
+import { useMobile } from "hooks/useMobile"
-import React from "react"
+import type React from "react"
-
+
-export function OnMobile(props: { children: React.ReactNode }) {
+export function OnMobile(props: { children: React.ReactNode }) {
-    const mobile = useMobile()
+    const mobile = useMobile()
-    return <Box>{mobile && props.children}</Box>
+    return <Box>{mobile && props.children}</Box>
-}
+}

commafeed-client/src/components/settings/CustomCodeSettings.tsx

@@ -1,7 +1,8 @@
-import { Trans } from "@lingui/macro"
+import { Trans } from "@lingui/react/macro"
-import { Box, Button, Group, Stack } from "@mantine/core"
+import { Anchor, Box, Button, Group, Stack } from "@mantine/core"
 import { useForm } from "@mantine/form"
 import { client, errorToStrings } from "app/client"
+import { Constants } from "app/constants"
 import { redirectToSelectedSource } from "app/redirect/thunks"
 import { useAppDispatch, useAppSelector } from "app/store"
 import { Alert } from "components/Alert"
@@ -57,13 +58,27 @@ export function CustomCodeSettings() {
             <form onSubmit={form.onSubmit(saveCustomCode.execute)}>
                 <Stack>
                     <CodeEditor
-                        description={<Trans>Custom CSS rules that will be applied</Trans>}
+                        label={<Trans>Custom CSS rules that will be applied</Trans>}
+                        description={
+                            <Trans>
+                                <span>See </span>
+                                <Anchor
+                                    href={Constants.customCssDocumentationUrl}
+                                    target="_blank"
+                                    rel="noreferrer"
+                                    style={{ fontSize: "inherit" }}
+                                >
+                                    here
+                                </Anchor>
+                                <span> for more information.</span>
+                            </Trans>
+                        }
                         language="css"
                         {...form.getInputProps("customCss")}
                     />
 
                     <CodeEditor
-                        description={<Trans>Custom JS code that will be executed on page load</Trans>}
+                        label={<Trans>Custom JS code that will be executed on page load</Trans>}
                         language="javascript"
                         {...form.getInputProps("customJs")}
                     />

commafeed-client/src/components/settings/DisplaySettings.tsx

@@ -1,121 +1,227 @@
-import { Trans } from "@lingui/macro"
+import { msg } from "@lingui/core/macro"
-import { Divider, Group, Radio, Select, SimpleGrid, Stack, Switch } from "@mantine/core"
+import { useLingui } from "@lingui/react"
-import { Constants } from "app/constants"
+import { Trans } from "@lingui/react/macro"
-import { useAppDispatch, useAppSelector } from "app/store"
+import { Box, Divider, Group, NumberInput, Radio, Select, type SelectProps, SimpleGrid, Stack, Switch } from "@mantine/core"
-import { type ScrollMode, type SharingSettings } from "app/types"
+import type { ComboboxData } from "@mantine/core/lib/components/Combobox/Combobox.types"
-import {
+import { Constants } from "app/constants"
-    changeCustomContextMenu,
+import { useAppDispatch, useAppSelector } from "app/store"
-    changeLanguage,
+import type { IconDisplayMode, ScrollMode, SharingSettings } from "app/types"
-    changeMarkAllAsReadConfirmation,
+import {
-    changeMobileFooter,
+    changeCustomContextMenu,
-    changeScrollMarks,
+    changeEntriesToKeepOnTopWhenScrolling,
-    changeScrollMode,
+    changeExternalLinkIconDisplayMode,
-    changeScrollSpeed,
+    changeLanguage,
-    changeSharingSetting,
+    changeMarkAllAsReadConfirmation,
-    changeShowRead,
+    changeMobileFooter,
-} from "app/user/thunks"
+    changePrimaryColor,
-import { locales } from "i18n"
+    changeScrollMarks,
-import { type ReactNode } from "react"
+    changeScrollMode,
-
+    changeScrollSpeed,
-export function DisplaySettings() {
+    changeSharingSetting,
-    const language = useAppSelector(state => state.user.settings?.language)
+    changeShowRead,
-    const scrollSpeed = useAppSelector(state => state.user.settings?.scrollSpeed)
+    changeStarIconDisplayMode,
-    const showRead = useAppSelector(state => state.user.settings?.showRead)
+    changeUnreadCountFavicon,
-    const scrollMarks = useAppSelector(state => state.user.settings?.scrollMarks)
+    changeUnreadCountTitle,
-    const scrollMode = useAppSelector(state => state.user.settings?.scrollMode)
+} from "app/user/thunks"
-    const markAllAsReadConfirmation = useAppSelector(state => state.user.settings?.markAllAsReadConfirmation)
+import { locales } from "i18n"
-    const customContextMenu = useAppSelector(state => state.user.settings?.customContextMenu)
+import type { ReactNode } from "react"
-    const mobileFooter = useAppSelector(state => state.user.settings?.mobileFooter)
+
-    const sharingSettings = useAppSelector(state => state.user.settings?.sharingSettings)
+export function DisplaySettings() {
-    const dispatch = useAppDispatch()
+    const language = useAppSelector(state => state.user.settings?.language)
-
+    const scrollSpeed = useAppSelector(state => state.user.settings?.scrollSpeed)
-    const scrollModeOptions: Record<ScrollMode, ReactNode> = {
+    const showRead = useAppSelector(state => state.user.settings?.showRead)
-        always: <Trans>Always</Trans>,
+    const scrollMarks = useAppSelector(state => state.user.settings?.scrollMarks)
-        never: <Trans>Never</Trans>,
+    const scrollMode = useAppSelector(state => state.user.settings?.scrollMode)
-        if_needed: <Trans>If the entry doesn't entirely fit on the screen</Trans>,
+    const entriesToKeepOnTop = useAppSelector(state => state.user.settings?.entriesToKeepOnTopWhenScrolling)
-    }
+    const starIconDisplayMode = useAppSelector(state => state.user.settings?.starIconDisplayMode)
-
+    const externalLinkIconDisplayMode = useAppSelector(state => state.user.settings?.externalLinkIconDisplayMode)
-    return (
+    const markAllAsReadConfirmation = useAppSelector(state => state.user.settings?.markAllAsReadConfirmation)
-        <Stack>
+    const customContextMenu = useAppSelector(state => state.user.settings?.customContextMenu)
-            <Select
+    const mobileFooter = useAppSelector(state => state.user.settings?.mobileFooter)
-                description={<Trans>Language</Trans>}
+    const unreadCountTitle = useAppSelector(state => state.user.settings?.unreadCountTitle)
-                value={language}
+    const unreadCountFavicon = useAppSelector(state => state.user.settings?.unreadCountFavicon)
-                data={locales.map(l => ({
+    const sharingSettings = useAppSelector(state => state.user.settings?.sharingSettings)
-                    value: l.key,
+    const primaryColor = useAppSelector(state => state.user.settings?.primaryColor) || Constants.theme.defaultPrimaryColor
-                    label: l.label,
+    const { _ } = useLingui()
-                }))}
+    const dispatch = useAppDispatch()
-                onChange={async s => await (s && dispatch(changeLanguage(s)))}
+
-            />
+    const scrollModeOptions: Record<ScrollMode, ReactNode> = {
-
+        always: <Trans>Always</Trans>,
-            <Switch
+        never: <Trans>Never</Trans>,
-                label={<Trans>Show feeds and categories with no unread entries</Trans>}
+        if_needed: <Trans>If the entry doesn't entirely fit on the screen</Trans>,
-                checked={showRead}
+    }
-                onChange={async e => await dispatch(changeShowRead(e.currentTarget.checked))}
+
-            />
+    const displayModeData: ComboboxData = [
-
+        {
-            <Switch
+            value: "always",
-                label={<Trans>Show confirmation when marking all entries as read</Trans>}
+            label: _(msg`Always`),
-                checked={markAllAsReadConfirmation}
+        },
-                onChange={async e => await dispatch(changeMarkAllAsReadConfirmation(e.currentTarget.checked))}
+        {
-            />
+            value: "on_desktop",
-
+            label: _(msg`On desktop`),
-            <Switch
+        },
-                label={<Trans>Show CommaFeed's own context menu on right click</Trans>}
+        {
-                checked={customContextMenu}
+            value: "on_mobile",
-                onChange={async e => await dispatch(changeCustomContextMenu(e.currentTarget.checked))}
+            label: _(msg`On mobile`),
-            />
+        },
-
+        {
-            <Switch
+            value: "never",
-                label={<Trans>On mobile, show action buttons at the bottom of the screen</Trans>}
+            label: _(msg`Never`),
-                checked={mobileFooter}
+        },
-                onChange={async e => await dispatch(changeMobileFooter(e.currentTarget.checked))}
+    ]
-            />
+
-
+    const colorData: ComboboxData = [
-            <Divider label={<Trans>Scrolling</Trans>} labelPosition="center" />
+        { value: "dark", label: _(msg`Dark`) },
-
+        { value: "gray", label: _(msg`Gray`) },
-            <Radio.Group
+        { value: "red", label: _(msg`Red`) },
-                label={<Trans>Scroll selected entry to the top of the page</Trans>}
+        { value: "pink", label: _(msg`Pink`) },
-                value={scrollMode}
+        { value: "grape", label: _(msg`Grape`) },
-                onChange={async value => await dispatch(changeScrollMode(value as ScrollMode))}
+        { value: "violet", label: _(msg`Violet`) },
-            >
+        { value: "indigo", label: _(msg`Indigo`) },
-                <Group mt="xs">
+        { value: "blue", label: _(msg`Blue`) },
-                    {Object.entries(scrollModeOptions).map(e => (
+        { value: "cyan", label: _(msg`Cyan`) },
-                        <Radio key={e[0]} value={e[0]} label={e[1]} />
+        { value: "green", label: _(msg`Green`) },
-                    ))}
+        { value: "lime", label: _(msg`Lime`) },
-                </Group>
+        { value: "yellow", label: _(msg`Yellow`) },
-            </Radio.Group>
+        { value: "orange", label: _(msg`Orange`) },
-
+        { value: "teal", label: _(msg`Teal`) },
-            <Switch
+    ].sort((a, b) => a.label.localeCompare(b.label))
-                label={<Trans>Scroll smoothly when navigating between entries</Trans>}
+    const colorRenderer: SelectProps["renderOption"] = ({ option }) => (
-                checked={scrollSpeed ? scrollSpeed > 0 : false}
+        <Group>
-                onChange={async e => await dispatch(changeScrollSpeed(e.currentTarget.checked))}
+            <Box h={18} w={18} bg={option.value} />
-            />
+            <Box>{option.label}</Box>
-
+        </Group>
-            <Switch
+    )
-                label={<Trans>In expanded view, scrolling through entries mark them as read</Trans>}
+
-                checked={scrollMarks}
+    return (
-                onChange={async e => await dispatch(changeScrollMarks(e.currentTarget.checked))}
+        <Stack>
-            />
+            <Divider label={<Trans>Display</Trans>} labelPosition="center" />
-
+
-            <Divider label={<Trans>Sharing sites</Trans>} labelPosition="center" />
+            <Select
-
+                label={<Trans>Language</Trans>}
-            <SimpleGrid cols={2}>
+                value={language}
-                {(Object.keys(Constants.sharing) as (keyof SharingSettings)[]).map(site => (
+                data={locales.map(l => ({
-                    <Switch
+                    value: l.key,
-                        key={site}
+                    label: l.label,
-                        label={Constants.sharing[site].label}
+                }))}
-                        checked={sharingSettings?.[site]}
+                onChange={async s => await (s && dispatch(changeLanguage(s)))}
-                        onChange={async e =>
+            />
-                            await dispatch(
+
-                                changeSharingSetting({
+            <Select
-                                    site,
+                label={<Trans>Primary color</Trans>}
-                                    value: e.currentTarget.checked,
+                data={colorData}
-                                })
+                value={primaryColor}
-                            )
+                onChange={async value => value && (await dispatch(changePrimaryColor(value)))}
-                        }
+                renderOption={colorRenderer}
-                    />
+            />
-                ))}
+
-            </SimpleGrid>
+            <Switch
-        </Stack>
+                label={<Trans>Show feeds and categories with no unread entries</Trans>}
-    )
+                checked={showRead}
-}
+                onChange={async e => await dispatch(changeShowRead(e.currentTarget.checked))}
+            />
+
+            <Switch
+                label={<Trans>Show confirmation when marking all entries as read</Trans>}
+                checked={markAllAsReadConfirmation}
+                onChange={async e => await dispatch(changeMarkAllAsReadConfirmation(e.currentTarget.checked))}
+            />
+
+            <Switch
+                label={<Trans>On mobile, show action buttons at the bottom of the screen</Trans>}
+                checked={mobileFooter}
+                onChange={async e => await dispatch(changeMobileFooter(e.currentTarget.checked))}
+            />
+
+            <Divider label={<Trans>Browser tab</Trans>} labelPosition="center" />
+
+            <Switch
+                label={<Trans>Show unread count in tab title</Trans>}
+                checked={unreadCountTitle}
+                onChange={async e => await dispatch(changeUnreadCountTitle(e.currentTarget.checked))}
+            />
+
+            <Switch
+                label={<Trans>Show unread count in tab favicon</Trans>}
+                checked={unreadCountFavicon}
+                onChange={async e => await dispatch(changeUnreadCountFavicon(e.currentTarget.checked))}
+            />
+
+            <Divider label={<Trans>Entry headers</Trans>} labelPosition="center" />
+
+            <Select
+                label={<Trans>Show star icon</Trans>}
+                value={starIconDisplayMode}
+                data={displayModeData}
+                onChange={async s => await dispatch(changeStarIconDisplayMode(s as IconDisplayMode))}
+            />
+
+            <Select
+                label={<Trans>Show external link icon</Trans>}
+                value={externalLinkIconDisplayMode}
+                data={displayModeData}
+                onChange={async s => await dispatch(changeExternalLinkIconDisplayMode(s as IconDisplayMode))}
+            />
+
+            <Switch
+                label={<Trans>Show CommaFeed's own context menu on right click</Trans>}
+                checked={customContextMenu}
+                onChange={async e => await dispatch(changeCustomContextMenu(e.currentTarget.checked))}
+            />
+
+            <Divider label={<Trans>Scrolling</Trans>} labelPosition="center" />
+
+            <Radio.Group
+                label={<Trans>Scroll selected entry to the top of the page</Trans>}
+                value={scrollMode}
+                onChange={async value => await dispatch(changeScrollMode(value as ScrollMode))}
+            >
+                <Group mt="xs">
+                    {Object.entries(scrollModeOptions).map(e => (
+                        <Radio key={e[0]} value={e[0]} label={e[1]} />
+                    ))}
+                </Group>
+            </Radio.Group>
+
+            <NumberInput
+                label={<Trans>Entries to keep above the selected entry when scrolling</Trans>}
+                description={<Trans>Only applies to compact, cozy and detailed modes</Trans>}
+                min={0}
+                value={entriesToKeepOnTop}
+                onChange={async value => await dispatch(changeEntriesToKeepOnTopWhenScrolling(+value))}
+            />
+
+            <Switch
+                label={<Trans>Scroll smoothly when navigating between entries</Trans>}
+                checked={scrollSpeed ? scrollSpeed > 0 : false}
+                onChange={async e => await dispatch(changeScrollSpeed(e.currentTarget.checked))}
+            />
+
+            <Switch
+                label={<Trans>In expanded view, scrolling through entries mark them as read</Trans>}
+                checked={scrollMarks}
+                onChange={async e => await dispatch(changeScrollMarks(e.currentTarget.checked))}
+            />
+
+            <Divider label={<Trans>Sharing sites</Trans>} labelPosition="center" />
+
+            <SimpleGrid cols={2}>
+                {(Object.keys(Constants.sharing) as Array<keyof SharingSettings>).map(site => (
+                    <Switch
+                        key={site}
+                        label={Constants.sharing[site].label}
+                        checked={sharingSettings?.[site]}
+                        onChange={async e =>
+                            await dispatch(
+                                changeSharingSetting({
+                                    site,
+                                    value: e.currentTarget.checked,
+                                })
+                            )
+                        }
+                    />
+                ))}
+            </SimpleGrid>
+        </Stack>
+    )
+}

commafeed-client/src/components/settings/ProfileSettings.tsx

@@ -1,162 +1,165 @@
-import { t, Trans } from "@lingui/macro"
+import { msg } from "@lingui/core/macro"
-import { Anchor, Box, Button, Checkbox, Divider, Group, Input, PasswordInput, Stack, Text, TextInput } from "@mantine/core"
+import { useLingui } from "@lingui/react"
-import { useForm } from "@mantine/form"
+import { Trans } from "@lingui/react/macro"
-import { openConfirmModal } from "@mantine/modals"
+import { Anchor, Box, Button, Checkbox, Divider, Group, Input, PasswordInput, Stack, Text, TextInput } from "@mantine/core"
-import { client, errorToStrings } from "app/client"
+import { useForm } from "@mantine/form"
-import { redirectToLogin, redirectToSelectedSource } from "app/redirect/thunks"
+import { openConfirmModal } from "@mantine/modals"
-import { useAppDispatch, useAppSelector } from "app/store"
+import { client, errorToStrings } from "app/client"
-import { type ProfileModificationRequest } from "app/types"
+import { redirectToLogin, redirectToSelectedSource } from "app/redirect/thunks"
-import { reloadProfile } from "app/user/thunks"
+import { useAppDispatch, useAppSelector } from "app/store"
-import { Alert } from "components/Alert"
+import type { ProfileModificationRequest } from "app/types"
-import { useEffect } from "react"
+import { reloadProfile } from "app/user/thunks"
-import { useAsyncCallback } from "react-async-hook"
+import { Alert } from "components/Alert"
-import { TbDeviceFloppy, TbTrash } from "react-icons/tb"
+import { useEffect } from "react"
-
+import { useAsyncCallback } from "react-async-hook"
-interface FormData extends ProfileModificationRequest {
+import { TbDeviceFloppy, TbTrash } from "react-icons/tb"
-    newPasswordConfirmation?: string
+
-}
+interface FormData extends ProfileModificationRequest {
-
+    newPasswordConfirmation?: string
-export function ProfileSettings() {
+}
-    const profile = useAppSelector(state => state.user.profile)
+
-    const dispatch = useAppDispatch()
+export function ProfileSettings() {
-
+    const profile = useAppSelector(state => state.user.profile)
-    const form = useForm<FormData>({
+    const dispatch = useAppDispatch()
-        validate: {
+    const { _ } = useLingui()
-            newPasswordConfirmation: (value, values) => (value !== values.newPassword ? t`Passwords do not match` : null),
+
-        },
+    const form = useForm<FormData>({
-    })
+        validate: {
-    const { setValues } = form
+            newPasswordConfirmation: (value, values) => (value !== values.newPassword ? _(msg`Passwords do not match`) : null),
-
+        },
-    const saveProfile = useAsyncCallback(client.user.saveProfile, {
+    })
-        onSuccess: () => {
+    const { setValues } = form
-            dispatch(reloadProfile())
+
-            dispatch(redirectToSelectedSource())
+    const saveProfile = useAsyncCallback(client.user.saveProfile, {
-        },
+        onSuccess: () => {
-    })
+            dispatch(reloadProfile())
-    const deleteProfile = useAsyncCallback(client.user.deleteProfile, {
+            dispatch(redirectToSelectedSource())
-        onSuccess: () => {
+        },
-            dispatch(redirectToLogin())
+    })
-        },
+    const deleteProfile = useAsyncCallback(client.user.deleteProfile, {
-    })
+        onSuccess: () => {
-
+            dispatch(redirectToLogin())
-    const openDeleteProfileModal = () =>
+        },
-        openConfirmModal({
+    })
-            title: <Trans>Delete account</Trans>,
+
-            children: (
+    const openDeleteProfileModal = () =>
-                <Text size="sm">
+        openConfirmModal({
-                    <Trans>Are you sure you want to delete your account? There's no turning back!</Trans>
+            title: <Trans>Delete account</Trans>,
-                </Text>
+            children: (
-            ),
+                <Text size="sm">
-            labels: { confirm: <Trans>Confirm</Trans>, cancel: <Trans>Cancel</Trans> },
+                    <Trans>Are you sure you want to delete your account? There's no turning back!</Trans>
-            confirmProps: { color: "red" },
+                </Text>
-            onConfirm: async () => await deleteProfile.execute(),
+            ),
-        })
+            labels: { confirm: <Trans>Confirm</Trans>, cancel: <Trans>Cancel</Trans> },
-
+            confirmProps: { color: "red" },
-    useEffect(() => {
+            onConfirm: async () => await deleteProfile.execute(),
-        if (!profile) return
+        })
-        setValues({
+
-            currentPassword: "",
+    useEffect(() => {
-            email: profile.email ?? "",
+        if (!profile) return
-            newApiKey: false,
+        setValues({
-        })
+            currentPassword: "",
-    }, [setValues, profile])
+            email: profile.email ?? "",
-
+            newApiKey: false,
-    return (
+        })
-        <>
+    }, [setValues, profile])
-            {saveProfile.error && (
+
-                <Box mb="md">
+    return (
-                    <Alert messages={errorToStrings(saveProfile.error)} />
+        <>
-                </Box>
+            {saveProfile.error && (
-            )}
+                <Box mb="md">
-
+                    <Alert messages={errorToStrings(saveProfile.error)} />
-            {deleteProfile.error && (
+                </Box>
-                <Box mb="md">
+            )}
-                    <Alert messages={errorToStrings(deleteProfile.error)} />
+
-                </Box>
+            {deleteProfile.error && (
-            )}
+                <Box mb="md">
-
+                    <Alert messages={errorToStrings(deleteProfile.error)} />
-            <form onSubmit={form.onSubmit(saveProfile.execute)}>
+                </Box>
-                <Stack>
+            )}
-                    <TextInput label={<Trans>User name</Trans>} readOnly value={profile?.name} />
+
-                    <TextInput
+            <form onSubmit={form.onSubmit(saveProfile.execute)}>
-                        label={<Trans>API key</Trans>}
+                <Stack>
-                        description={
+                    <TextInput label={<Trans>User name</Trans>} readOnly value={profile?.name} />
-                            <Trans>
+                    <TextInput
-                                This is your API key. It can be used for some read-only API operations and grants access to the Fever API.
+                        label={<Trans>API key</Trans>}
-                                Use the form at the bottom of the page to generate a new API key
+                        description={
-                            </Trans>
+                            <Trans>
-                        }
+                                This is your API key. It can be used for some read-only API operations and grants access to the Fever API.
-                        readOnly
+                                Use the form at the bottom of the page to generate a new API key
-                        value={profile?.apiKey}
+                            </Trans>
-                    />
+                        }
-
+                        readOnly
-                    <Input.Wrapper
+                        value={profile?.apiKey}
-                        label={<Trans>OPML export</Trans>}
+                    />
-                        description={
+
-                            <Trans>
+                    <Input.Wrapper
-                                Export your subscriptions and categories as an OPML file that can be imported in other feed reading services
+                        label={<Trans>OPML export</Trans>}
-                            </Trans>
+                        description={
-                        }
+                            <Trans>
-                    >
+                                Export your subscriptions and categories as an OPML file that can be imported in other feed reading services
-                        <Box>
+                            </Trans>
-                            <Anchor href="rest/feed/export" download="commafeed_opml.xml">
+                        }
-                                <Trans>Download</Trans>
+                    >
-                            </Anchor>
+                        <Box>
-                        </Box>
+                            <Anchor href="rest/feed/export" download="commafeed.opml">
-                    </Input.Wrapper>
+                                <Trans>Download</Trans>
-
+                            </Anchor>
-                    <Input.Wrapper
+                        </Box>
-                        label={<Trans>Fever API</Trans>}
+                    </Input.Wrapper>
-                        description={
+
-                            <Trans>
+                    <Input.Wrapper
-                                CommaFeed is compatible with the Fever API. Use the following URL in your Fever-compatible mobile client.
+                        label={<Trans>Fever API</Trans>}
-                                Login with your username and your <u>API key</u>.
+                        description={
-                            </Trans>
+                            <Trans>
-                        }
+                                CommaFeed is compatible with the Fever API. Use the following URL in your Fever-compatible mobile client.
-                    >
+                                Login with your username and your <u>API key</u>.
-                        <Box>
+                            </Trans>
-                            <Anchor href={`rest/fever/user/${profile?.id}`} target="_blank">
+                        }
-                                <Trans>Fever API URL</Trans>
+                    >
-                            </Anchor>
+                        <Box>
-                        </Box>
+                            <Anchor href={`rest/fever/user/${profile?.id}`} target="_blank">
-                    </Input.Wrapper>
+                                <Trans>Fever API URL</Trans>
-
+                            </Anchor>
-                    <Divider />
+                        </Box>
-
+                    </Input.Wrapper>
-                    <PasswordInput
+
-                        label={<Trans>Current password</Trans>}
+                    <Divider />
-                        description={<Trans>Enter your current password to change profile settings</Trans>}
+
-                        required
+                    <PasswordInput
-                        {...form.getInputProps("currentPassword")}
+                        label={<Trans>Current password</Trans>}
-                    />
+                        description={<Trans>Enter your current password to change profile settings</Trans>}
-                    <TextInput type="email" label={<Trans>E-mail</Trans>} {...form.getInputProps("email")} required />
+                        required
-                    <PasswordInput
+                        {...form.getInputProps("currentPassword")}
-                        label={<Trans>New password</Trans>}
+                    />
-                        description={<Trans>Changing password will generate a new API key</Trans>}
+                    <TextInput type="email" label={<Trans>E-mail</Trans>} {...form.getInputProps("email")} required />
-                        {...form.getInputProps("newPassword")}
+                    <PasswordInput
-                    />
+                        label={<Trans>New password</Trans>}
-                    <PasswordInput label={<Trans>Confirm password</Trans>} {...form.getInputProps("newPasswordConfirmation")} />
+                        description={<Trans>Changing password will generate a new API key</Trans>}
-                    <Checkbox label={<Trans>Generate new API key</Trans>} {...form.getInputProps("newApiKey", { type: "checkbox" })} />
+                        {...form.getInputProps("newPassword")}
-
+                    />
-                    <Group>
+                    <PasswordInput label={<Trans>Confirm password</Trans>} {...form.getInputProps("newPasswordConfirmation")} />
-                        <Button variant="default" onClick={async () => await dispatch(redirectToSelectedSource())}>
+                    <Checkbox label={<Trans>Generate new API key</Trans>} {...form.getInputProps("newApiKey", { type: "checkbox" })} />
-                            <Trans>Cancel</Trans>
+
-                        </Button>
+                    <Group>
-                        <Button type="submit" leftSection={<TbDeviceFloppy size={16} />} loading={saveProfile.loading}>
+                        <Button variant="default" onClick={async () => await dispatch(redirectToSelectedSource())}>
-                            <Trans>Save</Trans>
+                            <Trans>Cancel</Trans>
-                        </Button>
+                        </Button>
-                        <Divider orientation="vertical" />
+                        <Button type="submit" leftSection={<TbDeviceFloppy size={16} />} loading={saveProfile.loading}>
-                        <Button
+                            <Trans>Save</Trans>
-                            color="red"
+                        </Button>
-                            leftSection={<TbTrash size={16} />}
+                        <Divider orientation="vertical" />
-                            onClick={() => openDeleteProfileModal()}
+                        <Button
-                            loading={deleteProfile.loading}
+                            color="red"
-                        >
+                            leftSection={<TbTrash size={16} />}
-                            <Trans>Delete account</Trans>
+                            onClick={() => openDeleteProfileModal()}
-                        </Button>
+                            loading={deleteProfile.loading}
-                    </Group>
+                        >
-                </Stack>
+                            <Trans>Delete account</Trans>
-            </form>
+                        </Button>
-        </>
+                    </Group>
-    )
+                </Stack>
-}
+            </form>
+        </>
+    )
+}

commafeed-client/src/components/sidebar/Tree.tsx

@@ -1,175 +1,200 @@
-import { Trans } from "@lingui/macro"
+import { Trans } from "@lingui/react/macro"
-import { Box, Stack } from "@mantine/core"
+import { Box, Stack } from "@mantine/core"
-import { Constants } from "app/constants"
+import { Constants } from "app/constants"
-import {
+import {
-    redirectToCategory,
+    redirectToCategory,
-    redirectToCategoryDetails,
+    redirectToCategoryDetails,
-    redirectToFeed,
+    redirectToFeed,
-    redirectToFeedDetails,
+    redirectToFeedDetails,
-    redirectToTag,
+    redirectToTag,
-    redirectToTagDetails,
+    redirectToTagDetails,
-} from "app/redirect/thunks"
+} from "app/redirect/thunks"
-import { useAppDispatch, useAppSelector } from "app/store"
+import { useAppDispatch, useAppSelector } from "app/store"
-import { collapseTreeCategory } from "app/tree/thunks"
+import type { TreeSubscription } from "app/tree/slice"
-import { type Category, type Subscription } from "app/types"
+import { collapseTreeCategory } from "app/tree/thunks"
-import { categoryUnreadCount, flattenCategoryTree } from "app/utils"
+import type { Category, Subscription } from "app/types"
-import { Loader } from "components/Loader"
+import { categoryHasNewEntries, categoryUnreadCount, flattenCategoryTree } from "app/utils"
-import { OnDesktop } from "components/responsive/OnDesktop"
+import { Loader } from "components/Loader"
-import React from "react"
+import { OnDesktop } from "components/responsive/OnDesktop"
-import { TbChevronDown, TbChevronRight, TbInbox, TbStar, TbTag } from "react-icons/tb"
+import React from "react"
-import { TreeNode } from "./TreeNode"
+import { TbChevronDown, TbChevronRight, TbInbox, TbStar, TbTag } from "react-icons/tb"
-import { TreeSearch } from "./TreeSearch"
+import { TreeNode } from "./TreeNode"
-
+import { TreeSearch } from "./TreeSearch"
-const allIcon = <TbInbox size={16} />
+
-const starredIcon = <TbStar size={16} />
+const allIcon = <TbInbox size={16} />
-const tagIcon = <TbTag size={16} />
+const starredIcon = <TbStar size={16} />
-const expandedIcon = <TbChevronDown size={16} />
+const tagIcon = <TbTag size={16} />
-const collapsedIcon = <TbChevronRight size={16} />
+const expandedIcon = <TbChevronDown size={16} />
-
+const collapsedIcon = <TbChevronRight size={16} />
-const errorThreshold = 9
+
-
+const errorThreshold = 9
-export function Tree() {
+
-    const root = useAppSelector(state => state.tree.rootCategory)
+export function Tree() {
-    const source = useAppSelector(state => state.entries.source)
+    const root = useAppSelector(state => state.tree.rootCategory)
-    const tags = useAppSelector(state => state.user.tags)
+    const source = useAppSelector(state => state.entries.source)
-    const showRead = useAppSelector(state => state.user.settings?.showRead)
+    const tags = useAppSelector(state => state.user.tags)
-    const dispatch = useAppDispatch()
+    const showRead = useAppSelector(state => state.user.settings?.showRead)
-
+    const dispatch = useAppDispatch()
-    const feedClicked = (e: React.MouseEvent, id: string) => {
+
-        if (e.detail === 2) {
+    const isFeedDisplayed = (feed: Subscription) => {
-            dispatch(redirectToFeedDetails(id))
+        const isCurrentFeed = source.type === "feed" && source.id === String(feed.id)
-        } else {
+        return isCurrentFeed || feed.unread > 0 || showRead
-            dispatch(redirectToFeed(id))
+    }
-        }
+
-    }
+    const isCategoryDisplayed = (category: Category): boolean => {
-    const categoryClicked = (e: React.MouseEvent, id: string) => {
+        const isCurrentCategory = source.type === "category" && source.id === category.id
-        if (e.detail === 2) {
+        return (
-            dispatch(redirectToCategoryDetails(id))
+            isCurrentCategory ||
-        } else {
+            showRead ||
-            dispatch(redirectToCategory(id))
+            category.children.some(c => isCategoryDisplayed(c)) ||
-        }
+            category.feeds.some(f => isFeedDisplayed(f))
-    }
+        )
-    const categoryIconClicked = (e: React.MouseEvent, category: Category) => {
+    }
-        e.stopPropagation()
+
-
+    const feedClicked = (e: React.MouseEvent, id: string) => {
-        dispatch(
+        if (e.detail === 2) {
-            collapseTreeCategory({
+            dispatch(redirectToFeedDetails(id))
-                id: +category.id,
+        } else {
-                collapse: category.expanded,
+            dispatch(redirectToFeed(id))
-            })
+        }
-        )
+    }
-    }
+    const categoryClicked = (e: React.MouseEvent, id: string) => {
-    const tagClicked = (e: React.MouseEvent, id: string) => {
+        if (e.detail === 2) {
-        if (e.detail === 2) {
+            dispatch(redirectToCategoryDetails(id))
-            dispatch(redirectToTagDetails(id))
+        } else {
-        } else {
+            dispatch(redirectToCategory(id))
-            dispatch(redirectToTag(id))
+        }
-        }
+    }
-    }
+    const categoryIconClicked = (e: React.MouseEvent, category: Category) => {
-
+        e.stopPropagation()
-    const allCategoryNode = () => (
+
-        <TreeNode
+        dispatch(
-            id={Constants.categories.all.id}
+            collapseTreeCategory({
-            name={<Trans>All</Trans>}
+                id: +category.id,
-            icon={allIcon}
+                collapse: category.expanded,
-            unread={categoryUnreadCount(root)}
+            })
-            selected={source.type === "category" && source.id === Constants.categories.all.id}
+        )
-            expanded={false}
+    }
-            level={0}
+    const tagClicked = (e: React.MouseEvent, id: string) => {
-            hasError={false}
+        if (e.detail === 2) {
-            onClick={categoryClicked}
+            dispatch(redirectToTagDetails(id))
-        />
+        } else {
-    )
+            dispatch(redirectToTag(id))
-    const starredCategoryNode = () => (
+        }
-        <TreeNode
+    }
-            id={Constants.categories.starred.id}
+
-            name={<Trans>Starred</Trans>}
+    const allCategoryNode = () => (
-            icon={starredIcon}
+        <TreeNode
-            unread={0}
+            id={Constants.categories.all.id}
-            selected={source.type === "category" && source.id === Constants.categories.starred.id}
+            type="category"
-            expanded={false}
+            name={<Trans>All</Trans>}
-            level={0}
+            icon={allIcon}
-            hasError={false}
+            unread={categoryUnreadCount(root)}
-            onClick={categoryClicked}
+            hasNewEntries={categoryHasNewEntries(root)}
-        />
+            selected={source.type === "category" && source.id === Constants.categories.all.id}
-    )
+            expanded={false}
-
+            level={0}
-    const categoryNode = (category: Category, level = 0) => {
+            hasError={false}
-        const unreadCount = categoryUnreadCount(category)
+            onClick={categoryClicked}
-        if (unreadCount === 0 && !showRead) return null
+        />
-
+    )
-        const hasError = !category.expanded && flattenCategoryTree(category).some(c => c.feeds.some(f => f.errorCount > errorThreshold))
+    const starredCategoryNode = () => (
-        return (
+        <TreeNode
-            <TreeNode
+            id={Constants.categories.starred.id}
-                id={category.id}
+            type="category"
-                name={category.name}
+            name={<Trans>Starred</Trans>}
-                icon={category.expanded ? expandedIcon : collapsedIcon}
+            icon={starredIcon}
-                unread={unreadCount}
+            unread={0}
-                selected={source.type === "category" && source.id === category.id}
+            hasNewEntries={false}
-                expanded={category.expanded}
+            selected={source.type === "category" && source.id === Constants.categories.starred.id}
-                level={level}
+            expanded={false}
-                hasError={hasError}
+            level={0}
-                onClick={categoryClicked}
+            hasError={false}
-                onIconClick={e => categoryIconClicked(e, category)}
+            onClick={categoryClicked}
-                key={category.id}
+        />
-            />
+    )
-        )
+
-    }
+    const categoryNode = (category: Category, level = 0) => {
-
+        if (!isCategoryDisplayed(category)) return null
-    const feedNode = (feed: Subscription, level = 0) => {
+
-        if (feed.unread === 0 && !showRead) return null
+        const hasError = !category.expanded && flattenCategoryTree(category).some(c => c.feeds.some(f => f.errorCount > errorThreshold))
-
+        return (
-        return (
+            <TreeNode
-            <TreeNode
+                id={category.id}
-                id={String(feed.id)}
+                type="category"
-                name={feed.name}
+                name={category.name}
-                icon={feed.iconUrl}
+                icon={category.expanded ? expandedIcon : collapsedIcon}
-                unread={feed.unread}
+                unread={categoryUnreadCount(category)}
-                selected={source.type === "feed" && source.id === String(feed.id)}
+                hasNewEntries={categoryHasNewEntries(category)}
-                level={level}
+                selected={source.type === "category" && source.id === category.id}
-                hasError={feed.errorCount > errorThreshold}
+                expanded={category.expanded}
-                onClick={feedClicked}
+                level={level}
-                key={feed.id}
+                hasError={hasError}
-            />
+                onClick={categoryClicked}
-        )
+                onIconClick={e => categoryIconClicked(e, category)}
-    }
+                key={category.id}
-
+            />
-    const tagNode = (tag: string) => (
+        )
-        <TreeNode
+    }
-            id={tag}
+
-            name={tag}
+    const feedNode = (feed: TreeSubscription, level = 0) => {
-            icon={tagIcon}
+        if (!isFeedDisplayed(feed)) return null
-            unread={0}
+
-            selected={source.type === "tag" && source.id === tag}
+        return (
-            level={0}
+            <TreeNode
-            hasError={false}
+                id={String(feed.id)}
-            onClick={tagClicked}
+                type="feed"
-            key={tag}
+                name={feed.name}
-        />
+                icon={feed.iconUrl}
-    )
+                unread={feed.unread}
-
+                hasNewEntries={!!feed.hasNewEntries}
-    const recursiveCategoryNode = (category: Category, level = 0) => (
+                selected={source.type === "feed" && source.id === String(feed.id)}
-        <React.Fragment key={`recursiveCategoryNode-${category.id}`}>
+                level={level}
-            {categoryNode(category, level)}
+                hasError={feed.errorCount > errorThreshold}
-            {category.expanded && category.children.map(c => recursiveCategoryNode(c, level + 1))}
+                onClick={feedClicked}
-            {category.expanded && category.feeds.map(f => feedNode(f, level + 1))}
+                key={feed.id}
-        </React.Fragment>
+            />
-    )
+        )
-
+    }
-    if (!root) return <Loader />
+
-    const feeds = flattenCategoryTree(root).flatMap(c => c.feeds)
+    const tagNode = (tag: string) => (
-    return (
+        <TreeNode
-        <Stack>
+            id={tag}
-            <OnDesktop>
+            type="tag"
-                <TreeSearch feeds={feeds} />
+            name={tag}
-            </OnDesktop>
+            icon={tagIcon}
-            <Box>
+            unread={0}
-                {allCategoryNode()}
+            hasNewEntries={false}
-                {starredCategoryNode()}
+            selected={source.type === "tag" && source.id === tag}
-                {root.children.map(c => recursiveCategoryNode(c))}
+            level={0}
-                {root.feeds.map(f => feedNode(f))}
+            hasError={false}
-                {tags?.map(tag => tagNode(tag))}
+            onClick={tagClicked}
-            </Box>
+            key={tag}
-        </Stack>
+        />
-    )
+    )
-}
+
+    const recursiveCategoryNode = (category: Category, level = 0) => (
+        <React.Fragment key={`recursiveCategoryNode-${category.id}`}>
+            {categoryNode(category, level)}
+            {category.expanded && category.children.map(c => recursiveCategoryNode(c, level + 1))}
+            {category.expanded && category.feeds.map(f => feedNode(f, level + 1))}
+        </React.Fragment>
+    )
+
+    if (!root) return <Loader />
+    const feeds = flattenCategoryTree(root).flatMap(c => c.feeds)
+    return (
+        <Stack>
+            <OnDesktop>
+                <TreeSearch feeds={feeds} />
+            </OnDesktop>
+            <Box className="cf-tree">
+                {allCategoryNode()}
+                {starredCategoryNode()}
+                {root.children.map(c => recursiveCategoryNode(c))}
+                {root.feeds.map(f => feedNode(f))}
+                {tags?.map(tag => tagNode(tag))}
+            </Box>
+        </Stack>
+    )
+}

commafeed-client/src/components/sidebar/TreeNode.tsx

@@ -1,78 +1,89 @@
-import { Box, Center } from "@mantine/core"
+import { Box, Center } from "@mantine/core"
-import { FeedFavicon } from "components/content/FeedFavicon"
+import type { EntrySourceType } from "app/entries/slice"
-import React, { type ReactNode } from "react"
+import { FeedFavicon } from "components/content/FeedFavicon"
-import { tss } from "tss"
+import type React from "react"
-import { UnreadCount } from "./UnreadCount"
+import { tss } from "tss"
-
+import { UnreadCount } from "./UnreadCount"
-interface TreeNodeProps {
+
-    id: string
+interface TreeNodeProps {
-    name: ReactNode
+    id: string
-    icon: ReactNode
+    type: EntrySourceType
-    unread: number
+    name: React.ReactNode
-    selected: boolean
+    icon: React.ReactNode
-    expanded?: boolean
+    unread: number
-    level: number
+    selected: boolean
-    hasError: boolean
+    expanded?: boolean
-    onClick: (e: React.MouseEvent, id: string) => void
+    level: number
-    onIconClick?: (e: React.MouseEvent, id: string) => void
+    hasError: boolean
-}
+    hasNewEntries: boolean
-
+    onClick: (e: React.MouseEvent, id: string) => void
-const useStyles = tss
+    onIconClick?: (e: React.MouseEvent, id: string) => void
-    .withParams<{
+}
-        selected: boolean
+
-        hasError: boolean
+const useStyles = tss
-        hasUnread: boolean
+    .withParams<{
-    }>()
+        selected: boolean
-    .create(({ theme, colorScheme, selected, hasError, hasUnread }) => {
+        hasError: boolean
-        let backgroundColor = "inherit"
+        hasUnread: boolean
-        if (selected) backgroundColor = colorScheme === "dark" ? theme.colors.dark[4] : theme.colors.gray[1]
+    }>()
-
+    .create(({ theme, colorScheme, selected, hasError, hasUnread }) => {
-        let color
+        let backgroundColor = "inherit"
-        if (hasError) {
+        if (selected) backgroundColor = colorScheme === "dark" ? theme.colors.dark[4] : theme.colors.gray[1]
-            color = theme.colors.red[6]
+
-        } else if (colorScheme === "dark") {
+        let color: string
-            color = hasUnread ? theme.colors.dark[0] : theme.colors.dark[3]
+        if (hasError) {
-        } else {
+            color = theme.colors.red[6]
-            color = hasUnread ? theme.black : theme.colors.gray[6]
+        } else if (colorScheme === "dark") {
-        }
+            color = hasUnread ? theme.colors.dark[0] : theme.colors.dark[3]
-
+        } else {
-        return {
+            color = hasUnread ? theme.black : theme.colors.gray[6]
-            node: {
+        }
-                display: "flex",
+
-                alignItems: "center",
+        return {
-                cursor: "pointer",
+            node: {
-                color,
+                display: "flex",
-                backgroundColor,
+                alignItems: "center",
-                "&:hover": {
+                cursor: "pointer",
-                    backgroundColor: colorScheme === "dark" ? theme.colors.dark[6] : theme.colors.gray[0],
+                color,
-                },
+                backgroundColor,
-            },
+                "&:hover": {
-            nodeText: {
+                    backgroundColor: colorScheme === "dark" ? theme.colors.dark[6] : theme.colors.gray[0],
-                flexGrow: 1,
+                },
-                whiteSpace: "nowrap",
+            },
-                overflow: "hidden",
+            nodeText: {
-                textOverflow: "ellipsis",
+                flexGrow: 1,
-            },
+                whiteSpace: "nowrap",
-        }
+                overflow: "hidden",
-    })
+                textOverflow: "ellipsis",
-
+            },
-export function TreeNode(props: TreeNodeProps) {
+        }
-    const { classes } = useStyles({
+    })
-        selected: props.selected,
+
-        hasError: props.hasError,
+export function TreeNode(props: TreeNodeProps) {
-        hasUnread: props.unread > 0,
+    const { classes } = useStyles({
-    })
+        selected: props.selected,
-    return (
+        hasError: props.hasError,
-        <Box py={1} pl={props.level * 20} className={classes.node} onClick={(e: React.MouseEvent) => props.onClick(e, props.id)}>
+        hasUnread: props.unread > 0,
-            <Box mr={6} onClick={(e: React.MouseEvent) => props.onIconClick?.(e, props.id)}>
+    })
-                <Center>{typeof props.icon === "string" ? <FeedFavicon url={props.icon} /> : props.icon}</Center>
+    return (
-            </Box>
+        <Box
-            <Box className={classes.nodeText}>{props.name}</Box>
+            py={1}
-            {!props.expanded && (
+            pl={props.level * 20}
-                <Box>
+            className={`${classes.node} cf-treenode cf-treenode-${props.type}`}
-                    <UnreadCount unreadCount={props.unread} />
+            onClick={(e: React.MouseEvent) => props.onClick(e, props.id)}
-                </Box>
+            data-id={props.id}
-            )}
+            data-type={props.type}
-        </Box>
+            data-unread-count={props.unread}
-    )
+        >
-}
+            <Box mr={6} onClick={(e: React.MouseEvent) => props.onIconClick?.(e, props.id)} className="cf-treenode-icon">
+                <Center>{typeof props.icon === "string" ? <FeedFavicon url={props.icon} /> : props.icon}</Center>
+            </Box>
+            <Box className={classes.nodeText}>{props.name}</Box>
+            {!props.expanded && (
+                <Box className="cf-treenode-unread-count">
+                    <UnreadCount unreadCount={props.unread} showIndicator={props.hasNewEntries} />
+                </Box>
+            )}
+        </Box>
+    )
+}

commafeed-client/src/components/sidebar/TreeSearch.tsx

@@ -1,68 +1,63 @@
-import { t, Trans } from "@lingui/macro"
+import { msg } from "@lingui/core/macro"
-import { Box, Center, Kbd, TextInput } from "@mantine/core"
+import { useLingui } from "@lingui/react"
-import { Spotlight, spotlight, type SpotlightActionData } from "@mantine/spotlight"
+import { Trans } from "@lingui/react/macro"
-import { redirectToFeed } from "app/redirect/thunks"
+import { Box, TextInput } from "@mantine/core"
-import { useAppDispatch } from "app/store"
+import { Spotlight, type SpotlightActionData, spotlight } from "@mantine/spotlight"
-import { type Subscription } from "app/types"
+import { redirectToFeed } from "app/redirect/thunks"
-import { FeedFavicon } from "components/content/FeedFavicon"
+import { useAppDispatch } from "app/store"
-import { useMousetrap } from "hooks/useMousetrap"
+import type { Subscription } from "app/types"
-import { TbSearch } from "react-icons/tb"
+import { FeedFavicon } from "components/content/FeedFavicon"
-
+import { useMousetrap } from "hooks/useMousetrap"
-export interface TreeSearchProps {
+import { TbSearch } from "react-icons/tb"
-    feeds: Subscription[]
+
-}
+export interface TreeSearchProps {
-
+    feeds: Subscription[]
-export function TreeSearch(props: TreeSearchProps) {
+}
-    const dispatch = useAppDispatch()
+
-
+export function TreeSearch(props: TreeSearchProps) {
-    const actions: SpotlightActionData[] = props.feeds
+    const dispatch = useAppDispatch()
-        .map(f => ({
+    const { _ } = useLingui()
-            id: `${f.id}`,
+
-            label: f.name,
+    const actions: SpotlightActionData[] = props.feeds
-            leftSection: <FeedFavicon url={f.iconUrl} />,
+        .map(f => ({
-            onClick: async () => await dispatch(redirectToFeed(f.id)),
+            id: `${f.id}`,
-        }))
+            label: f.name,
-        .sort((f1, f2) => f1.label.localeCompare(f2.label))
+            leftSection: <FeedFavicon url={f.iconUrl} />,
-
+            onClick: async () => await dispatch(redirectToFeed(f.id)),
-    const searchIcon = <TbSearch size={18} />
+        }))
-    const rightSection = (
+        .sort((f1, f2) => f1.label.localeCompare(f2.label))
-        <Center style={{ cursor: "pointer" }} onClick={() => spotlight.open()}>
+
-            <Kbd>Ctrl</Kbd>
+    const searchIcon = <TbSearch size={18} />
-            <Box mx={5}>+</Box>
+
-            <Kbd>K</Kbd>
+    // additional keyboard shortcut used by commafeed v1
-        </Center>
+    useMousetrap("g u", () => spotlight.open())
-    )
+
-
+    return (
-    // additional keyboard shortcut used by commafeed v1
+        <Box className="cf-treesearch">
-    useMousetrap("g u", () => spotlight.open())
+            <TextInput
-
+                placeholder={_(msg`Search`)}
-    return (
+                leftSection={searchIcon}
-        <>
+                rightSectionWidth={100}
-            <TextInput
+                styles={{
-                placeholder={t`Search`}
+                    input: {
-                leftSection={searchIcon}
+                        cursor: "pointer",
-                rightSectionWidth={100}
+                    },
-                rightSection={rightSection}
+                }}
-                styles={{
+                onClick={() => spotlight.open()}
-                    input: {
+                // prevent focus
-                        cursor: "pointer",
+                onFocus={e => e.target.blur()}
-                    },
+                readOnly
-                }}
+            />
-                onClick={() => spotlight.open()}
+            <Spotlight
-                // prevent focus
+                actions={actions}
-                onFocus={e => e.target.blur()}
+                limit={10}
-                readOnly
+                shortcut="mod+k"
-            />
+                searchProps={{
-            <Spotlight
+                    leftSection: searchIcon,
-                actions={actions}
+                    placeholder: _(msg`Search`),
-                limit={10}
+                }}
-                shortcut="ctrl+k"
+                nothingFound={<Trans>Nothing found</Trans>}
-                searchProps={{
+            />
-                    leftSection: searchIcon,
+        </Box>
-                    placeholder: t`Search`,
+    )
-                }}
+}
-                nothingFound={<Trans>Nothing found</Trans>}
-            ></Spotlight>
-        </>
-    )
-}

commafeed-client/src/components/sidebar/UnreadCount.tsx

@@ -1,25 +1,28 @@
-import { Badge, Tooltip } from "@mantine/core"
+import { Badge, Indicator, Tooltip } from "@mantine/core"
-import { tss } from "tss"
+import { Constants } from "app/constants"
-
+import { tss } from "tss"
-const useStyles = tss.create(() => ({
+
-    badge: {
+const useStyles = tss.create(() => ({
-        width: "3.2rem",
+    badge: {
-        // for some reason, mantine Badge has "cursor: 'default'"
+        width: "3.2rem",
-        cursor: "pointer",
+        // for some reason, mantine Badge has "cursor: 'default'"
-    },
+        cursor: "pointer",
-}))
+    },
-
+}))
-export function UnreadCount(props: { unreadCount: number }) {
+
-    const { classes } = useStyles()
+export function UnreadCount(props: { unreadCount: number; showIndicator: boolean }) {
-
+    const { classes } = useStyles()
-    if (props.unreadCount <= 0) return null
+
-
+    if (props.unreadCount <= 0) return null
-    const count = props.unreadCount >= 10000 ? "10k+" : props.unreadCount
+
-    return (
+    const count = props.unreadCount >= 10000 ? "10k+" : props.unreadCount
-        <Tooltip label={props.unreadCount} disabled={props.unreadCount === count}>
+    return (
-            <Badge className={classes.badge} variant="light">
+        <Tooltip label={props.unreadCount} disabled={props.unreadCount === count} openDelay={Constants.tooltip.delay}>
-                {count}
+            <Indicator disabled={!props.showIndicator} size={4} offset={10} position="middle-start">
-            </Badge>
+                <Badge className={`${classes.badge} cf-badge`} variant="light" fullWidth>
-        </Tooltip>
+                    {count}
-    )
+                </Badge>
-}
+            </Indicator>
+        </Tooltip>
+    )
+}

commafeed-client/src/hooks/useActionButton.ts

@@ -1,9 +1,9 @@
-import { useMantineTheme } from "@mantine/core"
+import { useMantineTheme } from "@mantine/core"
-import { useMobile } from "hooks/useMobile"
+import { useMobile } from "hooks/useMobile"
-
+
-export const useActionButton = () => {
+export const useActionButton = () => {
-    const theme = useMantineTheme()
+    const theme = useMantineTheme()
-    const mobile = useMobile(theme.breakpoints.xl)
+    const mobile = useMobile(theme.breakpoints.xl)
-    const spacing = mobile ? 14 : 0
+    const spacing = mobile ? 14 : 0
-    return { mobile, spacing }
+    return { mobile, spacing }
-}
+}

commafeed-client/src/hooks/useAppLoading.ts

@@ -1,39 +1,41 @@
-import { t } from "@lingui/macro"
+import { msg } from "@lingui/core/macro"
-import { useAppSelector } from "app/store"
+import { useLingui } from "@lingui/react"
-
+import { useAppSelector } from "app/store"
-interface Step {
+
-    label: string
+interface Step {
-    done: boolean
+    label: string
-}
+    done: boolean
-
+}
-export const useAppLoading = () => {
+
-    const profile = useAppSelector(state => state.user.profile)
+export const useAppLoading = () => {
-    const settings = useAppSelector(state => state.user.settings)
+    const profileLoaded = useAppSelector(state => !!state.user.profile)
-    const rootCategory = useAppSelector(state => state.tree.rootCategory)
+    const settingsLoaded = useAppSelector(state => !!state.user.settings)
-    const tags = useAppSelector(state => state.user.tags)
+    const rootCategoryLoaded = useAppSelector(state => !!state.tree.rootCategory)
-
+    const tagsLoaded = useAppSelector(state => !!state.user.tags)
-    const steps: Step[] = [
+    const { _ } = useLingui()
-        {
+
-            label: t`Loading settings...`,
+    const steps: Step[] = [
-            done: !!settings,
+        {
-        },
+            label: _(msg`Loading settings...`),
-        {
+            done: settingsLoaded,
-            label: t`Loading profile...`,
+        },
-            done: !!profile,
+        {
-        },
+            label: _(msg`Loading profile...`),
-        {
+            done: profileLoaded,
-            label: t`Loading subscriptions...`,
+        },
-            done: !!rootCategory,
+        {
-        },
+            label: _(msg`Loading subscriptions...`),
-        {
+            done: rootCategoryLoaded,
-            label: t`Loading tags...`,
+        },
-            done: !!tags,
+        {
-        },
+            label: _(msg`Loading tags...`),
-    ]
+            done: tagsLoaded,
-
+        },
-    const loading = steps.some(s => !s.done)
+    ]
-    const loadingPercentage = Math.round((100.0 * steps.filter(s => s.done).length) / steps.length)
+
-    const loadingStepLabel = steps.find(s => !s.done)?.label
+    const loading = steps.some(s => !s.done)
-
+    const loadingPercentage = Math.round((100.0 * steps.filter(s => s.done).length) / steps.length)
-    return { steps, loading, loadingPercentage, loadingStepLabel }
+    const loadingStepLabel = steps.find(s => !s.done)?.label
-}
+
+    return { steps, loading, loadingPercentage, loadingStepLabel }
+}