garrettmills/commafeed
1
0
Fork 0
forked from Archives/Athou_commafeed
Code Pull Requests Activity

make sure we ignore cookies

Browse Source
This commit is contained in:
Athou
2023-12-18 15:09:04 +01:00
parent a30bf18102
commit 6c3895e60a
2 changed files with 23 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
commafeed-server/src/main/java/com/commafeed/backend/HttpGetter.java
View File

@@ -1,6 +1,8 @@
package com.commafeed.backend; package com.commafeed.backend;
import java.io.IOException; import java.io.IOException;
import java.net.CookieManager;
import java.net.CookiePolicy;
import java.net.URI; import java.net.URI;
import java.net.http.HttpClient; import java.net.http.HttpClient;
import java.net.http.HttpClient.Redirect; import java.net.http.HttpClient.Redirect;
@@ -106,6 +108,7 @@ public class HttpGetter {
.followRedirects(Redirect.ALWAYS) .followRedirects(Redirect.ALWAYS)
.sslContext(sslFactory.getSslContext()) .sslContext(sslFactory.getSslContext())
.sslParameters(sslFactory.getSslParameters()) .sslParameters(sslFactory.getSslParameters())
.cookieHandler(new CookieManager(null, CookiePolicy.ACCEPT_NONE))
.build(); .build();
} }

20
commafeed-server/src/test/java/com/commafeed/backend/HttpGetterTest.java
View File

@@ -3,6 +3,7 @@ package com.commafeed.backend;
import java.io.IOException; import java.io.IOException;
import java.net.http.HttpTimeoutException; import java.net.http.HttpTimeoutException;
import java.util.Objects; import java.util.Objects;
import java.util.concurrent.atomic.AtomicInteger;
import org.apache.commons.io.IOUtils; import org.apache.commons.io.IOUtils;
import org.eclipse.jetty.http.HttpStatus; import org.eclipse.jetty.http.HttpStatus;
@@ -137,4 +138,23 @@ class HttpGetterTest {
Assertions.assertThrows(NotModifiedException.class, () -> getter.getBinary(this.feedUrl, null, "78910", TIMEOUT)); Assertions.assertThrows(NotModifiedException.class, () -> getter.getBinary(this.feedUrl, null, "78910", TIMEOUT));
} }
@Test
void ignoreCookie() throws Exception {
AtomicInteger calls = new AtomicInteger();
this.mockServerClient.when(HttpRequest.request().withMethod("GET")).respond(req -> {
calls.incrementAndGet();
if (req.containsHeader(HttpHeaders.COOKIE)) {
throw new Exception("cookie should not be sent by the client");
}
return HttpResponse.response().withBody("ok").withHeader(HttpHeaders.SET_COOKIE, "foo=bar");
});
Assertions.assertDoesNotThrow(() -> getter.getBinary(this.feedUrl, TIMEOUT));
Assertions.assertDoesNotThrow(() -> getter.getBinary(this.feedUrl, TIMEOUT));
Assertions.assertEquals(2, calls.get());
}
} }