garrettmills/commafeed
1
0
Fork 0
forked from Archives/Athou_commafeed
Code Pull Requests Activity

always scroll to the element regardless of its visibility for more ux consistency

Browse Source
This commit is contained in:
Athou
2013-05-17 14:35:55 +02:00
parent 11632286bf
commit 48098219c7
1 changed files with 5 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/main/webapp/js/directives.js
View File

@@ -138,16 +138,11 @@ module.directive('scrollTo', [ '$timeout', function($timeout) {
var elemTop = $(element).offset().top; var elemTop = $(element).offset().top;
var elemBottom = elemTop + $(element).height(); var elemBottom = elemTop + $(element).height();
if ((elemTop > docTop) && (elemBottom < docBottom)) { var offset = parseInt(attrs.scrollToOffset, 10);
// element is entirely visible var scrollTop = $(element).offset().top + offset;
return; $('html, body').animate({
} else { scrollTop : scrollTop
var offset = parseInt(attrs.scrollToOffset, 10); }, 0);
var scrollTop = $(element).offset().top + offset;
$('html, body').animate({
scrollTop : scrollTop
}, 0);
}
}); });
}); });
} }