Noded
/
backend
3
0
Fork 0
Code Issues 19 Pull Requests Releases Wiki Activity
Labels Milestones
New Issue

Create PageRoute and PageNodeRoute middleware #18

Closed
opened 4 years ago by garrettmills · 0 comments
garrettmills commented 4 years ago
Owner

A lot of controller methods require a page and/or a node ID to be specified. This leads to a lot of duplicate code. Let's clean that up by creating middlewares do the following:

  1. Retrieve the PageId from the params
  2. Try to look up that page. If not exists, return 404 API error
  3. If exists, check user access. If not accessible, return 401 API error
    • allow passing in the access level as a parameter
  4. If accessible, set req.noded.page and/or req.noded.node
A lot of controller methods require a page and/or a node ID to be specified. This leads to a lot of duplicate code. Let's clean that up by creating middlewares do the following: 1. Retrieve the PageId from the params 2. Try to look up that page. If not exists, return 404 API error 3. If exists, check user access. If not accessible, return 401 API error - allow passing in the access level as a parameter 4. If accessible, set `req.noded.page` and/or `req.noded.node`
garrettmills added the Feature Request Scope: APIs labels 4 years ago
garrettmills closed this issue 4 years ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
Labels
Apply labels
Clear labels
Bug Deployed to: Production Deployed to: Staging Feature Request Infrastructure Out-there Idea Ready to Deploy Scope: APIs Scope: Authentication Scope: Databases Scope: Exports Scope: Plugins Under Development Won't Fix
No Label Bug Deployed to: Production Deployed to: Staging Feature Request Infrastructure Out-there Idea Ready to Deploy Scope: APIs Scope: Authentication Scope: Databases Scope: Exports Scope: Plugins Under Development Won't Fix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Noded/backend#18
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(<nil>)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes