Archives/wting_autojump
1
0
Fork 0
mirror of https://github.com/wting/autojump synced 2024-10-27 20:34:07 +00:00
Code Issues Releases Wiki Activity

try to make autojump more robust to concurrent uses over network filesystems

Browse Source 
When your home is on a network filesytems, multiple shells can try
to write to the autojump store concurrently. The previous system was
a bit dangerous since the name of the temp file was always the same.
This should be better, since the different autojump instances should
all write to different temporaries, and only the atomic rename() should
be concurrent. Time will tell...
This commit is contained in:
Joël Schaerer 2010-09-29 15:22:13 +02:00
parent de9270bb99
commit 52f3c84b29
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
autojump
View File

@ -19,6 +19,7 @@ from __future__ import division
import cPickle import cPickle
import getopt import getopt
from sys import argv,exit,stderr from sys import argv,exit,stderr
from tempfile import NamedTemporaryFile
import os import os
import signal import signal
max_keyweight=1000 max_keyweight=1000
@ -38,19 +39,19 @@ def dicadd(dic,key,increment=1):
dic[key]=dic.get(key,0.)+increment dic[key]=dic.get(key,0.)+increment
def save(path_dict,dic_file): def save(path_dict,dic_file):
f=open(dic_file+".tmp",'w') f=NamedTemporaryFile(dir=config_dir,delete=False)
cPickle.dump(path_dict,f,-1) cPickle.dump(path_dict,f,-1)
f.flush() f.flush()
os.fsync(f) os.fsync(f)
f.close() f.close()
try: os.rename(f.name,dic_file) #cf. http://thunk.org/tytso/blog/2009/03/15/dont-fear-the-fsync/
os.rename(dic_file+".tmp",dic_file) #cf. http://thunk.org/tytso/blog/2009/03/15/dont-fear-the-fsync/ try: #backup file
import time #backup file import time
if not os.path.exists(dic_file+".bak") or time.time()-os.path.getmtime(dic_file+".bak")>86400: if not os.path.exists(dic_file+".bak") or time.time()-os.path.getmtime(dic_file+".bak")>86400:
import shutil import shutil
shutil.copy(dic_file,dic_file+".bak") shutil.copy(dic_file,dic_file+".bak")
except OSError: except OSError, e:
pass #Fail quietly, this usually means a concurrent autojump process already did the job print >> stderr, "Error while creating backup autojump file. (%s)" % e
def forget(path_dict,dic_file): def forget(path_dict,dic_file):
"""Gradually forget about directories. Only call from the actual jump since it can take time""" """Gradually forget about directories. Only call from the actual jump since it can take time"""