Archives/wting_autojump
1
0
Fork 0
mirror of https://github.com/wting/autojump synced 2024-10-27 20:34:07 +00:00
Code Issues Releases Wiki Activity

Use non-lazy enumeration for removal of dictionary keys.

Browse Source 
In the current situation, iterating over `self.data.keys()` is OK only when
the dictionary is not modified, as `self.data.keys()` is lazily generated,
at least in Python 3.

Unfortunately, as we intend to change the dictionary with the `--purge`
option, we get a runtime exception when iterating the loop.

This commit fixes it by making the generation of the list of keys occur only
once, so that the dictionary itself can be modified in the body of the loop.

Tested with both Python 2.7 and Python 3.3.

Signed-off-by: Rogério Brito <rbrito@ime.usp.br>
This commit is contained in:
Rogério Brito 2013-04-14 12:52:13 -03:00
parent 883967e9f1
commit 2a49b8ca47
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
bin/autojump
View File

@ -173,7 +173,7 @@ class Database:
Deletes all entries that no longer exist on system. Deletes all entries that no longer exist on system.
""" """
removed = [] removed = []
for path in self.data.keys(): for path in list(self.data.keys()):
if not os.path.exists(path): if not os.path.exists(path):
removed.append(path) removed.append(path)
del self.data[path] del self.data[path]