mirror of
https://github.com/tobspr/shapez.io.git
synced 2024-10-27 20:34:29 +00:00
ff2274f671
Building the standalone with V8 v8 (Node v14) fails at step `sounds.musicHQ`, either by running out of memory or with the error "Invalid string length". Building with V8 v7 (Node v12) succeeds. This is because `gulp-cache` builds a 994-MB string when [stringifying file contents](https://github.com/jgable/gulp-cache/blob/master/src/task-proxy.js#L262) to cache them. V8 v8 [limits string length to around 537 MB](https://github.com/v8/v8/blob/master/src/objects/string.h#L384), and thus cannot represent this string. (V8 v7 allows around 1074 MB, which is why the build passes on Node v12.) But [`theme-full.mp3`](https://github.com/tobspr/shapez.io/blob/master/res_raw/sounds/music/theme-full.mp3) is only 79 MB: how did we get 1250% overhead? Unlike plaintext files, binary files are read as buffers, but [by default](https://github.com/jgable/gulp-cache/blob/master/src/index.js#L46) `gulp-cache` stringifies them naively, producing the extremely inefficient representation: ```` [ { "cwd": "/Users/tobspr/shapez.io/gulp", "base": "/Users/tobspr/shapez.io/res_raw/sounds/music", "contents": { "type": "Buffer", "data": [ 73, 68, 51, 4, 0, 0, …etc. ```` Fortunately, `gulp-cache` [can read base64-encoded cache files](https://github.com/jgable/gulp-cache/blob/master/src/index.js#L26). Instead of using the default file transform function, **pass a `value` option to base64-encode the file contents**. This results in only 33% overhead on cache file size (106 MB for the largest file). This has multiple benefits: - Fixes the build failure - Requires less memory (from 6 GB down to < 1 GB on my machine) - When cache files are found, the `sounds.musicHQ` is much faster (from ~30 s down to ~4 s on my machine) - Smaller cache files on disk |
||
|---|---|---|
| .. | ||
| .babelrc | ||
| .gitattributes | ||
| .gitignore | ||
| .itch.toml | ||
| babel-es6.config.js | ||
| babel.config.js | ||
| buildutils.js | ||
| bundle-loader.js | ||
| convert_atlas.js | ||
| cordova.js | ||
| css.js | ||
| docs.js | ||
| ftp.js | ||
| gulpfile.js | ||
| html.js | ||
| image-resources.js | ||
| js.js | ||
| jsconfig.json | ||
| loader.compressjson.js | ||
| loader.strip_block.js | ||
| package.json | ||
| sounds.js | ||
| standalone.js | ||
| translations.js | ||
| tsconfig.json | ||
| webpack.config.js | ||
| webpack.production.config.js | ||
| yarn.lock | ||