Archives/tobspr_shapez.io
1
0
Fork 0
mirror of https://github.com/tobspr/shapez.io.git synced 2024-10-27 20:34:29 +00:00
Code Issues Projects Releases Wiki Activity

[Perf] Avoid iterating over keys to generate assert message (#486)

Browse Source 
* Avoid iterating over keys to generate assert message

* Move assertion call behind guard

* Shorten line by using string template
This commit is contained in:
Bjorn Stromberg 2020-07-27 18:15:59 +09:00 committed by GitHub
parent 2be3eae2aa
commit 6d01c482d8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/js/core/sprites.js
View File

@ -158,7 +158,9 @@ export class AtlasSprite extends BaseSprite {
const scale = parameters.desiredAtlasScale; const scale = parameters.desiredAtlasScale;
const link = this.linksByResolution[scale]; const link = this.linksByResolution[scale];
assert(link, "Link not known: " + scale + " (having " + Object.keys(this.linksByResolution) + ")"); if (!link) {
assert(false, `Link not known: ${scale} (having ${Object.keys(this.linksByResolution)})`);
}
const scaleW = w / link.w; const scaleW = w / link.w;
const scaleH = h / link.h; const scaleH = h / link.h;