From 6d01c482d8ccb9f526836274066d9c604ae0a62f Mon Sep 17 00:00:00 2001 From: Bjorn Stromberg Date: Mon, 27 Jul 2020 18:15:59 +0900 Subject: [PATCH] [Perf] Avoid iterating over keys to generate assert message (#486) * Avoid iterating over keys to generate assert message * Move assertion call behind guard * Shorten line by using string template --- src/js/core/sprites.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/js/core/sprites.js b/src/js/core/sprites.js index 26cd65b2..8427f2ef 100644 --- a/src/js/core/sprites.js +++ b/src/js/core/sprites.js @@ -158,7 +158,9 @@ export class AtlasSprite extends BaseSprite { const scale = parameters.desiredAtlasScale; const link = this.linksByResolution[scale]; - assert(link, "Link not known: " + scale + " (having " + Object.keys(this.linksByResolution) + ")"); + if (!link) { + assert(false, `Link not known: ${scale} (having ${Object.keys(this.linksByResolution)})`); + } const scaleW = w / link.w; const scaleH = h / link.h;