Archives/ohwgiles_laminar
1
0
Fork 0
mirror of https://github.com/ohwgiles/laminar.git synced 2024-10-27 20:34:20 +00:00
Code Issues Projects Releases Wiki Activity

Http::cleanupPeers: check fulfiller is non-null

Browse Source 
resolves #185
This commit is contained in:
Oliver Giles 2023-03-17 09:51:24 +13:00
parent 1e7e9319c3
commit dab620b01e
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/http.cpp
View File

@ -131,10 +131,17 @@ kj::Promise<void> Http::cleanupPeers(kj::Timer& timer)
{ {
return timer.afterDelay(15 * kj::SECONDS).then([&]{ return timer.afterDelay(15 * kj::SECONDS).then([&]{
for(EventPeer* p : eventPeers) { for(EventPeer* p : eventPeers) {
// Even single threaded, if load causes this timeout to be serviced
// before writeEvents has created a fulfiller, or if an exception
// caused the destruction of the promise but attach(peer) hasn't yet
// removed it from the eventPeers list, we will see a null fulfiller
// here
if(p->fulfiller) {
// an empty SSE message is a colon followed by two newlines // an empty SSE message is a colon followed by two newlines
p->pendingOutput.push_back(":\n\n"); p->pendingOutput.push_back(":\n\n");
p->fulfiller->fulfill(); p->fulfiller->fulfill();
} }
}
return cleanupPeers(timer); return cleanupPeers(timer);
}).eagerlyEvaluate(nullptr); }).eagerlyEvaluate(nullptr);
} }