Archives/lancedikson_bowser
1
0
Fork 0
mirror of https://github.com/lancedikson/bowser synced 2024-10-27 20:34:22 +00:00
Code Issues Releases Wiki Activity

refactoring: use map instead of direct Array::map

Browse Source
This commit is contained in:
Alexander Lukin 2016-06-16 13:39:05 +03:00
parent b51a35e006
commit c77cf0ae1b
1 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/bowser.js
View File

@ -451,16 +451,21 @@
function compareVersions(versions) {
// 1) get common precision for both versions, for example for "10.0" and "9" it should be 2
var precision = Math.max(getVersionPrecision(versions[0]), getVersionPrecision(versions[1]));
var chunks = versions.map(function (version) {
var chunks = map(versions, function (version) {
var delta = precision - getVersionPrecision(version);
return (version + new Array(delta + 1).join(".0")) // 2) "9" -> "9.0" (for precision = 2)
.split(".")
.map(function (chunk) { return new Array(10 - chunk.length).join("0") + chunk; })
.reverse();
// 2) "9" -> "9.0" (for precision = 2)
version = version + new Array(delta + 1).join(".0");
// 3) "9.0" -> [""000000000"", "000000009"]
return map(version.split("."), function (chunk) {
return new Array(20 - chunk.length).join("0") + chunk;
}).reverse();
});
// iterate in reverse order by reversed chunks array
while (--precision >= 0) {
// 5) compare: "000000009" > "000000010" = false (but "9" > "10" = true)
// 4) compare: "000000009" > "000000010" = false (but "9" > "10" = true)
if (chunks[0][precision] > chunks[1][precision]) {
return 1;
}