From c77cf0ae1b124b79de2059ac3b9781a67692283d Mon Sep 17 00:00:00 2001 From: Alexander Lukin Date: Thu, 16 Jun 2016 13:39:05 +0300 Subject: [PATCH] refactoring: use map instead of direct Array::map --- src/bowser.js | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/src/bowser.js b/src/bowser.js index 81d1c6c..8d2dee4 100644 --- a/src/bowser.js +++ b/src/bowser.js @@ -451,16 +451,21 @@ function compareVersions(versions) { // 1) get common precision for both versions, for example for "10.0" and "9" it should be 2 var precision = Math.max(getVersionPrecision(versions[0]), getVersionPrecision(versions[1])); - var chunks = versions.map(function (version) { - var delta = precision - getVersionPrecision(version); - return (version + new Array(delta + 1).join(".0")) // 2) "9" -> "9.0" (for precision = 2) - .split(".") - .map(function (chunk) { return new Array(10 - chunk.length).join("0") + chunk; }) - .reverse(); + var chunks = map(versions, function (version) { + var delta = precision - getVersionPrecision(version); + + // 2) "9" -> "9.0" (for precision = 2) + version = version + new Array(delta + 1).join(".0"); + + // 3) "9.0" -> [""000000000"", "000000009"] + return map(version.split("."), function (chunk) { + return new Array(20 - chunk.length).join("0") + chunk; + }).reverse(); }); + // iterate in reverse order by reversed chunks array while (--precision >= 0) { - // 5) compare: "000000009" > "000000010" = false (but "9" > "10" = true) + // 4) compare: "000000009" > "000000010" = false (but "9" > "10" = true) if (chunks[0][precision] > chunks[1][precision]) { return 1; }