Archives/lancedikson_bowser
1
0
Fork 0
mirror of https://github.com/lancedikson/bowser synced 2026-10-29 23:09:03 +00:00
Code Issues Releases Wiki Activity

fix(types): allow undefined from compareVersion (#641)

Browse Source
This commit is contained in:
Hugohong258
2026-10-27 18:05:54 +08:00
committed by GitHub
parent c220b2bf1c
commit 83076d8bc2
3 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
index.d.ts vendored
View File

@@ -75,10 +75,10 @@ declare namespace Bowser {
/**
* Check if the version is equals the browser version
* @param version The string to compare with the browser version
* @returns {boolean}
* @returns {boolean | undefined} Undefined if no browser version is available.
*/
compareVersion(version: string): boolean;
compareVersion(version: string): boolean | undefined;
/**
* Get parsed browser object

3
test/types/fixtures/consumer-cjs.ts
View File

@@ -9,6 +9,9 @@ const result: Bowser.Parser.ParsedResult = Bowser.parse(UA);
const parser: Bowser.Parser.Parser = Bowser.getParser(UA);
const name: string | undefined = result.browser.name;
const satisfies: boolean | undefined = parser.satisfies({ chrome: '>100' });
const comparison: boolean | undefined = parser.compareVersion('>100');
// @ts-expect-error A browser without a detected version returns undefined.
const definiteComparison: boolean = parser.compareVersion('>100');
const hints: Bowser.ClientHints = { mobile: false };
const maps: Record<string, string> = Bowser.BROWSER_MAP;

3
test/types/fixtures/consumer-esm.ts
View File

@@ -12,6 +12,9 @@ const result: ParsedResult = parse(UA);
const parser: Parser = getParser(UA);
const tree: checkTree = { chrome: '>100' };
const satisfies: boolean | undefined = parser.satisfies(tree);
const comparison: boolean | undefined = parser.compareVersion('>100');
// @ts-expect-error A browser without a detected version returns undefined.
const definiteComparison: boolean = parser.compareVersion('>100');
const hints: ClientHints = { mobile: false };
const maps: Array<Record<string, string>> = [
Bowser.BROWSER_MAP, BROWSER_MAP, ENGINE_MAP, OS_MAP, PLATFORMS_MAP,