Archives/lancedikson_bowser
1
0
Fork 0
mirror of https://github.com/lancedikson/bowser synced 2025-12-04 21:52:14 +00:00
Code Issues Releases Wiki Activity

revert: rollback addition of named exports (#591)

Browse Source
This commit is contained in:
Naor Peled 2025-11-29 02:01:44 +02:00 committed by GitHub
parent eef8480944
commit 1df8838756
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 1 additions and 75 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
index.d.ts vendored
View File

@ -5,13 +5,6 @@
export = Bowser;
export as namespace Bowser;
export function getParser(UA: string, skipParsing?: boolean): Bowser.Parser.Parser;
export function parse(UA: string): Bowser.Parser.ParsedResult;
export const BROWSER_MAP: Record<string, string>;
export const ENGINE_MAP: Record<string, string>;
export const OS_MAP: Record<string, string>;
export const PLATFORMS_MAP: Record<string, string>;
declare namespace Bowser {
/**
* Creates a Parser instance

6
src/bowser.js
View File

@ -75,9 +75,3 @@ class Bowser {
}
export default Bowser;
export const { getParser } = Bowser;
export const { parse } = Bowser;
export {
BROWSER_MAP, ENGINE_MAP, OS_MAP, PLATFORMS_MAP,
};

63
test/unit/bowser.js
View File

@ -1,5 +1,5 @@
import test from 'ava';
import Bowser, { getParser, parse, BROWSER_MAP, ENGINE_MAP, OS_MAP, PLATFORMS_MAP } from '../../src/bowser';
import Bowser from '../../src/bowser';
import Parser from '../../src/parser';
const UA = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36 OPR/43.0.2442.1165';
@ -16,64 +16,3 @@ test('Bowser`s constructor fails if UA is empty', (t) => {
test('Bowser.parse parses UA and returns result', (t) => {
t.deepEqual(Bowser.parse(UA), browser.getResult());
});
test('Named export getParser works like Bowser.getParser', (t) => {
const namedExportParser = getParser(UA);
t.truthy(namedExportParser instanceof Parser);
t.deepEqual(namedExportParser.getResult(), browser.getResult());
});
test('Named export getParser with skipParsing parameter', (t) => {
const parserWithSkip = getParser(UA, true);
t.truthy(parserWithSkip instanceof Parser);
// With skipParsing=true, the result should be undefined until we explicitly parse
t.deepEqual(parserWithSkip.getResult(), Bowser.getParser(UA, true).getResult());
});
test('Named export getParser throws error for invalid UA', (t) => {
t.throws(() => getParser(undefined), { message: 'UserAgent should be a string' });
t.throws(() => getParser(123), { message: 'UserAgent should be a string' });
t.throws(() => getParser(null), { message: 'UserAgent should be a string' });
t.throws(() => getParser({}), { message: 'UserAgent should be a string' });
});
test('Named export parse works like Bowser.parse', (t) => {
t.deepEqual(parse(UA), Bowser.parse(UA));
});
test('Named export parse produces consistent results', (t) => {
const result1 = parse(UA);
const result2 = parse(UA);
t.deepEqual(result1, result2);
t.deepEqual(result1, Bowser.parse(UA));
});
test('Named exports of constants are available', (t) => {
t.truthy(BROWSER_MAP);
t.truthy(ENGINE_MAP);
t.truthy(OS_MAP);
t.truthy(PLATFORMS_MAP);
t.is(BROWSER_MAP, Bowser.BROWSER_MAP);
t.is(ENGINE_MAP, Bowser.ENGINE_MAP);
t.is(OS_MAP, Bowser.OS_MAP);
t.is(PLATFORMS_MAP, Bowser.PLATFORMS_MAP);
});
test('Named exports constants are objects with expected structure', (t) => {
t.is(typeof BROWSER_MAP, 'object');
t.is(typeof ENGINE_MAP, 'object');
t.is(typeof OS_MAP, 'object');
t.is(typeof PLATFORMS_MAP, 'object');
});
test('All named exports work together', (t) => {
// Test that we can use multiple named exports in the same scope
const result = parse(UA);
const parser = getParser(UA);
t.deepEqual(result, parser.getResult());
t.truthy(BROWSER_MAP);
t.truthy(ENGINE_MAP);
t.truthy(OS_MAP);
t.truthy(PLATFORMS_MAP);
});