Archives/lancedikson_bowser
1
0
Fork 0
mirror of https://github.com/lancedikson/bowser synced 2026-09-22 20:14:20 +00:00
Code Issues Releases Wiki Activity

fix(test): replace rm -rf with Node fs cleanup in package smoke test

Browse Source 
Shelling out to rm breaks on Windows. fs.rmSync covers Node 14.14+,
recursive fs.rmdirSync covers the bottom of the support matrix.
This commit is contained in:
naorpeled
2026-08-29 23:50:17 +03:00
parent 5cfd97ed08
commit 19c2d8d3a1
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
test/package/smoke.cjs
View File

@@ -41,8 +41,10 @@ var modules = path.join(tmp, 'node_modules');
fs.mkdirSync(modules);
// `npm install <tarball>` would work too, but plain tar keeps this dependency
// free and identical across the whole Node matrix. npm tarballs always unpack
// to a single top-level `package/` directory.
// free and identical across the whole Node matrix, and sidesteps the
// npm.cmd-needs-a-shell quirks of spawning npm on Windows. tar itself is on
// PATH everywhere this runs: Linux, macOS, and Windows 10 1803+ (bsdtar).
// npm tarballs always unpack to a single top-level `package/` directory.
cp.execFileSync('tar', ['-xzf', tarball, '-C', modules], { stdio: 'inherit' });
fs.renameSync(path.join(modules, 'package'), path.join(modules, 'bowser'));
@@ -52,8 +54,13 @@ fs.writeFileSync(runner, fs.readFileSync(path.join(__dirname, 'assertions.cjs'))
var result = cp.spawnSync(process.execPath, [runner], { cwd: tmp, stdio: 'inherit' });
try {
// fs.rmSync landed in Node 14.14; rimraf-by-hand keeps Node 12 happy.
cp.execFileSync('rm', ['-rf', tmp]);
// fs.rmSync landed in Node 14.14; recursive fs.rmdirSync (12.10+) covers the
// bottom of the matrix. Both work on Windows, unlike shelling out to `rm`.
if (fs.rmSync) {
fs.rmSync(tmp, { recursive: true, force: true });
} else {
fs.rmdirSync(tmp, { recursive: true });
}
} catch (e) { /* best effort */ }
if (result.status !== 0) {