Dmitry S d1c1416d78 (core) Add rules to eslint to better match our coding conventions. ...

Summary:
We used tslint earlier, and on switching to eslint, some rules were not
transfered. This moves more rules over, for consistent conventions or helpful
warnings.

- Name private members with a leading underscore.
- Prefer interface over a type alias.
- Use consistent spacing around ':' in type annotations.
- Use consistent spacing around braces of code blocks.
- Use semicolons consistently at the ends of statements.
- Use braces around even one-liner blocks, like conditionals and loops.
- Warn about shadowed variables.

Test Plan: Fixed all new warnings. Should be no behavior changes in code.

Reviewers: paulfitz

Reviewed By: paulfitz

Differential Revision: https://phab.getgrist.com/D2831

2021-05-24 12:56:18 -04:00

..

AceEditor.css

(core) move client code to core

2020-10-02 13:24:21 -04:00

AceEditor.js

(core) Document keeps track of latest cursor position and latest editor value and is able to restore them when it is reloaded.

2021-05-18 10:36:59 +02:00

AceEditorCompletions.ts

(core) One more phase of ACL UI revision.

2020-12-22 22:18:12 -05:00

ActionLog.css

(core) move client code to core

2020-10-02 13:24:21 -04:00

ActionLog.ts

(core) Add rules to eslint to better match our coding conventions.

2021-05-24 12:56:18 -04:00

Base.js

(core) move client code to core

2020-10-02 13:24:21 -04:00

BaseView.js

(core) Document keeps track of latest cursor position and latest editor value and is able to restore them when it is reloaded.

2021-05-18 10:36:59 +02:00

CellPosition.ts

(core) Add rules to eslint to better match our coding conventions.

2021-05-24 12:56:18 -04:00

ChartView.css

(core) move client code to core

2020-10-02 13:24:21 -04:00

ChartView.ts

(core) Fix JS error when switching to a page containing a chart.

2021-02-25 10:50:24 -05:00

ClientScope.ts

(core) move client code to core

2020-10-02 13:24:21 -04:00

Clipboard.css

(core) move client code to core

2020-10-02 13:24:21 -04:00

Clipboard.js

(core) Add support for editing on mobile.

2021-02-03 23:10:51 -05:00

CodeEditorPanel.css

(core) move client code to core

2020-10-02 13:24:21 -04:00

CodeEditorPanel.js

(core) Add rules to eslint to better match our coding conventions.

2021-05-24 12:56:18 -04:00

ColumnFilters.css

(core) move client code to core

2020-10-02 13:24:21 -04:00

ColumnTransform.ts

(core) Configure more comprehensive eslint rules for Typescript

2021-04-26 18:54:55 -04:00

Comm.ts

(core) Add rules to eslint to better match our coding conventions.

2021-05-24 12:56:18 -04:00

commandList.js

(core) Change how formula columns can be converted to data.

2021-03-05 12:42:57 -05:00

commands.css

(core) move client code to core

2020-10-02 13:24:21 -04:00

commands.js

(core) Improve focus and keyboard shortcuts in modals.

2020-10-03 22:56:00 -04:00

CopySelection.js

(core) move client code to core

2020-10-02 13:24:21 -04:00

Cursor.ts

(core) Add rules to eslint to better match our coding conventions.

2021-05-24 12:56:18 -04:00

CursorMonitor.ts

(core) Add rules to eslint to better match our coding conventions.

2021-05-24 12:56:18 -04:00

CustomView.css

(core) Fix CustomView css to take full height of widget on all browsers including Safari

2020-10-06 13:18:50 -04:00

CustomView.ts

(core) Implement 'Print widget' option to print individual view sections.

2020-10-10 00:35:33 -04:00

DetailView.css

(core) Document keeps track of latest cursor position and latest editor value and is able to restore them when it is reloaded.

2021-05-18 10:36:59 +02:00

DetailView.js

(core) show differences in card views when comparing documents

2020-11-11 17:25:38 -05:00

DocComm.ts

(core) granular access control in the presence of schema changes

2021-03-01 13:49:31 -05:00

DocConfigTab.js

(core) move client code to core

2020-10-02 13:24:21 -04:00

duplicatePage.ts

(core) Add rules to eslint to better match our coding conventions.

2021-05-24 12:56:18 -04:00

EditorMonitor.ts

(core) Add rules to eslint to better match our coding conventions.

2021-05-24 12:56:18 -04:00

EmbedForm.css

(core) move client code to core

2020-10-02 13:24:21 -04:00

FieldConfigTab.css

(core) move client code to core

2020-10-02 13:24:21 -04:00

FormulaTransform.ts

(core) Automatically finalize action bundles when unrelated actions/bundles come in.

2020-11-10 10:32:07 -05:00

GridView.css

(core) Select all functionality by clicking the upper left margin corner

2021-04-29 20:56:25 +02:00

GridView.js

(core) Document keeps track of latest cursor position and latest editor value and is able to restore them when it is reloaded.

2021-05-18 10:36:59 +02:00

GristDoc.css

(core) move client code to core

2020-10-02 13:24:21 -04:00

GristDoc.ts

(core) Add rules to eslint to better match our coding conventions.

2021-05-24 12:56:18 -04:00

GristWSConnection.ts

(core) Add rules to eslint to better match our coding conventions.

2021-05-24 12:56:18 -04:00

Importer.ts

(core) Configure more comprehensive eslint rules for Typescript

2021-04-26 18:54:55 -04:00

Layout.css

(core) Collapse inactive view sections on mobile screens.

2021-02-09 09:17:32 -05:00

Layout.js

(core) Collapse inactive view sections on mobile screens.

2021-02-09 09:17:32 -05:00

LayoutEditor.css

(core) move client code to core

2020-10-02 13:24:21 -04:00

LayoutEditor.js

(core) move client code to core

2020-10-02 13:24:21 -04:00

LayoutPreview.css

(core) move client code to core

2020-10-02 13:24:21 -04:00

LayoutPreview.js

(core) move client code to core

2020-10-02 13:24:21 -04:00

LinkingState.js

(core) When filter-linking by a reference column, update the filter-linking when the value in that column changes

2021-02-05 10:15:01 -05:00

Login.css

(core) move client code to core

2020-10-02 13:24:21 -04:00

ParseOptions.ts

(core) move client code to core

2020-10-02 13:24:21 -04:00

Preferences.css

(core) move client code to core

2020-10-02 13:24:21 -04:00

Printing.css

(core) Improve printing of tables, fix printing of charts, add a browser test.

2020-10-12 16:04:18 -04:00

Printing.ts

(core) Improve printing of tables, fix printing of charts, add a browser test.

2020-10-12 16:04:18 -04:00

RecordLayout.css

(core) move client code to core

2020-10-02 13:24:21 -04:00

RecordLayout.js

(core) Automatically finalize action bundles when unrelated actions/bundles come in.

2020-11-10 10:32:07 -05:00

RecordLayoutEditor.js

(core) move client code to core

2020-10-02 13:24:21 -04:00

RefSelect.js

(core) Update UI for formula and column label/id in the right-side panel.

2021-03-17 01:35:56 -04:00

REPLTab.css

(core) move client code to core

2020-10-02 13:24:21 -04:00

REPLTab.js

(core) move client code to core

2020-10-02 13:24:21 -04:00

SearchBar.css

(core) move client code to core

2020-10-02 13:24:21 -04:00

SearchBar.ts

(core) Configure more comprehensive eslint rules for Typescript

2021-04-26 18:54:55 -04:00

Selector.js

(core) Configure more comprehensive eslint rules for Typescript

2021-04-26 18:54:55 -04:00

SummaryConfig.js

(core) move client code to core

2020-10-02 13:24:21 -04:00

TypeConversion.ts

(core) Preserve configured choices when converting between Choice and ChoiceList types.

2021-05-18 09:59:20 -04:00

TypeTransform.ts

(core) Add rules to eslint to better match our coding conventions.

2021-05-24 12:56:18 -04:00

UndoStack.ts

(core) Add rules to eslint to better match our coding conventions.

2021-05-24 12:56:18 -04:00

UnsavedChanges.ts

(core) support ?embed=true and &style=light for a clean embed experience

2020-08-14 13:34:38 -04:00

ValidationPanel.css

(core) move client code to core

2020-10-02 13:24:21 -04:00

ValidationPanel.js

(core) move client code to core

2020-10-02 13:24:21 -04:00

viewCommon.css

(core) Document keeps track of latest cursor position and latest editor value and is able to restore them when it is reloaded.

2021-05-18 10:36:59 +02:00

viewCommon.js

(core) move client code to core

2020-10-02 13:24:21 -04:00

ViewConfigTab.css

(core) move client code to core

2020-10-02 13:24:21 -04:00

ViewConfigTab.js

(core) change filtering section of the sort&Filter side panel to match newui style

2021-05-05 15:05:13 +02:00

ViewLayout.css

(core) split sort and filter menu into its own button

2021-05-03 09:13:28 +02:00

ViewLayout.ts

(core) split sort and filter menu into its own button

2021-05-03 09:13:28 +02:00

ViewLinker.css

(core) move client code to core

2020-10-02 13:24:21 -04:00

ViewPane.ts

(core) Update UI for formula and column label/id in the right-side panel.

2021-03-17 01:35:56 -04:00