Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity
c470c4041b
gristlabs_grist-core/app/client/components
History
Alex Hall c470c4041b (core) Use visibleCol instead of displayCol with createFormatter 
Summary:
Some things (like rendering cells) use the `visibleCol` for `createFormatter`, while other things (like `CopySelection`) used the `displayCol`. For references, the display column has type Any and doesn't know about the original formatting. This resulted in formatting being lost when copying from reference columns even though formatting was preserved when copying from the original (visible) column which looked identical. This diff fixes this and ensures that `createFormatter` is always used with the `visibleCol`. This was agreed on in https://grist.slack.com/archives/C0234CPPXPA/p1639571321043000

Additionally:

- Replaces the functions `createVisibleColFormatter` computed properties `visibleColFormatter` as suggested by a `TODO`.
- Extracts common code from `createVisibleColFormatter` in `ColumnRec` and `ViewFieldRec`

Test Plan: Fixed a test in CopyPaste which displayed the previous inconsistent behaviour.

Reviewers: jarek

Reviewed By: jarek

Differential Revision: https://phab.getgrist.com/D3189
2021-12-16 22:19:36 +02:00
..
AceEditor.css
AceEditor.js (core) Fixing scrollbars on ace editor for windows users. 2021-10-25 10:56:43 +02:00
AceEditorCompletions.ts (core) One more phase of ACL UI revision. 2020-12-22 22:18:12 -05:00
ActionLog.css
ActionLog.ts (core) Add rules to eslint to better match our coding conventions. 2021-05-24 12:56:18 -04:00
Base.js
BaseView.js (core) Refactor more value parsing code into common 2021-12-09 21:05:27 +02:00
CellPosition.ts (core) Draft cells 2021-05-25 21:14:49 +02:00
ChartView.css
ChartView.ts (core) Use visibleCol instead of displayCol with createFormatter 2021-12-16 22:19:36 +02:00
ClientScope.ts
Clipboard.css
Clipboard.js (core) Trim trailing whitespace when pasting plain text 2021-11-04 01:26:47 +02:00
CodeEditorPanel.css (core) apply access control to code view 2021-05-27 17:52:23 -04:00
CodeEditorPanel.js (core) apply access control to code view 2021-05-27 17:52:23 -04:00
ColumnFilters.css (core) Context menu for cards. 2021-06-29 15:29:56 +02:00
ColumnTransform.ts (core) Configure more comprehensive eslint rules for Typescript 2021-04-26 18:54:55 -04:00
Comm.ts (core) Remove a bunch of dead code 2021-07-01 18:38:21 +02:00
commandList.js (core) Freezing columns on a GridView 2021-06-18 12:22:13 +02:00
commands.css
commands.js
CopySelection.ts (core) Use visibleCol instead of displayCol with createFormatter 2021-12-16 22:19:36 +02:00
Cursor.ts (core) Support 'new' row in anchor links. 2021-09-24 09:01:10 -04:00
CursorMonitor.ts (core) Exposing custom widgets on the UI 2021-12-01 18:21:06 +01:00
CustomView.css
CustomView.ts (core) Initial page for custom widget 2021-08-13 23:58:25 +02:00
DetailView.css (core) Context menu for cards. 2021-06-29 15:29:56 +02:00
DetailView.js (core) Convert CopySelection and tableUtil to typescript 2021-10-25 18:55:26 -04:00
DocComm.ts (core) Add diff preview to Importer 2021-10-08 14:15:07 -07:00
DocConfigTab.js
Drafts.ts (core) Adding colors to toast notification 2021-10-05 10:19:25 +02:00
duplicatePage.ts (core) Use MetaTableData more 2021-12-07 17:09:58 +02:00
EditorMonitor.ts (core) Storing last position for doc and user 2021-11-19 12:01:49 +01:00
EmbedForm.css
FieldConfigTab.css
FormulaTransform.ts (core) Automatically finalize action bundles when unrelated actions/bundles come in. 2020-11-10 10:32:07 -05:00
GridView.css (core) Context menu for cards. 2021-06-29 15:29:56 +02:00
GridView.js (core) Skip saving column resizes in read-only mode 2021-12-07 14:37:25 -08:00
GristDoc.css
GristDoc.ts (core) Use MetaTableData more 2021-12-07 17:09:58 +02:00
GristWSConnection.ts (core) Add rules to eslint to better match our coding conventions. 2021-05-24 12:56:18 -04:00
Importer.ts (core) Adding Skip options when importing multiple tables. 2021-12-13 19:07:33 +01:00
Layout.css (core) Collapse inactive view sections on mobile screens. 2021-02-09 09:17:32 -05:00
Layout.js (core) Collapse inactive view sections on mobile screens. 2021-02-09 09:17:32 -05:00
LayoutEditor.css
LayoutEditor.js
LayoutPreview.css
LayoutPreview.js
LinkingState.ts (core) Move cursor to new record in link target when selecting new record in link source 2021-09-22 22:57:05 +02:00
Login.css
ParseOptions.ts
PluginScreen.ts (core) Add column matching to Importer 2021-11-09 12:30:52 -08:00
Preferences.css
Printing.css
Printing.ts
RecordLayout.css
RecordLayout.js (core) Context menu for cards. 2021-06-29 15:29:56 +02:00
RecordLayoutEditor.js
RefSelect.js (core) Update UI for formula and column label/id in the right-side panel. 2021-03-17 01:35:56 -04:00
SearchBar.css
Selector.js (core) Configure more comprehensive eslint rules for Typescript 2021-04-26 18:54:55 -04:00
SummaryConfig.js
TypeConversion.ts (core) Fix converting column to ChoiceList when cells contain JSON arrays with non-string values 2021-11-09 12:53:20 +02:00
TypeTransform.ts (core) Add rules to eslint to better match our coding conventions. 2021-05-24 12:56:18 -04:00
UndoStack.ts (core) do not look at content of recent actions when loading documents 2021-09-29 11:27:02 -04:00
UnsavedChanges.ts
ValidationPanel.css
ValidationPanel.js
viewCommon.css (core) Set min-height for cells, including in Card view, to make them look consistent. 2021-11-19 17:23:03 -05:00
viewCommon.js (core) Skip saving column resizes in read-only mode 2021-12-07 14:37:25 -08:00
ViewConfigTab.css
ViewConfigTab.js (core) Exposing custom widgets on the UI 2021-12-01 18:21:06 +01:00
ViewLayout.css (core) Show sigma next to summary table titles 2021-07-12 20:10:15 -07:00
ViewLayout.ts (core) Skip saving layout resizes in read-only mode 2021-12-06 07:37:45 -08:00
ViewLinker.css
ViewPane.ts (core) Update UI for formula and column label/id in the right-side panel. 2021-03-17 01:35:56 -04:00