gristlabs_grist-core/app
Alex Hall c470c4041b (core) Use visibleCol instead of displayCol with createFormatter
Summary:
Some things (like rendering cells) use the `visibleCol` for `createFormatter`, while other things (like `CopySelection`) used the `displayCol`. For references, the display column has type Any and doesn't know about the original formatting. This resulted in formatting being lost when copying from reference columns even though formatting was preserved when copying from the original (visible) column which looked identical. This diff fixes this and ensures that `createFormatter` is always used with the `visibleCol`. This was agreed on in https://grist.slack.com/archives/C0234CPPXPA/p1639571321043000

Additionally:

- Replaces the functions `createVisibleColFormatter` computed properties `visibleColFormatter` as suggested by a `TODO`.
- Extracts common code from `createVisibleColFormatter` in `ColumnRec` and `ViewFieldRec`

Test Plan: Fixed a test in CopyPaste which displayed the previous inconsistent behaviour.

Reviewers: jarek

Reviewed By: jarek

Differential Revision: https://phab.getgrist.com/D3189
2021-12-16 22:19:36 +02:00
..
client (core) Use visibleCol instead of displayCol with createFormatter 2021-12-16 22:19:36 +02:00
common (core) Adding Skip options when importing multiple tables. 2021-12-13 19:07:33 +01:00
gen-server (core) move more tests to grist-core 2021-12-10 18:33:07 -05:00
plugin (core) Parsing multiple values in reflists, parsing refs without table data in client 2021-11-09 14:41:04 +02:00
server (core) Adding Skip options when importing multiple tables. 2021-12-13 19:07:33 +01:00
tsconfig.json (core) move home server into core 2020-07-21 20:39:10 -04:00