mirror of
https://github.com/gristlabs/grist-core.git
synced 2024-09-29 07:20:48 +00:00
bd52665f96
Summary: When a widget `A` is selected by a widget `B` so that `A` is filtered, adding a new row to `A` uses the values in the selected row of `B` and the columns relevant to the linking as default values for the new row. This ensures that the new row matches the current linking filter and remains visible. However this would previously cause a sandbox error when one of the linking columns was a formula column, which doesn't allow setting values. This diff ignores formula columns when picking default values. Since the value of the formula column in the new row typically won't match the linking filter, extra measures are needed to avoid the new row immediately disappearing. Regular filters already have a mechanism for this, but I didn't manage to extend it to also work for linking. Thanks @dsagal for creating `UnionRowSource` (originally in D4017) which is now used as the solution for temporarily exempting rows from both kinds of filtering. While testing, I also came across another bug in linking summary tables that caused incorrect filtering, which I fixed with some changes to `DynamicQuerySet`. Test Plan: Extended an nbrowser test, which both tests for the main change as well as the secondary bugfix. Reviewers: georgegevoian Reviewed By: georgegevoian Subscribers: dsagal Differential Revision: https://phab.getgrist.com/D4135 |
||
|---|---|---|
| .. | ||
| entities | ||
| AppModel.ts | ||
| BaseRowModel.js | ||
| ClientColumnGetters.ts | ||
| ColumnACIndexes.ts | ||
| ColumnCache.ts | ||
| ColumnFilter.ts | ||
| ColumnFilterMenuModel.ts | ||
| ColumnToMap.ts | ||
| ConnectState.ts | ||
| DataRowModel.ts | ||
| DataTableModel.js | ||
| DataTableModelWithDiff.ts | ||
| DocData.ts | ||
| DocModel.ts | ||
| DocPageModel.ts | ||
| errors.ts | ||
| features.ts | ||
| gristConfigCache.ts | ||
| gristUrlState.ts | ||
| HomeModel.ts | ||
| MetaRowModel.js | ||
| MetaTableModel.js | ||
| modelUtil.js | ||
| NotifyModel.ts | ||
| QuerySet.ts | ||
| rowset.ts | ||
| rowuid.js | ||
| RuleOwner.ts | ||
| SearchModel.ts | ||
| SectionFilter.ts | ||
| Styles.ts | ||
| TableData.ts | ||
| TableModel.js | ||
| TelemetryModel.ts | ||
| TreeModel.ts | ||
| UnionRowSource.ts | ||
| UserManagerModel.ts | ||
| UserPrefs.ts | ||
| ViewFieldConfig.ts | ||
| VirtualTable.ts | ||
| WorkspaceInfo.ts | ||