Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity
bc54a6646e
gristlabs_grist-core/test/nbrowser
History
Alex Hall bc54a6646e (core) Filter rows based on linked widgets when exporting view 
Summary:
Fixes a problem reported here: https://community.getgrist.com/t/exporting-the-records-in-a-linked-view/2556/4

The download CSV/Excel link now contains an additional `linkingFilter` URL parameter containing JSON-encoded `filters` and `operations`. This object is originally created in the frontend in `LinkingState`, and previously it was only used internally in the frontend. It would make its way via `QuerySetManager` to `QuerySet.getFilterFunc` where the actual filtering logic happened. Now most of that logic has been moved to a similar function in `common`. The new function works with a new interface `ColumnGettersByColId` which abstract over the different ways data is accessed in the client and server in this context. There's no significant new logic in the diff, just refactoring and wiring.

Test Plan: Expanded two `nbrowser/SelectBy*.ts` test suites to also check the contents of a downloaded CSV in different linking scenarios.

Reviewers: paulfitz

Reviewed By: paulfitz

Differential Revision: https://phab.getgrist.com/D3961
2023-07-26 21:49:52 +02:00
..
aclTestUtils.ts (core) Preserving cursor position when linked state is removed. 2023-02-08 21:54:55 +01:00
ActionLog.ts Fixing flaky tests. 2022-12-09 20:15:08 +01:00
AttachmentsLinking.ts (core) Fix linking of new records when attachment is the first thing added. 2023-03-09 08:54:36 -05:00
CellColor.ts (core) Move CellColor tests to grist-core 2023-07-20 15:17:10 -04:00
ChoiceList.ts (core) Save choice config on focus loss 2023-05-08 14:16:10 -04:00
ClientUnitTests.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
CodeEditor.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
ColumnOps.ntest.js adapt tests after switch to parallel runs (#547) 2023-06-28 17:17:14 -04:00
customUtil.ts (core) Moving widget tests to core 2022-09-06 17:17:14 +02:00
CustomView.ts Fixing flaky tests. 2022-12-09 20:15:08 +01:00
CustomWidgets.ts Fixing flaky tests. 2022-12-09 20:15:08 +01:00
CustomWidgetsConfig.ts adapt tests after switch to parallel runs (#547) 2023-06-28 17:17:14 -04:00
Dates.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
DescriptionColumn.ts (core) Fix scrolling and column title bugs 2023-06-15 14:51:10 -04:00
DescriptionWidget.ts use gu.toggleSidePanel to open side panel (#523) 2023-05-24 16:29:14 -04:00
DetailView.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
DocTutorial.ts (core) Billing for formula assistant 2023-07-10 13:24:08 +02:00
DuplicateDocument.ts (core) tweak duplicate document test to be more reliable 2022-09-22 14:26:56 -04:00
Export.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
Features.ts Fix Features and DocTutorial tests (#520) 2023-05-23 14:34:48 -04:00
FieldConfigTab.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
FieldSettings.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
FillLinkedRecords.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
Fork.ts (core) Extending timeout in Fork tests 2023-04-19 22:19:37 +02:00
GridOptions.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
gristUtil-nbrowser.js adapt tests after switch to parallel runs (#547) 2023-06-28 17:17:14 -04:00
gristUtils.ts (core) Filter rows based on linked widgets when exporting view 2023-07-26 21:49:52 +02:00
gristWebDriverUtils.ts factor out low-dependency browser test code useful for grist-widget (#576) 2023-07-21 10:05:43 -04:00
Health.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
HomeIntro.ts (core) Adding tutorial card 2023-03-28 19:57:52 +02:00
homeUtil.ts (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
LanguageSettings.ts (core) Fix missing placeholder flag icon 2023-02-26 22:23:04 -05:00
LinkingSelector.ts (core) Fixing cursor position for filtered linked section. 2023-07-07 19:04:30 +02:00
Localization.ts skip building test harness in docker image (#551) 2023-06-30 05:50:40 -04:00
MultiColumn.ts (core) Fixing DELETE and BACKSPACE keys on ChoiceList and RefList editor. 2023-06-01 16:53:38 +02:00
NewDocument.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
Pages.ts (core) When a page starts with a number, don't treat it as an emoji 2023-07-12 15:13:25 -04:00
Properties.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
ReferenceColumns.ts (core) Preserving cursor position when linked state is removed. 2023-02-08 21:54:55 +01:00
ReferenceList.ts (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
RefTransforms.ts (core) Fix bug preventing changes to ref list table 2022-10-17 07:49:54 -07:00
RightPanel.ts (core) Floating formula editor 2023-06-02 17:59:22 +02:00
RightPanelSelectBy.ts avoid test files importing other test files (#550) 2023-06-29 03:15:14 -04:00
RowMenu.ts (core) Fix hidden columns bug when editing data selection 2022-10-18 08:36:11 -07:00
SavePosition.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
saveViewSection.ts (core) Adds a UI panel for managing webhooks 2023-05-08 18:25:27 -04:00
SelectBy.ts (core) Preserving cursor position when linked state is removed. 2023-02-08 21:54:55 +01:00
SelectByRefList.ts (core) Filter rows based on linked widgets when exporting view 2023-07-26 21:49:52 +02:00
SelectByRightPanel.ts (core) Preserving cursor position when linked state is removed. 2023-02-08 21:54:55 +01:00
SelectBySummary.ts (core) Filter rows based on linked widgets when exporting view 2023-07-26 21:49:52 +02:00
SelectBySummaryRef.ts avoid test files importing other test files (#550) 2023-06-29 03:15:14 -04:00
SelectionSummary.ts (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
Smoke.ts (core) Remove code for unused welcome flows 2022-02-28 13:21:28 -08:00
SortDates.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
SortEditSave.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
Summaries.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
SupportGrist.ts (core) Add Support Grist page and nudge 2023-07-04 17:36:59 -04:00
testServer.ts skip building test harness in docker image (#551) 2023-06-30 05:50:40 -04:00
testUtils.ts (core) Highlight rows used as a selector in linking, but do not show 'inactive' cursors. 2023-06-21 12:21:19 -04:00
TextEditor.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
ToggleColumns.ts (core) When a checkbox is clicked on a new record, set default values determined by linking 2022-11-10 14:34:40 -05:00
TokenField.ts (core) Fixing DELETE and BACKSPACE keys on ChoiceList and RefList editor. 2023-06-01 16:53:38 +02:00
TypeChange.ntest.js (core) export WindowDimensions from gristUtils after refactor 2023-07-24 15:10:51 -04:00
UndoJumps.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
Validations.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
ViewConfigTab.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
Views.ntest.js (core) Fixing cursor position for filtered linked section. 2023-07-07 19:04:30 +02:00
webdriverjq-nbrowser.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
webdriverjq.ntest.js (core) bump mocha version to allow parallel tests; move more tests to core 2023-06-27 02:55:34 -04:00
WebhookOverflow.ts (core) deleting queue from single webhook 2023-07-18 11:46:10 +02:00
WebhookPage.ts (core) deleting queue from single webhook 2023-07-18 11:46:10 +02:00