Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) export WindowDimensions from gristUtils after refactor

Browse Source 
Summary:
WindowDimensions from gristUtils needs exporting
after it got moved to another file.

Test Plan: existing tests should pass

Reviewers: georgegevoian

Reviewed By: georgegevoian

Subscribers: georgegevoian

Differential Revision: https://phab.getgrist.com/D3971
This commit is contained in:
Paul Fitzpatrick 2023-07-24 12:21:46 -04:00
parent 7256e0c245
commit 14b14f116e
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/nbrowser/TypeChange.ntest.js
View File

@ -116,6 +116,7 @@ describe('TypeChange.ntest', function() {
// Revise formula to get text length and accept
await $('.test-type-transform-revise').wait().click();
await $('.test-type-transform-formula').click();
await gu.waitAppFocus(false);
await gu.sendKeys($.SELECT_ALL, $.DELETE, 'return len($F) + 1');
// Check that updating the type conversion works
@ -126,6 +127,7 @@ describe('TypeChange.ntest', function() {
// Check that applying the type conversion without first updating works
// (the weird formula keeps other tests consistent with past behaviour)
await $('.test-type-transform-formula').click();
await gu.waitAppFocus(false);
await gu.sendKeys($.SELECT_ALL, $.DELETE, 'return len($F.replace("0", "0.0"))');
await gu.waitForServer();
await gu.applyTypeConversion();

5
test/nbrowser/gristUtils.ts
View File

@ -22,7 +22,8 @@ import { Organization } from 'app/gen-server/entity/Organization';
import { Product } from 'app/gen-server/entity/Product';
import { create } from 'app/server/lib/create';
import { GristWebDriverUtils, PageWidgetPickerOptions, WindowDimensions } from 'test/nbrowser/gristWebDriverUtils';
import { GristWebDriverUtils, PageWidgetPickerOptions,
WindowDimensions as WindowDimensionsBase } from 'test/nbrowser/gristWebDriverUtils';
import { HomeUtil } from 'test/nbrowser/homeUtil';
import { server } from 'test/nbrowser/testServer';
import { Cleanup } from 'test/nbrowser/testUtils';
@ -85,6 +86,8 @@ export const fixturesRoot: string = testUtils.fixturesRoot;
// it is sometimes useful in debugging to turn off automatic cleanup of docs and workspaces.
export const noCleanup = Boolean(process.env.NO_CLEANUP);
export type WindowDimensions = WindowDimensionsBase;
// Most test code uses simulateLogin through the server reference. Keep them to reduce unnecessary
// code changes.
server.simulateLogin = simulateLogin;