Dmitry S
2b581ab7dc
(core) Fix issue with lodash's map interpreting objects with length as array-like
...
Summary:
Here's a series of badness that easily leads to a crash, in reverse order:
- Lodash's map() function interprets an object with a .length property as an array.
- Some very old code generated human-friendly descriptions of user actions,
applying map() to parts of them. It so happens that this generated description
isn't even used.
- If a user action is encountered with a sufficiently large length propery,
map() would exhaust the server memory.
Fixed by removing old unneeded code, and replacing some other occurrences of
lodash's map() with native equivalents.
Test Plan: Tested manually on a local reproduction of the issue.
Reviewers: paulfitz
Reviewed By: paulfitz
Subscribers: paulfitz
Differential Revision: https://phab.getgrist.com/D3938
2023-07-01 21:07:39 -04:00
..
2023-06-30 16:57:35 -04:00
2023-01-18 10:55:44 -05:00
2023-01-18 10:55:44 -05:00
2022-11-15 09:52:32 -05:00
2020-07-21 20:39:10 -04:00
2022-05-04 13:46:55 -07:00
2020-07-21 20:39:10 -04:00
2023-05-08 18:25:27 -04:00
2022-02-19 09:46:49 +00:00
2023-05-08 14:15:22 -04:00
2023-05-08 18:25:27 -04:00
2021-02-15 17:02:24 -05:00
2020-07-21 20:39:10 -04:00
2023-05-08 14:15:22 -04:00
2021-09-16 10:06:04 -04:00
2020-07-21 20:39:10 -04:00
2022-05-09 21:44:57 +02:00
2022-12-22 09:10:30 -05:00
2023-05-08 18:25:27 -04:00
2020-07-21 20:39:10 -04:00
2020-07-21 20:39:10 -04:00
2023-02-20 15:32:58 -05:00
2022-02-19 09:46:49 +00:00
2021-08-26 13:36:49 -07:00
2022-08-23 19:20:10 +02:00
2023-01-18 10:18:15 +01:00
2021-11-03 15:31:39 +01:00
2023-05-08 18:25:27 -04:00
2021-05-03 17:16:24 -04:00
2022-01-13 11:10:17 +01:00
2022-02-21 22:39:47 +02:00
2020-07-21 20:39:10 -04:00
2020-07-21 20:39:10 -04:00
2023-07-01 21:07:39 -04:00
2023-05-08 18:25:27 -04:00
2023-05-08 18:25:27 -04:00
2022-08-03 08:13:33 -07:00
2022-05-16 11:16:19 -07:00
2022-05-09 21:44:57 +02:00
2021-09-16 10:06:04 -04:00
2022-08-03 08:13:33 -07:00
2020-07-21 20:39:10 -04:00
2020-07-21 20:39:10 -04:00
2021-02-15 17:02:24 -05:00
2022-07-26 11:33:23 -07:00
2022-12-20 09:58:42 +01:00
2020-07-21 20:39:10 -04:00
2023-01-12 09:40:45 +01:00
2022-11-15 09:52:32 -05:00
2021-07-01 18:38:21 +02:00
2022-10-17 13:38:21 +02:00
2023-06-07 12:00:51 -04:00
2023-03-15 14:54:28 +01:00
2023-05-19 13:06:15 -04:00
2022-06-27 16:10:10 -04:00
2022-08-25 12:38:36 -07:00
2022-09-02 10:59:59 -04:00
2020-11-10 08:12:31 -05:00
2022-06-06 16:19:41 -04:00
2021-09-24 15:10:13 +02:00
2023-02-03 18:56:24 -05:00
2023-04-12 01:58:48 -04:00
2023-05-23 15:17:28 -04:00
2020-07-21 20:39:10 -04:00
2022-10-17 09:51:19 +02:00
2022-03-03 21:32:03 +02:00
2023-06-07 12:00:51 -04:00
2022-07-04 10:42:40 -04:00
2020-07-21 20:39:10 -04:00
2022-02-19 09:46:49 +00:00
2023-06-02 17:59:22 +02:00
2022-08-23 19:20:10 +02:00
2020-11-06 09:24:56 -05:00
2023-05-24 11:39:49 -04:00
2022-05-26 15:01:35 -07:00
2023-01-16 16:50:42 -08:00
2021-05-27 15:48:12 +02:00
2023-05-15 11:56:15 -04:00
2022-12-14 01:23:49 -05:00
2020-07-21 20:39:10 -04:00
2023-01-31 12:14:22 +01:00
2021-11-03 15:31:39 +01:00
2022-05-27 14:32:05 +02:00
2023-05-08 18:25:27 -04:00
2020-07-21 20:39:10 -04:00
2022-03-12 14:34:46 -08:00
2021-04-26 18:54:55 -04:00
2023-06-15 00:15:18 -04:00
2020-07-21 20:39:10 -04:00
2023-07-01 21:07:39 -04:00
2023-06-30 16:57:35 -04:00
2022-09-05 19:17:32 -07:00
2020-07-21 20:39:10 -04:00
2021-04-26 18:54:55 -04:00
2023-05-08 18:25:27 -04:00
2023-05-08 18:25:27 -04:00
2022-10-12 16:02:01 -04:00
2020-07-21 20:39:10 -04:00
2021-09-24 09:01:10 -04:00
2021-10-01 10:47:12 +02:00
2020-09-29 18:57:56 -04:00
2023-06-13 20:40:59 -04:00
2021-07-20 15:17:03 +02:00
2023-06-07 22:30:01 +02:00
2023-05-02 10:28:14 -04:00
2022-05-19 12:49:51 -04:00
2023-05-02 10:28:14 -04:00
2023-03-16 17:37:24 -04:00