Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity
aa88c156e6
gristlabs_grist-core/app/client/components
History
Dmitry S 82eb5b3f76 (core) Fix bug causing cursor to jump to first row in a widget linked to a summary table. 
Summary:
When editing data in a table linked to its summary, if the edit results in an
update to the summary table, the cursor was jumping to the first row in the
linked table.

This is visible, for example, in the template
https://templates.getgrist.com/2i9WoHs2oRzK/Credit-Card-Activity-Template-AmEx/p/2
if editing "Amount" in the "ACTIVITY" widget (because that causes an update in
"ACTIVITY [by Category]").

The fix removes the offending line which seems unneeded: group-by columns in
summary tables don't change for an existing row, so there is no need to watch
the summary table for changes.

Test Plan: Adds a test case that fails without the fix, and passes with it.

Reviewers: jarek

Reviewed By: jarek

Subscribers: cyprien

Differential Revision: https://phab.getgrist.com/D3674
2022-10-21 16:10:19 -04:00
..
AceEditor.css (core) Show example values in formula autocomplete 2022-09-28 19:42:36 +02:00
AceEditor.js (core) Show example values in formula autocomplete 2022-09-28 19:42:36 +02:00
AceEditorCompletions.ts (core) Show example values in formula autocomplete 2022-09-28 19:42:36 +02:00
ActionLog.css (core) Add dark mode to user preferences 2022-09-05 19:17:32 -07:00
ActionLog.ts (core) Faster builds all around. 2022-07-04 10:42:40 -04:00
Banner.ts (core) Add product for new personal plan 2022-07-26 11:33:23 -07:00
Base.js (core) move client code to core 2020-10-02 13:24:21 -04:00
BaseView2.ts (core) Copy column type and options when pasting into an empty column 2022-04-04 14:53:16 +02:00
BaseView.js (core) Changing shortcuts for adding and removing rows 2022-10-21 18:45:25 +02:00
CellPosition.ts (core) Draft cells 2021-05-25 21:14:49 +02:00
CellSelector.ts (core) Add cell selection summary 2022-09-30 09:11:46 -07:00
ChartView.css (core) move client code to core 2020-10-02 13:24:21 -04:00
ChartView.ts (core) mark first field as label (rather than x-axis) for two more chart types 2022-10-12 16:01:33 -04:00
ClientScope.ts (core) move client code to core 2020-10-02 13:24:21 -04:00
Clipboard.css (core) move client code to core 2020-10-02 13:24:21 -04:00
Clipboard.js (core) Trim trailing whitespace when pasting plain text 2021-11-04 01:26:47 +02:00
CodeEditorPanel.css (core) Add dark mode to user preferences 2022-09-05 19:17:32 -07:00
CodeEditorPanel.ts (core) another bundle of dependabot suggestions 2022-09-12 14:20:09 -04:00
ColumnFilters.css (core) Context menu for cards. 2021-06-29 15:29:56 +02:00
ColumnTransform.ts (core) Adding font options to the style picker 2022-04-07 20:35:03 +02:00
Comm.ts (core) Fix issue with 'UNEXPECTED ORDER OF CALLBACKS' in Client.ts. 2022-06-16 23:51:14 -04:00
commandList.js (core) Changing shortcuts for adding and removing rows 2022-10-21 18:45:25 +02:00
commands.css (core) move client code to core 2020-10-02 13:24:21 -04:00
commands.js (core) Changing shortcuts for adding and removing rows 2022-10-21 18:45:25 +02:00
CopySelection.ts (core) Copy column type and options when pasting into an empty column 2022-04-04 14:53:16 +02:00
Cursor.ts (core) Faster builds all around. 2022-07-04 10:42:40 -04:00
CursorMonitor.ts (core) Raw renames 2022-04-27 22:21:55 +02:00
CustomView.css (core) Fix CustomView css to take full height of widget on all browsers including Safari 2020-10-06 13:18:50 -04:00
CustomView.ts (core) Faster builds all around. 2022-07-04 10:42:40 -04:00
DataTables.ts (core) Allow duplicating tables from Raw Data page 2022-09-29 08:59:42 -07:00
DeprecatedCommands.ts (core) Changing shortcuts for adding and removing rows 2022-10-21 18:45:25 +02:00
DetailView.css (core) Add dark mode to user preferences 2022-09-05 19:17:32 -07:00
DetailView.js (core) Changing shortcuts for adding and removing rows 2022-10-21 18:45:25 +02:00
DocComm.ts (core) add an access token mechanism to help with attachments in custom widgets 2022-07-19 11:55:18 -04:00
DocConfigTab.js (core) move client code to core 2020-10-02 13:24:21 -04:00
DocumentUsage.ts (core) Add info and hover tooltips 2022-10-20 15:17:44 -07:00
Drafts.ts (core) Add dark mode to user preferences 2022-09-05 19:17:32 -07:00
duplicatePage.ts (core) Speed up and upgrade build. 2022-06-27 16:10:10 -04:00
EditorMonitor.ts (core) Raw renames 2022-04-27 22:21:55 +02:00
EmbedForm.css (core) move client code to core 2020-10-02 13:24:21 -04:00
FieldConfigTab.css (core) move client code to core 2020-10-02 13:24:21 -04:00
FormulaTransform.ts (core) Add dark mode to user preferences 2022-09-05 19:17:32 -07:00
GridView.css (core) Fix CSS errors related to dark mode 2022-10-05 00:05:57 -07:00
GridView.js (core) Changing shortcuts for adding and removing rows 2022-10-21 18:45:25 +02:00
GristDoc.css (core) move client code to core 2020-10-02 13:24:21 -04:00
GristDoc.ts (core) Changing shortcuts for adding and removing rows 2022-10-21 18:45:25 +02:00
GristWSConnection.ts (core) Fix issue with 'UNEXPECTED ORDER OF CALLBACKS' in Client.ts. 2022-06-16 23:51:14 -04:00
Importer.ts (core) Add dark mode to user preferences 2022-09-05 19:17:32 -07:00
Layout.css (core) Collapse inactive view sections on mobile screens. 2021-02-09 09:17:32 -05:00
Layout.js (core) Fixing bug with undoing page delation with a custom layout 2021-12-20 19:32:14 +01:00
LayoutEditor.css (core) move client code to core 2020-10-02 13:24:21 -04:00
LayoutEditor.js (core) move client code to core 2020-10-02 13:24:21 -04:00
LayoutPreview.css (core) move client code to core 2020-10-02 13:24:21 -04:00
LayoutPreview.js (core) move client code to core 2020-10-02 13:24:21 -04:00
LinkingState.ts (core) Fix bug causing cursor to jump to first row in a widget linked to a summary table. 2022-10-21 16:10:19 -04:00
Login.css (core) move client code to core 2020-10-02 13:24:21 -04:00
modals.ts (core) Changing shortcuts for adding and removing rows 2022-10-21 18:45:25 +02:00
ParseOptions.ts (core) Add dark mode to user preferences 2022-09-05 19:17:32 -07:00
PluginScreen.ts (core) Show proper message on empty Excel import, rather than a code error 2022-04-27 00:49:28 -04:00
Preferences.css (core) Add dark mode to user preferences 2022-09-05 19:17:32 -07:00
Printing.css (core) Improve printing of tables, fix printing of charts, add a browser test. 2020-10-12 16:04:18 -04:00
Printing.ts (core) Faster builds all around. 2022-07-04 10:42:40 -04:00
RawDataPage.ts (core) Add cell selection summary 2022-09-30 09:11:46 -07:00
RecordLayout.css (core) Add dark mode to user preferences 2022-09-05 19:17:32 -07:00
RecordLayout.js (core) Showing a raw data section on a popup 2022-08-25 09:30:07 +02:00
RecordLayoutEditor.js (core) move client code to core 2020-10-02 13:24:21 -04:00
RefSelect.ts (core) Reference columns weren't added to Raw Data Views 2022-07-07 17:07:13 +02:00
SearchBar.css (core) move client code to core 2020-10-02 13:24:21 -04:00
SelectionSummary.ts (core) Fix scrolling in Raw Data page, and tweak background of selection-summary in Raw Data tables to look better 2022-10-05 15:02:11 -04:00
TypeConversion.ts (core) Fix bug preventing changes to ref list table 2022-10-17 07:49:54 -07:00
TypeTransform.ts (core) Add dark mode to user preferences 2022-09-05 19:17:32 -07:00
UndoStack.ts (core) Change UndoStack._linkMap to store an array of action groups for each linkId 2022-01-20 19:00:01 +02:00
UnsavedChanges.ts (core) support ?embed=true and &style=light for a clean embed experience 2020-08-14 13:34:38 -04:00
ValidationPanel.css (core) move client code to core 2020-10-02 13:24:21 -04:00
ValidationPanel.js (core) move client code to core 2020-10-02 13:24:21 -04:00
viewCommon.css (core) Switching the order that colors are applied to a cell 2022-10-13 15:13:57 +02:00
viewCommon.js (core) Skip saving column resizes in read-only mode 2021-12-07 14:37:25 -08:00
ViewConfigTab.css (core) move client code to core 2020-10-02 13:24:21 -04:00
ViewConfigTab.js (core) Add dark mode to user preferences 2022-09-05 19:17:32 -07:00
ViewLayout.css (core) Fix CSS errors related to dark mode 2022-10-05 00:05:57 -07:00
ViewLayout.ts (core) Add cell selection summary 2022-09-30 09:11:46 -07:00
ViewLinker.css (core) move client code to core 2020-10-02 13:24:21 -04:00
ViewPane.ts (core) Implementing row conditional formatting 2022-08-09 20:11:36 +02:00
WidgetFrame.ts (core) add an access token mechanism to help with attachments in custom widgets 2022-07-19 11:55:18 -04:00