Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-09-29 09:20:47 +00:00
Code Issues Projects Releases Wiki Activity
a1c62f32f4
gristlabs_grist-core/test/fixtures/docs
History
Alex Hall a1c62f32f4 (core) Fix selecting new row in chain of filter links 
Summary:
When the 'new' row of a table is selected, another table filter linked to the first shows no data. This diff ensures that a third table filtered by the second also shows no data, i.e. that it behaves the same as if the second table was also on the 'new' row. Video of the bug: https://grist.slack.com/archives/C069RUP71/p1692622810900179

The functional code is copied almost verbatim from https://github.com/gristlabs/grist-core/pull/666 by @jvorob which was working correctly. A comment there mentioned a possible bug where:

> ...you can have the grayed-out "No row selected" text from disableEditing but still have rows showing up in the section. Haven't been able to reproduce...

I noticed this behaviour when I copied only part of the fix, but it disappeared after copying the whole thing, so it seems likely to me that this is why it couldn't be reproduced.

Test Plan: Added a new nbrowser test with a new fixture, which also tests filter link chains and selecting the new row more generally, since I couldn't find other tests of this.

Reviewers: georgegevoian

Reviewed By: georgegevoian

Subscribers: jvorob

Differential Revision: https://phab.getgrist.com/D4126
2023-12-05 16:56:13 +02:00
..
video (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
ACL-Test.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
ActiveDoc-sqlite.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
AllColumns.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
ApiDataRecordsTest.grist (core) disentangle some server tests, release to core, add GRIST_PROXY_AUTH_HEADER test 2022-03-24 15:11:32 -04:00
AttachmentsJsonMigration.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
BlobMigrationV1.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
BlobMigrationV2.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
BlobMigrationV3.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
BlobMigrationV4.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
BlobMigrationV5.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
BlobMigrationV6.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
BlobMigrationV7.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
BlobMigrationV8.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
BlobMigrationV16.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
BlobMigrationV17.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
CardView.grist (core) Fix hidden columns bug when editing data selection 2022-10-18 08:36:11 -07:00
CC_Statement.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
CC_Summaries-v2.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
CC_Summaries-v6.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
CC_Summaries.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
CCTransactions.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
ChartData.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
Class Enrollment.grist (core) Highlight rows used as a selector in linking, but do not show 'inactive' cursors. 2023-06-21 12:21:19 -04:00
CopyOptions.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
CopyPaste2.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
CopyPaste.grist (core) Adds a UI panel for managing webhooks 2023-05-08 18:25:27 -04:00
Countries-Print.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
Covid-19.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
Currencies.grist (core) Currency from grist column is persistent when exporting to excel 2023-05-08 10:39:01 +02:00
CustomWidget.grist (core) Moving widget tests to core 2022-09-06 17:17:14 +02:00
DefaultValuesV5.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
DefaultValuesV6.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
DefaultValuesV7.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
DefaultValuesV8.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
DeleteColumnsUndo.grist (core) Fix error in sandbox when removing multiple summary source columns 2023-09-27 16:23:49 +02:00
doctour.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
DocTutorial.grist (core) Add initial tutorials implementation 2023-03-22 10:09:02 -04:00
DownmigrateTest.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
Excel.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
Exports.grist (core) Fix imports into reference columns, and support two ways to import Numeric as a reference. 2023-05-02 10:28:14 -04:00
Favorite_Films_Raw.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
Favorite_Films_With_Linked_Ref.grist Add test 2023-02-02 09:54:36 +01:00
Favorite_Films.grist (core) disentangle some server tests, release to core, add GRIST_PROXY_AUTH_HEADER test 2022-03-24 15:11:32 -04:00
FetchSelectedOptions.grist (core) Options for plugin API functions which fetch data from the selected table or record 2023-10-26 23:46:00 +02:00
FieldSettings.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
FilmsWithImages.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
FilterByComplexCellValues.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
FilterLinkChain.grist (core) Fix selecting new row in chain of filter links 2023-12-05 16:56:13 +02:00
FilterTest.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
GristNewUserInfo.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
Hello.grist (core) Record Cards 2023-11-19 20:12:37 -05:00
Hooks-v37.grist (core) Adds a UI panel for managing webhooks 2023-05-08 18:25:27 -04:00
ImportReferences.grist (core) Fix imports into reference columns, and support two ways to import Numeric as a reference. 2023-05-02 10:28:14 -04:00
InvalidValues.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
Investment Research.grist (core) move more tests to grist-core 2021-12-10 18:33:07 -05:00
Landlord.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
LastPosition.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
LinkChain.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
LongList.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
Memos-v34.grist (core) Add new UI for writing memos 2022-12-12 17:52:01 -05:00
NumericFormatting.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
Pages-v19.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
Pages.grist Adding tests for left panel 2022-08-03 16:15:45 +02:00
PasteParsing.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
RawSummaryTables.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
Ref-AC-Test.grist Moving 3 ACinput tests to grist core 2022-08-10 13:10:50 +02:00
Ref-List-AC-Test.grist Moving 3 ACinput tests to grist core 2022-08-10 13:10:50 +02:00
RemoveTransformColumns.grist (core) Remove transform columns on shutdown 2023-11-14 22:31:34 +02:00
SchoolsSample.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
selectBy.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
SelectByRefList.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
SelectBySummary.grist allow Grist front-end to function when location history is unavailable (#596) 2023-07-27 07:02:17 -04:00
SelectBySummaryRef.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
SelectionSummary.grist (core) Add cell selection summary 2022-09-30 09:11:46 -07:00
ShiftSelection.grist Support grid selection with Ctrl+Shift+Arrow (#615) 2023-08-14 09:28:41 -07:00
SortDates.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
SortFilterIconTest.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
SummarizeByRef.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
SummaryRulesBug.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
SummaryTableFormula.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
TabBar.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
Teams.grist (core) Fixing scrolling for linked sections 2022-11-09 20:39:26 +01:00
TypeConversions.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
TypeEncoding.grist (core) Moving widget tests to core 2022-09-06 17:17:14 +02:00
Widgets.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
World-v0.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
World-v1.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
World-v3.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
World-v8.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
World-v10.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
World-v11.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
World-v12.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
World-v13.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
World-v14.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
World-v15.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
World-v18.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
World-v20.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
World-v24.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
World-v25.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
World-v33.grist (core) Update sort and filter UI 2022-11-17 15:33:45 -05:00
World-v39.grist (core) Record Cards 2023-11-19 20:12:37 -05:00
World.grist (core) move more tests to grist-core 2021-12-10 18:33:07 -05:00
WorldSQLDB.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00
WorldUndo.grist (core) Moving nbrowser tests to grist-core 2022-10-25 17:22:54 +02:00