mirror of
https://github.com/gristlabs/grist-core.git
synced 2024-10-27 20:44:07 +00:00
a1c62f32f4
Summary: When the 'new' row of a table is selected, another table filter linked to the first shows no data. This diff ensures that a third table filtered by the second also shows no data, i.e. that it behaves the same as if the second table was also on the 'new' row. Video of the bug: https://grist.slack.com/archives/C069RUP71/p1692622810900179 The functional code is copied almost verbatim from https://github.com/gristlabs/grist-core/pull/666 by @jvorob which was working correctly. A comment there mentioned a possible bug where: > ...you can have the grayed-out "No row selected" text from disableEditing but still have rows showing up in the section. Haven't been able to reproduce... I noticed this behaviour when I copied only part of the fix, but it disappeared after copying the whole thing, so it seems likely to me that this is why it couldn't be reproduced. Test Plan: Added a new nbrowser test with a new fixture, which also tests filter link chains and selecting the new row more generally, since I couldn't find other tests of this. Reviewers: georgegevoian Reviewed By: georgegevoian Subscribers: jvorob Differential Revision: https://phab.getgrist.com/D4126 |
||
|---|---|---|
| .. | ||
| client | ||
| client-harness | ||
| common | ||
| deployment | ||
| fixtures | ||
| formula-dataset | ||
| gen-server | ||
| nbrowser | ||
| server | ||
| timings | ||
| .eslintrc.js | ||
| chai-as-promised.js | ||
| declarations.d.ts | ||
| init-mocha-webdriver.js | ||
| report-why-tests-hang.js | ||
| setupPaths.js | ||
| split-tests.js | ||
| test_under_docker.sh | ||
| testUtils.ts | ||
| tsconfig.json | ||
| upgradeDocument | ||
| upgradeDocumentImpl.ts | ||
| utils.js | ||
| xunit-file.js | ||