Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity
a19f19b503
gristlabs_grist-core/app/common
History
Dmitry S a19f19b503 (core) Changes to Billing to better handle error scenarios. 
Summary:
- Bad status of a subscription is now reported, along with the last payment error, if any.
- Error caused when getting valueRemaining of a subscription in a bad state is now ignored.
- Certain kinds of errors from Stripe are now reported to the user in a
  friendlier way (avoiding statusCode of 500 when there is a better one)
- A wide range of Stripe errors are logged with metadata.
- Show a link to the Stripe-hosted last invoice, which seems useful generally,
  and also gives the user more options to pay after a payment failure.
- Get default_source along with customer to save a roundtrip to Stripe.
- Use a simpler (single) Stripe call for updating a customer’s card.
- Retry paying an invoice when updating a card when there is an unpaid invoice
  with a payment error.

Some refactoring included:
- Simplified ISubscriptionModel by extending IBillingSubscription.
- Factor out common portions from several Billing tests.

Add a test case for how some card errors are reported
Add bits to the new billing test, still WIP.

Test Plan:
Added a test suite for incomplete and past_due subscriptions, and a
test case one for better error reporting.

Reviewers: paulfitz

Reviewed By: paulfitz

Differential Revision: https://phab.getgrist.com/D2553
2020-07-22 14:40:54 -04:00
..
ActionBundle.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
ActionDispatcher.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
ActionGroup.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
ActionRouter.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
ActionSummary.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
ActiveDocAPI.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
ApiError.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
arrayToString.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
AsyncCreate.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
AsyncFlow.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
BaseAPI.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
BasketClientAPI.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
BigInt.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
BillingAPI.ts (core) Changes to Billing to better handle error scenarios. 2020-07-22 14:40:54 -04:00
BinaryIndexedTree.js (core) move home server into core 2020-07-21 20:39:10 -04:00
BrowserSettings.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
ColumnGetters.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
declarations.d.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
delay.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
DisposableWithEvents.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
DocActions.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
DocData.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
DocListAPI.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
emails.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
EncActionBundle.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
ErrorWithCode.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
Features.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
Formula.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
GristServerAPI.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
gristTypes.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
gristUrls.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
gutil.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
InactivityTimer.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
KeyedOps.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
LoginSessionAPI.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
LoginState.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
marshal.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
MemBuffer.js (core) move home server into core 2020-07-21 20:39:10 -04:00
MetricCollector.js (core) move home server into core 2020-07-21 20:39:10 -04:00
metricConfig.js (core) move home server into core 2020-07-21 20:39:10 -04:00
metricTools.js (core) move home server into core 2020-07-21 20:39:10 -04:00
NumberFormat.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
orgNameUtils.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
parseDate.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
plugin.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
PluginInstance.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
RefCountMap.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
resetOrg.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
roles.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
schema.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
sharing.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
SortFunc.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
StringUnion.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
TableData.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
TabularDiff.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
tbind.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
TestState.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
timeFormat.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
tpromisified.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
tsconfig.json (core) move home server into core 2020-07-21 20:39:10 -04:00
tsvFormat.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
uploads.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
urlUtils.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
UserAPI.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
UserConfig.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
ValueFormatter.ts (core) move home server into core 2020-07-21 20:39:10 -04:00
version.ts (core) move home server into core 2020-07-21 20:39:10 -04:00