mirror of
https://github.com/gristlabs/grist-core.git
synced 2026-03-02 04:09:24 +00:00
a19f19b503
Summary: - Bad status of a subscription is now reported, along with the last payment error, if any. - Error caused when getting valueRemaining of a subscription in a bad state is now ignored. - Certain kinds of errors from Stripe are now reported to the user in a friendlier way (avoiding statusCode of 500 when there is a better one) - A wide range of Stripe errors are logged with metadata. - Show a link to the Stripe-hosted last invoice, which seems useful generally, and also gives the user more options to pay after a payment failure. - Get default_source along with customer to save a roundtrip to Stripe. - Use a simpler (single) Stripe call for updating a customer’s card. - Retry paying an invoice when updating a card when there is an unpaid invoice with a payment error. Some refactoring included: - Simplified ISubscriptionModel by extending IBillingSubscription. - Factor out common portions from several Billing tests. Add a test case for how some card errors are reported Add bits to the new billing test, still WIP. Test Plan: Added a test suite for incomplete and past_due subscriptions, and a test case one for better error reporting. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2553