gristlabs_grist-core/app/client
Cyprien P 710014ce54 (core) Animate side panels
Summary:
Diff makes side panels slide horizontally when opening/closing them.

Caveats:
 . Right panel: even though the panel do transition nicely, the content however disappears suddently. We could prevent disposal of the dom by removing the two below lines. But it's hard to tell what possible side effect we could get from it as I don't know why these line were added in the first place. I could investigate further, but maybe it's already good enough as it is.
 ```
   private _buildContentDom() {
    return dom.domComputed((use) => {
      // if (!use(this._isOpen)) { return null; } // remove line
      const tool = use(this._extraTool);
```
```
  private _buildHeaderDom() {
    return dom.domComputed((use) => {
      // if (!use(this._isOpen)) { return null; } // remove line
      const tool = use(this._extraTool);
      return tool ? this._buildToolHeader(tool) : this._buildStandardHeader();
```

Test Plan: Tested manually on desktop environnment with  FF and chrome by shrinking the window.

Reviewers: paulfitz

Reviewed By: paulfitz

Differential Revision: https://phab.getgrist.com/D2710
2021-01-25 15:01:39 +01:00
..
aclui (core) Add a Users dropdown to AccessRules page. 2021-01-22 09:20:40 -05:00
components (core) Add getAclResources method for making all tables/columns available when editing ACL rules 2021-01-14 13:43:55 -05:00
lib (core) Add viewport meta tag conditionally, and show a toggle for it on small devices. 2021-01-21 14:54:02 -05:00
models (core) Show a clearer message when actions are blocked by ACL rules 2021-01-22 10:21:36 -05:00
ui (core) Animate side panels 2021-01-25 15:01:39 +01:00
ui2018 (core) Add viewport meta tag conditionally, and show a toggle for it on small devices. 2021-01-21 14:54:02 -05:00
widgets (core) Convert a few widgets to typescript and grainjs. 2020-11-23 09:49:55 -05:00
app.css (core) Cleanup removing some old unused files, fixing logo.css, and removing #grist-app. 2020-10-09 17:04:09 -04:00
app.js (core) Cleanup removing some old unused files, fixing logo.css, and removing #grist-app. 2020-10-09 17:04:09 -04:00
declarations.d.ts (core) Some cleanup: remove old unused modules. 2020-11-20 11:23:20 -05:00
exposeModulesForTests.js (core) Some cleanup: remove old unused modules. 2020-11-20 11:23:20 -05:00
logo.css (core) Cleanup removing some old unused files, fixing logo.css, and removing #grist-app. 2020-10-09 17:04:09 -04:00
tsconfig.json freshen app/client/ui2018/cssVars.ts 2020-06-23 16:16:38 -04:00