gristlabs_grist-core/app
Cyprien P 710014ce54 (core) Animate side panels
Summary:
Diff makes side panels slide horizontally when opening/closing them.

Caveats:
 . Right panel: even though the panel do transition nicely, the content however disappears suddently. We could prevent disposal of the dom by removing the two below lines. But it's hard to tell what possible side effect we could get from it as I don't know why these line were added in the first place. I could investigate further, but maybe it's already good enough as it is.
 ```
   private _buildContentDom() {
    return dom.domComputed((use) => {
      // if (!use(this._isOpen)) { return null; } // remove line
      const tool = use(this._extraTool);
```
```
  private _buildHeaderDom() {
    return dom.domComputed((use) => {
      // if (!use(this._isOpen)) { return null; } // remove line
      const tool = use(this._extraTool);
      return tool ? this._buildToolHeader(tool) : this._buildStandardHeader();
```

Test Plan: Tested manually on desktop environnment with  FF and chrome by shrinking the window.

Reviewers: paulfitz

Reviewed By: paulfitz

Differential Revision: https://phab.getgrist.com/D2710
2021-01-25 15:01:39 +01:00
..
client (core) Animate side panels 2021-01-25 15:01:39 +01:00
common (core) Add a Users dropdown to AccessRules page. 2021-01-22 09:20:40 -05:00
gen-server (core) allow a doc owner to test access as a different user 2021-01-15 18:45:57 -05:00
plugin (core) hide long sequences of unchanged rows in diffs 2020-11-19 18:19:54 -05:00
server (core) Show a clearer message when actions are blocked by ACL rules 2021-01-22 10:21:36 -05:00
tsconfig.json (core) move home server into core 2020-07-21 20:39:10 -04:00