mirror of
https://github.com/gristlabs/grist-core.git
synced 2024-10-27 20:44:07 +00:00
3513c1e8d2
Summary: Previously, a change was made to include the opening parenthesis into the "identifier regex", so that backend received the function call name for cases like 'T.lookupOne(B' (to autocomplete columns of table T that start with "B"). Unfortunately, that interferes with common cases like 'SUM($B', since instead of sending '$B', it is now including the function name. To properly fix the common case, we need to exclude the function name from the call, but for lookups we need to include it. ACE's methods aren't flexible enough to override this logic cleanly, so some monkey-patching was needed. Test Plan: Added a test case Reviewers: georgegevoian Reviewed By: georgegevoian Differential Revision: https://phab.getgrist.com/D3874 |
||
|---|---|---|
| .. | ||
| AceEditor.css | ||
| AceEditor.js | ||
| AceEditorCompletions.ts | ||
| ActionLog.css | ||
| ActionLog.ts | ||
| Banner.ts | ||
| Base.js | ||
| BaseView2.ts | ||
| BaseView.js | ||
| BehavioralPromptsManager.ts | ||
| buildViewSectionDom.ts | ||
| CellPosition.ts | ||
| CellSelector.ts | ||
| ChartView.css | ||
| ChartView.ts | ||
| ClientScope.ts | ||
| Clipboard.css | ||
| Clipboard.js | ||
| CodeEditorPanel.css | ||
| CodeEditorPanel.ts | ||
| ColumnFilters.css | ||
| ColumnTransform.ts | ||
| Comm.ts | ||
| commandList.ts | ||
| commands.css | ||
| commands.ts | ||
| CopySelection.ts | ||
| Cursor.ts | ||
| CursorMonitor.ts | ||
| CustomView.css | ||
| CustomView.ts | ||
| DataTables.ts | ||
| DetailView.css | ||
| DetailView.js | ||
| DocComm.ts | ||
| DocConfigTab.js | ||
| DocumentUsage.ts | ||
| Drafts.ts | ||
| duplicatePage.ts | ||
| EditorMonitor.ts | ||
| EmbedForm.css | ||
| FieldConfigTab.css | ||
| FormulaTransform.ts | ||
| GridView.css | ||
| GridView.js | ||
| GristDoc.css | ||
| GristDoc.ts | ||
| GristWSConnection.ts | ||
| Importer.ts | ||
| Layout.css | ||
| Layout.ts | ||
| LayoutEditor.css | ||
| LayoutEditor.ts | ||
| LayoutTray.ts | ||
| LinkingState.ts | ||
| Login.css | ||
| modals.ts | ||
| ParseOptions.ts | ||
| PluginScreen.ts | ||
| Preferences.css | ||
| Printing.css | ||
| Printing.ts | ||
| RawDataPage.ts | ||
| RecordLayout.css | ||
| RecordLayout.js | ||
| RecordLayoutEditor.js | ||
| RefSelect.ts | ||
| SearchBar.css | ||
| SelectionSummary.ts | ||
| TypeConversion.ts | ||
| TypeTransform.ts | ||
| UndoStack.ts | ||
| UnsavedChanges.ts | ||
| ValidationPanel.css | ||
| ValidationPanel.js | ||
| ViewAsBanner.ts | ||
| viewCommon.css | ||
| viewCommon.js | ||
| ViewConfigTab.css | ||
| ViewConfigTab.js | ||
| ViewLayout.css | ||
| ViewLayout.ts | ||
| ViewLinker.css | ||
| ViewPane.ts | ||
| WidgetFrame.ts | ||