mirror of
https://github.com/gristlabs/grist-core.git
synced 2024-09-28 19:00:45 +00:00
4b258ae0fa
Summary: When adding a summary table widget to a page and using 'select by' in the add widget config (as opposed to in the right panel for an existing widget): 1. If an equivalent summary table already exists, use its referencing columns (if any) to construct link nodes. Previously the source table columns were being used instead, which could include referencing columns that don't have any equivalent in the summary table, and exclude referencing columns in the summary table. 2. If no such summary table exists yet, then keep using the source table columns, but only the selected groupby columns, and 3. After the summary table is created, correct the `linkTargetColRef` (which points to a source table column) to the corresponding column from the new summary table instead. This fixes bugs which only appeared recently since 'select by' for a summary table previously involved no target columns. Test Plan: Added two new tests to `nbrowser/SelectBySummaryRef`, and confirmed that they fail without the fixes to all three points above. Reviewers: dsagal Reviewed By: dsagal Subscribers: dsagal Differential Revision: https://phab.getgrist.com/D3527 |
||
|---|---|---|
| .. | ||
| aclui | ||
| components | ||
| lib | ||
| models | ||
| ui | ||
| ui2018 | ||
| widgets | ||
| accountMain.ts | ||
| app.css | ||
| app.js | ||
| browserCheck.ts | ||
| declarations.d.ts | ||
| errorMain.ts | ||
| exposeModulesForTests.js | ||
| logo.css | ||
| tsconfig.json | ||