gristlabs_grist-core/app
Alex Hall 4b258ae0fa (core) Fix 'select by' when adding summary table widget to page
Summary:
When adding a summary table widget to a page and using 'select by' in the add widget config (as opposed to in the right panel for an existing widget):

1. If an equivalent summary table already exists, use its referencing columns (if any) to construct link nodes. Previously the source table columns were being used instead, which could include referencing columns that don't have any equivalent in the summary table, and exclude referencing columns in the summary table.
2. If no such summary table exists yet, then keep using the source table columns, but only the selected groupby columns, and
3. After the summary table is created, correct the `linkTargetColRef` (which points to a source table column) to the corresponding column from the new summary table instead.

This fixes bugs which only appeared recently since 'select by' for a summary table previously involved no target columns.

Test Plan: Added two new tests to `nbrowser/SelectBySummaryRef`, and confirmed that they fail without the fixes to all three points above.

Reviewers: dsagal

Reviewed By: dsagal

Subscribers: dsagal

Differential Revision: https://phab.getgrist.com/D3527
2022-07-19 16:28:38 +02:00
..
client (core) Fix 'select by' when adding summary table widget to page 2022-07-19 16:28:38 +02:00
common (core) Use table title instead of ID in ACL UI 2022-07-19 16:27:17 +02:00
gen-server (core) add a yarn run cli tool, and add a sqlite gristify option 2022-07-14 12:00:30 -04:00
plugin (core) Speed up and upgrade build. 2022-06-27 16:10:10 -04:00
server (core) Use table title instead of ID in ACL UI 2022-07-19 16:27:17 +02:00
tsconfig.json (core) move home server into core 2020-07-21 20:39:10 -04:00