gristlabs_grist-core

Commit Graph

Author	SHA1	Message	Date
Alex Hall	ba16d50080	(core) Upgrade to latest versions of asttokens and wrapt Summary: Upgrades asttokens mainly because I suspected it would have helped with an error in a user's document (see https://grist.slack.com/archives/C0234CPPXPA/p1686145370484509) but we were unable to confirm that. Also adds a related test that I (wrongly) expected to have a similar problem before upgrading asttokens. Upgrades wrapt for Python 3.11 support. Closes https://github.com/gristlabs/grist-core/issues/534. Not upgrading the dependencies for Python 2 because pip is giving me errors when I try to install to the `thirdparty` folder. Both these upgrades are motivated by issues specific to Python 3 so this doesn't seem worth pursuing immediately. Test Plan: Existing tests. Reviewers: paulfitz Reviewed By: paulfitz Subscribers: paulfitz Differential Revision: https://phab.getgrist.com/D3973	1 year ago
Dmitry S	b4cc519616	(core) Ignore leading whitespace in formulas, and strip out leading '=' sign users might add Summary: This addresses two issues, differently: - For a formula with leading whitespace, like " 1+1", it is stored as is, but is fixed to work (it should be valid Python, and whitespace is only stripped out at parsing time to avoid intentation errors caused by the way it gets parsed) - For a formula with a leading equals-sign ("="), it is stripped out on the client side before the formula is stored. Grist documentation uses leading "=" to indicate formulas (because UI shows an "=" icon), and Excel formulas actually contain the leading "=", so it is a common mistake to include it. Test Plan: Added new test cases Reviewers: jarek Reviewed By: jarek Differential Revision: https://phab.getgrist.com/D3873	1 year ago
Alex Hall	49cb51bac5	(core) Error explanations from friendly-traceback Summary: Extend formula error messages with explanations from https://github.com/friendly-traceback/friendly-traceback. Only for Python 3. Test Plan: Updated several Python tests. In general, these require separate branches for Python 2 and 3. Reviewers: georgegevoian Reviewed By: georgegevoian Differential Revision: https://phab.getgrist.com/D3542	2 years ago
Alex Hall	fb575a8b7e	(core) Ensure formulas return something and don't assign to attributes of rec Summary: To help with mistakes in formulas, forbid assigning to attributes of `rec` (e.g. `$foo = 1` which should probably be `==`) and ensure that there is at least one `return` in the formula (after maybe adding an implicit one at the end). Test Plan: Extended Python unit test, updated tests which were missing return. Reviewers: georgegevoian Reviewed By: georgegevoian Subscribers: dsagal Differential Revision: https://phab.getgrist.com/D3439	2 years ago
Alex Hall	52fd28815e	(core) Raise syntax errors that Python can format nicely to show the location Summary: Update _create_syntax_error_code to raise an error with similar arguments to the real arguments it already has, with our modifications. Test Plan: Updated python unit tests Reviewers: jarek, dsagal Reviewed By: dsagal Subscribers: dsagal Differential Revision: https://phab.getgrist.com/D3040	3 years ago
Alex Hall	305b133c59	(core) Remaining Python 3 compatibility changes Summary: Biggest change is turning everything to unicode Test Plan: The tests Reviewers: dsagal, paulfitz Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2875	3 years ago
Alex Hall	16f297a250	(core) Simple Python 3 compatibility changes Summary: Changes that move towards python 3 compatibility that are easy to review without much thought Test Plan: The tests Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2873	3 years ago
Paul Fitzpatrick	b82eec714a	(core) move data engine code to core Summary: this moves sandbox/grist to core, and adds a requirements.txt file for reconstructing the content of sandbox/thirdparty. Test Plan: existing tests pass. Tested core functionality manually. Tested docker build manually. Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2563	4 years ago

8 Commits (fe12562ad7043606bc139ae98b2f0462168681ce)