6 Commits (95592b81bd269bf206a4062cd66b39ac8c254164)

Author	SHA1	Message	Date
Cyprien P	89dc9334c3	(core) Fix error bars for bar chart ... Summary: The culprit was `series = uniqXValues(series);` because it creates new series objects when they are used as keys to access error bars info (`errorBars.get(line)`). Fixed by making uniqXValues mutating series instead. Test Plan: Adds a case to test error bars with bar charts. Reviewers: jarek Reviewed By: jarek Differential Revision: https://phab.getgrist.com/D3198	3 years ago
Cyprien P	0b437d1544	(core) Brings in the new donut charts. ... Summary: - Donut charts is same as pie chart with few extra options to control size of the hole and to show/hide a big total in it. - Add a new option type to tune a numeric options using a slider/spinner/keyboard. - Add a new option type to tune a numeric options using a slider/keyboard - Add a new .propWithDefault method to ObjObservable to allows to set a default value when options is undefined. - mocha-webdriver's findContent does not work to find content in svg elements. So had to tweak original function into a sister function using .textContent instead. Test Plan: Adds new tests Reviewers: dsagal Reviewed By: dsagal Subscribers: anaisconce, dsagal Differential Revision: https://phab.getgrist.com/D3107	3 years ago
Cyprien P	ab7af2b2ef	(core) Fix bars order in chart bars order when multiseries is on. ... Summary: - Grouping series may result in series with inconsistent number of values. This can result in inconsistent ordering of the bars displayed by plotly. - This diff fixes it by consolidating grouped series by adding unll values for each missing xvalues in the series. Here a is a minimal example of that bug: {F36639} Test Plan: Includes new nbrowser test. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D3085	3 years ago
Cyprien P	a0c53f2b61	(core) Fix chart when x axis is set to a choice list column ... Summary: Bug reported by user: https://gristlabs.getgrist.com/doc/check-ins/p/3#a1.s7.r1183.c19p Setting x axis to a column of type ChoiceList was breaking chart. This diff fixes that by splitting the record into several records: one for each choice. `test/nbrowser/ChartView1.ts` was becoming too big and long to run, so this diff introduces `test/nbrowser/ChartView2.ts` to add more test and `test/nbrowser/chartViewTestUtils.ts` to put all utilities or testing charts. Test Plan: Adds new test. Reviewers: georgegevoian Reviewed By: georgegevoian Differential Revision: https://phab.getgrist.com/D3041	3 years ago
Cyprien P	cecebded1f	(core) Fix bar chart weirdness when x axis has redundant values ... Summary: Bar chart was a bit broken when there were redundant values on the X axis: the bars’s height maps to the sum of all the corresponding y values, when the data that shows up on hover is only the last one. It seems that plotly does not support redundant values in the x axis and in all Plotly examples (implementation relies on plotly) x values only have unique values. This diff, fixes by making sure x axis has unique values. If user actually wants to plot groups, they'll have to use a summary charts. Test Plan: tested manually Reviewers: georgegevoian Reviewed By: georgegevoian Differential Revision: https://phab.getgrist.com/D3011	3 years ago
Paul Fitzpatrick	1654a2681f	(core) move client code to core ... Summary: This moves all client code to core, and makes minimal fix-ups to get grist and grist-core to compile correctly. The client works in core, but I'm leaving clean-up around the build and bundles to follow-up. Test Plan: existing tests pass; server-dev bundle looks sane Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2627	4 years ago