gristlabs_grist-core

Commit Graph

Author	SHA1	Message	Date
Cyprien P	e3801a5eb9	(core) Fix pie sectors order according to section sort spec Summary: Plotly sorts pie charts sectors by default and that is overiding the section ordering. This diff fixes that by passing setting .sort to false (thus disabling reordering) when there is a sort spec going on. Issue was reported by user: https://gristlabs.getgrist.com/k1f3bMzUvitZ/User-Feedback#a1.s3.r333.c19 Test Plan: Added nbrowser test Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D3075	3 years ago
Cyprien P	a0c53f2b61	(core) Fix chart when x axis is set to a choice list column Summary: Bug reported by user: https://gristlabs.getgrist.com/doc/check-ins/p/3#a1.s7.r1183.c19p Setting x axis to a column of type ChoiceList was breaking chart. This diff fixes that by splitting the record into several records: one for each choice. `test/nbrowser/ChartView1.ts` was becoming too big and long to run, so this diff introduces `test/nbrowser/ChartView2.ts` to add more test and `test/nbrowser/chartViewTestUtils.ts` to put all utilities or testing charts. Test Plan: Adds new test. Reviewers: georgegevoian Reviewed By: georgegevoian Differential Revision: https://phab.getgrist.com/D3041	3 years ago
Cyprien P	33f056a187	(core) Fix js errors when (un)summarizing underlying table of charts Summary: Used to throw js errors: `Resize must be passed a displayed plot div element.` Summarizing (or unsummarizing) causes the ChartView view instance to be replace by a new one in the view layout. However, the problem is that the old view instance get disposed only after the new view instance is added to the view layout. This causes the old view layout to try to resize chart while chart dom has been removed from the dom (which Plotly does not support). This diff fixes it by checking the the chart dom elemnt is still in the dom before making the plotly call to resize the chart. TODO: It feels weird that the old view instance gets disposed after the new one get added. Maybe we should check that also. Test Plan: New test added. Reviewers: dsagal Reviewed By: dsagal Subscribers: dsagal Differential Revision: https://phab.getgrist.com/D3035	3 years ago
Cyprien P	a1480faa09	(core) Changes X-AXIS to LABEL in the axis config when chart is a pie chart Summary: Also fixes issue with group data options when switching to pie chart. Issue was that if the group data picker was on, switching to the pie chart was not hiding it. Test Plan: Adds more tests. Reviewers: georgegevoian Reviewed By: georgegevoian Differential Revision: https://phab.getgrist.com/D3028	3 years ago
Cyprien P	4fcdd2ba07	(core) Fix y-axis blinking in chart view configuration Summary: This is a follow up diff for https://phab.getgrist.com/D3021. Y-axis draggable list used to blink when user changed either one of the x axis or groupdata column. This was due to the fact that all of theses axis are stored into the same array and changing one of them changes the whole array even though items relative to the y-axis actually were not changing. This diff addresses this issue by 1) being carefull at not updating the array of items when the changes do not impact y axis. And 2) by adding a freeze observable allowing to freeze the draggable list of y-axis while actions are being treated on the server. Test Plan: Catching such bug is hard, and given that it's only look and fill, maybe not worth the time and effort. Tested manually though. Reviewers: georgegevoian Reviewed By: georgegevoian Differential Revision: https://phab.getgrist.com/D3023	3 years ago
Cyprien P	2cf2088373	(core) New chart view axis conf with picker for each of X,Y and group by Summary: Chart view used to rely on the same view field configuration as used in any other widget. This diff allows to explicitely select X-AXIS, Y-AXIS and group by column with column picker. As charts supports several y-axis, we still use a draggable list to arrange them. Diff also fix doc to the `insertPositions` function. Test Plan: Updated the relevant test. Reviewers: georgegevoian Reviewed By: georgegevoian Differential Revision: https://phab.getgrist.com/D3021	3 years ago
Cyprien P	cecebded1f	(core) Fix bar chart weirdness when x axis has redundant values Summary: Bar chart was a bit broken when there were redundant values on the X axis: the bars’s height maps to the sum of all the corresponding y values, when the data that shows up on hover is only the last one. It seems that plotly does not support redundant values in the x axis and in all Plotly examples (implementation relies on plotly) x values only have unique values. This diff, fixes by making sure x axis has unique values. If user actually wants to plot groups, they'll have to use a summary charts. Test Plan: tested manually Reviewers: georgegevoian Reviewed By: georgegevoian Differential Revision: https://phab.getgrist.com/D3011	3 years ago
Dmitry S	31ffd21b4e	(core) Fix JS error when switching to a page containing a chart. Summary: - The error appeared recently, due to more frequent resize calls (added for mobile) - In fact, charts' own resize logic can now be simplified. Test Plan: Added a test case (which fails without the fix) Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2739	4 years ago
Dmitry S	5247521cb8	(core) Improve printing of tables, fix printing of charts, add a browser test. Summary: - Include column headers on each page for printing tables. - Avoid page-breaks inside rows or cards of a card-list. - Fix printing of charts that did not show up at all before. - Add a browser test, not great, but somewhat functional. Test Plan: New test, plus tested manually. Column headers work on Chrome and Firefox (not Safari). Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2636	4 years ago
Paul Fitzpatrick	1654a2681f	(core) move client code to core Summary: This moves all client code to core, and makes minimal fix-ups to get grist and grist-core to compile correctly. The client works in core, but I'm leaving clean-up around the build and bundles to follow-up. Test Plan: existing tests pass; server-dev bundle looks sane Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2627	4 years ago

10 Commits (4894631ba4032d7dc3b68e3ac57fd533f84b00e1)