Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) Remove duplicate shouldHideUiElement

Browse Source 
Summary: Also adds an explanatory comment for a recently-added column.

Test Plan: N/A

Reviewers: jarek

Reviewed By: jarek

Differential Revision: https://phab.getgrist.com/D3854
This commit is contained in:
George Gevoian 2023-04-11 02:13:34 -04:00
parent 8a0bb4d4fe
commit c5029af4e7
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/client/ui/TutorialCard.ts
View File

@ -23,7 +23,6 @@ export function buildTutorialCard(owner: IDisposableOwner, options: Options) {
const visible = Computed.create(owner, (use) => const visible = Computed.create(owner, (use) =>
!use(dismissed) !use(dismissed)
&& !use(isNarrowScreenObs()) && !use(isNarrowScreenObs())
&& !shouldHideUiElement("templates")
); );
return dom.maybe(visible, () => { return dom.maybe(visible, () => {
return cssCard( return cssCard(

6
sandbox/grist/schema.py
View File

@ -236,7 +236,11 @@ def schema_create_actions():
make_column("fileName", "Text"), # User defined file name make_column("fileName", "Text"), # User defined file name
make_column("fileType", "Text"), # A string indicating the MIME type of the data make_column("fileType", "Text"), # A string indicating the MIME type of the data
make_column("fileSize", "Int"), # The size in bytes make_column("fileSize", "Int"), # The size in bytes
make_column("fileExt", "Text"), # The file extension # The file extension, including the "." prefix.
# Prior to April 2023, this column did not exist, so attachments created before then have a
# blank fileExt. The extension may still be present in fileName, so a migration can backfill
# some older attachments if the need arises.
make_column("fileExt", "Text"),
make_column("imageHeight", "Int"), # height in pixels make_column("imageHeight", "Int"), # height in pixels
make_column("imageWidth", "Int"), # width in pixels make_column("imageWidth", "Int"), # width in pixels
make_column("timeDeleted", "DateTime"), make_column("timeDeleted", "DateTime"),