From c5029af4e73476061c15cc886c488908cb716219 Mon Sep 17 00:00:00 2001 From: George Gevoian Date: Tue, 11 Apr 2023 02:13:34 -0400 Subject: [PATCH] (core) Remove duplicate shouldHideUiElement Summary: Also adds an explanatory comment for a recently-added column. Test Plan: N/A Reviewers: jarek Reviewed By: jarek Differential Revision: https://phab.getgrist.com/D3854 --- app/client/ui/TutorialCard.ts | 1 - sandbox/grist/schema.py | 6 +++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/app/client/ui/TutorialCard.ts b/app/client/ui/TutorialCard.ts index 4146cc43..c224c3ce 100644 --- a/app/client/ui/TutorialCard.ts +++ b/app/client/ui/TutorialCard.ts @@ -23,7 +23,6 @@ export function buildTutorialCard(owner: IDisposableOwner, options: Options) { const visible = Computed.create(owner, (use) => !use(dismissed) && !use(isNarrowScreenObs()) - && !shouldHideUiElement("templates") ); return dom.maybe(visible, () => { return cssCard( diff --git a/sandbox/grist/schema.py b/sandbox/grist/schema.py index d000ddb6..0c516965 100644 --- a/sandbox/grist/schema.py +++ b/sandbox/grist/schema.py @@ -236,7 +236,11 @@ def schema_create_actions(): make_column("fileName", "Text"), # User defined file name make_column("fileType", "Text"), # A string indicating the MIME type of the data make_column("fileSize", "Int"), # The size in bytes - make_column("fileExt", "Text"), # The file extension + # The file extension, including the "." prefix. + # Prior to April 2023, this column did not exist, so attachments created before then have a + # blank fileExt. The extension may still be present in fileName, so a migration can backfill + # some older attachments if the need arises. + make_column("fileExt", "Text"), make_column("imageHeight", "Int"), # height in pixels make_column("imageWidth", "Int"), # width in pixels make_column("timeDeleted", "DateTime"),