Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

Remove unused variable

Browse Source
This commit is contained in:
vviers 2024-10-22 17:38:44 +02:00
parent 033947ba04
commit c21305f4d0
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/server/lib/OIDCConfig.ts
View File

@ -279,7 +279,7 @@ export class OIDCConfig {
}); });
} }
public async getLogoutRedirectUrl(req: express.Request, redirectUrl: URL): Promise<string> { public async getLogoutRedirectUrl(req: express.Request): Promise<string> {
const session: SessionObj|undefined = (req as RequestWithLogin).session; const session: SessionObj|undefined = (req as RequestWithLogin).session;
const stableRedirectUri = new URL('/signed-out', getOriginUrl(req)).href; const stableRedirectUri = new URL('/signed-out', getOriginUrl(req)).href;
// For IdPs that don't have end_session_endpoint, we just redirect to the logout page. // For IdPs that don't have end_session_endpoint, we just redirect to the logout page.

5
test/server/lib/OIDCConfig.ts
View File

@ -752,7 +752,6 @@ describe('OIDCConfig', () => {
}); });
describe('getLogoutRedirectUrl', () => { describe('getLogoutRedirectUrl', () => {
const REDIRECT_URL = new URL('http://localhost:8484/docs/signed-out');
const STABLE_LOGOUT_URL = new URL('http://localhost:8484/signed-out'); const STABLE_LOGOUT_URL = new URL('http://localhost:8484/signed-out');
const URL_RETURNED_BY_CLIENT = 'http://localhost:8484/logout_url_from_issuer'; const URL_RETURNED_BY_CLIENT = 'http://localhost:8484/logout_url_from_issuer';
const ENV_VALUE_GRIST_OIDC_IDP_END_SESSION_ENDPOINT = 'http://localhost:8484/logout'; const ENV_VALUE_GRIST_OIDC_IDP_END_SESSION_ENDPOINT = 'http://localhost:8484/logout';
@ -800,11 +799,11 @@ describe('OIDCConfig', () => {
const config = await OIDCConfigStubbed.buildWithStub(clientStub.asClient()); const config = await OIDCConfigStubbed.buildWithStub(clientStub.asClient());
const req = { const req = {
headers: { headers: {
host: REDIRECT_URL.host host: STABLE_LOGOUT_URL.host
}, },
session: 'session' in ctx ? ctx.session : FAKE_SESSION session: 'session' in ctx ? ctx.session : FAKE_SESSION
} as unknown as RequestWithLogin; } as unknown as RequestWithLogin;
const url = await config.getLogoutRedirectUrl(req, REDIRECT_URL); const url = await config.getLogoutRedirectUrl(req);
assert.equal(url, ctx.expectedUrl); assert.equal(url, ctx.expectedUrl);
if (ctx.expectedLogoutParams) { if (ctx.expectedLogoutParams) {
assert.isTrue(clientStub.endSessionUrl.calledOnce); assert.isTrue(clientStub.endSessionUrl.calledOnce);