From c21305f4d0d2ae4d189c5b25a1d2b2c0565d38e1 Mon Sep 17 00:00:00 2001
From: vviers <vincent.viers@beta.gouv.fr>
Date: Tue, 22 Oct 2024 17:38:44 +0200
Subject: [PATCH] Remove unused variable
---
app/server/lib/OIDCConfig.ts | 2 +-
test/server/lib/OIDCConfig.ts | 5 ++---
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/app/server/lib/OIDCConfig.ts b/app/server/lib/OIDCConfig.ts
index 31180ca6..b14a2693 100644
--- a/app/server/lib/OIDCConfig.ts
+++ b/app/server/lib/OIDCConfig.ts
@@ -279,7 +279,7 @@ export class OIDCConfig {
});
}
- public async getLogoutRedirectUrl(req: express.Request, redirectUrl: URL): Promise<string> {
+ public async getLogoutRedirectUrl(req: express.Request): Promise<string> {
const session: SessionObj|undefined = (req as RequestWithLogin).session;
const stableRedirectUri = new URL('/signed-out', getOriginUrl(req)).href;
// For IdPs that don't have end_session_endpoint, we just redirect to the logout page.
diff --git a/test/server/lib/OIDCConfig.ts b/test/server/lib/OIDCConfig.ts
index 099c0950..d7f46814 100644
--- a/test/server/lib/OIDCConfig.ts
+++ b/test/server/lib/OIDCConfig.ts
@@ -752,7 +752,6 @@ describe('OIDCConfig', () => {
});
describe('getLogoutRedirectUrl', () => {
- const REDIRECT_URL = new URL('http://localhost:8484/docs/signed-out');
const STABLE_LOGOUT_URL = new URL('http://localhost:8484/signed-out');
const URL_RETURNED_BY_CLIENT = 'http://localhost:8484/logout_url_from_issuer';
const ENV_VALUE_GRIST_OIDC_IDP_END_SESSION_ENDPOINT = 'http://localhost:8484/logout';
@@ -800,11 +799,11 @@ describe('OIDCConfig', () => {
const config = await OIDCConfigStubbed.buildWithStub(clientStub.asClient());
const req = {
headers: {
- host: REDIRECT_URL.host
+ host: STABLE_LOGOUT_URL.host
},
session: 'session' in ctx ? ctx.session : FAKE_SESSION
} as unknown as RequestWithLogin;
- const url = await config.getLogoutRedirectUrl(req, REDIRECT_URL);
+ const url = await config.getLogoutRedirectUrl(req);
assert.equal(url, ctx.expectedUrl);
if (ctx.expectedLogoutParams) {
assert.isTrue(clientStub.endSessionUrl.calledOnce);