Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2025-06-13 20:53:59 +00:00
Code Issues Projects Releases Wiki Activity

(core) make ValueFormatter.format honor its return type

Browse Source 
Summary: make ValueFormatter.format honor its return type

Test Plan: existing tests pass

Reviewers: dsagal

Reviewed By: dsagal

Subscribers: dsagal

Differential Revision: https://phab.getgrist.com/D2663
This commit is contained in:
Paul Fitzpatrick 2020-11-12 15:01:11 -05:00
parent f1842cd89e
commit ab01ce495d
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/common/ValueFormatter.ts
View File

@ -56,7 +56,7 @@ export class BaseFormatter {
* classes to handle values in formatter-specific ways.
*/
public format(value: any): string {
return value;
return String(value);
}
/**

2
app/server/serverMethods.js
View File

@ -105,7 +105,7 @@ function makeCSV(activeDoc, viewSectionId, sortOrder, req) {
rowIds.forEach(row => {
csvMatrix.push(access.map((getter, c) => formatters[c].formatAny(getter(row))));
});
return csv.stringifyAsync(csvMatrix, {formatters: {bool: v => '' + Number(v)}});
return csv.stringifyAsync(csvMatrix);
});
}
exports.makeCSV = makeCSV;