Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) Select all functionality by clicking the upper left margin corner

Browse Source 
Summary: Select all functionality by clicking the upper left margin corner

Test Plan: Browser test created

Reviewers: dsagal, paulfitz

Reviewed By: dsagal

Differential Revision: https://phab.getgrist.com/D2793
This commit is contained in:
Jarosław Sadziński 2021-04-29 20:10:01 +02:00
parent 0e22716761
commit 8f008d8de2
3 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/client/components/GridView.css
View File

@ -146,6 +146,7 @@
top: 1px; /* go under 1px border on scrollpane */ top: 1px; /* go under 1px border on scrollpane */
border-bottom: 1px solid lightgray; border-bottom: 1px solid lightgray;
z-index: 3; z-index: 3;
cursor: pointer;
} }
.scroll_shadow_left { .scroll_shadow_left {

5
app/client/components/GridView.js
View File

@ -736,7 +736,10 @@ GridView.prototype.buildDom = function() {
// Corner, bars and shadows // Corner, bars and shadows
// Corner and shadows (so it's fixed to the grid viewport) // Corner and shadows (so it's fixed to the grid viewport)
self._cornerDom = dom('div.gridview_data_corner_overlay'), self._cornerDom = dom(
'div.gridview_data_corner_overlay',
dom.on('click', () => this.selectAll()),
),
dom('div.scroll_shadow_top', kd.show(this.scrollShadow.top)), dom('div.scroll_shadow_top', kd.show(this.scrollShadow.top)),
dom('div.scroll_shadow_left', kd.show(this.scrollShadow.left)), dom('div.scroll_shadow_left', kd.show(this.scrollShadow.left)),
dom('div.gridview_header_backdrop_left'), //these hide behind the actual headers to keep them from flashing dom('div.gridview_header_backdrop_left'), //these hide behind the actual headers to keep them from flashing

1
test/nbrowser/gristUtils.ts
View File

@ -728,7 +728,6 @@ export async function addNewTable() {
await waitForServer(); await waitForServer();
} }
// Add a new page using the 'Add New' menu and wait for the new page to be shown. // Add a new page using the 'Add New' menu and wait for the new page to be shown.
export async function addNewPage(typeRe: RegExp, tableRe: RegExp, summarize?: RegExp[]) { export async function addNewPage(typeRe: RegExp, tableRe: RegExp, summarize?: RegExp[]) {
const url = await driver.getCurrentUrl(); const url = await driver.getCurrentUrl();