From 8f008d8de22151296909c5aca0eb7735eeda2bc8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jaros=C5=82aw=20Sadzi=C5=84ski?= Date: Thu, 29 Apr 2021 20:10:01 +0200 Subject: [PATCH] (core) Select all functionality by clicking the upper left margin corner Summary: Select all functionality by clicking the upper left margin corner Test Plan: Browser test created Reviewers: dsagal, paulfitz Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2793 --- app/client/components/GridView.css | 1 + app/client/components/GridView.js | 5 ++++- test/nbrowser/gristUtils.ts | 1 - 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/app/client/components/GridView.css b/app/client/components/GridView.css index 3b0d4b7b..819234da 100644 --- a/app/client/components/GridView.css +++ b/app/client/components/GridView.css @@ -146,6 +146,7 @@ top: 1px; /* go under 1px border on scrollpane */ border-bottom: 1px solid lightgray; z-index: 3; + cursor: pointer; } .scroll_shadow_left { diff --git a/app/client/components/GridView.js b/app/client/components/GridView.js index a2d990dc..93e893e5 100644 --- a/app/client/components/GridView.js +++ b/app/client/components/GridView.js @@ -736,7 +736,10 @@ GridView.prototype.buildDom = function() { // Corner, bars and shadows // Corner and shadows (so it's fixed to the grid viewport) - self._cornerDom = dom('div.gridview_data_corner_overlay'), + self._cornerDom = dom( + 'div.gridview_data_corner_overlay', + dom.on('click', () => this.selectAll()), + ), dom('div.scroll_shadow_top', kd.show(this.scrollShadow.top)), dom('div.scroll_shadow_left', kd.show(this.scrollShadow.left)), dom('div.gridview_header_backdrop_left'), //these hide behind the actual headers to keep them from flashing diff --git a/test/nbrowser/gristUtils.ts b/test/nbrowser/gristUtils.ts index 7e7de066..b7cae450 100644 --- a/test/nbrowser/gristUtils.ts +++ b/test/nbrowser/gristUtils.ts @@ -728,7 +728,6 @@ export async function addNewTable() { await waitForServer(); } - // Add a new page using the 'Add New' menu and wait for the new page to be shown. export async function addNewPage(typeRe: RegExp, tableRe: RegExp, summarize?: RegExp[]) { const url = await driver.getCurrentUrl();