Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) Fix small Start Tutorial button

Browse Source 
Summary: The button was missing an href.

Test Plan: Tested manually.

Reviewers: paulfitz

Reviewed By: paulfitz

Subscribers: paulfitz

Differential Revision: https://phab.getgrist.com/D3843
This commit is contained in:
George Gevoian 2023-03-29 23:01:14 -04:00
parent 3c610b365b
commit 8833958963
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/client/ui/TutorialCard.ts
View File

@ -9,11 +9,10 @@ const testId = makeTestId('test-tutorial-card-');
interface Options { interface Options {
app: AppModel, app: AppModel,
onStart?: () => void,
} }
export function buildTutorialCard(owner: IDisposableOwner, options: Options) { export function buildTutorialCard(owner: IDisposableOwner, options: Options) {
const {app, onStart} = options; const {app} = options;
const dismissed = app.dismissedPopup('tutorialFirstCard'); const dismissed = app.dismissedPopup('tutorialFirstCard');
owner.autoDispose(dismissed); owner.autoDispose(dismissed);
function onClose() { function onClose() {
@ -43,7 +42,7 @@ export function buildTutorialCard(owner: IDisposableOwner, options: Options) {
cssButtonWrapper( cssButtonWrapper(
cssButtonWrapper.cls('-small'), cssButtonWrapper.cls('-small'),
cssHeroButton("Start Tutorial"), cssHeroButton("Start Tutorial"),
dom.on('click', () => onStart?.()) {href: commonUrls.basicTutorial, target: '_blank'},
), ),
), ),
), ),