From 88339589638d6665a9e7d7d75abb6833517ad8a3 Mon Sep 17 00:00:00 2001 From: George Gevoian Date: Wed, 29 Mar 2023 23:01:14 -0400 Subject: [PATCH] (core) Fix small Start Tutorial button Summary: The button was missing an href. Test Plan: Tested manually. Reviewers: paulfitz Reviewed By: paulfitz Subscribers: paulfitz Differential Revision: https://phab.getgrist.com/D3843 --- app/client/ui/TutorialCard.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/app/client/ui/TutorialCard.ts b/app/client/ui/TutorialCard.ts index 81d72b5a..e3002335 100644 --- a/app/client/ui/TutorialCard.ts +++ b/app/client/ui/TutorialCard.ts @@ -9,11 +9,10 @@ const testId = makeTestId('test-tutorial-card-'); interface Options { app: AppModel, - onStart?: () => void, } export function buildTutorialCard(owner: IDisposableOwner, options: Options) { - const {app, onStart} = options; + const {app} = options; const dismissed = app.dismissedPopup('tutorialFirstCard'); owner.autoDispose(dismissed); function onClose() { @@ -43,7 +42,7 @@ export function buildTutorialCard(owner: IDisposableOwner, options: Options) { cssButtonWrapper( cssButtonWrapper.cls('-small'), cssHeroButton("Start Tutorial"), - dom.on('click', () => onStart?.()) + {href: commonUrls.basicTutorial, target: '_blank'}, ), ), ),