Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) Use auto popup placement for DocTour on mobile

Browse Source 
Summary: For GristDocTours on mobile, ignore the Placement column and always use automatic placement for popups

Test Plan: Tested manually with chrome devtools

Reviewers: jarek

Reviewed By: jarek

Subscribers: dsagal

Differential Revision: https://phab.getgrist.com/D3188
This commit is contained in:
Alex Hall 2021-12-15 17:14:57 +02:00
parent f024aaaf5d
commit 30c8ba3019
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/client/ui/DocTour.ts
View File

@ -4,6 +4,7 @@ import {DocComm} from 'app/client/components/DocComm';
import {sameDocumentUrlState} from 'app/client/models/gristUrlState'; import {sameDocumentUrlState} from 'app/client/models/gristUrlState';
import {cssButtons, cssLinkBtn, cssLinkIcon} from 'app/client/ui/ExampleCard'; import {cssButtons, cssLinkBtn, cssLinkIcon} from 'app/client/ui/ExampleCard';
import {IOnBoardingMsg, startOnBoarding} from 'app/client/ui/OnBoardingPopups'; import {IOnBoardingMsg, startOnBoarding} from 'app/client/ui/OnBoardingPopups';
import {isNarrowScreen} from 'app/client/ui2018/cssVars';
import {IconList, IconName} from 'app/client/ui2018/IconList'; import {IconList, IconName} from 'app/client/ui2018/IconList';
import {DocData} from 'app/common/DocData'; import {DocData} from 'app/common/DocData';
import {dom} from 'grainjs'; import {dom} from 'grainjs';
@ -35,6 +36,7 @@ async function makeDocTour(docData: DocData, docComm: DocComm): Promise<IOnBoard
await docComm.waitForInitialization(); await docComm.waitForInitialization();
await docData.fetchTable(tableId); await docData.fetchTable(tableId);
const tableData = docData.getTable(tableId)!; const tableData = docData.getTable(tableId)!;
const result = sortBy(tableData.getRowIds(), tableData.getRowPropFunc('manualSort') as any).map(rowId => { const result = sortBy(tableData.getRowIds(), tableData.getRowPropFunc('manualSort') as any).map(rowId => {
function getValue(colId: string): string { function getValue(colId: string): string {
return String(tableData.getValue(rowId, colId) || ""); return String(tableData.getValue(rowId, colId) || "");
@ -52,7 +54,7 @@ async function makeDocTour(docData: DocData, docComm: DocComm): Promise<IOnBoard
} }
const urlState = sameDocumentUrlState(locationValue); const urlState = sameDocumentUrlState(locationValue);
if (!placements.includes(placement as Placement)) { if (isNarrowScreen() || !placements.includes(placement as Placement)) {
placement = "auto"; placement = "auto";
} }