From 30c8ba30194f0b3e50296539613447ee0d73a8e9 Mon Sep 17 00:00:00 2001
From: Alex Hall <alex.mojaki@gmail.com>
Date: Wed, 15 Dec 2021 17:14:57 +0200
Subject: [PATCH] (core) Use auto popup placement for DocTour on mobile

Summary: For GristDocTours on mobile, ignore the Placement column and always use automatic placement for popups

Test Plan: Tested manually with chrome devtools

Reviewers: jarek

Reviewed By: jarek

Subscribers: dsagal

Differential Revision: https://phab.getgrist.com/D3188
---
 app/client/ui/DocTour.ts | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/app/client/ui/DocTour.ts b/app/client/ui/DocTour.ts
index 58cb954a..d0a94f3f 100644
--- a/app/client/ui/DocTour.ts
+++ b/app/client/ui/DocTour.ts
@@ -4,6 +4,7 @@ import {DocComm} from 'app/client/components/DocComm';
 import {sameDocumentUrlState} from 'app/client/models/gristUrlState';
 import {cssButtons, cssLinkBtn, cssLinkIcon} from 'app/client/ui/ExampleCard';
 import {IOnBoardingMsg, startOnBoarding} from 'app/client/ui/OnBoardingPopups';
+import {isNarrowScreen} from 'app/client/ui2018/cssVars';
 import {IconList, IconName} from 'app/client/ui2018/IconList';
 import {DocData} from 'app/common/DocData';
 import {dom} from 'grainjs';
@@ -35,6 +36,7 @@ async function makeDocTour(docData: DocData, docComm: DocComm): Promise<IOnBoard
   await docComm.waitForInitialization();
   await docData.fetchTable(tableId);
   const tableData = docData.getTable(tableId)!;
+
   const result = sortBy(tableData.getRowIds(), tableData.getRowPropFunc('manualSort') as any).map(rowId => {
     function getValue(colId: string): string {
       return String(tableData.getValue(rowId, colId) || "");
@@ -52,7 +54,7 @@ async function makeDocTour(docData: DocData, docComm: DocComm): Promise<IOnBoard
     }
 
     const urlState = sameDocumentUrlState(locationValue);
-    if (!placements.includes(placement as Placement)) {
+    if (isNarrowScreen() || !placements.includes(placement as Placement)) {
       placement = "auto";
     }